create_sotr, remove unused parameters (#3739)

* minor changes

* create_sotr, remove unused parameters
This commit is contained in:
Lars Hvam 2020-08-16 08:21:49 +02:00 committed by GitHub
parent 2a0a97bcd7
commit d1f277365b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
12 changed files with 27 additions and 59 deletions

View File

@ -85,7 +85,7 @@
"^flag$", "^char12$", "^char10$", "^char70$", "^char4$", "^sydatum$", "^syuzeit$"]
},
"forbidden_identifier": true,
"try_without_catch": false,
"try_without_catch": true,
"unused_variables": false,
"prefix_is_current_class": {
"omitMeInstanceCalls": false

View File

@ -114,11 +114,8 @@ CLASS ZCL_ABAPGIT_OBJECT_ENHC IMPLEMENTATION.
li_enh_composite->if_enh_object~unlock( ).
zcl_abapgit_sotr_handler=>create_sotr(
iv_pgmid = 'R3TR'
iv_object = ms_item-obj_type
iv_obj_name = ms_item-obj_name
iv_package = iv_package
io_xml = io_xml ).
iv_package = iv_package
io_xml = io_xml ).
CATCH cx_enh_root INTO lx_error.
zcx_abapgit_exception=>raise( lx_error->get_text( ) ).

View File

@ -149,11 +149,8 @@ CLASS ZCL_ABAPGIT_OBJECT_ENHO IMPLEMENTATION.
iv_package = iv_package ).
zcl_abapgit_sotr_handler=>create_sotr(
iv_pgmid = 'R3TR'
iv_object = ms_item-obj_type
iv_obj_name = ms_item-obj_name
iv_package = iv_package
io_xml = io_xml ).
iv_package = iv_package
io_xml = io_xml ).
zcl_abapgit_objects_activation=>add_item( ms_item ).

View File

@ -125,11 +125,8 @@ CLASS ZCL_ABAPGIT_OBJECT_ENHS IMPLEMENTATION.
ii_enh_spot_tool = li_spot_ref ).
zcl_abapgit_sotr_handler=>create_sotr(
iv_pgmid = 'R3TR'
iv_object = ms_item-obj_type
iv_obj_name = ms_item-obj_name
iv_package = iv_package
io_xml = io_xml ).
iv_package = iv_package
io_xml = io_xml ).
ENDMETHOD.

View File

@ -101,11 +101,8 @@ CLASS ZCL_ABAPGIT_OBJECT_ENSC IMPLEMENTATION.
lo_spot_ref->if_enh_object~unlock( ).
zcl_abapgit_sotr_handler=>create_sotr(
iv_pgmid = 'R3TR'
iv_object = ms_item-obj_type
iv_obj_name = ms_item-obj_name
iv_package = iv_package
io_xml = io_xml ).
iv_package = iv_package
io_xml = io_xml ).
CATCH cx_enh_root INTO lx_root.
lv_message = `Error occured while deserializing ENSC: `

View File

@ -522,11 +522,8 @@ CLASS ZCL_ABAPGIT_OBJECT_WAPA IMPLEMENTATION.
it_remote_pages = lt_pages_info ).
zcl_abapgit_sotr_handler=>create_sotr(
iv_pgmid = 'LIMU'
iv_object = 'WAPP'
iv_obj_name = ms_item-obj_name
iv_package = iv_package
io_xml = io_xml ).
iv_package = iv_package
io_xml = io_xml ).
ENDMETHOD.

View File

@ -172,11 +172,8 @@ CLASS ZCL_ABAPGIT_OBJECT_WDYA IMPLEMENTATION.
iv_package = iv_package ).
zcl_abapgit_sotr_handler=>create_sotr(
iv_pgmid = 'R3TR'
iv_object = ms_item-obj_type
iv_obj_name = ms_item-obj_name
iv_package = iv_package
io_xml = io_xml ).
iv_package = iv_package
io_xml = io_xml ).
ENDMETHOD.

View File

@ -780,11 +780,8 @@ CLASS ZCL_ABAPGIT_OBJECT_WDYN IMPLEMENTATION.
READ TABLE ls_component-comp_metadata-descriptions INTO ls_description INDEX 1.
IF sy-subrc = 0.
zcl_abapgit_sotr_handler=>create_sotr(
iv_pgmid = 'LIMU'
iv_object = 'WDYV'
iv_obj_name = ms_item-obj_name
iv_package = iv_package
io_xml = io_xml ).
iv_package = iv_package
io_xml = io_xml ).
ENDIF.
zcl_abapgit_objects_activation=>add_item( ms_item ).

View File

@ -401,11 +401,8 @@ CLASS ZCL_ABAPGIT_OBJECT_WEBI IMPLEMENTATION.
zcl_abapgit_objects_activation=>add_item( ms_item ).
zcl_abapgit_sotr_handler=>create_sotr(
iv_pgmid = 'R3TR'
iv_object = ms_item-obj_type
iv_obj_name = ms_item-obj_name
iv_package = iv_package
io_xml = io_xml ).
iv_package = iv_package
io_xml = io_xml ).
ENDMETHOD.

View File

@ -437,11 +437,8 @@ CLASS ZCL_ABAPGIT_OO_CLASS IMPLEMENTATION.
METHOD zif_abapgit_oo_object_fnc~create_sotr.
zcl_abapgit_sotr_handler=>create_sotr(
iv_pgmid = 'LIMU'
iv_object = 'CPUB'
iv_obj_name = iv_object_name
iv_package = iv_package
io_xml = io_xml ).
iv_package = iv_package
io_xml = io_xml ).
ENDMETHOD.

View File

@ -15,20 +15,16 @@ CLASS zcl_abapgit_sotr_handler DEFINITION
!iv_pgmid TYPE pgmid
!iv_object TYPE trobjtype
!iv_obj_name TYPE csequence
io_xml TYPE REF TO zcl_abapgit_xml_output OPTIONAL
!io_xml TYPE REF TO zcl_abapgit_xml_output OPTIONAL
EXPORTING
et_sotr TYPE zif_abapgit_definitions=>ty_sotr_tt
et_sotr_use TYPE zif_abapgit_definitions=>ty_sotr_use_tt
!et_sotr TYPE zif_abapgit_definitions=>ty_sotr_tt
!et_sotr_use TYPE zif_abapgit_definitions=>ty_sotr_use_tt
RAISING
zcx_abapgit_exception .
CLASS-METHODS create_sotr
IMPORTING
!iv_pgmid TYPE pgmid
!iv_object TYPE trobjtype
!iv_obj_name TYPE csequence
!iv_package TYPE devclass
io_xml TYPE REF TO zcl_abapgit_xml_input
!iv_package TYPE devclass
!io_xml TYPE REF TO zcl_abapgit_xml_input
RAISING
zcx_abapgit_exception .
PROTECTED SECTION.
@ -129,8 +125,8 @@ CLASS ZCL_ABAPGIT_SOTR_HANDLER IMPLEMENTATION.
METHOD get_sotr_4_concept.
DATA: ls_header TYPE sotr_head,
lt_entries TYPE sotr_text_tt.
DATA: ls_header TYPE sotr_head,
lt_entries TYPE sotr_text_tt.
FIELD-SYMBOLS: <ls_entry> LIKE LINE OF lt_entries.

View File

@ -572,11 +572,10 @@ CLASS zcl_abapgit_gui_chunk_lib IMPLEMENTATION.
METHOD render_order_by_header_cells.
DATA:
lt_colspec TYPE zif_abapgit_definitions=>tty_col_spec,
lv_tmp TYPE string,
lv_disp_name TYPE string.
FIELD-SYMBOLS <ls_col> LIKE LINE OF lt_colspec.
FIELD-SYMBOLS <ls_col> LIKE LINE OF it_col_spec.
CREATE OBJECT ro_html.