From d1f277365b6e77e144e85cbe56fb3bc7c8adcd83 Mon Sep 17 00:00:00 2001 From: Lars Hvam Date: Sun, 16 Aug 2020 08:21:49 +0200 Subject: [PATCH] create_sotr, remove unused parameters (#3739) * minor changes * create_sotr, remove unused parameters --- abaplint.json | 2 +- src/objects/zcl_abapgit_object_enhc.clas.abap | 7 ++----- src/objects/zcl_abapgit_object_enho.clas.abap | 7 ++----- src/objects/zcl_abapgit_object_enhs.clas.abap | 7 ++----- src/objects/zcl_abapgit_object_ensc.clas.abap | 7 ++----- src/objects/zcl_abapgit_object_wapa.clas.abap | 7 ++----- src/objects/zcl_abapgit_object_wdya.clas.abap | 7 ++----- src/objects/zcl_abapgit_object_wdyn.clas.abap | 7 ++----- src/objects/zcl_abapgit_object_webi.clas.abap | 7 ++----- src/objects/zcl_abapgit_oo_class.clas.abap | 7 ++----- src/objects/zcl_abapgit_sotr_handler.clas.abap | 18 +++++++----------- src/ui/zcl_abapgit_gui_chunk_lib.clas.abap | 3 +-- 12 files changed, 27 insertions(+), 59 deletions(-) diff --git a/abaplint.json b/abaplint.json index aa124f74e..4c533e88d 100644 --- a/abaplint.json +++ b/abaplint.json @@ -85,7 +85,7 @@ "^flag$", "^char12$", "^char10$", "^char70$", "^char4$", "^sydatum$", "^syuzeit$"] }, "forbidden_identifier": true, - "try_without_catch": false, + "try_without_catch": true, "unused_variables": false, "prefix_is_current_class": { "omitMeInstanceCalls": false diff --git a/src/objects/zcl_abapgit_object_enhc.clas.abap b/src/objects/zcl_abapgit_object_enhc.clas.abap index 8d2cae7a9..af987e3b6 100644 --- a/src/objects/zcl_abapgit_object_enhc.clas.abap +++ b/src/objects/zcl_abapgit_object_enhc.clas.abap @@ -114,11 +114,8 @@ CLASS ZCL_ABAPGIT_OBJECT_ENHC IMPLEMENTATION. li_enh_composite->if_enh_object~unlock( ). zcl_abapgit_sotr_handler=>create_sotr( - iv_pgmid = 'R3TR' - iv_object = ms_item-obj_type - iv_obj_name = ms_item-obj_name - iv_package = iv_package - io_xml = io_xml ). + iv_package = iv_package + io_xml = io_xml ). CATCH cx_enh_root INTO lx_error. zcx_abapgit_exception=>raise( lx_error->get_text( ) ). diff --git a/src/objects/zcl_abapgit_object_enho.clas.abap b/src/objects/zcl_abapgit_object_enho.clas.abap index f1649ab1e..3726e0282 100644 --- a/src/objects/zcl_abapgit_object_enho.clas.abap +++ b/src/objects/zcl_abapgit_object_enho.clas.abap @@ -149,11 +149,8 @@ CLASS ZCL_ABAPGIT_OBJECT_ENHO IMPLEMENTATION. iv_package = iv_package ). zcl_abapgit_sotr_handler=>create_sotr( - iv_pgmid = 'R3TR' - iv_object = ms_item-obj_type - iv_obj_name = ms_item-obj_name - iv_package = iv_package - io_xml = io_xml ). + iv_package = iv_package + io_xml = io_xml ). zcl_abapgit_objects_activation=>add_item( ms_item ). diff --git a/src/objects/zcl_abapgit_object_enhs.clas.abap b/src/objects/zcl_abapgit_object_enhs.clas.abap index a74574f09..d07f4d64b 100644 --- a/src/objects/zcl_abapgit_object_enhs.clas.abap +++ b/src/objects/zcl_abapgit_object_enhs.clas.abap @@ -125,11 +125,8 @@ CLASS ZCL_ABAPGIT_OBJECT_ENHS IMPLEMENTATION. ii_enh_spot_tool = li_spot_ref ). zcl_abapgit_sotr_handler=>create_sotr( - iv_pgmid = 'R3TR' - iv_object = ms_item-obj_type - iv_obj_name = ms_item-obj_name - iv_package = iv_package - io_xml = io_xml ). + iv_package = iv_package + io_xml = io_xml ). ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_ensc.clas.abap b/src/objects/zcl_abapgit_object_ensc.clas.abap index e9ca78869..6bb8b4874 100644 --- a/src/objects/zcl_abapgit_object_ensc.clas.abap +++ b/src/objects/zcl_abapgit_object_ensc.clas.abap @@ -101,11 +101,8 @@ CLASS ZCL_ABAPGIT_OBJECT_ENSC IMPLEMENTATION. lo_spot_ref->if_enh_object~unlock( ). zcl_abapgit_sotr_handler=>create_sotr( - iv_pgmid = 'R3TR' - iv_object = ms_item-obj_type - iv_obj_name = ms_item-obj_name - iv_package = iv_package - io_xml = io_xml ). + iv_package = iv_package + io_xml = io_xml ). CATCH cx_enh_root INTO lx_root. lv_message = `Error occured while deserializing ENSC: ` diff --git a/src/objects/zcl_abapgit_object_wapa.clas.abap b/src/objects/zcl_abapgit_object_wapa.clas.abap index 8171881b3..6f79443d1 100644 --- a/src/objects/zcl_abapgit_object_wapa.clas.abap +++ b/src/objects/zcl_abapgit_object_wapa.clas.abap @@ -522,11 +522,8 @@ CLASS ZCL_ABAPGIT_OBJECT_WAPA IMPLEMENTATION. it_remote_pages = lt_pages_info ). zcl_abapgit_sotr_handler=>create_sotr( - iv_pgmid = 'LIMU' - iv_object = 'WAPP' - iv_obj_name = ms_item-obj_name - iv_package = iv_package - io_xml = io_xml ). + iv_package = iv_package + io_xml = io_xml ). ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_wdya.clas.abap b/src/objects/zcl_abapgit_object_wdya.clas.abap index fd60f4ecf..f9a40acb7 100644 --- a/src/objects/zcl_abapgit_object_wdya.clas.abap +++ b/src/objects/zcl_abapgit_object_wdya.clas.abap @@ -172,11 +172,8 @@ CLASS ZCL_ABAPGIT_OBJECT_WDYA IMPLEMENTATION. iv_package = iv_package ). zcl_abapgit_sotr_handler=>create_sotr( - iv_pgmid = 'R3TR' - iv_object = ms_item-obj_type - iv_obj_name = ms_item-obj_name - iv_package = iv_package - io_xml = io_xml ). + iv_package = iv_package + io_xml = io_xml ). ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_wdyn.clas.abap b/src/objects/zcl_abapgit_object_wdyn.clas.abap index cb6dba051..d8a0d38ad 100644 --- a/src/objects/zcl_abapgit_object_wdyn.clas.abap +++ b/src/objects/zcl_abapgit_object_wdyn.clas.abap @@ -780,11 +780,8 @@ CLASS ZCL_ABAPGIT_OBJECT_WDYN IMPLEMENTATION. READ TABLE ls_component-comp_metadata-descriptions INTO ls_description INDEX 1. IF sy-subrc = 0. zcl_abapgit_sotr_handler=>create_sotr( - iv_pgmid = 'LIMU' - iv_object = 'WDYV' - iv_obj_name = ms_item-obj_name - iv_package = iv_package - io_xml = io_xml ). + iv_package = iv_package + io_xml = io_xml ). ENDIF. zcl_abapgit_objects_activation=>add_item( ms_item ). diff --git a/src/objects/zcl_abapgit_object_webi.clas.abap b/src/objects/zcl_abapgit_object_webi.clas.abap index 1b6b4796c..718a242c8 100644 --- a/src/objects/zcl_abapgit_object_webi.clas.abap +++ b/src/objects/zcl_abapgit_object_webi.clas.abap @@ -401,11 +401,8 @@ CLASS ZCL_ABAPGIT_OBJECT_WEBI IMPLEMENTATION. zcl_abapgit_objects_activation=>add_item( ms_item ). zcl_abapgit_sotr_handler=>create_sotr( - iv_pgmid = 'R3TR' - iv_object = ms_item-obj_type - iv_obj_name = ms_item-obj_name - iv_package = iv_package - io_xml = io_xml ). + iv_package = iv_package + io_xml = io_xml ). ENDMETHOD. diff --git a/src/objects/zcl_abapgit_oo_class.clas.abap b/src/objects/zcl_abapgit_oo_class.clas.abap index f6f4f7f1b..026d1c449 100644 --- a/src/objects/zcl_abapgit_oo_class.clas.abap +++ b/src/objects/zcl_abapgit_oo_class.clas.abap @@ -437,11 +437,8 @@ CLASS ZCL_ABAPGIT_OO_CLASS IMPLEMENTATION. METHOD zif_abapgit_oo_object_fnc~create_sotr. zcl_abapgit_sotr_handler=>create_sotr( - iv_pgmid = 'LIMU' - iv_object = 'CPUB' - iv_obj_name = iv_object_name - iv_package = iv_package - io_xml = io_xml ). + iv_package = iv_package + io_xml = io_xml ). ENDMETHOD. diff --git a/src/objects/zcl_abapgit_sotr_handler.clas.abap b/src/objects/zcl_abapgit_sotr_handler.clas.abap index 044c81518..695ef8ada 100644 --- a/src/objects/zcl_abapgit_sotr_handler.clas.abap +++ b/src/objects/zcl_abapgit_sotr_handler.clas.abap @@ -15,20 +15,16 @@ CLASS zcl_abapgit_sotr_handler DEFINITION !iv_pgmid TYPE pgmid !iv_object TYPE trobjtype !iv_obj_name TYPE csequence - io_xml TYPE REF TO zcl_abapgit_xml_output OPTIONAL + !io_xml TYPE REF TO zcl_abapgit_xml_output OPTIONAL EXPORTING - et_sotr TYPE zif_abapgit_definitions=>ty_sotr_tt - et_sotr_use TYPE zif_abapgit_definitions=>ty_sotr_use_tt + !et_sotr TYPE zif_abapgit_definitions=>ty_sotr_tt + !et_sotr_use TYPE zif_abapgit_definitions=>ty_sotr_use_tt RAISING zcx_abapgit_exception . - CLASS-METHODS create_sotr IMPORTING - !iv_pgmid TYPE pgmid - !iv_object TYPE trobjtype - !iv_obj_name TYPE csequence - !iv_package TYPE devclass - io_xml TYPE REF TO zcl_abapgit_xml_input + !iv_package TYPE devclass + !io_xml TYPE REF TO zcl_abapgit_xml_input RAISING zcx_abapgit_exception . PROTECTED SECTION. @@ -129,8 +125,8 @@ CLASS ZCL_ABAPGIT_SOTR_HANDLER IMPLEMENTATION. METHOD get_sotr_4_concept. - DATA: ls_header TYPE sotr_head, - lt_entries TYPE sotr_text_tt. + DATA: ls_header TYPE sotr_head, + lt_entries TYPE sotr_text_tt. FIELD-SYMBOLS: LIKE LINE OF lt_entries. diff --git a/src/ui/zcl_abapgit_gui_chunk_lib.clas.abap b/src/ui/zcl_abapgit_gui_chunk_lib.clas.abap index 408fed429..be181ec67 100644 --- a/src/ui/zcl_abapgit_gui_chunk_lib.clas.abap +++ b/src/ui/zcl_abapgit_gui_chunk_lib.clas.abap @@ -572,11 +572,10 @@ CLASS zcl_abapgit_gui_chunk_lib IMPLEMENTATION. METHOD render_order_by_header_cells. DATA: - lt_colspec TYPE zif_abapgit_definitions=>tty_col_spec, lv_tmp TYPE string, lv_disp_name TYPE string. - FIELD-SYMBOLS LIKE LINE OF lt_colspec. + FIELD-SYMBOLS LIKE LINE OF it_col_spec. CREATE OBJECT ro_html.