From c6e502b6ecac275f8cb3e57e597195cb828b9460 Mon Sep 17 00:00:00 2001 From: Christian Guenter Date: Wed, 9 Aug 2017 19:59:18 +0000 Subject: [PATCH 1/5] JOBD Serialization --- src/zabapgit_object_jobd.prog.abap | 154 ++++++++++++++++++++++ src/zabapgit_object_jobd.prog.xml | 25 ++++ src/zabapgit_object_serializing.prog.abap | 1 + 3 files changed, 180 insertions(+) create mode 100644 src/zabapgit_object_jobd.prog.abap create mode 100644 src/zabapgit_object_jobd.prog.xml diff --git a/src/zabapgit_object_jobd.prog.abap b/src/zabapgit_object_jobd.prog.abap new file mode 100644 index 000000000..8f0d4dea2 --- /dev/null +++ b/src/zabapgit_object_jobd.prog.abap @@ -0,0 +1,154 @@ +*&---------------------------------------------------------------------* +*& Include zabapgit_object_jobd +*&---------------------------------------------------------------------* + +CLASS lcl_object_jobd DEFINITION INHERITING FROM lcl_objects_super FINAL. + + PUBLIC SECTION. + INTERFACES lif_object. + +ENDCLASS. + +CLASS lcl_object_jobd IMPLEMENTATION. + + METHOD lif_object~has_changed_since. + + rv_changed = abap_true. + + ENDMETHOD. + + METHOD lif_object~changed_by. + + rv_user = c_user_unknown. + + ENDMETHOD. + + METHOD lif_object~get_metadata. + + rs_metadata = get_metadata( ). + rs_metadata-delete_tadir = abap_true. + + ENDMETHOD. + + METHOD lif_object~exists. + + TRY. + cl_jr_jd_manager=>check_jd_existence( + EXPORTING + im_jd_name = |{ ms_item-obj_name }| + IMPORTING + ex_is_existing = rv_bool ). + + CATCH cx_root. + lcx_exception=>raise( |JOBD not supported| ). + ENDTRY. + + ENDMETHOD. + + METHOD lif_object~serialize. + + DATA: ls_job_definition TYPE cl_jr_job_definition=>ty_job_definition. + + TRY. + cl_jr_jd_manager=>get_instance( + EXPORTING + im_jd_name = |{ ms_item-obj_name }| + IMPORTING + ex_jd_obj = DATA(lo_job_definition) ). + + lo_job_definition->get_jd_attributes( + IMPORTING + ex_jd_attributes = ls_job_definition ). + + CLEAR: ls_job_definition-jdpackage, + ls_job_definition-btcjob_user, + ls_job_definition-owner, + ls_job_definition-created_date, + ls_job_definition-created_time, + ls_job_definition-changed_date, + ls_job_definition-changed_time. + + io_xml->add( iv_name = 'JOBD' + ig_data = ls_job_definition ). + + CATCH cx_root. + lcx_exception=>raise( |Error serializing JOBD| ). + ENDTRY. + + ENDMETHOD. + + METHOD lif_object~deserialize. + + DATA: ls_job_definition TYPE cl_jr_job_definition=>ty_job_definition. + + TRY. + io_xml->read( + EXPORTING + iv_name = 'JOBD' + CHANGING + cg_data = ls_job_definition ). + + cl_jr_jd_manager=>create_instance( + EXPORTING + im_jd_name = |{ ms_item-obj_name }| + IMPORTING + ex_jd_obj = DATA(lo_job_definition) ). + + ls_job_definition-jdpackage = iv_package. + + lo_job_definition->create_jd( ls_job_definition ). + + CATCH cx_root. + lcx_exception=>raise( |Error deserializing JOBD| ). + ENDTRY. + + lcl_objects_activation=>add_item( ms_item ). + + ENDMETHOD. + + METHOD lif_object~delete. + + TRY. + cl_jr_jd_manager=>get_instance( + EXPORTING + im_jd_name = |{ ms_item-obj_name }| + IMPORTING + ex_jd_obj = DATA(lo_job_definition) ). + + lo_job_definition->delete_jd( ). + + CATCH cx_root. + lcx_exception=>raise( |Error deleting JOBD| ). + ENDTRY. + + ENDMETHOD. + + METHOD lif_object~jump. + + DATA: obj_name TYPE e071-obj_name. + + obj_name = ms_item-obj_name. + + CALL FUNCTION 'TR_OBJECT_JUMP_TO_TOOL' + EXPORTING + iv_pgmid = 'R3TR' + iv_object = ms_item-obj_type + iv_obj_name = obj_name + iv_action = 'SHOW' + EXCEPTIONS + jump_not_possible = 1 + OTHERS = 2. + + IF sy-subrc <> 0. + lcx_exception=>raise( |Error from TR_OBJECT_JUMP_TO_TOOL, JOBD| ). + ENDIF. + + ENDMETHOD. + + METHOD lif_object~compare_to_remote_version. + + CREATE OBJECT ro_comparison_result TYPE lcl_comparison_null. + + ENDMETHOD. + +ENDCLASS. diff --git a/src/zabapgit_object_jobd.prog.xml b/src/zabapgit_object_jobd.prog.xml new file mode 100644 index 000000000..e74762cd6 --- /dev/null +++ b/src/zabapgit_object_jobd.prog.xml @@ -0,0 +1,25 @@ + + + + + + ZABAPGIT_OBJECT_JOBD + A + X + S + D$ + I + X + D$S + X + + + + R + ZABAPGIT_OBJECT_JOBD + 20 + + + + + diff --git a/src/zabapgit_object_serializing.prog.abap b/src/zabapgit_object_serializing.prog.abap index faf27989e..4a674a53a 100644 --- a/src/zabapgit_object_serializing.prog.abap +++ b/src/zabapgit_object_serializing.prog.abap @@ -25,6 +25,7 @@ INCLUDE zabapgit_object_fugr. INCLUDE zabapgit_object_iarp. INCLUDE zabapgit_object_iasp. INCLUDE zabapgit_object_iatu. +INCLUDE zabapgit_object_JOBD. INCLUDE zabapgit_object_intf. INCLUDE zabapgit_object_msag. INCLUDE zabapgit_object_nrob. From 1ec1c7ef99e84b4fccae423d7e95a1f6dcbf0b2c Mon Sep 17 00:00:00 2001 From: Christian Guenter Date: Wed, 9 Aug 2017 20:27:31 +0000 Subject: [PATCH 2/5] JOBD downport objects --- src/zabapgit_object_jobd.prog.abap | 57 ++++++++++++++++++------------ 1 file changed, 35 insertions(+), 22 deletions(-) diff --git a/src/zabapgit_object_jobd.prog.abap b/src/zabapgit_object_jobd.prog.abap index 8f0d4dea2..74502dac2 100644 --- a/src/zabapgit_object_jobd.prog.abap +++ b/src/zabapgit_object_jobd.prog.abap @@ -32,12 +32,16 @@ CLASS lcl_object_jobd IMPLEMENTATION. METHOD lif_object~exists. + DATA: jd_name TYPE c LENGTH 32. + + jd_name = ms_item-obj_name. + TRY. - cl_jr_jd_manager=>check_jd_existence( + CALL METHOD ('CL_JR_JD_MANAGER')=>('CHECK_JD_EXISTENCE') EXPORTING im_jd_name = |{ ms_item-obj_name }| IMPORTING - ex_is_existing = rv_bool ). + ex_is_existing = rv_bool. CATCH cx_root. lcx_exception=>raise( |JOBD not supported| ). @@ -47,18 +51,20 @@ CLASS lcl_object_jobd IMPLEMENTATION. METHOD lif_object~serialize. - DATA: ls_job_definition TYPE cl_jr_job_definition=>ty_job_definition. + DATA: ls_job_definition TYPE cl_jr_job_definition=>ty_job_definition, + lo_job_definition TYPE REF TO object, + jd_name TYPE c LENGTH 32. + + jd_name = ms_item-obj_name. TRY. - cl_jr_jd_manager=>get_instance( + CREATE OBJECT lo_job_definition TYPE ('CL_JR_JOB_DEFINITION') EXPORTING - im_jd_name = |{ ms_item-obj_name }| - IMPORTING - ex_jd_obj = DATA(lo_job_definition) ). + im_jd_name = jd_name. - lo_job_definition->get_jd_attributes( + CALL METHOD lo_job_definition->('GET_JD_ATTRIBUTES') IMPORTING - ex_jd_attributes = ls_job_definition ). + ex_jd_attributes = ls_job_definition. CLEAR: ls_job_definition-jdpackage, ls_job_definition-btcjob_user, @@ -79,7 +85,11 @@ CLASS lcl_object_jobd IMPLEMENTATION. METHOD lif_object~deserialize. - DATA: ls_job_definition TYPE cl_jr_job_definition=>ty_job_definition. + DATA: ls_job_definition TYPE cl_jr_job_definition=>ty_job_definition, + lo_job_definition TYPE REF TO object, + jd_name TYPE c LENGTH 32. + + jd_name = ms_item-obj_name. TRY. io_xml->read( @@ -88,15 +98,15 @@ CLASS lcl_object_jobd IMPLEMENTATION. CHANGING cg_data = ls_job_definition ). - cl_jr_jd_manager=>create_instance( + CREATE OBJECT lo_job_definition TYPE ('CL_JR_JOB_DEFINITION') EXPORTING - im_jd_name = |{ ms_item-obj_name }| - IMPORTING - ex_jd_obj = DATA(lo_job_definition) ). + im_jd_name = jd_name. ls_job_definition-jdpackage = iv_package. - lo_job_definition->create_jd( ls_job_definition ). + CALL METHOD lo_job_definition->('CREATE_JD') + EXPORTING + im_jd_attributes = ls_job_definition. CATCH cx_root. lcx_exception=>raise( |Error deserializing JOBD| ). @@ -108,14 +118,17 @@ CLASS lcl_object_jobd IMPLEMENTATION. METHOD lif_object~delete. - TRY. - cl_jr_jd_manager=>get_instance( - EXPORTING - im_jd_name = |{ ms_item-obj_name }| - IMPORTING - ex_jd_obj = DATA(lo_job_definition) ). + DATA: lo_job_definition TYPE REF TO object, + jd_name TYPE c LENGTH 32. - lo_job_definition->delete_jd( ). + jd_name = ms_item-obj_name. + + TRY. + CREATE OBJECT lo_job_definition TYPE ('CL_JR_JOB_DEFINITION') + EXPORTING + im_jd_name = jd_name. + + CALL METHOD lo_job_definition->('DELETE_JD'). CATCH cx_root. lcx_exception=>raise( |Error deleting JOBD| ). From 0ce7d9c5d8386598a4ba9dbc0ca9ac3617ef3c75 Mon Sep 17 00:00:00 2001 From: Christian Guenter Date: Wed, 9 Aug 2017 20:34:47 +0000 Subject: [PATCH 3/5] JOBD Downport structures --- src/zabapgit_object_jobd.prog.abap | 58 ++++++++++++++++++++++-------- 1 file changed, 44 insertions(+), 14 deletions(-) diff --git a/src/zabapgit_object_jobd.prog.abap b/src/zabapgit_object_jobd.prog.abap index 74502dac2..7109904f4 100644 --- a/src/zabapgit_object_jobd.prog.abap +++ b/src/zabapgit_object_jobd.prog.abap @@ -51,31 +51,51 @@ CLASS lcl_object_jobd IMPLEMENTATION. METHOD lif_object~serialize. - DATA: ls_job_definition TYPE cl_jr_job_definition=>ty_job_definition, + DATA: lr_job_definition TYPE REF TO data, lo_job_definition TYPE REF TO object, jd_name TYPE c LENGTH 32. + FIELD-SYMBOLS: TYPE any, + TYPE any. + jd_name = ms_item-obj_name. TRY. + CREATE DATA lr_job_definition TYPE ('CL_JR_JOB_DEFINITION=>TY_JOB_DEFINITION'). + ASSIGN lr_job_definition->* TO . + ASSERT sy-subrc = 0. + CREATE OBJECT lo_job_definition TYPE ('CL_JR_JOB_DEFINITION') EXPORTING im_jd_name = jd_name. CALL METHOD lo_job_definition->('GET_JD_ATTRIBUTES') IMPORTING - ex_jd_attributes = ls_job_definition. + ex_jd_attributes = . - CLEAR: ls_job_definition-jdpackage, - ls_job_definition-btcjob_user, - ls_job_definition-owner, - ls_job_definition-created_date, - ls_job_definition-created_time, - ls_job_definition-changed_date, - ls_job_definition-changed_time. + ASSIGN COMPONENT 'JDPACKAGE' OF STRUCTURE TO . + CLEAR . + + ASSIGN COMPONENT 'BTCJOB_USER' OF STRUCTURE TO . + CLEAR . + + ASSIGN COMPONENT 'OWNER' OF STRUCTURE TO . + CLEAR . + + ASSIGN COMPONENT 'CREATED_DATE' OF STRUCTURE TO . + CLEAR . + + ASSIGN COMPONENT 'CREATED_TIME' OF STRUCTURE TO . + CLEAR . + + ASSIGN COMPONENT 'CHANGED_DATE' OF STRUCTURE TO . + CLEAR . + + ASSIGN COMPONENT 'CHANGED_TIME' OF STRUCTURE TO . + CLEAR . io_xml->add( iv_name = 'JOBD' - ig_data = ls_job_definition ). + ig_data = ). CATCH cx_root. lcx_exception=>raise( |Error serializing JOBD| ). @@ -85,28 +105,38 @@ CLASS lcl_object_jobd IMPLEMENTATION. METHOD lif_object~deserialize. - DATA: ls_job_definition TYPE cl_jr_job_definition=>ty_job_definition, + DATA: lr_job_definition TYPE REF TO data, lo_job_definition TYPE REF TO object, jd_name TYPE c LENGTH 32. + FIELD-SYMBOLS: TYPE any, + TYPE any. + jd_name = ms_item-obj_name. TRY. + CREATE DATA lr_job_definition TYPE ('CL_JR_JOB_DEFINITION=>TY_JOB_DEFINITION'). + ASSIGN lr_job_definition->* TO . + ASSERT sy-subrc = 0. + io_xml->read( EXPORTING iv_name = 'JOBD' CHANGING - cg_data = ls_job_definition ). + cg_data = ). CREATE OBJECT lo_job_definition TYPE ('CL_JR_JOB_DEFINITION') EXPORTING im_jd_name = jd_name. - ls_job_definition-jdpackage = iv_package. + + ASSIGN COMPONENT 'JDPACKAGE' OF STRUCTURE TO . + + = iv_package. CALL METHOD lo_job_definition->('CREATE_JD') EXPORTING - im_jd_attributes = ls_job_definition. + im_jd_attributes = . CATCH cx_root. lcx_exception=>raise( |Error deserializing JOBD| ). From 82dbd63fee04d0fd777cca2f98154b293b7ae9e8 Mon Sep 17 00:00:00 2001 From: Christian Guenter Date: Thu, 10 Aug 2017 18:23:23 +0000 Subject: [PATCH 4/5] cleanup --- src/zabapgit_object_jobd.prog.abap | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/zabapgit_object_jobd.prog.abap b/src/zabapgit_object_jobd.prog.abap index 7109904f4..94feb8df0 100644 --- a/src/zabapgit_object_jobd.prog.abap +++ b/src/zabapgit_object_jobd.prog.abap @@ -7,6 +7,9 @@ CLASS lcl_object_jobd DEFINITION INHERITING FROM lcl_objects_super FINAL. PUBLIC SECTION. INTERFACES lif_object. + PRIVATE SECTION. + TYPES: ty_jd_name TYPE c LENGTH 32. + ENDCLASS. CLASS lcl_object_jobd IMPLEMENTATION. @@ -32,14 +35,14 @@ CLASS lcl_object_jobd IMPLEMENTATION. METHOD lif_object~exists. - DATA: jd_name TYPE c LENGTH 32. + DATA: jd_name TYPE ty_jd_name. jd_name = ms_item-obj_name. TRY. CALL METHOD ('CL_JR_JD_MANAGER')=>('CHECK_JD_EXISTENCE') EXPORTING - im_jd_name = |{ ms_item-obj_name }| + im_jd_name = jd_name IMPORTING ex_is_existing = rv_bool. @@ -53,7 +56,7 @@ CLASS lcl_object_jobd IMPLEMENTATION. DATA: lr_job_definition TYPE REF TO data, lo_job_definition TYPE REF TO object, - jd_name TYPE c LENGTH 32. + jd_name TYPE ty_jd_name. FIELD-SYMBOLS: TYPE any, TYPE any. @@ -107,7 +110,7 @@ CLASS lcl_object_jobd IMPLEMENTATION. DATA: lr_job_definition TYPE REF TO data, lo_job_definition TYPE REF TO object, - jd_name TYPE c LENGTH 32. + jd_name TYPE ty_jd_name. FIELD-SYMBOLS: TYPE any, TYPE any. From b0c25b0d0405970e04dec7f3235a13513958d3d5 Mon Sep 17 00:00:00 2001 From: Christian Guenter Date: Thu, 10 Aug 2017 18:27:55 +0000 Subject: [PATCH 5/5] Pretty Print --- src/zabapgit_object_serializing.prog.abap | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/zabapgit_object_serializing.prog.abap b/src/zabapgit_object_serializing.prog.abap index 4a674a53a..21d37a603 100644 --- a/src/zabapgit_object_serializing.prog.abap +++ b/src/zabapgit_object_serializing.prog.abap @@ -25,7 +25,7 @@ INCLUDE zabapgit_object_fugr. INCLUDE zabapgit_object_iarp. INCLUDE zabapgit_object_iasp. INCLUDE zabapgit_object_iatu. -INCLUDE zabapgit_object_JOBD. +INCLUDE zabapgit_object_jobd. INCLUDE zabapgit_object_intf. INCLUDE zabapgit_object_msag. INCLUDE zabapgit_object_nrob.