From a4019f38fbbcdccdaeb5312148b14e316137e4c1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Christian=20G=C3=BCnter?= Date: Thu, 10 Apr 2025 20:02:07 +0200 Subject: [PATCH 1/3] HTTP: Detect if it's supported in constructor (#7204) --- src/objects/zcl_abapgit_object_http.clas.abap | 26 +++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/src/objects/zcl_abapgit_object_http.clas.abap b/src/objects/zcl_abapgit_object_http.clas.abap index 319ca7f39..3824833cf 100644 --- a/src/objects/zcl_abapgit_object_http.clas.abap +++ b/src/objects/zcl_abapgit_object_http.clas.abap @@ -7,6 +7,14 @@ CLASS zcl_abapgit_object_http DEFINITION PUBLIC SECTION. INTERFACES zif_abapgit_object. + METHODS constructor + IMPORTING + is_item TYPE zif_abapgit_definitions=>ty_item + iv_language TYPE spras + io_files TYPE REF TO zcl_abapgit_objects_files OPTIONAL + io_i18n_params TYPE REF TO zcl_abapgit_i18n_params OPTIONAL + RAISING + zcx_abapgit_exception. PROTECTED SECTION. PRIVATE SECTION. @@ -45,6 +53,24 @@ ENDCLASS. CLASS zcl_abapgit_object_http IMPLEMENTATION. + METHOD constructor. + + DATA: lr_dummy TYPE REF TO data. + + super->constructor( + is_item = is_item + iv_language = iv_language + io_files = io_files + io_i18n_params = io_i18n_params ). + + TRY. + CREATE DATA lr_dummy TYPE ('UCONHTTPSERVHEAD'). + CATCH cx_root. + zcx_abapgit_exception=>raise( 'HTTP not supported' ). + ENDTRY. + + ENDMETHOD. + METHOD zif_abapgit_object~changed_by. From b55791765f199fcdf20b815d5b29c3830b32bb99 Mon Sep 17 00:00:00 2001 From: Marc Bernard <59966492+mbtools@users.noreply.github.com> Date: Thu, 10 Apr 2025 20:10:41 +0200 Subject: [PATCH 2/3] Fix `zcl_abapgit_serializer` test (#7205) --- src/objects/core/zcl_abapgit_serialize.clas.abap | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/objects/core/zcl_abapgit_serialize.clas.abap b/src/objects/core/zcl_abapgit_serialize.clas.abap index 209eddd7c..4c6fe52a9 100644 --- a/src/objects/core/zcl_abapgit_serialize.clas.abap +++ b/src/objects/core/zcl_abapgit_serialize.clas.abap @@ -278,9 +278,11 @@ CLASS zcl_abapgit_serialize IMPLEMENTATION. ms_i18n_params-main_language_only = is_local_settings-main_language_only. ENDIF. - CREATE OBJECT mo_abap_language_version - EXPORTING - io_dot_abapgit = mo_dot_abapgit. + IF mo_dot_abapgit IS NOT INITIAL. + CREATE OBJECT mo_abap_language_version + EXPORTING + io_dot_abapgit = mo_dot_abapgit. + ENDIF. ENDMETHOD. From c0ce2cb2e29deae39fbf4a09c42f142d8456a11d Mon Sep 17 00:00:00 2001 From: Marc Bernard <59966492+mbtools@users.noreply.github.com> Date: Thu, 10 Apr 2025 20:32:57 +0200 Subject: [PATCH 3/3] Add clarifying comment to `exists` check (#7207) --- src/objects/zcl_abapgit_objects.clas.abap | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/objects/zcl_abapgit_objects.clas.abap b/src/objects/zcl_abapgit_objects.clas.abap index c2c25fb4b..f7c8a0dab 100644 --- a/src/objects/zcl_abapgit_objects.clas.abap +++ b/src/objects/zcl_abapgit_objects.clas.abap @@ -991,6 +991,9 @@ CLASS zcl_abapgit_objects IMPLEMENTATION. RETURN. ENDIF. + " We want the object list of a repository to show unsupported object (without serializing them) + " This is why the follow check and the caught exception return true. + " For unsupported objects, assume object exists IF is_type_supported( is_item-obj_type ) = abap_false. rv_bool = abap_true.