From d36b43defe2949fc53c880206ebb8537f21d0463 Mon Sep 17 00:00:00 2001 From: Lars Hvam Date: Thu, 4 Jun 2020 15:10:35 +0200 Subject: [PATCH] line break parameters (#3444) * line break parameters * Update zcl_abapgit_gui_page_repo_sett.clas.abap * Update zcl_abapgit_gui_page_repo_sett.clas.abap * fix --- abaplint.json | 1 + ...abapgit_apack_reader.clas.testclasses.abap | 9 +- src/git/zcl_abapgit_git_pack.clas.abap | 3 +- ...zcl_abapgit_git_pack.clas.testclasses.abap | 9 +- src/git/zcl_abapgit_git_porcelain.clas.abap | 6 +- .../zcl_abapgit_2fa_github_auth.clas.abap | 9 +- src/objects/zcl_abapgit_object_dcls.clas.abap | 3 +- src/objects/zcl_abapgit_object_devc.clas.abap | 12 ++- src/objects/zcl_abapgit_object_doma.clas.abap | 3 +- src/objects/zcl_abapgit_object_dtel.clas.abap | 3 +- .../zcl_abapgit_object_enho_class.clas.abap | 3 +- src/objects/zcl_abapgit_object_enqu.clas.abap | 3 +- src/objects/zcl_abapgit_object_fugr.clas.abap | 24 +++-- src/objects/zcl_abapgit_object_sfpf.clas.abap | 3 +- src/objects/zcl_abapgit_object_shi3.clas.abap | 3 +- src/objects/zcl_abapgit_object_shlp.clas.abap | 3 +- src/objects/zcl_abapgit_object_tabl.clas.abap | 3 +- .../zcl_abapgit_object_tabl_compar.clas.abap | 3 +- src/objects/zcl_abapgit_object_ttyp.clas.abap | 3 +- src/objects/zcl_abapgit_object_udmo.clas.abap | 3 +- src/objects/zcl_abapgit_object_ueno.clas.abap | 3 +- src/objects/zcl_abapgit_object_vcls.clas.abap | 18 ++-- src/objects/zcl_abapgit_object_view.clas.abap | 3 +- .../zcl_abapgit_object_w3super.clas.abap | 12 ++- .../zcl_abapgit_objects_generic.clas.abap | 7 +- .../zcl_abapgit_objects_super.clas.abap | 3 +- .../zcl_abapgit_sotr_handler.clas.abap | 8 +- .../zcl_abapgit_persistence_user.clas.abap | 12 ++- src/syntax/zcl_abapgit_syntax_abap.clas.abap | 4 +- src/syntax/zcl_abapgit_syntax_css.clas.abap | 24 +++-- .../zcl_abapgit_syntax_highlighter.clas.abap | 7 +- ...t_syntax_highlighter.clas.testclasses.abap | 48 ++++++---- src/syntax/zcl_abapgit_syntax_js.clas.abap | 6 +- ...it_gui_asset_manager.clas.testclasses.abap | 6 +- .../zcl_abapgit_gui_css_processor.clas.abap | 3 +- ...it_gui_css_processor.clas.testclasses.abap | 36 ++++--- .../zcl_abapgit_gui_html_processor.clas.abap | 23 +++-- ...t_gui_html_processor.clas.testclasses.abap | 12 ++- src/ui/core/zcl_abapgit_html.clas.abap | 12 ++- src/ui/db/zcl_abapgit_gui_page_db.clas.abap | 9 +- src/ui/zcl_abapgit_gui_chunk_lib.clas.abap | 15 ++- .../zcl_abapgit_gui_page_boverview.clas.abap | 3 +- .../zcl_abapgit_gui_page_codi_base.clas.abap | 3 +- src/ui/zcl_abapgit_gui_page_diff.clas.abap | 21 ++-- src/ui/zcl_abapgit_gui_page_main.clas.abap | 6 +- src/ui/zcl_abapgit_gui_page_merge.clas.abap | 7 +- .../zcl_abapgit_gui_page_merge_res.clas.abap | 24 +++-- .../zcl_abapgit_gui_page_repo_sett.clas.abap | 6 +- src/ui/zcl_abapgit_gui_router.clas.abap | 3 +- src/ui/zcl_abapgit_gui_view_repo.clas.abap | 21 ++-- .../zcl_abapgit_gui_view_tutorial.clas.abap | 12 ++- .../zcl_abapgit_html_action_utils.clas.abap | 71 +++++++++----- ...it_html_action_utils.clas.testclasses.abap | 10 +- ...cl_abapgit_ui_factory.clas.locals_imp.abap | 3 +- .../zcl_abapgit_path.clas.testclasses.abap | 96 ++++++++++++------- src/xml/zcl_abapgit_xml.clas.abap | 3 +- src/xml/zcl_abapgit_xml_input.clas.abap | 3 +- src/xml/zcl_abapgit_xml_output.clas.abap | 3 +- ..._abapgit_dot_abapgit.clas.testclasses.abap | 15 ++- src/zcl_abapgit_news.clas.abap | 15 ++- src/zcl_abapgit_news.clas.testclasses.abap | 57 +++++++---- src/zcl_abapgit_objects.clas.abap | 24 +++-- src/zcl_abapgit_repo_content_list.clas.abap | 3 +- ...cx_abapgit_exception.clas.testclasses.abap | 30 ++++-- 64 files changed, 552 insertions(+), 267 deletions(-) diff --git a/abaplint.json b/abaplint.json index 143f76b94..111a252c1 100644 --- a/abaplint.json +++ b/abaplint.json @@ -68,6 +68,7 @@ "globalMacros": [] }, "rules": { + "line_break_multiple_parameters": true, "unknown_types": true, "forbidden_void_type": { "check": ["^stringtab$", "^SYCHAR01$", "^char2$", "^char20$", "^int4$", "^flag$", "^char12$", "^char10$", "^char70$", "^char4$"] diff --git a/src/apack/zcl_abapgit_apack_reader.clas.testclasses.abap b/src/apack/zcl_abapgit_apack_reader.clas.testclasses.abap index a0996d56c..91f11ceb9 100644 --- a/src/apack/zcl_abapgit_apack_reader.clas.testclasses.abap +++ b/src/apack/zcl_abapgit_apack_reader.clas.testclasses.abap @@ -30,9 +30,12 @@ CLASS ltcl_apack_manifest_reader IMPLEMENTATION. METHOD verify_own_descriptor. cl_abap_unit_assert=>assert_not_initial( is_manifest_descriptor ). - cl_abap_unit_assert=>assert_equals( exp = 'github.com/larshp' act = is_manifest_descriptor-group_id ). - cl_abap_unit_assert=>assert_equals( exp = 'abapGit' act = is_manifest_descriptor-artifact_id ). - cl_abap_unit_assert=>assert_equals( exp = '1.42' act = is_manifest_descriptor-version ). + cl_abap_unit_assert=>assert_equals( exp = 'github.com/larshp' + act = is_manifest_descriptor-group_id ). + cl_abap_unit_assert=>assert_equals( exp = 'abapGit' + act = is_manifest_descriptor-artifact_id ). + cl_abap_unit_assert=>assert_equals( exp = '1.42' + act = is_manifest_descriptor-version ). " Repository type is added automatically by serializer later cl_abap_unit_assert=>assert_initial( is_manifest_descriptor-repository_type ). cl_abap_unit_assert=>assert_equals( exp = 'https://github.com/larshp/abapGit.git' diff --git a/src/git/zcl_abapgit_git_pack.clas.abap b/src/git/zcl_abapgit_git_pack.clas.abap index b79b7dc50..77c24aca9 100644 --- a/src/git/zcl_abapgit_git_pack.clas.abap +++ b/src/git/zcl_abapgit_git_pack.clas.abap @@ -582,7 +582,8 @@ CLASS ZCL_ABAPGIT_GIT_PACK IMPLEMENTATION. ENDWHILE. - lv_sha1 = zcl_abapgit_hash=>sha1( iv_type = -type iv_data = lv_result ). + lv_sha1 = zcl_abapgit_hash=>sha1( iv_type = -type + iv_data = lv_result ). CLEAR ls_object. ls_object-sha1 = lv_sha1. diff --git a/src/git/zcl_abapgit_git_pack.clas.testclasses.abap b/src/git/zcl_abapgit_git_pack.clas.testclasses.abap index d74b35068..c961af714 100644 --- a/src/git/zcl_abapgit_git_pack.clas.testclasses.abap +++ b/src/git/zcl_abapgit_git_pack.clas.testclasses.abap @@ -326,7 +326,8 @@ CLASS ltcl_pack IMPLEMENTATION. * blob lv_data = lc_data. CLEAR ls_object. - ls_object-sha1 = zcl_abapgit_hash=>sha1( iv_type = zif_abapgit_definitions=>c_type-blob iv_data = lv_data ). + ls_object-sha1 = zcl_abapgit_hash=>sha1( iv_type = zif_abapgit_definitions=>c_type-blob + iv_data = lv_data ). ls_object-type = zif_abapgit_definitions=>c_type-blob. ls_object-data = lv_data. ls_object-index = 1. @@ -342,7 +343,8 @@ CLASS ltcl_pack IMPLEMENTATION. ls_commit-body = 'body'. lv_data = zcl_abapgit_git_pack=>encode_commit( ls_commit ). CLEAR ls_object. - ls_object-sha1 = zcl_abapgit_hash=>sha1( iv_type = zif_abapgit_definitions=>c_type-commit iv_data = lv_data ). + ls_object-sha1 = zcl_abapgit_hash=>sha1( iv_type = zif_abapgit_definitions=>c_type-commit + iv_data = lv_data ). ls_object-type = zif_abapgit_definitions=>c_type-commit. ls_object-data = lv_data. ls_object-index = 2. @@ -357,7 +359,8 @@ CLASS ltcl_pack IMPLEMENTATION. APPEND ls_node TO lt_nodes. lv_data = zcl_abapgit_git_pack=>encode_tree( lt_nodes ). CLEAR ls_object. - ls_object-sha1 = zcl_abapgit_hash=>sha1( iv_type = zif_abapgit_definitions=>c_type-tree iv_data = lv_data ). + ls_object-sha1 = zcl_abapgit_hash=>sha1( iv_type = zif_abapgit_definitions=>c_type-tree + iv_data = lv_data ). ls_object-type = zif_abapgit_definitions=>c_type-tree. ls_object-data = lv_data. ls_object-index = 3. diff --git a/src/git/zcl_abapgit_git_porcelain.clas.abap b/src/git/zcl_abapgit_git_porcelain.clas.abap index 4d88496e0..2a729592b 100644 --- a/src/git/zcl_abapgit_git_porcelain.clas.abap +++ b/src/git/zcl_abapgit_git_porcelain.clas.abap @@ -212,7 +212,8 @@ CLASS ZCL_ABAPGIT_GIT_PORCELAIN IMPLEMENTATION. CLEAR ls_tree. ls_tree-path = -path. ls_tree-data = zcl_abapgit_git_pack=>encode_tree( lt_nodes ). - ls_tree-sha1 = zcl_abapgit_hash=>sha1( iv_type = zif_abapgit_definitions=>c_type-tree iv_data = ls_tree-data ). + ls_tree-sha1 = zcl_abapgit_hash=>sha1( iv_type = zif_abapgit_definitions=>c_type-tree + iv_data = ls_tree-data ). APPEND ls_tree TO rt_trees. -sha1 = ls_tree-sha1. @@ -597,7 +598,8 @@ CLASS ZCL_ABAPGIT_GIT_PORCELAIN IMPLEMENTATION. ls_commit-body = is_comment-comment. lv_commit = zcl_abapgit_git_pack=>encode_commit( ls_commit ). - ls_object-sha1 = zcl_abapgit_hash=>sha1( iv_type = zif_abapgit_definitions=>c_type-commit iv_data = lv_commit ). + ls_object-sha1 = zcl_abapgit_hash=>sha1( iv_type = zif_abapgit_definitions=>c_type-commit + iv_data = lv_commit ). ls_object-type = zif_abapgit_definitions=>c_type-commit. ls_object-data = lv_commit. APPEND ls_object TO et_new_objects. diff --git a/src/http/zcl_abapgit_2fa_github_auth.clas.abap b/src/http/zcl_abapgit_2fa_github_auth.clas.abap index 224a5eebc..a462317d2 100644 --- a/src/http/zcl_abapgit_2fa_github_auth.clas.abap +++ b/src/http/zcl_abapgit_2fa_github_auth.clas.abap @@ -93,8 +93,10 @@ CLASS ZCL_ABAPGIT_2FA_GITHUB_AUTH IMPLEMENTATION. " https://developer.github.com/v3/auth/#working-with-two-factor-authentication ri_client->propertytype_accept_cookie = if_http_client=>co_enabled. - ri_client->request->set_header_field( name = c_otp_header_name value = iv_2fa_token ). - ri_client->authenticate( username = iv_username password = iv_password ). + ri_client->request->set_header_field( name = c_otp_header_name + value = iv_2fa_token ). + ri_client->authenticate( username = iv_username + password = iv_password ). ri_client->propertytype_logon_popup = if_http_client=>co_disabled. ri_client->send( EXCEPTIONS OTHERS = 1 ). @@ -327,7 +329,8 @@ CLASS ZCL_ABAPGIT_2FA_GITHUB_AUTH IMPLEMENTATION. li_client->request->set_method( if_http_request=>co_request_method_post ). " Try to authenticate, if 2FA is required there will be a specific response header - li_client->authenticate( username = iv_username password = iv_password ). + li_client->authenticate( username = iv_username + password = iv_password ). li_client->send( EXCEPTIONS OTHERS = 1 ). IF sy-subrc <> 0. diff --git a/src/objects/zcl_abapgit_object_dcls.clas.abap b/src/objects/zcl_abapgit_object_dcls.clas.abap index f3815ec28..066013cad 100644 --- a/src/objects/zcl_abapgit_object_dcls.clas.abap +++ b/src/objects/zcl_abapgit_object_dcls.clas.abap @@ -213,7 +213,8 @@ CLASS ZCL_ABAPGIT_OBJECT_DCLS IMPLEMENTATION. ASSIGN COMPONENT 'SOURCE' OF STRUCTURE TO . ASSERT sy-subrc = 0. - mo_files->add_string( iv_ext = 'asdcls' iv_string = ). + mo_files->add_string( iv_ext = 'asdcls' + iv_string = ). CLEAR . diff --git a/src/objects/zcl_abapgit_object_devc.clas.abap b/src/objects/zcl_abapgit_object_devc.clas.abap index 844d50cb6..050ec77cf 100644 --- a/src/objects/zcl_abapgit_object_devc.clas.abap +++ b/src/objects/zcl_abapgit_object_devc.clas.abap @@ -419,7 +419,8 @@ CLASS ZCL_ABAPGIT_OBJECT_DEVC IMPLEMENTATION. IF li_package IS BOUND. " Package already exists, change it - set_lock( ii_package = li_package iv_lock = abap_true ). + set_lock( ii_package = li_package + iv_lock = abap_true ). li_package->set_all_attributes( EXPORTING @@ -516,7 +517,8 @@ CLASS ZCL_ABAPGIT_OBJECT_DEVC IMPLEMENTATION. zcx_abapgit_exception=>raise_t100( ). ENDIF. - set_lock( ii_package = li_package iv_lock = abap_false ). + set_lock( ii_package = li_package + iv_lock = abap_false ). ENDMETHOD. @@ -670,7 +672,8 @@ CLASS ZCL_ABAPGIT_OBJECT_DEVC IMPLEMENTATION. CLEAR: ls_package_data-korrflag. - io_xml->add( iv_name = 'DEVC' ig_data = ls_package_data ). + io_xml->add( iv_name = 'DEVC' + ig_data = ls_package_data ). " Save package interface usages li_package->get_permissions_to_use( @@ -702,7 +705,8 @@ CLASS ZCL_ABAPGIT_OBJECT_DEVC IMPLEMENTATION. ENDLOOP. IF lt_usage_data IS NOT INITIAL. - io_xml->add( iv_name = 'PERMISSION' ig_data = lt_usage_data ). + io_xml->add( iv_name = 'PERMISSION' + ig_data = lt_usage_data ). ENDIF. ENDMETHOD. ENDCLASS. diff --git a/src/objects/zcl_abapgit_object_doma.clas.abap b/src/objects/zcl_abapgit_object_doma.clas.abap index 6410f2656..6367baabd 100644 --- a/src/objects/zcl_abapgit_object_doma.clas.abap +++ b/src/objects/zcl_abapgit_object_doma.clas.abap @@ -267,7 +267,8 @@ CLASS zcl_abapgit_object_doma IMPLEMENTATION. io_xml->read( EXPORTING iv_name = 'DD07V_TAB' CHANGING cg_data = lt_dd07v ). - corr_insert( iv_package = iv_package ig_object_class = 'DICT' ). + corr_insert( iv_package = iv_package + ig_object_class = 'DICT' ). lv_name = ms_item-obj_name. " type conversion diff --git a/src/objects/zcl_abapgit_object_dtel.clas.abap b/src/objects/zcl_abapgit_object_dtel.clas.abap index f6711539e..fc73e7e9a 100644 --- a/src/objects/zcl_abapgit_object_dtel.clas.abap +++ b/src/objects/zcl_abapgit_object_dtel.clas.abap @@ -190,7 +190,8 @@ CLASS ZCL_ABAPGIT_OBJECT_DTEL IMPLEMENTATION. io_xml->read( EXPORTING iv_name = 'DD04V' CHANGING cg_data = ls_dd04v ). - corr_insert( iv_package = iv_package ig_object_class = 'DICT' ). + corr_insert( iv_package = iv_package + ig_object_class = 'DICT' ). lv_name = ms_item-obj_name. " type conversion diff --git a/src/objects/zcl_abapgit_object_enho_class.clas.abap b/src/objects/zcl_abapgit_object_enho_class.clas.abap index 2454cfcfc..3dc9042ed 100644 --- a/src/objects/zcl_abapgit_object_enho_class.clas.abap +++ b/src/objects/zcl_abapgit_object_enho_class.clas.abap @@ -205,7 +205,8 @@ CLASS zcl_abapgit_object_enho_class IMPLEMENTATION. methname = lv_methname methsource = lt_abap ). CATCH cx_enh_mod_not_allowed cx_enh_is_not_enhanceable INTO lx_enh. - zcx_abapgit_exception=>raise( iv_text = 'Error deserializing ENHO method include' ix_previous = lx_enh ). + zcx_abapgit_exception=>raise( iv_text = 'Error deserializing ENHO method include' + ix_previous = lx_enh ). ENDTRY. ENDLOOP. diff --git a/src/objects/zcl_abapgit_object_enqu.clas.abap b/src/objects/zcl_abapgit_object_enqu.clas.abap index 6670ab1c9..dc32286a6 100644 --- a/src/objects/zcl_abapgit_object_enqu.clas.abap +++ b/src/objects/zcl_abapgit_object_enqu.clas.abap @@ -68,7 +68,8 @@ CLASS ZCL_ABAPGIT_OBJECT_ENQU IMPLEMENTATION. io_xml->read( EXPORTING iv_name = 'DD27P_TABLE' CHANGING cg_data = lt_dd27p ). - corr_insert( iv_package = iv_package ig_object_class = 'DICT' ). + corr_insert( iv_package = iv_package + ig_object_class = 'DICT' ). lv_name = ms_item-obj_name. diff --git a/src/objects/zcl_abapgit_object_fugr.clas.abap b/src/objects/zcl_abapgit_object_fugr.clas.abap index 1108e0d66..380952a5f 100644 --- a/src/objects/zcl_abapgit_object_fugr.clas.abap +++ b/src/objects/zcl_abapgit_object_fugr.clas.abap @@ -253,7 +253,8 @@ CLASS ZCL_ABAPGIT_OBJECT_FUGR IMPLEMENTATION. IF sy-subrc <> 0. MESSAGE ID sy-msgid TYPE 'S' NUMBER sy-msgno WITH sy-msgv1 sy-msgv2 sy-msgv3 sy-msgv4 INTO lv_msg. - ii_log->add_error( iv_msg = |Function module { -funcname }: { lv_msg }| is_item = ms_item ). + ii_log->add_error( iv_msg = |Function module { -funcname }: { lv_msg }| + is_item = ms_item ). CONTINUE. "with next function module ENDIF. @@ -276,7 +277,8 @@ CLASS ZCL_ABAPGIT_OBJECT_FUGR IMPLEMENTATION. OTHERS = 2. IF sy-subrc <> 0. MESSAGE ID sy-msgid TYPE 'S' NUMBER sy-msgno WITH sy-msgv1 sy-msgv2 sy-msgv3 sy-msgv4 INTO lv_msg. - ii_log->add_error( iv_msg = |Function module { -funcname }: { lv_msg }| is_item = ms_item ). + ii_log->add_error( iv_msg = |Function module { -funcname }: { lv_msg }| + is_item = ms_item ). CONTINUE. "with next function module ENDIF. ENDIF. @@ -325,12 +327,14 @@ CLASS ZCL_ABAPGIT_OBJECT_FUGR IMPLEMENTATION. OTHERS = 11. IF sy-subrc <> 0. MESSAGE ID sy-msgid TYPE 'S' NUMBER sy-msgno WITH sy-msgv1 sy-msgv2 sy-msgv3 sy-msgv4 INTO lv_msg. - ii_log->add_error( iv_msg = |Function module { -funcname }: { lv_msg }| is_item = ms_item ). + ii_log->add_error( iv_msg = |Function module { -funcname }: { lv_msg }| + is_item = ms_item ). CONTINUE. "with next function module ENDIF. INSERT REPORT lv_include FROM lt_source. - ii_log->add_success( iv_msg = |Function module { -funcname } imported| is_item = ms_item ). + ii_log->add_success( iv_msg = |Function module { -funcname } imported| + is_item = ms_item ). ENDLOOP. ENDMETHOD. @@ -358,7 +362,8 @@ CLASS ZCL_ABAPGIT_OBJECT_FUGR IMPLEMENTATION. "ignore simple transformation includes (as long as they remain in existing repositories) IF strlen( ) = 33 AND +30(3) = 'XTI'. - ii_log->add_warning( iv_msg = |Simple Transformation include { } ignored| is_item = ms_item ). + ii_log->add_warning( iv_msg = |Simple Transformation include { } ignored| + is_item = ms_item ). CONTINUE. ENDIF. @@ -383,10 +388,12 @@ CLASS ZCL_ABAPGIT_OBJECT_FUGR IMPLEMENTATION. it_tpool = lt_tpool iv_is_include = abap_true ). - ii_log->add_success( iv_msg = |Include { ls_progdir-name } imported| is_item = ms_item ). + ii_log->add_success( iv_msg = |Include { ls_progdir-name } imported| + is_item = ms_item ). CATCH zcx_abapgit_exception INTO lx_exc. - ii_log->add_exception( ix_exc = lx_exc is_item = ms_item ). + ii_log->add_exception( ix_exc = lx_exc + is_item = ms_item ). CONTINUE. ENDTRY. @@ -599,7 +606,8 @@ CLASS ZCL_ABAPGIT_OBJECT_FUGR IMPLEMENTATION. lv_maintviewname = |L{ ms_item-obj_name }T00|. ELSE. "FGroup name contains a namespace - lv_offset_ns = find( val = ms_item-obj_name+1 sub = '/' ). + lv_offset_ns = find( val = ms_item-obj_name+1 + sub = '/' ). lv_offset_ns = lv_offset_ns + 2. lv_maintviewname = |{ ms_item-obj_name(lv_offset_ns) }L{ ms_item-obj_name+lv_offset_ns }T00|. ENDIF. diff --git a/src/objects/zcl_abapgit_object_sfpf.clas.abap b/src/objects/zcl_abapgit_object_sfpf.clas.abap index 8be195c1c..6603e2789 100644 --- a/src/objects/zcl_abapgit_object_sfpf.clas.abap +++ b/src/objects/zcl_abapgit_object_sfpf.clas.abap @@ -91,7 +91,8 @@ CLASS ZCL_ABAPGIT_OBJECT_SFPF IMPLEMENTATION. lv_count = lv_count + 1. lv_new = |o{ lv_count }|. * Rewrite id - IF li_elem->set_attribute( name = 'id' value = lv_new ) IS NOT INITIAL. + IF li_elem->set_attribute( name = 'id' + value = lv_new ) IS NOT INITIAL. zcx_abapgit_exception=>raise( 'SFPF error, FIX_OREF' ). ENDIF. * Update references diff --git a/src/objects/zcl_abapgit_object_shi3.clas.abap b/src/objects/zcl_abapgit_object_shi3.clas.abap index 0b3d55e61..3e6be9962 100644 --- a/src/objects/zcl_abapgit_object_shi3.clas.abap +++ b/src/objects/zcl_abapgit_object_shi3.clas.abap @@ -62,7 +62,8 @@ CLASS ZCL_ABAPGIT_OBJECT_SHI3 IMPLEMENTATION. METHOD constructor. - super->constructor( is_item = is_item iv_language = iv_language ). + super->constructor( is_item = is_item + iv_language = iv_language ). mv_tree_id = ms_item-obj_name. ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_shlp.clas.abap b/src/objects/zcl_abapgit_object_shlp.clas.abap index 424faea61..7f49e0690 100644 --- a/src/objects/zcl_abapgit_object_shlp.clas.abap +++ b/src/objects/zcl_abapgit_object_shlp.clas.abap @@ -67,7 +67,8 @@ CLASS ZCL_ABAPGIT_OBJECT_SHLP IMPLEMENTATION. io_xml->read( EXPORTING iv_name = 'DD33V_TABLE' CHANGING cg_data = lt_dd33v ). - corr_insert( iv_package = iv_package ig_object_class = 'DICT' ). + corr_insert( iv_package = iv_package + ig_object_class = 'DICT' ). lv_name = ms_item-obj_name. diff --git a/src/objects/zcl_abapgit_object_tabl.clas.abap b/src/objects/zcl_abapgit_object_tabl.clas.abap index e88687a0c..2bc75b116 100644 --- a/src/objects/zcl_abapgit_object_tabl.clas.abap +++ b/src/objects/zcl_abapgit_object_tabl.clas.abap @@ -495,7 +495,8 @@ CLASS ZCL_ABAPGIT_OBJECT_TABL IMPLEMENTATION. io_xml->read( EXPORTING iv_name = 'DD36M' CHANGING cg_data = lt_dd36m ). - corr_insert( iv_package = iv_package ig_object_class = 'DICT' ). + corr_insert( iv_package = iv_package + ig_object_class = 'DICT' ). lv_name = ms_item-obj_name. " type conversion diff --git a/src/objects/zcl_abapgit_object_tabl_compar.clas.abap b/src/objects/zcl_abapgit_object_tabl_compar.clas.abap index 7835fa6c8..3f5c385df 100644 --- a/src/objects/zcl_abapgit_object_tabl_compar.clas.abap +++ b/src/objects/zcl_abapgit_object_tabl_compar.clas.abap @@ -207,7 +207,8 @@ CLASS ZCL_ABAPGIT_OBJECT_TABL_COMPAR IMPLEMENTATION. lv_inconsistent = abap_true. ENDIF. ELSE. - ii_log->add_info( iv_msg = |Field { ls_previous_table_field-fieldname } removed| is_item = ls_item ). + ii_log->add_info( iv_msg = |Field { ls_previous_table_field-fieldname } removed| + is_item = ls_item ). lv_inconsistent = abap_true. ENDIF. ENDLOOP. diff --git a/src/objects/zcl_abapgit_object_ttyp.clas.abap b/src/objects/zcl_abapgit_object_ttyp.clas.abap index d36d1db56..9ac47f856 100644 --- a/src/objects/zcl_abapgit_object_ttyp.clas.abap +++ b/src/objects/zcl_abapgit_object_ttyp.clas.abap @@ -67,7 +67,8 @@ CLASS ZCL_ABAPGIT_OBJECT_TTYP IMPLEMENTATION. io_xml->read( EXPORTING iv_name = 'DD43V' CHANGING cg_data = lt_dd43v ). - corr_insert( iv_package = iv_package ig_object_class = 'DICT' ). + corr_insert( iv_package = iv_package + ig_object_class = 'DICT' ). lv_name = ms_item-obj_name. " type conversion diff --git a/src/objects/zcl_abapgit_object_udmo.clas.abap b/src/objects/zcl_abapgit_object_udmo.clas.abap index e6c710abb..c8d1d2747 100644 --- a/src/objects/zcl_abapgit_object_udmo.clas.abap +++ b/src/objects/zcl_abapgit_object_udmo.clas.abap @@ -169,7 +169,8 @@ CLASS ZCL_ABAPGIT_OBJECT_UDMO IMPLEMENTATION. METHOD constructor. - super->constructor( is_item = is_item iv_language = iv_language ). + super->constructor( is_item = is_item + iv_language = iv_language ). " Conversion to Data model diff --git a/src/objects/zcl_abapgit_object_ueno.clas.abap b/src/objects/zcl_abapgit_object_ueno.clas.abap index ed673d7e6..c5c5eba67 100644 --- a/src/objects/zcl_abapgit_object_ueno.clas.abap +++ b/src/objects/zcl_abapgit_object_ueno.clas.abap @@ -128,7 +128,8 @@ CLASS zcl_abapgit_object_ueno IMPLEMENTATION. METHOD constructor. - super->constructor( is_item = is_item iv_language = iv_language ). + super->constructor( is_item = is_item + iv_language = iv_language ). me->mv_entity_id = is_item-obj_name. diff --git a/src/objects/zcl_abapgit_object_vcls.clas.abap b/src/objects/zcl_abapgit_object_vcls.clas.abap index 11be16778..1ef735c5f 100644 --- a/src/objects/zcl_abapgit_object_vcls.clas.abap +++ b/src/objects/zcl_abapgit_object_vcls.clas.abap @@ -192,12 +192,18 @@ CLASS ZCL_ABAPGIT_OBJECT_VCLS IMPLEMENTATION. lv_argument_langu = |@{ me->ms_item-obj_name }|. "Check all relevant maintein tabeles for view clusters - IF check_lock( iv_tabname = 'VCLDIR' iv_argument = lv_argument ) = abap_true - OR check_lock( iv_tabname = 'VCLDIRT' iv_argument = lv_argument_langu ) = abap_true - OR check_lock( iv_tabname = 'VCLSTRUC' iv_argument = lv_argument ) = abap_true - OR check_lock( iv_tabname = 'VCLSTRUCT' iv_argument = lv_argument_langu ) = abap_true - OR check_lock( iv_tabname = 'VCLSTRUC' iv_argument = lv_argument ) = abap_true - OR check_lock( iv_tabname = 'VCLMF' iv_argument = lv_argument ) = abap_true. + IF check_lock( iv_tabname = 'VCLDIR' + iv_argument = lv_argument ) = abap_true + OR check_lock( iv_tabname = 'VCLDIRT' + iv_argument = lv_argument_langu ) = abap_true + OR check_lock( iv_tabname = 'VCLSTRUC' + iv_argument = lv_argument ) = abap_true + OR check_lock( iv_tabname = 'VCLSTRUCT' + iv_argument = lv_argument_langu ) = abap_true + OR check_lock( iv_tabname = 'VCLSTRUC' + iv_argument = lv_argument ) = abap_true + OR check_lock( iv_tabname = 'VCLMF' + iv_argument = lv_argument ) = abap_true. rv_is_locked = abap_true. ENDIF. diff --git a/src/objects/zcl_abapgit_object_view.clas.abap b/src/objects/zcl_abapgit_object_view.clas.abap index 83e4fa3bf..8f091a8cb 100644 --- a/src/objects/zcl_abapgit_object_view.clas.abap +++ b/src/objects/zcl_abapgit_object_view.clas.abap @@ -107,7 +107,8 @@ CLASS ZCL_ABAPGIT_OBJECT_VIEW IMPLEMENTATION. io_xml->read( EXPORTING iv_name = 'DD28V_TABLE' CHANGING cg_data = lt_dd28v ). - corr_insert( iv_package = iv_package ig_object_class = 'DICT' ). + corr_insert( iv_package = iv_package + ig_object_class = 'DICT' ). lv_name = ms_item-obj_name. " type conversion diff --git a/src/objects/zcl_abapgit_object_w3super.clas.abap b/src/objects/zcl_abapgit_object_w3super.clas.abap index 5833f10c5..6975c8037 100644 --- a/src/objects/zcl_abapgit_object_w3super.clas.abap +++ b/src/objects/zcl_abapgit_object_w3super.clas.abap @@ -60,7 +60,8 @@ CLASS ZCL_ABAPGIT_OBJECT_W3SUPER IMPLEMENTATION. METHOD constructor. - super->constructor( is_item = is_item iv_language = iv_language ). + super->constructor( is_item = is_item + iv_language = iv_language ). ms_key-relid = ms_item-obj_type+2(2). ms_key-objid = ms_item-obj_name. ENDMETHOD. @@ -83,7 +84,8 @@ CLASS ZCL_ABAPGIT_OBJECT_W3SUPER IMPLEMENTATION. METHOD get_ext. - rv_ext = find_param( it_params = it_params iv_name = c_param_names-fileext ). + rv_ext = find_param( it_params = it_params + iv_name = c_param_names-fileext ). SHIFT rv_ext LEFT DELETING LEADING '.'. ENDMETHOD. @@ -124,7 +126,8 @@ CLASS ZCL_ABAPGIT_OBJECT_W3SUPER IMPLEMENTATION. FIELD-SYMBOLS LIKE LINE OF ct_params. " Remove path from filename - find_param( it_params = ct_params iv_name = c_param_names-filename ). " Check exists + find_param( it_params = ct_params + iv_name = c_param_names-filename ). " Check exists READ TABLE ct_params ASSIGNING WITH KEY name = c_param_names-filename. -value = zcl_abapgit_path=>get_filename_from_syspath( |{ -value }| ). @@ -463,7 +466,8 @@ CLASS ZCL_ABAPGIT_OBJECT_W3SUPER IMPLEMENTATION. zcx_abapgit_exception=>raise( 'Cannot read W3xx data' ). ENDIF. - lv_size = find_param( it_params = lt_w3params iv_name = c_param_names-filesize ). + lv_size = find_param( it_params = lt_w3params + iv_name = c_param_names-filesize ). " Clean params (remove version, filesize & clear filename from path) strip_params( CHANGING ct_params = lt_w3params ). diff --git a/src/objects/zcl_abapgit_objects_generic.clas.abap b/src/objects/zcl_abapgit_objects_generic.clas.abap index df407d8e3..44016352f 100644 --- a/src/objects/zcl_abapgit_objects_generic.clas.abap +++ b/src/objects/zcl_abapgit_objects_generic.clas.abap @@ -331,7 +331,8 @@ CLASS ZCL_ABAPGIT_OBJECTS_GENERIC IMPLEMENTATION. * Some datatype used in the key might exceed the total remaining characters length (e. g. SICF) TRY. - lv_remaining_length = strlen( |{ substring( val = cs_objkey-value off = lv_objkey_sub_pos ) }| ). + lv_remaining_length = strlen( |{ substring( val = cs_objkey-value + off = lv_objkey_sub_pos ) }| ). CATCH cx_sy_range_out_of_bounds. lv_remaining_length = 0. RETURN. ">>>>>>>>>>>>>>>>>>>>>>>>>>> @@ -342,7 +343,9 @@ CLASS ZCL_ABAPGIT_OBJECTS_GENERIC IMPLEMENTATION. lv_len = lv_remaining_length. ENDIF. - ls_objkey_sub-value = |{ substring( val = cs_objkey-value off = lv_objkey_sub_pos len = lv_len ) }|. + ls_objkey_sub-value = |{ substring( val = cs_objkey-value + off = lv_objkey_sub_pos + len = lv_len ) }|. ls_objkey_sub-num = cv_non_value_pos. INSERT ls_objkey_sub INTO TABLE ct_objkey. diff --git a/src/objects/zcl_abapgit_objects_super.clas.abap b/src/objects/zcl_abapgit_objects_super.clas.abap index e22a7e0c6..31deb4343 100644 --- a/src/objects/zcl_abapgit_objects_super.clas.abap +++ b/src/objects/zcl_abapgit_objects_super.clas.abap @@ -271,7 +271,8 @@ CLASS ZCL_ABAPGIT_OBJECTS_SUPER IMPLEMENTATION. ENDIF. CATCH cx_root INTO lx_error. - zcx_abapgit_exception=>raise( iv_text = 'ADT Jump Error' ix_previous = lx_error ). + zcx_abapgit_exception=>raise( iv_text = 'ADT Jump Error' + ix_previous = lx_error ). ENDTRY. ENDMETHOD. diff --git a/src/objects/zcl_abapgit_sotr_handler.clas.abap b/src/objects/zcl_abapgit_sotr_handler.clas.abap index e2c18a258..f25deaf3a 100644 --- a/src/objects/zcl_abapgit_sotr_handler.clas.abap +++ b/src/objects/zcl_abapgit_sotr_handler.clas.abap @@ -163,7 +163,9 @@ CLASS ZCL_ABAPGIT_SOTR_HANDLER IMPLEMENTATION. IF sy-subrc = 0. LOOP AT lt_seocompodf ASSIGNING . - lv_concept = translate( val = -attvalue from = '''' to = '' ). + lv_concept = translate( val = -attvalue + from = '''' + to = '' ). rt_sotr = get_sotr_4_concept( lv_concept ). ENDLOOP. ENDIF. @@ -191,7 +193,9 @@ CLASS ZCL_ABAPGIT_SOTR_HANDLER IMPLEMENTATION. OTHERS = 3. IF sy-subrc = 0. LOOP AT lt_sotr_use ASSIGNING . - lv_concept = translate( val = -concept from = '''' to = '' ). + lv_concept = translate( val = -concept + from = '''' + to = '' ). rt_sotr = get_sotr_4_concept( lv_concept ). ENDLOOP. ENDIF. diff --git a/src/persist/zcl_abapgit_persistence_user.clas.abap b/src/persist/zcl_abapgit_persistence_user.clas.abap index 7856d3a51..b3f21c091 100644 --- a/src/persist/zcl_abapgit_persistence_user.clas.abap +++ b/src/persist/zcl_abapgit_persistence_user.clas.abap @@ -332,7 +332,8 @@ CLASS ZCL_ABAPGIT_PERSISTENCE_USER IMPLEMENTATION. ls_repo_config = read_repo_config( iv_url ). ls_repo_config-git_user-email = iv_email. - update_repo_config( iv_url = iv_url is_repo_config = ls_repo_config ). + update_repo_config( iv_url = iv_url + is_repo_config = ls_repo_config ). ENDMETHOD. @@ -343,7 +344,8 @@ CLASS ZCL_ABAPGIT_PERSISTENCE_USER IMPLEMENTATION. ls_repo_config = read_repo_config( iv_url ). ls_repo_config-git_user-name = iv_username. - update_repo_config( iv_url = iv_url is_repo_config = ls_repo_config ). + update_repo_config( iv_url = iv_url + is_repo_config = ls_repo_config ). ENDMETHOD. @@ -354,7 +356,8 @@ CLASS ZCL_ABAPGIT_PERSISTENCE_USER IMPLEMENTATION. ls_repo_config = read_repo_config( iv_url ). ls_repo_config-last_change_seen = iv_version. - update_repo_config( iv_url = iv_url is_repo_config = ls_repo_config ). + update_repo_config( iv_url = iv_url + is_repo_config = ls_repo_config ). ENDMETHOD. @@ -365,7 +368,8 @@ CLASS ZCL_ABAPGIT_PERSISTENCE_USER IMPLEMENTATION. ls_repo_config = read_repo_config( iv_url ). ls_repo_config-login = iv_login. - update_repo_config( iv_url = iv_url is_repo_config = ls_repo_config ). + update_repo_config( iv_url = iv_url + is_repo_config = ls_repo_config ). ENDMETHOD. diff --git a/src/syntax/zcl_abapgit_syntax_abap.clas.abap b/src/syntax/zcl_abapgit_syntax_abap.clas.abap index 4a04475c8..3464475ff 100644 --- a/src/syntax/zcl_abapgit_syntax_abap.clas.abap +++ b/src/syntax/zcl_abapgit_syntax_abap.clas.abap @@ -220,7 +220,9 @@ CLASS ZCL_ABAPGIT_SYNTAX_ABAP IMPLEMENTATION. CASE -token. WHEN c_token-keyword. IF -offset > 0 - AND substring( val = iv_line off = ( -offset - 1 ) len = 1 ) CA '-<'. + AND substring( val = iv_line + off = ( -offset - 1 ) + len = 1 ) CA '-<'. " Delete match if keyword is part of structure or field symbol DELETE ct_matches INDEX lv_index. CONTINUE. diff --git a/src/syntax/zcl_abapgit_syntax_css.clas.abap b/src/syntax/zcl_abapgit_syntax_css.clas.abap index d94fa3654..98e72af05 100644 --- a/src/syntax/zcl_abapgit_syntax_css.clas.abap +++ b/src/syntax/zcl_abapgit_syntax_css.clas.abap @@ -197,27 +197,31 @@ CLASS ZCL_ABAPGIT_SYNTAX_CSS IMPLEMENTATION. 'transform|transform-origin|transform-style|transition|transition-delay|transition-duration|' && 'transition-property|transition-timing-function|unicode-bidi|user-select|vertical-align|visibility|' && 'white-space|width|word-break|word-spacing|word-wrap|writing-mode|z-index'. - insert_keywords( iv_keywords = lv_keywords iv_token = c_token-properties ). + insert_keywords( iv_keywords = lv_keywords + iv_token = c_token-properties ). " 2) CSS Values lv_keywords = 'absolute|all|auto|block|bold|border-box|both|bottom|center|counter|cover|dashed|fixed|hidden|important|' && 'inherit|initial|inline-block|italic|left|max-content|middle|min-content|no-repeat|none|normal|pointer|' && 'relative|rem|right|solid|table-cell|text|top|transparent|underline|url'. - insert_keywords( iv_keywords = lv_keywords iv_token = c_token-values ). + insert_keywords( iv_keywords = lv_keywords + iv_token = c_token-values ). " 3) CSS Selectors lv_keywords = ':active|::after|::before|:checked|:disabled|:empty|:enabled|:first-child|::first-letter|::first-line|' && ':first-of-type|:focus|:hover|:lang|:last-child|:last-of-type|:link|:not|:nth-child|:nth-last-child|' && ':nth-last-of-type|:nth-of-type|:only-child|:only-of-type|:root|:target|:visited'. - insert_keywords( iv_keywords = lv_keywords iv_token = c_token-selectors ). + insert_keywords( iv_keywords = lv_keywords + iv_token = c_token-selectors ). " 4) CSS Functions lv_keywords = 'attr|calc|cubic-bezier|hsl|hsla|linear-gradient|radial-gradient|repeating-linear-gradient|' && 'repeating-radial-gradient|rgb|rgba|rotate|scale|translateX|translateY|var'. - insert_keywords( iv_keywords = lv_keywords iv_token = c_token-functions ). + insert_keywords( iv_keywords = lv_keywords + iv_token = c_token-functions ). " 5) CSS Colors lv_keywords = @@ -236,7 +240,8 @@ CLASS ZCL_ABAPGIT_SYNTAX_CSS IMPLEMENTATION. 'peru|pink|plum|powderblue|purple|rebeccapurple|red|rosybrown|royalblue|saddlebrown|salmon|sandybrown|' && 'seagreen|seashell|sienna|silver|skyblue|slateblue|slategray|slategrey|snow|springgreen|steelblue|' && 'tan|teal|thistle|tomato|turquoise|violet|wheat|white|whitesmoke|yellow|yellowgreen'. - insert_keywords( iv_keywords = lv_keywords iv_token = c_token-colors ). + insert_keywords( iv_keywords = lv_keywords + iv_token = c_token-colors ). " 6) CSS Extensions lv_keywords = @@ -296,12 +301,14 @@ CLASS ZCL_ABAPGIT_SYNTAX_CSS IMPLEMENTATION. 'webkit-transform-origin-y|webkit-transform-origin-z|webkit-transition|' && 'webkit-transition-delay|webkit-user-drag|webkit-user-modify|overflow-clip-box|' && 'overflow-clip-box-block|overflow-clip-box-inline|zoom'. - insert_keywords( iv_keywords = lv_keywords iv_token = c_token-extensions ). + insert_keywords( iv_keywords = lv_keywords + iv_token = c_token-extensions ). " 6) CSS At-Rules lv_keywords = '@|charset|counter-style|font-face|import|keyframes'. - insert_keywords( iv_keywords = lv_keywords iv_token = c_token-at_rules ). + insert_keywords( iv_keywords = lv_keywords + iv_token = c_token-at_rules ). " 7) HTML tage lv_keywords = @@ -324,7 +331,8 @@ CLASS ZCL_ABAPGIT_SYNTAX_CSS IMPLEMENTATION. 'entity-ref|eval|expr|for-each|if|match|no-entities|node-name|order-by|otherwise|select|' && 'stylesheet|template|test|value-of|version|when|xmlns|xsl|cellpadding|cellspacing|table|td|' && 'tfoot|th|thead|tr'. - insert_keywords( iv_keywords = lv_keywords iv_token = c_token-html ). + insert_keywords( iv_keywords = lv_keywords + iv_token = c_token-html ). ENDMETHOD. diff --git a/src/syntax/zcl_abapgit_syntax_highlighter.clas.abap b/src/syntax/zcl_abapgit_syntax_highlighter.clas.abap index c299b72c2..cc6b578d7 100644 --- a/src/syntax/zcl_abapgit_syntax_highlighter.clas.abap +++ b/src/syntax/zcl_abapgit_syntax_highlighter.clas.abap @@ -103,7 +103,8 @@ CLASS ZCL_ABAPGIT_SYNTAX_HIGHLIGHTER IMPLEMENTATION. DATA lv_escaped TYPE string. - lv_escaped = escape( val = iv_line format = cl_abap_format=>e_html_attr ). + lv_escaped = escape( val = iv_line + format = cl_abap_format=>e_html_attr ). IF iv_class IS NOT INITIAL. rv_line = |{ lv_escaped }|. ELSE. @@ -179,7 +180,9 @@ CLASS ZCL_ABAPGIT_SYNTAX_HIGHLIGHTER IMPLEMENTATION. FIELD-SYMBOLS TYPE ty_match. LOOP AT it_matches ASSIGNING . - lv_chunk = substring( val = iv_line off = -offset len = -length ). + lv_chunk = substring( val = iv_line + off = -offset + len = -length ). CLEAR ls_rule. " Failed read equals no style READ TABLE mt_rules INTO ls_rule WITH KEY token = -token. diff --git a/src/syntax/zcl_abapgit_syntax_highlighter.clas.testclasses.abap b/src/syntax/zcl_abapgit_syntax_highlighter.clas.testclasses.abap index fdf0e5aec..d10e228cd 100644 --- a/src/syntax/zcl_abapgit_syntax_highlighter.clas.testclasses.abap +++ b/src/syntax/zcl_abapgit_syntax_highlighter.clas.testclasses.abap @@ -159,7 +159,8 @@ CLASS ltcl_syntax_cases IMPLEMENTATION. iv_length = 39 iv_text_tag = '' ). - do_test( iv_line = lv_line iv_filename = '*.abap' ). + do_test( iv_line = lv_line + iv_filename = '*.abap' ). ENDMETHOD. @@ -208,7 +209,8 @@ CLASS ltcl_syntax_cases IMPLEMENTATION. iv_length = 8 iv_text_tag = '' ). - do_test( iv_line = lv_line iv_filename = '*.abap' ). + do_test( iv_line = lv_line + iv_filename = '*.abap' ). ENDMETHOD. @@ -287,7 +289,8 @@ CLASS ltcl_syntax_cases IMPLEMENTATION. iv_length = 11 iv_text_tag = '' ). - do_test( iv_line = lv_line iv_filename = '*.abap' ). + do_test( iv_line = lv_line + iv_filename = '*.abap' ). ENDMETHOD. @@ -372,7 +375,8 @@ CLASS ltcl_syntax_cases IMPLEMENTATION. iv_length = 1 iv_text_tag = '' ). - do_test( iv_line = lv_line iv_filename = '*.abap' ). + do_test( iv_line = lv_line + iv_filename = '*.abap' ). ENDMETHOD. @@ -464,7 +468,8 @@ CLASS ltcl_syntax_cases IMPLEMENTATION. iv_length = 1 iv_text_tag = '' ). - do_test( iv_line = lv_line iv_filename = '*.abap' ). + do_test( iv_line = lv_line + iv_filename = '*.abap' ). ENDMETHOD. @@ -621,7 +626,8 @@ CLASS ltcl_syntax_cases IMPLEMENTATION. iv_length = 1 iv_text_tag = '}' ). - do_test( iv_line = lv_line iv_filename = '*.abap' ). + do_test( iv_line = lv_line + iv_filename = '*.abap' ). ENDMETHOD. @@ -671,7 +677,8 @@ CLASS ltcl_syntax_cases IMPLEMENTATION. iv_length = 4 iv_text_tag = '' ). - do_test( iv_line = lv_line iv_filename = '*.abap' ). + do_test( iv_line = lv_line + iv_filename = '*.abap' ). ENDMETHOD. @@ -698,7 +705,8 @@ CLASS ltcl_syntax_cases IMPLEMENTATION. iv_length = 27 iv_text_tag = '' ). - do_test( iv_line = lv_line iv_filename = '*.abap' ). + do_test( iv_line = lv_line + iv_filename = '*.abap' ). ENDMETHOD. @@ -750,7 +758,8 @@ CLASS ltcl_syntax_cases IMPLEMENTATION. iv_length = 6 iv_text_tag = '<' ). - do_test( iv_line = lv_line iv_filename = '*.xml' ). + do_test( iv_line = lv_line + iv_filename = '*.xml' ). ENDMETHOD. @@ -779,7 +788,8 @@ CLASS ltcl_syntax_cases IMPLEMENTATION. iv_length = 6 iv_text_tag = '<' ). - do_test( iv_line = lv_line iv_filename = '*.xml' ). + do_test( iv_line = lv_line + iv_filename = '*.xml' ). ENDMETHOD. @@ -843,7 +853,8 @@ CLASS ltcl_syntax_cases IMPLEMENTATION. iv_length = 2 iv_text_tag = '>' ). - do_test( iv_line = lv_line iv_filename = '*.xml' ). + do_test( iv_line = lv_line + iv_filename = '*.xml' ). ENDMETHOD. @@ -907,7 +918,8 @@ CLASS ltcl_syntax_cases IMPLEMENTATION. iv_length = 2 iv_text_tag = '>' ). - do_test( iv_line = lv_line iv_filename = '*.xml' ). + do_test( iv_line = lv_line + iv_filename = '*.xml' ). ENDMETHOD. @@ -1018,7 +1030,8 @@ CLASS ltcl_syntax_cases IMPLEMENTATION. iv_length = 9 iv_text_tag = '<' ). - do_test( iv_line = lv_line iv_filename = '*.xml' ). + do_test( iv_line = lv_line + iv_filename = '*.xml' ). ENDMETHOD. @@ -1071,7 +1084,8 @@ CLASS ltcl_syntax_cases IMPLEMENTATION. iv_length = 4 iv_text_tag = '' ). - do_test( iv_line = lv_line iv_filename = '*.xml' ). + do_test( iv_line = lv_line + iv_filename = '*.xml' ). ENDMETHOD. METHOD test_xml_07. @@ -1135,7 +1149,8 @@ CLASS ltcl_syntax_cases IMPLEMENTATION. iv_length = 2 iv_text_tag = '>' ). - do_test( iv_line = lv_line iv_filename = '*.xml' ). + do_test( iv_line = lv_line + iv_filename = '*.xml' ). ENDMETHOD. @@ -1180,7 +1195,8 @@ CLASS ltcl_syntax_cases IMPLEMENTATION. iv_length = 5 iv_text_tag = '' ). - do_test( iv_line = lv_line iv_filename = '*.xml' ). + do_test( iv_line = lv_line + iv_filename = '*.xml' ). ENDMETHOD. diff --git a/src/syntax/zcl_abapgit_syntax_js.clas.abap b/src/syntax/zcl_abapgit_syntax_js.clas.abap index 7c8ecf9d5..56691929b 100644 --- a/src/syntax/zcl_abapgit_syntax_js.clas.abap +++ b/src/syntax/zcl_abapgit_syntax_js.clas.abap @@ -134,12 +134,14 @@ CLASS ZCL_ABAPGIT_SYNTAX_JS IMPLEMENTATION. 'scrollbars|search|selected|selectedindex|self|siblingabove|siblingbelow|src|srcelement|status|statusbar|style|' && 'suffixes|tags|target|text|this|title|toolbar|top|true|type|useragent|value|visibility|vlinkcolor|vspace|width|' && 'window|zindex'. - insert_keywords( iv_keywords = lv_keywords iv_token = c_token-keyword ). + insert_keywords( iv_keywords = lv_keywords + iv_token = c_token-keyword ). " 2) Variable types lv_keywords = 'array|boolean|date|function|image|layer|math|number|object|option|regexp|string'. - insert_keywords( iv_keywords = lv_keywords iv_token = c_token-variables ). + insert_keywords( iv_keywords = lv_keywords + iv_token = c_token-variables ). ENDMETHOD. diff --git a/src/ui/core/zcl_abapgit_gui_asset_manager.clas.testclasses.abap b/src/ui/core/zcl_abapgit_gui_asset_manager.clas.testclasses.abap index 406c16d8f..b0134d032 100644 --- a/src/ui/core/zcl_abapgit_gui_asset_manager.clas.testclasses.abap +++ b/src/ui/core/zcl_abapgit_gui_asset_manager.clas.testclasses.abap @@ -28,8 +28,10 @@ CLASS ltcl_abapgit_gui_asset_manager IMPLEMENTATION. ls_asset = lo_assetman->zif_abapgit_gui_asset_manager~get_asset( 'css/common.css' ). - cl_abap_unit_assert=>assert_equals( act = ls_asset-type exp = 'text' ). - cl_abap_unit_assert=>assert_equals( act = ls_asset-subtype exp = 'css' ). + cl_abap_unit_assert=>assert_equals( act = ls_asset-type + exp = 'text' ). + cl_abap_unit_assert=>assert_equals( act = ls_asset-subtype + exp = 'css' ). cl_abap_unit_assert=>assert_equals( act = zcl_abapgit_convert=>xstring_to_string_utf8( ls_asset-content ) exp = 'ABC' ). diff --git a/src/ui/core/zcl_abapgit_gui_css_processor.clas.abap b/src/ui/core/zcl_abapgit_gui_css_processor.clas.abap index 61aa87849..9262a6ff4 100644 --- a/src/ui/core/zcl_abapgit_gui_css_processor.clas.abap +++ b/src/ui/core/zcl_abapgit_gui_css_processor.clas.abap @@ -129,7 +129,8 @@ CLASS ZCL_ABAPGIT_GUI_CSS_PROCESSOR IMPLEMENTATION. ENDLOOP. ENDLOOP. - rv_result = concat_lines_of( table = lt_contents sep = cl_abap_char_utilities=>newline ). + rv_result = concat_lines_of( table = lt_contents + sep = cl_abap_char_utilities=>newline ). ENDMETHOD. diff --git a/src/ui/core/zcl_abapgit_gui_css_processor.clas.testclasses.abap b/src/ui/core/zcl_abapgit_gui_css_processor.clas.testclasses.abap index d98867f8e..1e9386ac5 100644 --- a/src/ui/core/zcl_abapgit_gui_css_processor.clas.testclasses.abap +++ b/src/ui/core/zcl_abapgit_gui_css_processor.clas.testclasses.abap @@ -49,7 +49,8 @@ ENDCLASS. CLASS ltcl_single_file IMPLEMENTATION. METHOD test_file_exists. - add_file( iv_url = 'does/exist.css' iv_content = |body \{\}\n| ). + add_file( iv_url = 'does/exist.css' + iv_content = |body \{\}\n| ). mo_cut->add_file( 'does/exist.css' ). TRY. mo_cut->process( ). @@ -86,10 +87,12 @@ CLASS ltcl_single_file IMPLEMENTATION. ` background: #000000;\n` && ` color: #ffffff;\n` && `}\n`. - add_file( iv_url = 'novars.css' iv_content = lv_content ). + add_file( iv_url = 'novars.css' + iv_content = lv_content ). mo_cut->add_file( 'novars.css' ). - cl_abap_unit_assert=>assert_equals( act = mo_cut->process( ) exp = lv_content ). + cl_abap_unit_assert=>assert_equals( act = mo_cut->process( ) + exp = lv_content ). ENDMETHOD. METHOD test_simple_variables. @@ -105,7 +108,8 @@ CLASS ltcl_single_file IMPLEMENTATION. ` background: var(--my-bg-color);\n` && ` color: #ffffff;\n` && `}\n`. - add_file( iv_url = 'simple.css' iv_content = lv_content ). + add_file( iv_url = 'simple.css' + iv_content = lv_content ). lv_expected = `:root {\n` && @@ -118,7 +122,8 @@ CLASS ltcl_single_file IMPLEMENTATION. `}\n`. mo_cut->add_file( 'simple.css' ). - cl_abap_unit_assert=>assert_equals( act = mo_cut->process( ) exp = lv_expected ). + cl_abap_unit_assert=>assert_equals( act = mo_cut->process( ) + exp = lv_expected ). ENDMETHOD. METHOD test_complex_variables. @@ -137,7 +142,8 @@ CLASS ltcl_single_file IMPLEMENTATION. ` background: var(--my-bg-color);\n` && ` color: #ffffff;\n` && `}\n`. - add_file( iv_url = 'complex.css' iv_content = lv_content ). + add_file( iv_url = 'complex.css' + iv_content = lv_content ). lv_expected = `:root {\n` && @@ -153,7 +159,8 @@ CLASS ltcl_single_file IMPLEMENTATION. `}\n`. mo_cut->add_file( 'complex.css' ). - cl_abap_unit_assert=>assert_equals( act = mo_cut->process( ) exp = lv_expected ). + cl_abap_unit_assert=>assert_equals( act = mo_cut->process( ) + exp = lv_expected ). ENDMETHOD. METHOD test_overwrite. @@ -170,7 +177,8 @@ CLASS ltcl_single_file IMPLEMENTATION. `body {\n` && ` width: var(--var1);\n` && `}\n`. - add_file( iv_url = 'overwrite.css' iv_content = lv_content ). + add_file( iv_url = 'overwrite.css' + iv_content = lv_content ). lv_expected = `:root {\n` && @@ -184,7 +192,8 @@ CLASS ltcl_single_file IMPLEMENTATION. `}\n`. mo_cut->add_file( 'overwrite.css' ). - cl_abap_unit_assert=>assert_equals( act = mo_cut->process( ) exp = lv_expected ). + cl_abap_unit_assert=>assert_equals( act = mo_cut->process( ) + exp = lv_expected ). ENDMETHOD. ENDCLASS. @@ -213,7 +222,8 @@ CLASS ltcl_multiple_files IMPLEMENTATION. ` width: var(--var1);\n` && `}\n`. REPLACE ALL OCCURRENCES OF '\n' IN lv_file1 WITH cl_abap_char_utilities=>newline. - add_file( iv_url = 'file1.css' iv_content = lv_file1 ). + add_file( iv_url = 'file1.css' + iv_content = lv_file1 ). mo_cut->add_file( 'file1.css' ). lv_file2 = @@ -221,7 +231,8 @@ CLASS ltcl_multiple_files IMPLEMENTATION. ` --var3: 19;\n` && `}\n`. REPLACE ALL OCCURRENCES OF '\n' IN lv_file2 WITH cl_abap_char_utilities=>newline. - add_file( iv_url = 'file2.css' iv_content = lv_file2 ). + add_file( iv_url = 'file2.css' + iv_content = lv_file2 ). mo_cut->add_file( 'file2.css' ). lv_expected = @@ -240,6 +251,7 @@ CLASS ltcl_multiple_files IMPLEMENTATION. `}\n`. REPLACE ALL OCCURRENCES OF '\n' IN lv_expected WITH cl_abap_char_utilities=>newline. - cl_abap_unit_assert=>assert_equals( act = mo_cut->process( ) exp = lv_expected ). + cl_abap_unit_assert=>assert_equals( act = mo_cut->process( ) + exp = lv_expected ). ENDMETHOD. ENDCLASS. diff --git a/src/ui/core/zcl_abapgit_gui_html_processor.clas.abap b/src/ui/core/zcl_abapgit_gui_html_processor.clas.abap index c8ba0a249..e80338cf6 100644 --- a/src/ui/core/zcl_abapgit_gui_html_processor.clas.abap +++ b/src/ui/core/zcl_abapgit_gui_html_processor.clas.abap @@ -98,14 +98,20 @@ CLASS ZCL_ABAPGIT_GUI_HTML_PROCESSOR IMPLEMENTATION. IF abap_false = is_preserved( lv_css_path ). lv_off = lo_matcher->get_offset( ). lv_len = lo_matcher->get_length( ). - ev_html = ev_html && substring( val = iv_html off = lv_cur len = lv_off - lv_cur ). - ev_html = ev_html && c_comment_start && substring( val = iv_html off = lv_off len = lv_len ) && c_comment_end. + ev_html = ev_html && substring( val = iv_html + off = lv_cur + len = lv_off - lv_cur ). + ev_html = ev_html && c_comment_start && substring( val = iv_html + off = lv_off + len = lv_len ) && c_comment_end. lv_cur = lv_off + lv_len. APPEND lv_css_path TO et_css_urls. ENDIF. ENDWHILE. - ev_html = ev_html && substring( val = iv_html off = lv_cur len = lv_head_end - lv_cur ). + ev_html = ev_html && substring( val = iv_html + off = lv_cur + len = lv_head_end - lv_cur ). IF lines( et_css_urls ) > 0. lv_marker = cl_abap_char_utilities=>newline && ` ` " Assume 4 space indent, maybe improve and detect ? @@ -114,7 +120,8 @@ CLASS ZCL_ABAPGIT_GUI_HTML_PROCESSOR IMPLEMENTATION. && ` `. ev_html = ev_html && lv_marker && lv_css_build. ENDIF. - ev_html = ev_html && substring( val = iv_html off = lv_head_end ). + ev_html = ev_html && substring( val = iv_html + off = lv_head_end ). ENDMETHOD. @@ -161,9 +168,13 @@ CLASS ZCL_ABAPGIT_GUI_HTML_PROCESSOR IMPLEMENTATION. METHOD find_head_offset. - rv_head_end = find( val = iv_html regex = |{ cl_abap_char_utilities=>newline }?\\s*| case = abap_false ). + rv_head_end = find( val = iv_html + regex = |{ cl_abap_char_utilities=>newline }?\\s*| + case = abap_false ). IF rv_head_end <= 0. - rv_head_end = find( val = iv_html regex = || case = abap_false ). + rv_head_end = find( val = iv_html + regex = || + case = abap_false ). IF rv_head_end <= 0. zcx_abapgit_exception=>raise( 'HTML preprocessor: not found' ). ENDIF. diff --git a/src/ui/core/zcl_abapgit_gui_html_processor.clas.testclasses.abap b/src/ui/core/zcl_abapgit_gui_html_processor.clas.testclasses.abap index bce6b0a8d..414a121c5 100644 --- a/src/ui/core/zcl_abapgit_gui_html_processor.clas.testclasses.abap +++ b/src/ui/core/zcl_abapgit_gui_html_processor.clas.testclasses.abap @@ -76,9 +76,15 @@ CLASS ltcl_html_processor_test IMPLEMENTATION. DATA lo_asset_man TYPE REF TO zcl_abapgit_gui_asset_manager. CREATE OBJECT lo_asset_man. - lo_asset_man->register_asset( iv_url = 'css/style1.css' iv_type = 'text/css' iv_inline = 'dummy1' ). - lo_asset_man->register_asset( iv_url = 'css/style2.css' iv_type = 'text/css' iv_inline = 'dummy2' ). - lo_asset_man->register_asset( iv_url = 'css/style3.css' iv_type = 'text/css' iv_inline = 'dummy3' ). + lo_asset_man->register_asset( iv_url = 'css/style1.css' + iv_type = 'text/css' + iv_inline = 'dummy1' ). + lo_asset_man->register_asset( iv_url = 'css/style2.css' + iv_type = 'text/css' + iv_inline = 'dummy2' ). + lo_asset_man->register_asset( iv_url = 'css/style3.css' + iv_type = 'text/css' + iv_inline = 'dummy3' ). CREATE OBJECT mo_cut EXPORTING diff --git a/src/ui/core/zcl_abapgit_html.clas.abap b/src/ui/core/zcl_abapgit_html.clas.abap index 493cba4cd..ace487c1f 100644 --- a/src/ui/core/zcl_abapgit_html.clas.abap +++ b/src/ui/core/zcl_abapgit_html.clas.abap @@ -234,7 +234,8 @@ CLASS ZCL_ABAPGIT_HTML IMPLEMENTATION. lv_color = | { lv_color }|. ENDIF. - lv_xpixel = cl_gui_cfw=>compute_pixel_from_metric( x_or_y = 'X' in = 1 ). + lv_xpixel = cl_gui_cfw=>compute_pixel_from_metric( x_or_y = 'X' + in = 1 ). IF lv_xpixel >= 2. lv_large_icon = ' large'. ENDIF. @@ -260,7 +261,8 @@ CLASS ZCL_ABAPGIT_HTML IMPLEMENTATION. OR ls_study-curly_close = abap_true OR ls_study-tag_close = abap_true ) AND cs_context-indent > 0. - lv_x_str = repeat( val = ` ` occ = ( cs_context-indent - 1 ) * c_indent_size ). + lv_x_str = repeat( val = ` ` + occ = ( cs_context-indent - 1 ) * c_indent_size ). cv_line = lv_x_str && cv_line. ELSE. cv_line = cs_context-indent_str && cv_line. @@ -287,7 +289,8 @@ CLASS ZCL_ABAPGIT_HTML IMPLEMENTATION. ELSEIF cs_context-indent > 0. " AND ls_study-openings < ls_study-closings cs_context-indent = cs_context-indent - 1. ENDIF. - cs_context-indent_str = repeat( val = ` ` occ = cs_context-indent * c_indent_size ). + cs_context-indent_str = repeat( val = ` ` + occ = cs_context-indent * c_indent_size ). ENDIF. ENDMETHOD. @@ -323,7 +326,8 @@ CLASS ZCL_ABAPGIT_HTML IMPLEMENTATION. DATA: lv_line TYPE string, lv_len TYPE i. - lv_line = to_upper( shift_left( val = iv_line sub = ` ` ) ). + lv_line = to_upper( shift_left( val = iv_line + sub = ` ` ) ). lv_len = strlen( lv_line ). " Some assumptions for simplification and speed diff --git a/src/ui/db/zcl_abapgit_gui_page_db.clas.abap b/src/ui/db/zcl_abapgit_gui_page_db.clas.abap index eab34259c..4a1f325ca 100644 --- a/src/ui/db/zcl_abapgit_gui_page_db.clas.abap +++ b/src/ui/db/zcl_abapgit_gui_page_db.clas.abap @@ -166,9 +166,12 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_DB IMPLEMENTATION. lv_action = zcl_abapgit_html_action_utils=>dbkey_encode( ). CREATE OBJECT lo_toolbar. - lo_toolbar->add( iv_txt = 'Display' iv_act = |{ zif_abapgit_definitions=>c_action-db_display }?{ lv_action }| ). - lo_toolbar->add( iv_txt = 'Edit' iv_act = |{ zif_abapgit_definitions=>c_action-db_edit }?{ lv_action }| ). - lo_toolbar->add( iv_txt = 'Delete' iv_act = |{ c_action-delete }?{ lv_action }| ). + lo_toolbar->add( iv_txt = 'Display' + iv_act = |{ zif_abapgit_definitions=>c_action-db_display }?{ lv_action }| ). + lo_toolbar->add( iv_txt = 'Edit' + iv_act = |{ zif_abapgit_definitions=>c_action-db_edit }?{ lv_action }| ). + lo_toolbar->add( iv_txt = 'Delete' + iv_act = |{ c_action-delete }?{ lv_action }| ). ro_html->add( || ). ro_html->add( |{ -type }| ). diff --git a/src/ui/zcl_abapgit_gui_chunk_lib.clas.abap b/src/ui/zcl_abapgit_gui_chunk_lib.clas.abap index 5230639b5..2655de33d 100644 --- a/src/ui/zcl_abapgit_gui_chunk_lib.clas.abap +++ b/src/ui/zcl_abapgit_gui_chunk_lib.clas.abap @@ -206,7 +206,8 @@ CLASS ZCL_ABAPGIT_GUI_CHUNK_LIB IMPLEMENTATION. CREATE OBJECT ro_html. ro_html->add( || ). - ro_html->add_icon( iv_name = 'code-branch/grey70' iv_hint = 'Current branch' ). + ro_html->add_icon( iv_name = 'code-branch/grey70' + iv_hint = 'Current branch' ). IF iv_interactive = abap_true. ro_html->add_a( iv_act = |{ zif_abapgit_definitions=>c_action-git_branch_switch }?{ io_repo->get_key( ) }| iv_txt = lv_text ). @@ -381,7 +382,8 @@ CLASS ZCL_ABAPGIT_GUI_CHUNK_LIB IMPLEMENTATION. IF iv_hint IS NOT INITIAL. ro_html->add( '
' - && zcl_abapgit_html=>icon( iv_name = 'exclamation-triangle' iv_class = 'pad-right' ) + && zcl_abapgit_html=>icon( iv_name = 'exclamation-triangle' + iv_class = 'pad-right' ) && iv_hint && '
' ). ENDIF. @@ -576,7 +578,8 @@ CLASS ZCL_ABAPGIT_GUI_CHUNK_LIB IMPLEMENTATION. ro_html->add( '' ). " Repo type and name - ro_html->add_icon( iv_name = lv_icon iv_hint = lv_hint ). + ro_html->add_icon( iv_name = lv_icon + iv_hint = lv_hint ). ro_html->add( |{ io_repo->get_name( ) }| ). IF io_repo->is_offline( ) = abap_false. lo_repo_online ?= io_repo. @@ -623,7 +626,8 @@ CLASS ZCL_ABAPGIT_GUI_CHUNK_LIB IMPLEMENTATION. " Write protect IF io_repo->get_local_settings( )-write_protected = abap_true. - ro_html->add_icon( iv_name = 'lock/grey70' iv_hint = 'Locked from pulls' ). + ro_html->add_icon( iv_name = 'lock/grey70' + iv_hint = 'Locked from pulls' ). ENDIF. " Branch @@ -644,7 +648,8 @@ CLASS ZCL_ABAPGIT_GUI_CHUNK_LIB IMPLEMENTATION. " Package IF iv_show_package = abap_true. - ro_html->add_icon( iv_name = 'box/grey70' iv_hint = 'SAP package' ). + ro_html->add_icon( iv_name = 'box/grey70' + iv_hint = 'SAP package' ). ro_html->add( '' ). lv_package_jump_data = zcl_abapgit_html_action_utils=>jump_encode( diff --git a/src/ui/zcl_abapgit_gui_page_boverview.clas.abap b/src/ui/zcl_abapgit_gui_page_boverview.clas.abap index e5abf64c6..dcf060c4d 100644 --- a/src/ui/zcl_abapgit_gui_page_boverview.clas.abap +++ b/src/ui/zcl_abapgit_gui_page_boverview.clas.abap @@ -211,7 +211,8 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_BOVERVIEW IMPLEMENTATION. iv_act = c_actions-compress ) ##NO_TEXT. ENDIF. - ro_menu->add( iv_txt = 'Refresh' iv_act = c_actions-refresh ) ##NO_TEXT. + ro_menu->add( iv_txt = 'Refresh' + iv_act = c_actions-refresh ) ##NO_TEXT. ENDMETHOD. diff --git a/src/ui/zcl_abapgit_gui_page_codi_base.clas.abap b/src/ui/zcl_abapgit_gui_page_codi_base.clas.abap index e757d79b9..868392610 100644 --- a/src/ui/zcl_abapgit_gui_page_codi_base.clas.abap +++ b/src/ui/zcl_abapgit_gui_page_codi_base.clas.abap @@ -163,7 +163,8 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_CODI_BASE IMPLEMENTATION. lv_class = 'ci-info'. ENDCASE. - lv_msg = escape( val = is_result-text format = cl_abap_format=>e_html_attr ). + lv_msg = escape( val = is_result-text + format = cl_abap_format=>e_html_attr ). IF is_result-sobjname IS INITIAL OR ( is_result-sobjname = is_result-objname AND diff --git a/src/ui/zcl_abapgit_gui_page_diff.clas.abap b/src/ui/zcl_abapgit_gui_page_diff.clas.abap index 5bd50cae7..79c2d698b 100644 --- a/src/ui/zcl_abapgit_gui_page_diff.clas.abap +++ b/src/ui/zcl_abapgit_gui_page_diff.clas.abap @@ -219,7 +219,8 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_DIFF IMPLEMENTATION. " File types IF lines( lt_types ) > 1. - lo_sub_filter->add( iv_txt = 'TYPE' iv_typ = zif_abapgit_html=>c_action_type-separator ). + lo_sub_filter->add( iv_txt = 'TYPE' + iv_typ = zif_abapgit_html=>c_action_type-separator ). LOOP AT lt_types ASSIGNING . lo_sub_filter->add( iv_txt = iv_typ = zif_abapgit_html=>c_action_type-onclick @@ -230,7 +231,8 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_DIFF IMPLEMENTATION. " Changed by IF lines( lt_users ) > 1. - lo_sub_filter->add( iv_txt = 'CHANGED BY' iv_typ = zif_abapgit_html=>c_action_type-separator ). + lo_sub_filter->add( iv_txt = 'CHANGED BY' + iv_typ = zif_abapgit_html=>c_action_type-separator ). LOOP AT lt_users ASSIGNING . lo_sub_filter->add( iv_txt = iv_typ = zif_abapgit_html=>c_action_type-onclick @@ -346,13 +348,15 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_DIFF IMPLEMENTATION. ENDIF. FIND FIRST OCCURRENCE OF '.' IN -type MATCH OFFSET lv_offs. - -type = reverse( substring( val = -type len = lv_offs ) ). + -type = reverse( substring( val = -type + len = lv_offs ) ). IF -type <> 'xml' AND -type <> 'abap'. -type = 'other'. ENDIF. IF -type = 'other' - AND is_binary( iv_d1 = -data iv_d2 = -file-data ) = abap_true. + AND is_binary( iv_d1 = -data + iv_d2 = -file-data ) = abap_true. -type = 'binary'. ENDIF. @@ -705,7 +709,8 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_DIFF IMPLEMENTATION. ENDIF. IF lv_insert_nav = abap_true. " Insert separator line with navigation - ro_html->add( render_beacon( is_diff_line = is_diff = is_diff ) ). + ro_html->add( render_beacon( is_diff_line = + is_diff = is_diff ) ). lv_insert_nav = abap_false. ENDIF. @@ -713,8 +718,10 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_DIFF IMPLEMENTATION. -new = lo_highlighter->process_line( -new ). -old = lo_highlighter->process_line( -old ). ELSE. - -new = escape( val = -new format = cl_abap_format=>e_html_attr ). - -old = escape( val = -old format = cl_abap_format=>e_html_attr ). + -new = escape( val = -new + format = cl_abap_format=>e_html_attr ). + -old = escape( val = -old + format = cl_abap_format=>e_html_attr ). ENDIF. CONDENSE -new_num. "get rid of leading spaces diff --git a/src/ui/zcl_abapgit_gui_page_main.clas.abap b/src/ui/zcl_abapgit_gui_page_main.clas.abap index b76469971..a34d5ef09 100644 --- a/src/ui/zcl_abapgit_gui_page_main.clas.abap +++ b/src/ui/zcl_abapgit_gui_page_main.clas.abap @@ -227,7 +227,8 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_MAIN IMPLEMENTATION. ro_html->add( '' ). ro_html->add( || ). ro_html->add( '' ). diff --git a/src/ui/zcl_abapgit_gui_page_merge.clas.abap b/src/ui/zcl_abapgit_gui_page_merge.clas.abap index 0ee868812..59c5362af 100644 --- a/src/ui/zcl_abapgit_gui_page_merge.clas.abap +++ b/src/ui/zcl_abapgit_gui_page_merge.clas.abap @@ -51,10 +51,13 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_MERGE IMPLEMENTATION. CREATE OBJECT ro_menu. - ro_menu->add( iv_txt = 'Merge' iv_act = c_actions-merge iv_cur = abap_false ) ##NO_TEXT. + ro_menu->add( iv_txt = 'Merge' + iv_act = c_actions-merge + iv_cur = abap_false ) ##NO_TEXT. IF iv_with_conflict = abap_true. - ro_menu->add( iv_txt = 'Resolve Conflicts' iv_act = c_actions-res_conflicts ) ##NO_TEXT. + ro_menu->add( iv_txt = 'Resolve Conflicts' + iv_act = c_actions-res_conflicts ) ##NO_TEXT. ENDIF. ENDMETHOD. diff --git a/src/ui/zcl_abapgit_gui_page_merge_res.clas.abap b/src/ui/zcl_abapgit_gui_page_merge_res.clas.abap index e1cf04ae0..2516ae69a 100644 --- a/src/ui/zcl_abapgit_gui_page_merge_res.clas.abap +++ b/src/ui/zcl_abapgit_gui_page_merge_res.clas.abap @@ -152,8 +152,10 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_MERGE_RES IMPLEMENTATION. METHOD build_menu. CREATE OBJECT ro_menu. - ro_menu->add( iv_txt = 'Toggle merge mode' iv_act = c_actions-toggle_mode ) ##NO_TEXT. - ro_menu->add( iv_txt = 'Cancel' iv_act = c_actions-cancel ) ##NO_TEXT. + ro_menu->add( iv_txt = 'Toggle merge mode' + iv_act = c_actions-toggle_mode ) ##NO_TEXT. + ro_menu->add( iv_txt = 'Cancel' + iv_act = c_actions-cancel ) ##NO_TEXT. ENDMETHOD. @@ -305,7 +307,8 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_MERGE_RES IMPLEMENTATION. READ TABLE mt_conflicts ASSIGNING INDEX mv_current_conflict_index. IF sy-subrc = 0. lv_target_content = zcl_abapgit_convert=>xstring_to_string_utf8( -target_data ). - lv_target_content = escape( val = lv_target_content format = cl_abap_format=>e_html_text ). + lv_target_content = escape( val = lv_target_content + format = cl_abap_format=>e_html_text ). ENDIF. ro_html->add( '' ). "#EC NOTEXT @@ -375,7 +378,8 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_MERGE_RES IMPLEMENTATION. ENDIF. IF lv_insert_nav = abap_true. " Insert separator line with navigation - ro_html->add( render_beacon( is_diff_line = is_diff = is_diff ) ). + ro_html->add( render_beacon( is_diff_line = + is_diff = is_diff ) ). lv_insert_nav = abap_false. ENDIF. @@ -383,8 +387,10 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_MERGE_RES IMPLEMENTATION. -new = lo_highlighter->process_line( -new ). -old = lo_highlighter->process_line( -old ). ELSE. - -new = escape( val = -new format = cl_abap_format=>e_html_attr ). - -old = escape( val = -old format = cl_abap_format=>e_html_attr ). + -new = escape( val = -new + format = cl_abap_format=>e_html_attr ). + -old = escape( val = -old + format = cl_abap_format=>e_html_attr ). ENDIF. CONDENSE -new_num. "get rid of leading spaces @@ -495,13 +501,15 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_MERGE_RES IMPLEMENTATION. ms_diff_file-type = reverse( -filename ). FIND FIRST OCCURRENCE OF '.' IN ms_diff_file-type MATCH OFFSET lv_offs. - ms_diff_file-type = reverse( substring( val = ms_diff_file-type len = lv_offs ) ). + ms_diff_file-type = reverse( substring( val = ms_diff_file-type + len = lv_offs ) ). IF ms_diff_file-type <> 'xml' AND ms_diff_file-type <> 'abap'. ms_diff_file-type = 'other'. ENDIF. IF ms_diff_file-type = 'other' - AND is_binary( iv_d1 = -source_data iv_d2 = -target_data ) = abap_true. + AND is_binary( iv_d1 = -source_data + iv_d2 = -target_data ) = abap_true. ms_diff_file-type = 'binary'. ENDIF. diff --git a/src/ui/zcl_abapgit_gui_page_repo_sett.clas.abap b/src/ui/zcl_abapgit_gui_page_repo_sett.clas.abap index 573ae5b3f..676ccd636 100644 --- a/src/ui/zcl_abapgit_gui_page_repo_sett.clas.abap +++ b/src/ui/zcl_abapgit_gui_page_repo_sett.clas.abap @@ -345,11 +345,13 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_REPO_SETT IMPLEMENTATION. DELETE lt_ignore WHERE table_line IS INITIAL. " Remove everything LOOP AT lo_dot->get_data( )-ignore INTO lv_ignore. - lo_dot->remove_ignore( iv_path = '' iv_filename = lv_ignore ). + lo_dot->remove_ignore( iv_path = '' + iv_filename = lv_ignore ). ENDLOOP. " Add newly entered files LOOP AT lt_ignore INTO lv_ignore. - lo_dot->add_ignore( iv_path = '' iv_filename = lv_ignore ). + lo_dot->add_ignore( iv_path = '' + iv_filename = lv_ignore ). ENDLOOP. lo_requirements = lcl_requirements=>new( ). diff --git a/src/ui/zcl_abapgit_gui_router.clas.abap b/src/ui/zcl_abapgit_gui_router.clas.abap index ddf968254..0b4f2bc1f 100644 --- a/src/ui/zcl_abapgit_gui_router.clas.abap +++ b/src/ui/zcl_abapgit_gui_router.clas.abap @@ -504,7 +504,8 @@ CLASS zcl_abapgit_gui_router IMPLEMENTATION. ev_state = zcl_abapgit_gui=>c_event_state-new_page. WHEN zif_abapgit_definitions=>c_action-repo_log. li_log = zcl_abapgit_repo_srv=>get_instance( )->get( lv_key )->get_log( ). - zcl_abapgit_log_viewer=>show_log( ii_log = li_log iv_header_text = li_log->get_title( ) ). + zcl_abapgit_log_viewer=>show_log( ii_log = li_log + iv_header_text = li_log->get_title( ) ). ev_state = zcl_abapgit_gui=>c_event_state-no_more_act. ENDCASE. diff --git a/src/ui/zcl_abapgit_gui_view_repo.clas.abap b/src/ui/zcl_abapgit_gui_view_repo.clas.abap index 53cd957cc..df2420e9a 100644 --- a/src/ui/zcl_abapgit_gui_view_repo.clas.abap +++ b/src/ui/zcl_abapgit_gui_view_repo.clas.abap @@ -517,7 +517,8 @@ CLASS ZCL_ABAPGIT_GUI_VIEW_REPO IMPLEMENTATION. ENDIF. IF lines( lt_class ) > 0. - rv_html = | class="{ concat_lines_of( table = lt_class sep = ` ` ) }"|. + rv_html = | class="{ concat_lines_of( table = lt_class + sep = ` ` ) }"|. ENDIF. ENDMETHOD. @@ -627,7 +628,8 @@ CLASS ZCL_ABAPGIT_GUI_VIEW_REPO IMPLEMENTATION. DATA lo_toolbar TYPE REF TO zcl_abapgit_html_toolbar. CREATE OBJECT ro_html. - lo_toolbar = build_head_menu( iv_lstate = iv_lstate iv_rstate = iv_rstate ). + lo_toolbar = build_head_menu( iv_lstate = iv_lstate + iv_rstate = iv_rstate ). ro_html->add( '
' ). ro_html->add( '
{ - zcl_abapgit_html=>icon( iv_name = 'star/blue' iv_hint = 'Favorites' ) + zcl_abapgit_html=>icon( iv_name = 'star/blue' + iv_hint = 'Favorites' ) }' ). " Maximize width @@ -235,7 +236,8 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_MAIN IMPLEMENTATION. ro_html->add( lo_favbar->render( iv_sort = abap_true ) ). ELSE. ro_html->add( |No favorites so far. For more info please check { - zcl_abapgit_html=>a( iv_txt = 'tutorial' iv_act = zif_abapgit_definitions=>c_action-go_tutorial ) + zcl_abapgit_html=>a( iv_txt = 'tutorial' + iv_act = zif_abapgit_definitions=>c_action-go_tutorial ) }| ). ENDIF. ro_html->add( '
' ). @@ -874,7 +876,8 @@ CLASS ZCL_ABAPGIT_GUI_VIEW_REPO IMPLEMENTATION. ev_state = zcl_abapgit_gui=>c_event_state-re_render. WHEN c_actions-change_dir. " Change dir lv_path = zcl_abapgit_html_action_utils=>dir_decode( iv_getdata ). - mv_cur_dir = zcl_abapgit_path=>change_dir( iv_cur_dir = mv_cur_dir iv_cd = lv_path ). + mv_cur_dir = zcl_abapgit_path=>change_dir( iv_cur_dir = mv_cur_dir + iv_cd = lv_path ). ev_state = zcl_abapgit_gui=>c_event_state-re_render. WHEN c_actions-toggle_folders. " Toggle folder view mv_show_folders = boolc( mv_show_folders <> abap_true ). @@ -994,7 +997,8 @@ CLASS ZCL_ABAPGIT_GUI_VIEW_REPO IMPLEMENTATION. lv_max = abap_true. EXIT. " current loop ENDIF. - ri_html->add( render_item( is_item = iv_render_transports = lv_render_transports ) ). + ri_html->add( render_item( is_item = + iv_render_transports = lv_render_transports ) ). ENDLOOP. ENDIF. @@ -1009,9 +1013,11 @@ CLASS ZCL_ABAPGIT_GUI_VIEW_REPO IMPLEMENTATION. ENDIF. lv_add_str = |+{ mv_max_setting }|. ri_html->add( |Only { lv_max_str } shown in list. Display { - zcl_abapgit_html=>a( iv_txt = lv_add_str iv_act = c_actions-display_more ) + zcl_abapgit_html=>a( iv_txt = lv_add_str + iv_act = c_actions-display_more ) } more. (Set in Advanced > { - zcl_abapgit_html=>a( iv_txt = 'Settings' iv_act = zif_abapgit_definitions=>c_action-go_settings ) + zcl_abapgit_html=>a( iv_txt = 'Settings' + iv_act = zif_abapgit_definitions=>c_action-go_settings ) } )| ). ri_html->add( '' ). ENDIF. @@ -1019,7 +1025,8 @@ CLASS ZCL_ABAPGIT_GUI_VIEW_REPO IMPLEMENTATION. ri_html->add( '' ). CATCH zcx_abapgit_exception INTO lx_error. - ri_html->add( render_head_line( iv_lstate = lv_lstate iv_rstate = lv_rstate ) ). + ri_html->add( render_head_line( iv_lstate = lv_lstate + iv_rstate = lv_rstate ) ). ri_html->add( zcl_abapgit_gui_chunk_lib=>render_error( ix_error = lx_error ) ). ENDTRY. diff --git a/src/ui/zcl_abapgit_gui_view_tutorial.clas.abap b/src/ui/zcl_abapgit_gui_view_tutorial.clas.abap index 34efc945f..16f6d66e2 100644 --- a/src/ui/zcl_abapgit_gui_view_tutorial.clas.abap +++ b/src/ui/zcl_abapgit_gui_view_tutorial.clas.abap @@ -32,17 +32,20 @@ CLASS ZCL_ABAPGIT_GUI_VIEW_TUTORIAL IMPLEMENTATION. ro_html->add( '

    ' ). ro_html->add( `
  • To clone a remote repo (e.g. from github) click ` ). - ro_html->add_a( iv_txt = '+ Online' iv_act = zif_abapgit_definitions=>c_action-repo_newonline ). + ro_html->add_a( iv_txt = '+ Online' + iv_act = zif_abapgit_definitions=>c_action-repo_newonline ). ro_html->add( ' from the top menu. This will copy a remote repo to your system.
    • ' ). ro_html->add( `
  • To add a local package as a repo click ` ). - ro_html->add_a( iv_txt = '+ Offline' iv_act = zif_abapgit_definitions=>c_action-repo_newoffline ). + ro_html->add_a( iv_txt = '+ Offline' + iv_act = zif_abapgit_definitions=>c_action-repo_newoffline ). ro_html->add( ' from the top menu. This will track a repo which already exist in' ). ro_html->add( ' the system with abapGit. You''ll be able to attach it to remote origin' ). ro_html->add( ' or just serialize as a zip file
    • ' ). ro_html->add( `
  • Go ` ). - ro_html->add_a( iv_txt = 'Explore' iv_act = zif_abapgit_definitions=>c_action-go_explore ). + ro_html->add_a( iv_txt = 'Explore' + iv_act = zif_abapgit_definitions=>c_action-go_explore ). ro_html->add( ' to find projects using abapGit
    • ' ). ro_html->add( '

' ). @@ -64,7 +67,8 @@ CLASS ZCL_ABAPGIT_GUI_VIEW_TUTORIAL IMPLEMENTATION. ro_html->add( 'abapGit installed in package ' ). ro_html->add( lv_devclass ). ELSE. - ro_html->add_a( iv_txt = 'install abapGit repo' iv_act = zif_abapgit_definitions=>c_action-abapgit_install ). + ro_html->add_a( iv_txt = 'install abapGit repo' + iv_act = zif_abapgit_definitions=>c_action-abapgit_install ). ro_html->add( ' - To keep abapGit up-to-date (or also to contribute) you need to' ). ro_html->add( 'install it as a repository.' ). ENDIF. diff --git a/src/ui/zcl_abapgit_html_action_utils.clas.abap b/src/ui/zcl_abapgit_html_action_utils.clas.abap index b52dc8c37..1e14c782c 100644 --- a/src/ui/zcl_abapgit_html_action_utils.clas.abap +++ b/src/ui/zcl_abapgit_html_action_utils.clas.abap @@ -140,8 +140,10 @@ CLASS ZCL_ABAPGIT_HTML_ACTION_UTILS IMPLEMENTATION. lt_fields = parse_fields_upper_case_name( cl_http_utility=>unescape_url( |{ iv_string }| ) ). - get_field( EXPORTING iv_name = 'TYPE' it_field = lt_fields CHANGING cg_field = rs_key-type ). - get_field( EXPORTING iv_name = 'VALUE' it_field = lt_fields CHANGING cg_field = rs_key-value ). + get_field( EXPORTING iv_name = 'TYPE' + it_field = lt_fields CHANGING cg_field = rs_key-type ). + get_field( EXPORTING iv_name = 'VALUE' + it_field = lt_fields CHANGING cg_field = rs_key-value ). ENDMETHOD. @@ -150,8 +152,10 @@ CLASS ZCL_ABAPGIT_HTML_ACTION_UTILS IMPLEMENTATION. DATA: lt_fields TYPE tihttpnvp. - add_field( EXPORTING iv_name = 'TYPE' ig_field = is_key-type CHANGING ct_field = lt_fields ). - add_field( EXPORTING iv_name = 'VALUE' ig_field = is_key-value CHANGING ct_field = lt_fields ). + add_field( EXPORTING iv_name = 'TYPE' + ig_field = is_key-type CHANGING ct_field = lt_fields ). + add_field( EXPORTING iv_name = 'VALUE' + ig_field = is_key-value CHANGING ct_field = lt_fields ). rv_string = cl_http_utility=>if_http_utility~fields_to_string( lt_fields ). @@ -163,7 +167,8 @@ CLASS ZCL_ABAPGIT_HTML_ACTION_UTILS IMPLEMENTATION. DATA: lt_fields TYPE tihttpnvp. lt_fields = parse_fields( iv_string ). - get_field( EXPORTING iv_name = 'PATH' it_field = lt_fields CHANGING cg_field = rv_path ). + get_field( EXPORTING iv_name = 'PATH' + it_field = lt_fields CHANGING cg_field = rv_path ). ENDMETHOD. @@ -171,7 +176,8 @@ CLASS ZCL_ABAPGIT_HTML_ACTION_UTILS IMPLEMENTATION. METHOD dir_encode. DATA: lt_fields TYPE tihttpnvp. - add_field( EXPORTING iv_name = 'PATH' ig_field = iv_path CHANGING ct_field = lt_fields ). + add_field( EXPORTING iv_name = 'PATH' + ig_field = iv_path CHANGING ct_field = lt_fields ). rv_string = cl_http_utility=>if_http_utility~fields_to_string( lt_fields ). ENDMETHOD. @@ -193,9 +199,12 @@ CLASS ZCL_ABAPGIT_HTML_ACTION_UTILS IMPLEMENTATION. DATA: lt_fields TYPE tihttpnvp. - add_field( EXPORTING iv_name = 'KEY' ig_field = iv_key CHANGING ct_field = lt_fields ). - add_field( EXPORTING iv_name = 'PATH' ig_field = ig_file CHANGING ct_field = lt_fields ). - add_field( EXPORTING iv_name = 'FILENAME' ig_field = ig_file CHANGING ct_field = lt_fields ). + add_field( EXPORTING iv_name = 'KEY' + ig_field = iv_key CHANGING ct_field = lt_fields ). + add_field( EXPORTING iv_name = 'PATH' + ig_field = ig_file CHANGING ct_field = lt_fields ). + add_field( EXPORTING iv_name = 'FILENAME' + ig_field = ig_file CHANGING ct_field = lt_fields ). rv_string = cl_http_utility=>if_http_utility~fields_to_string( lt_fields ). @@ -211,17 +220,24 @@ CLASS ZCL_ABAPGIT_HTML_ACTION_UTILS IMPLEMENTATION. CLEAR: ev_key, eg_file, eg_object. lt_fields = parse_fields_upper_case_name( iv_string ). - get_field( EXPORTING iv_name = 'KEY' it_field = lt_fields CHANGING cg_field = ev_key ). + get_field( EXPORTING iv_name = 'KEY' + it_field = lt_fields CHANGING cg_field = ev_key ). IF eg_file IS SUPPLIED. - get_field( EXPORTING iv_name = 'PATH' it_field = lt_fields CHANGING cg_field = eg_file ). - get_field( EXPORTING iv_name = 'FILENAME' it_field = lt_fields iv_decode = abap_true + get_field( EXPORTING iv_name = 'PATH' + it_field = lt_fields CHANGING cg_field = eg_file ). + get_field( EXPORTING iv_name = 'FILENAME' + it_field = lt_fields + iv_decode = abap_true CHANGING cg_field = eg_file ). ENDIF. IF eg_object IS SUPPLIED. - get_field( EXPORTING iv_name = 'OBJ_TYPE' it_field = lt_fields CHANGING cg_field = eg_object ). - get_field( EXPORTING iv_name = 'OBJ_NAME' it_field = lt_fields iv_decode = abap_true + get_field( EXPORTING iv_name = 'OBJ_TYPE' + it_field = lt_fields CHANGING cg_field = eg_object ). + get_field( EXPORTING iv_name = 'OBJ_NAME' + it_field = lt_fields + iv_decode = abap_true CHANGING cg_field = eg_object ). ENDIF. @@ -267,8 +283,10 @@ CLASS ZCL_ABAPGIT_HTML_ACTION_UTILS IMPLEMENTATION. lt_fields = parse_fields( iv_string ). - get_field( EXPORTING iv_name = 'TYPE' it_field = lt_fields CHANGING cg_field = ev_obj_type ). - get_field( EXPORTING iv_name = 'NAME' it_field = lt_fields CHANGING cg_field = ev_obj_name ). + get_field( EXPORTING iv_name = 'TYPE' + it_field = lt_fields CHANGING cg_field = ev_obj_type ). + get_field( EXPORTING iv_name = 'NAME' + it_field = lt_fields CHANGING cg_field = ev_obj_name ). ENDMETHOD. @@ -278,8 +296,10 @@ CLASS ZCL_ABAPGIT_HTML_ACTION_UTILS IMPLEMENTATION. DATA: lt_fields TYPE tihttpnvp. - add_field( EXPORTING iv_name = 'TYPE' ig_field = iv_obj_type CHANGING ct_field = lt_fields ). - add_field( EXPORTING iv_name = 'NAME' ig_field = iv_obj_name CHANGING ct_field = lt_fields ). + add_field( EXPORTING iv_name = 'TYPE' + ig_field = iv_obj_type CHANGING ct_field = lt_fields ). + add_field( EXPORTING iv_name = 'NAME' + ig_field = iv_obj_name CHANGING ct_field = lt_fields ). rv_string = cl_http_utility=>if_http_utility~fields_to_string( lt_fields ). @@ -291,9 +311,12 @@ CLASS ZCL_ABAPGIT_HTML_ACTION_UTILS IMPLEMENTATION. DATA: lt_fields TYPE tihttpnvp. - add_field( EXPORTING iv_name = 'KEY' ig_field = iv_key CHANGING ct_field = lt_fields ). - add_field( EXPORTING iv_name = 'OBJ_TYPE' ig_field = ig_object CHANGING ct_field = lt_fields ). - add_field( EXPORTING iv_name = 'OBJ_NAME' ig_field = ig_object CHANGING ct_field = lt_fields ). + add_field( EXPORTING iv_name = 'KEY' + ig_field = iv_key CHANGING ct_field = lt_fields ). + add_field( EXPORTING iv_name = 'OBJ_TYPE' + ig_field = ig_object CHANGING ct_field = lt_fields ). + add_field( EXPORTING iv_name = 'OBJ_NAME' + ig_field = ig_object CHANGING ct_field = lt_fields ). rv_string = cl_http_utility=>if_http_utility~fields_to_string( lt_fields ). @@ -343,8 +366,10 @@ CLASS ZCL_ABAPGIT_HTML_ACTION_UTILS IMPLEMENTATION. lt_fields = parse_fields_upper_case_name( iv_getdata ). - get_field( EXPORTING iv_name = 'KEY' it_field = lt_fields CHANGING cg_field = ev_key ). - get_field( EXPORTING iv_name = 'SEED' it_field = lt_fields CHANGING cg_field = ev_seed ). + get_field( EXPORTING iv_name = 'KEY' + it_field = lt_fields CHANGING cg_field = ev_key ). + get_field( EXPORTING iv_name = 'SEED' + it_field = lt_fields CHANGING cg_field = ev_seed ). ASSERT NOT ev_key IS INITIAL. diff --git a/src/ui/zcl_abapgit_html_action_utils.clas.testclasses.abap b/src/ui/zcl_abapgit_html_action_utils.clas.testclasses.abap index 8d152702d..75d597361 100644 --- a/src/ui/zcl_abapgit_html_action_utils.clas.testclasses.abap +++ b/src/ui/zcl_abapgit_html_action_utils.clas.testclasses.abap @@ -65,9 +65,11 @@ CLASS ltcl_html_action_utils IMPLEMENTATION. ls_answer-value = 'TEST'. APPEND ls_answer TO lt_fields. - zcl_abapgit_html_action_utils=>get_field( EXPORTING iv_name = 'NAME' it_field = lt_fields + zcl_abapgit_html_action_utils=>get_field( EXPORTING iv_name = 'NAME' + it_field = lt_fields CHANGING cg_field = ls_field-value ). - zcl_abapgit_html_action_utils=>get_field( EXPORTING iv_name = 'NAME' it_field = lt_fields + zcl_abapgit_html_action_utils=>get_field( EXPORTING iv_name = 'NAME' + it_field = lt_fields CHANGING cg_field = ls_field ). ls_answer-name = 'TEST'. @@ -85,7 +87,9 @@ CLASS ltcl_html_action_utils IMPLEMENTATION. _when_fields_are_parsed( ). - _then_fields_should_be( iv_index = 1 iv_name = `COMMITTER_NAME` iv_value = `Gustav Gans` ). + _then_fields_should_be( iv_index = 1 + iv_name = `COMMITTER_NAME` + iv_value = `Gustav Gans` ). ENDMETHOD. diff --git a/src/ui/zcl_abapgit_ui_factory.clas.locals_imp.abap b/src/ui/zcl_abapgit_ui_factory.clas.locals_imp.abap index e0dec40e6..7b99fca3d 100644 --- a/src/ui/zcl_abapgit_ui_factory.clas.locals_imp.abap +++ b/src/ui/zcl_abapgit_ui_factory.clas.locals_imp.abap @@ -21,7 +21,8 @@ CLASS lcl_string_buffer IMPLEMENTATION. CLEAR mt_buffer. ENDMETHOD. METHOD join_w_newline_and_flush. - rv_str = concat_lines_of( table = mt_buffer sep = cl_abap_char_utilities=>newline ). + rv_str = concat_lines_of( table = mt_buffer + sep = cl_abap_char_utilities=>newline ). CLEAR mt_buffer. ENDMETHOD. ENDCLASS. diff --git a/src/utils/zcl_abapgit_path.clas.testclasses.abap b/src/utils/zcl_abapgit_path.clas.testclasses.abap index 51ca5a7e8..04cb64069 100644 --- a/src/utils/zcl_abapgit_path.clas.testclasses.abap +++ b/src/utils/zcl_abapgit_path.clas.testclasses.abap @@ -43,38 +43,50 @@ CLASS ltcl_path IMPLEMENTATION. zcl_abapgit_path=>split_file_location( EXPORTING iv_fullpath = '' IMPORTING ev_path = lv_path ev_filename = lv_name ). - cl_abap_unit_assert=>assert_equals( act = lv_path exp = '' ). - cl_abap_unit_assert=>assert_equals( act = lv_name exp = '' ). + cl_abap_unit_assert=>assert_equals( act = lv_path + exp = '' ). + cl_abap_unit_assert=>assert_equals( act = lv_name + exp = '' ). zcl_abapgit_path=>split_file_location( EXPORTING iv_fullpath = 'somefile' IMPORTING ev_path = lv_path ev_filename = lv_name ). - cl_abap_unit_assert=>assert_equals( act = lv_path exp = '' ). - cl_abap_unit_assert=>assert_equals( act = lv_name exp = 'somefile' ). + cl_abap_unit_assert=>assert_equals( act = lv_path + exp = '' ). + cl_abap_unit_assert=>assert_equals( act = lv_name + exp = 'somefile' ). zcl_abapgit_path=>split_file_location( EXPORTING iv_fullpath = '/' IMPORTING ev_path = lv_path ev_filename = lv_name ). - cl_abap_unit_assert=>assert_equals( act = lv_path exp = '/' ). - cl_abap_unit_assert=>assert_equals( act = lv_name exp = '' ). + cl_abap_unit_assert=>assert_equals( act = lv_path + exp = '/' ). + cl_abap_unit_assert=>assert_equals( act = lv_name + exp = '' ). zcl_abapgit_path=>split_file_location( EXPORTING iv_fullpath = '/somefile' IMPORTING ev_path = lv_path ev_filename = lv_name ). - cl_abap_unit_assert=>assert_equals( act = lv_path exp = '/' ). - cl_abap_unit_assert=>assert_equals( act = lv_name exp = 'somefile' ). + cl_abap_unit_assert=>assert_equals( act = lv_path + exp = '/' ). + cl_abap_unit_assert=>assert_equals( act = lv_name + exp = 'somefile' ). zcl_abapgit_path=>split_file_location( EXPORTING iv_fullpath = '/somedir/' IMPORTING ev_path = lv_path ev_filename = lv_name ). - cl_abap_unit_assert=>assert_equals( act = lv_path exp = '/somedir/' ). - cl_abap_unit_assert=>assert_equals( act = lv_name exp = '' ). + cl_abap_unit_assert=>assert_equals( act = lv_path + exp = '/somedir/' ). + cl_abap_unit_assert=>assert_equals( act = lv_name + exp = '' ). zcl_abapgit_path=>split_file_location( EXPORTING iv_fullpath = '/somedir/somefile' IMPORTING ev_path = lv_path ev_filename = lv_name ). - cl_abap_unit_assert=>assert_equals( act = lv_path exp = '/somedir/' ). - cl_abap_unit_assert=>assert_equals( act = lv_name exp = 'somefile' ). + cl_abap_unit_assert=>assert_equals( act = lv_path + exp = '/somedir/' ). + cl_abap_unit_assert=>assert_equals( act = lv_name + exp = 'somefile' ). ENDMETHOD. @@ -85,27 +97,33 @@ CLASS ltcl_path IMPLEMENTATION. lv_yes = zcl_abapgit_path=>is_subdir( iv_path = '/dir/subdir' iv_parent = '/dir' ). - cl_abap_unit_assert=>assert_equals( act = lv_yes exp = abap_true ). + cl_abap_unit_assert=>assert_equals( act = lv_yes + exp = abap_true ). lv_yes = zcl_abapgit_path=>is_subdir( iv_path = '/dir/subdir' iv_parent = '/dir/' ). - cl_abap_unit_assert=>assert_equals( act = lv_yes exp = abap_true ). + cl_abap_unit_assert=>assert_equals( act = lv_yes + exp = abap_true ). lv_yes = zcl_abapgit_path=>is_subdir( iv_path = '/another' iv_parent = '/dir' ). - cl_abap_unit_assert=>assert_equals( act = lv_yes exp = abap_false ). + cl_abap_unit_assert=>assert_equals( act = lv_yes + exp = abap_false ). lv_yes = zcl_abapgit_path=>is_subdir( iv_path = '/dir' iv_parent = '/dir' ). - cl_abap_unit_assert=>assert_equals( act = lv_yes exp = abap_false ). + cl_abap_unit_assert=>assert_equals( act = lv_yes + exp = abap_false ). lv_yes = zcl_abapgit_path=>is_subdir( iv_path = '/dir' iv_parent = '/' ). - cl_abap_unit_assert=>assert_equals( act = lv_yes exp = abap_true ). + cl_abap_unit_assert=>assert_equals( act = lv_yes + exp = abap_true ). lv_yes = zcl_abapgit_path=>is_subdir( iv_path = '/dir2' iv_parent = '/dir' ). - cl_abap_unit_assert=>assert_equals( act = lv_yes exp = abap_false ). + cl_abap_unit_assert=>assert_equals( act = lv_yes + exp = abap_false ). ENDMETHOD. @@ -115,31 +133,38 @@ CLASS ltcl_path IMPLEMENTATION. lv_path = zcl_abapgit_path=>change_dir( iv_cur_dir = '' iv_cd = '' ). - cl_abap_unit_assert=>assert_equals( act = lv_path exp = '' ). + cl_abap_unit_assert=>assert_equals( act = lv_path + exp = '' ). lv_path = zcl_abapgit_path=>change_dir( iv_cur_dir = '/dir' iv_cd = '' ). - cl_abap_unit_assert=>assert_equals( act = lv_path exp = '/dir' ). + cl_abap_unit_assert=>assert_equals( act = lv_path + exp = '/dir' ). lv_path = zcl_abapgit_path=>change_dir( iv_cur_dir = '/dir' iv_cd = '.' ). - cl_abap_unit_assert=>assert_equals( act = lv_path exp = '/dir' ). + cl_abap_unit_assert=>assert_equals( act = lv_path + exp = '/dir' ). lv_path = zcl_abapgit_path=>change_dir( iv_cur_dir = '/dir' iv_cd = '..' ). - cl_abap_unit_assert=>assert_equals( act = lv_path exp = '/' ). + cl_abap_unit_assert=>assert_equals( act = lv_path + exp = '/' ). lv_path = zcl_abapgit_path=>change_dir( iv_cur_dir = '/dir/sub' iv_cd = '..' ). - cl_abap_unit_assert=>assert_equals( act = lv_path exp = '/dir/' ). + cl_abap_unit_assert=>assert_equals( act = lv_path + exp = '/dir/' ). lv_path = zcl_abapgit_path=>change_dir( iv_cur_dir = '/dir/' iv_cd = 'sub' ). - cl_abap_unit_assert=>assert_equals( act = lv_path exp = '/dir/sub' ). + cl_abap_unit_assert=>assert_equals( act = lv_path + exp = '/dir/sub' ). lv_path = zcl_abapgit_path=>change_dir( iv_cur_dir = '/dir' iv_cd = 'sub' ). - cl_abap_unit_assert=>assert_equals( act = lv_path exp = '/dir/sub' ). + cl_abap_unit_assert=>assert_equals( act = lv_path + exp = '/dir/sub' ). ENDMETHOD. @@ -148,26 +173,33 @@ CLASS ltcl_path IMPLEMENTATION. DATA lv_filename TYPE string. lv_filename = zcl_abapgit_path=>get_filename_from_syspath( 'file.txt' ). - cl_abap_unit_assert=>assert_equals( act = lv_filename exp = 'file.txt' ). + cl_abap_unit_assert=>assert_equals( act = lv_filename + exp = 'file.txt' ). lv_filename = zcl_abapgit_path=>get_filename_from_syspath( 'c:\dir\file.txt' ). - cl_abap_unit_assert=>assert_equals( act = lv_filename exp = 'file.txt' ). + cl_abap_unit_assert=>assert_equals( act = lv_filename + exp = 'file.txt' ). lv_filename = zcl_abapgit_path=>get_filename_from_syspath( 'c:\file.txt' ). - cl_abap_unit_assert=>assert_equals( act = lv_filename exp = 'file.txt' ). + cl_abap_unit_assert=>assert_equals( act = lv_filename + exp = 'file.txt' ). lv_filename = zcl_abapgit_path=>get_filename_from_syspath( '/dir/file.txt' ). - cl_abap_unit_assert=>assert_equals( act = lv_filename exp = 'file.txt' ). + cl_abap_unit_assert=>assert_equals( act = lv_filename + exp = 'file.txt' ). lv_filename = zcl_abapgit_path=>get_filename_from_syspath( '/file.txt' ). - cl_abap_unit_assert=>assert_equals( act = lv_filename exp = 'file.txt' ). + cl_abap_unit_assert=>assert_equals( act = lv_filename + exp = 'file.txt' ). lv_filename = zcl_abapgit_path=>get_filename_from_syspath( '\\server$\file.txt' ). - cl_abap_unit_assert=>assert_equals( act = lv_filename exp = 'file.txt' ). + cl_abap_unit_assert=>assert_equals( act = lv_filename + exp = 'file.txt' ). lv_filename = zcl_abapgit_path=>get_filename_from_syspath( 'C:\foo\bar\moo.boo\dev\qas\_blah\goog\muuh\sap\hello\world\lorem\ipsum\s_foo.gif' ). - cl_abap_unit_assert=>assert_equals( act = lv_filename exp = 's_foo.gif' ). + cl_abap_unit_assert=>assert_equals( act = lv_filename + exp = 's_foo.gif' ). ENDMETHOD. diff --git a/src/xml/zcl_abapgit_xml.clas.abap b/src/xml/zcl_abapgit_xml.clas.abap index 0a13b766e..b14977f0c 100644 --- a/src/xml/zcl_abapgit_xml.clas.abap +++ b/src/xml/zcl_abapgit_xml.clas.abap @@ -153,7 +153,8 @@ CLASS zcl_abapgit_xml IMPLEMENTATION. li_istream->close( ). - li_element = mi_xml_doc->find_from_name_ns( depth = 0 name = c_abapgit_tag ). + li_element = mi_xml_doc->find_from_name_ns( depth = 0 + name = c_abapgit_tag ). li_version = li_element->if_ixml_node~get_attributes( )->get_named_item_ns( c_attr_version ) ##no_text. IF li_version->get_value( ) <> zif_abapgit_version=>gc_xml_version. diff --git a/src/xml/zcl_abapgit_xml_input.clas.abap b/src/xml/zcl_abapgit_xml_input.clas.abap index 2a7f47dd9..36de6c10b 100644 --- a/src/xml/zcl_abapgit_xml_input.clas.abap +++ b/src/xml/zcl_abapgit_xml_input.clas.abap @@ -51,7 +51,8 @@ CLASS ZCL_ABAPGIT_XML_INPUT IMPLEMENTATION. li_abap TYPE REF TO if_ixml_node. - li_git ?= mi_xml_doc->find_from_name_ns( depth = 0 name = c_abapgit_tag ). + li_git ?= mi_xml_doc->find_from_name_ns( depth = 0 + name = c_abapgit_tag ). li_abap = li_git->get_first_child( ). mi_xml_doc->get_root( )->remove_child( li_git ). diff --git a/src/xml/zcl_abapgit_xml_output.clas.abap b/src/xml/zcl_abapgit_xml_output.clas.abap index 8f3f0343c..dfad60162 100644 --- a/src/xml/zcl_abapgit_xml_output.clas.abap +++ b/src/xml/zcl_abapgit_xml_output.clas.abap @@ -150,7 +150,8 @@ CLASS ZCL_ABAPGIT_XML_OUTPUT IMPLEMENTATION. ENDIF. li_git = mi_xml_doc->create_element( c_abapgit_tag ). - li_git->set_attribute( name = c_attr_version value = zif_abapgit_version=>gc_xml_version ). + li_git->set_attribute( name = c_attr_version + value = zif_abapgit_version=>gc_xml_version ). IF NOT is_metadata IS INITIAL. li_git->set_attribute( name = c_attr_serializer value = is_metadata-class ). diff --git a/src/zcl_abapgit_dot_abapgit.clas.testclasses.abap b/src/zcl_abapgit_dot_abapgit.clas.testclasses.abap index 2ed48139c..7796ee51b 100644 --- a/src/zcl_abapgit_dot_abapgit.clas.testclasses.abap +++ b/src/zcl_abapgit_dot_abapgit.clas.testclasses.abap @@ -44,21 +44,26 @@ CLASS ltcl_dot_abapgit IMPLEMENTATION. lo_dot = zcl_abapgit_dot_abapgit=>build_default( ). - lv_ignored = lo_dot->is_ignored( iv_path = lc_path iv_filename = lc_filename ). + lv_ignored = lo_dot->is_ignored( iv_path = lc_path + iv_filename = lc_filename ). cl_abap_unit_assert=>assert_equals( act = lv_ignored exp = abap_false ). - lo_dot->add_ignore( iv_path = lc_path iv_filename = lc_filename ). + lo_dot->add_ignore( iv_path = lc_path + iv_filename = lc_filename ). - lv_ignored = lo_dot->is_ignored( iv_path = lc_path iv_filename = lc_filename ). + lv_ignored = lo_dot->is_ignored( iv_path = lc_path + iv_filename = lc_filename ). cl_abap_unit_assert=>assert_equals( act = lv_ignored exp = abap_true ). - lo_dot->remove_ignore( iv_path = lc_path iv_filename = lc_filename ). + lo_dot->remove_ignore( iv_path = lc_path + iv_filename = lc_filename ). - lv_ignored = lo_dot->is_ignored( iv_path = lc_path iv_filename = lc_filename ). + lv_ignored = lo_dot->is_ignored( iv_path = lc_path + iv_filename = lc_filename ). cl_abap_unit_assert=>assert_equals( act = lv_ignored exp = abap_false ). diff --git a/src/zcl_abapgit_news.clas.abap b/src/zcl_abapgit_news.clas.abap index ee87ed6e6..1d4330e83 100644 --- a/src/zcl_abapgit_news.clas.abap +++ b/src/zcl_abapgit_news.clas.abap @@ -132,7 +132,8 @@ CLASS ZCL_ABAPGIT_NEWS IMPLEMENTATION. lv_string = zcl_abapgit_convert=>xstring_to_string_utf8( iv_rawdata ). lt_lines = zcl_abapgit_convert=>split_string( lv_string ). - mt_log = parse( it_lines = lt_lines iv_current_version = mv_current_version ). + mt_log = parse( it_lines = lt_lines + iv_current_version = mv_current_version ). READ TABLE mt_log INTO ls_log_line INDEX 1. mv_latest_version = ls_log_line-version. " Empty if not found @@ -261,7 +262,8 @@ CLASS ZCL_ABAPGIT_NEWS IMPLEMENTATION. LOOP AT it_lines ASSIGNING . - ls_log = parse_line( iv_line = iv_current_version = iv_current_version ). + ls_log = parse_line( iv_line = + iv_current_version = iv_current_version ). " Skip until first version head and Skip empty lines CHECK ls_log IS NOT INITIAL AND @@ -269,14 +271,16 @@ CLASS ZCL_ABAPGIT_NEWS IMPLEMENTATION. IF lv_first_version_found = abap_false. lv_first_version_found = abap_true. - IF compare_versions( iv_a = ls_log-version iv_b = iv_current_version ) <= 0. + IF compare_versions( iv_a = ls_log-version + iv_b = iv_current_version ) <= 0. lv_tail = c_tail_length. " Display some last versions if no updates ENDIF. ENDIF. IF ls_log-is_header = abap_true. "Skip everything below current version or show tail news - IF compare_versions( iv_a = ls_log-version iv_b = iv_current_version ) <= 0. + IF compare_versions( iv_a = ls_log-version + iv_b = iv_current_version ) <= 0. IF lv_tail > 0. lv_tail = lv_tail - 1. ELSE. @@ -311,7 +315,8 @@ CLASS ZCL_ABAPGIT_NEWS IMPLEMENTATION. lv_version = normalize_version( lv_version ). rs_log-version = lv_version. rs_log-is_header = abap_true. - rs_log-pos_to_cur = compare_versions( iv_a = lv_version iv_b = iv_current_version ). + rs_log-pos_to_cur = compare_versions( iv_a = lv_version + iv_b = iv_current_version ). ELSE. FIND FIRST OCCURRENCE OF REGEX '^\s*!' IN iv_line. rs_log-is_important = boolc( sy-subrc IS INITIAL ). " Change is important diff --git a/src/zcl_abapgit_news.clas.testclasses.abap b/src/zcl_abapgit_news.clas.testclasses.abap index 982dcd984..b78770c6d 100644 --- a/src/zcl_abapgit_news.clas.testclasses.abap +++ b/src/zcl_abapgit_news.clas.testclasses.abap @@ -148,7 +148,8 @@ CLASS ltcl_news IMPLEMENTATION. DATA lv_result TYPE i. " Case 1: version A > version B - lv_result = zcl_abapgit_news=>compare_versions( iv_a = '1.28.10' iv_b = '1.23.10' ). + lv_result = zcl_abapgit_news=>compare_versions( iv_a = '1.28.10' + iv_b = '1.23.10' ). cl_abap_unit_assert=>assert_equals( exp = 1 act = lv_result @@ -157,7 +158,8 @@ CLASS ltcl_news IMPLEMENTATION. CLEAR: lv_result. " Case 2: version A < version B - lv_result = zcl_abapgit_news=>compare_versions( iv_a = '1.28.10' iv_b = '2.23.10' ). + lv_result = zcl_abapgit_news=>compare_versions( iv_a = '1.28.10' + iv_b = '2.23.10' ). cl_abap_unit_assert=>assert_equals( exp = -1 act = lv_result @@ -166,7 +168,8 @@ CLASS ltcl_news IMPLEMENTATION. CLEAR: lv_result. " Case 3: version A = version B - lv_result = zcl_abapgit_news=>compare_versions( iv_a = '1.28.10' iv_b = '1.28.10' ). + lv_result = zcl_abapgit_news=>compare_versions( iv_a = '1.28.10' + iv_b = '1.28.10' ). cl_abap_unit_assert=>assert_equals( exp = 0 act = lv_result @@ -217,37 +220,53 @@ CLASS ltcl_news IMPLEMENTATION. ls_log = zcl_abapgit_news=>parse_line( iv_line = '2017-02-13 v1.28.0' iv_current_version = '1.26.01' ). - cl_abap_unit_assert=>assert_equals( act = ls_log-version exp = '1.28.0' ). - cl_abap_unit_assert=>assert_equals( act = ls_log-is_header exp = abap_true ). - cl_abap_unit_assert=>assert_equals( act = ls_log-pos_to_cur exp = 1 ). + cl_abap_unit_assert=>assert_equals( act = ls_log-version + exp = '1.28.0' ). + cl_abap_unit_assert=>assert_equals( act = ls_log-is_header + exp = abap_true ). + cl_abap_unit_assert=>assert_equals( act = ls_log-pos_to_cur + exp = 1 ). CLEAR ls_log. ls_log = zcl_abapgit_news=>parse_line( iv_line = '2017-02-13 v1.26.0' iv_current_version = '1.26.01' ). - cl_abap_unit_assert=>assert_equals( act = ls_log-version exp = '1.26.0' ). - cl_abap_unit_assert=>assert_equals( act = ls_log-is_header exp = abap_true ). - cl_abap_unit_assert=>assert_equals( act = ls_log-pos_to_cur exp = -1 ). + cl_abap_unit_assert=>assert_equals( act = ls_log-version + exp = '1.26.0' ). + cl_abap_unit_assert=>assert_equals( act = ls_log-is_header + exp = abap_true ). + cl_abap_unit_assert=>assert_equals( act = ls_log-pos_to_cur + exp = -1 ). CLEAR ls_log. ls_log = zcl_abapgit_news=>parse_line( iv_line = 'news' iv_current_version = '1.26.01' ). - cl_abap_unit_assert=>assert_equals( act = ls_log-version exp = '' ). - cl_abap_unit_assert=>assert_equals( act = ls_log-is_header exp = abap_false ). - cl_abap_unit_assert=>assert_equals( act = ls_log-pos_to_cur exp = 0 ). - cl_abap_unit_assert=>assert_equals( act = ls_log-is_important exp = abap_false ). - cl_abap_unit_assert=>assert_equals( act = ls_log-text exp = 'news' ). + cl_abap_unit_assert=>assert_equals( act = ls_log-version + exp = '' ). + cl_abap_unit_assert=>assert_equals( act = ls_log-is_header + exp = abap_false ). + cl_abap_unit_assert=>assert_equals( act = ls_log-pos_to_cur + exp = 0 ). + cl_abap_unit_assert=>assert_equals( act = ls_log-is_important + exp = abap_false ). + cl_abap_unit_assert=>assert_equals( act = ls_log-text + exp = 'news' ). CLEAR ls_log. ls_log = zcl_abapgit_news=>parse_line( iv_line = ' ! important news' iv_current_version = '1.26.01' ). - cl_abap_unit_assert=>assert_equals( act = ls_log-version exp = '' ). - cl_abap_unit_assert=>assert_equals( act = ls_log-is_header exp = abap_false ). - cl_abap_unit_assert=>assert_equals( act = ls_log-pos_to_cur exp = 0 ). - cl_abap_unit_assert=>assert_equals( act = ls_log-is_important exp = abap_true ). - cl_abap_unit_assert=>assert_equals( act = ls_log-text exp = ' ! important news' ). + cl_abap_unit_assert=>assert_equals( act = ls_log-version + exp = '' ). + cl_abap_unit_assert=>assert_equals( act = ls_log-is_header + exp = abap_false ). + cl_abap_unit_assert=>assert_equals( act = ls_log-pos_to_cur + exp = 0 ). + cl_abap_unit_assert=>assert_equals( act = ls_log-is_important + exp = abap_true ). + cl_abap_unit_assert=>assert_equals( act = ls_log-text + exp = ' ! important news' ). ENDMETHOD. diff --git a/src/zcl_abapgit_objects.clas.abap b/src/zcl_abapgit_objects.clas.abap index bb8cc60b1..007d564be 100644 --- a/src/zcl_abapgit_objects.clas.abap +++ b/src/zcl_abapgit_objects.clas.abap @@ -398,7 +398,8 @@ CLASS ZCL_ABAPGIT_OBJECTS IMPLEMENTATION. iv_xml = zcl_abapgit_convert=>xstring_to_string_utf8( ls_remote_file-data ) iv_filename = ls_remote_file-filename. - ls_result = li_comparator->compare( io_remote = lo_remote_version ii_log = ii_log ). + ls_result = li_comparator->compare( io_remote = lo_remote_version + ii_log = ii_log ). IF ls_result-text IS INITIAL. RETURN. ENDIF. @@ -406,7 +407,8 @@ CLASS ZCL_ABAPGIT_OBJECTS IMPLEMENTATION. "log comparison result ls_item-obj_type = is_result-obj_type. ls_item-obj_name = is_result-obj_name. - ii_log->add_warning( iv_msg = ls_result-text is_item = ls_item ). + ii_log->add_warning( iv_msg = ls_result-text + is_item = ls_item ). "continue or abort? lv_gui_is_available = zcl_abapgit_ui_factory=>get_gui_functions( )->gui_is_available( ). @@ -610,7 +612,8 @@ CLASS ZCL_ABAPGIT_OBJECTS IMPLEMENTATION. lt_remote = io_repo->get_files_remote( ). - lt_results = files_to_deserialize( io_repo = io_repo ii_log = ii_log ). + lt_results = files_to_deserialize( io_repo = io_repo + ii_log = ii_log ). checks_adjust( EXPORTING @@ -690,8 +693,10 @@ CLASS ZCL_ABAPGIT_OBJECTS IMPLEMENTATION. CLEAR: lv_path, lv_package. CATCH zcx_abapgit_exception INTO lx_exc. - ii_log->add_exception( ix_exc = lx_exc is_item = ls_item ). - ii_log->add_error( iv_msg = |Import of object { ls_item-obj_name } failed| is_item = ls_item ). + ii_log->add_exception( ix_exc = lx_exc + is_item = ls_item ). + ii_log->add_error( iv_msg = |Import of object { ls_item-obj_name } failed| + is_item = ls_item ). "object should not be part of any deserialization step CONTINUE. ENDTRY. @@ -765,11 +770,14 @@ CLASS ZCL_ABAPGIT_OBJECTS IMPLEMENTATION. ii_log = ii_log ). APPEND LINES OF -obj->mo_files->get_accessed_files( ) TO ct_files. - ii_log->add_success( iv_msg = |Object { -item-obj_name } imported| is_item = -item ). + ii_log->add_success( iv_msg = |Object { -item-obj_name } imported| + is_item = -item ). CATCH zcx_abapgit_exception INTO lx_exc. - ii_log->add_exception( ix_exc = lx_exc is_item = -item ). - ii_log->add_error( iv_msg = |Import of object { -item-obj_name } failed| is_item = -item ). + ii_log->add_exception( ix_exc = lx_exc + is_item = -item ). + ii_log->add_error( iv_msg = |Import of object { -item-obj_name } failed| + is_item = -item ). ENDTRY. ENDLOOP. diff --git a/src/zcl_abapgit_repo_content_list.clas.abap b/src/zcl_abapgit_repo_content_list.clas.abap index 87698aef3..09cff9118 100644 --- a/src/zcl_abapgit_repo_content_list.clas.abap +++ b/src/zcl_abapgit_repo_content_list.clas.abap @@ -66,7 +66,8 @@ CLASS ZCL_ABAPGIT_REPO_CONTENT_LIST IMPLEMENTATION. lv_index = sy-tabix. CHECK -path <> iv_cur_dir. " files in target dir - just leave them be - IF zcl_abapgit_path=>is_subdir( iv_path = -path iv_parent = iv_cur_dir ) = abap_true. + IF zcl_abapgit_path=>is_subdir( iv_path = -path + iv_parent = iv_cur_dir ) = abap_true. ls_subitem-changes = -changes. ls_subitem-path = -path. ls_subitem-lstate = -lstate. diff --git a/src/zcx_abapgit_exception.clas.testclasses.abap b/src/zcx_abapgit_exception.clas.testclasses.abap index 0a9aec388..47200ea02 100644 --- a/src/zcx_abapgit_exception.clas.testclasses.abap +++ b/src/zcx_abapgit_exception.clas.testclasses.abap @@ -57,7 +57,8 @@ CLASS ltcl_test IMPLEMENTATION. CATCH zcx_abapgit_exception INTO lx_ex. cl_abap_unit_assert=>assert_equals( act = get_exc_text( lx_ex ) exp = lx_previous->get_text( ) ). - cl_abap_unit_assert=>assert_equals( act = lx_ex->previous exp = lx_previous ). + cl_abap_unit_assert=>assert_equals( act = lx_ex->previous + exp = lx_previous ). ENDTRY. FREE: lx_ex, lx_previous. @@ -66,7 +67,8 @@ CLASS ltcl_test IMPLEMENTATION. zcx_abapgit_exception=>raise( lc_text1 ). cl_abap_unit_assert=>fail( ). CATCH zcx_abapgit_exception INTO lx_ex. - cl_abap_unit_assert=>assert_equals( act = get_exc_text( lx_ex ) exp = lc_text1 ). + cl_abap_unit_assert=>assert_equals( act = get_exc_text( lx_ex ) + exp = lc_text1 ). ENDTRY. FREE lx_ex. @@ -114,7 +116,8 @@ CLASS ltcl_test IMPLEMENTATION. zcx_abapgit_exception=>raise_t100( ). cl_abap_unit_assert=>fail( ). CATCH zcx_abapgit_exception INTO lx_ex. - cl_abap_unit_assert=>assert_equals( act = get_exc_text( lx_ex ) exp = lv_text ). + cl_abap_unit_assert=>assert_equals( act = get_exc_text( lx_ex ) + exp = lv_text ). ENDTRY. ENDMETHOD. @@ -137,7 +140,8 @@ CLASS ltcl_test IMPLEMENTATION. zcx_abapgit_exception=>raise_t100( ). cl_abap_unit_assert=>fail( ). CATCH zcx_abapgit_exception INTO lx_ex. - cl_abap_unit_assert=>assert_equals( act = get_exc_text( lx_ex ) exp = lv_text ). + cl_abap_unit_assert=>assert_equals( act = get_exc_text( lx_ex ) + exp = lv_text ). ENDTRY. ENDMETHOD. @@ -160,7 +164,8 @@ CLASS ltcl_test IMPLEMENTATION. zcx_abapgit_exception=>raise_t100( ). cl_abap_unit_assert=>fail( ). CATCH zcx_abapgit_exception INTO lx_ex. - cl_abap_unit_assert=>assert_equals( act = get_exc_text( lx_ex ) exp = lv_text ). + cl_abap_unit_assert=>assert_equals( act = get_exc_text( lx_ex ) + exp = lv_text ). ENDTRY. ENDMETHOD. @@ -183,7 +188,8 @@ CLASS ltcl_test IMPLEMENTATION. zcx_abapgit_exception=>raise_t100( ). cl_abap_unit_assert=>fail( ). CATCH zcx_abapgit_exception INTO lx_ex. - cl_abap_unit_assert=>assert_equals( act = get_exc_text( lx_ex ) exp = lv_text ). + cl_abap_unit_assert=>assert_equals( act = get_exc_text( lx_ex ) + exp = lv_text ). ENDTRY. ENDMETHOD. @@ -206,7 +212,8 @@ CLASS ltcl_test IMPLEMENTATION. zcx_abapgit_exception=>raise_t100( ). cl_abap_unit_assert=>fail( ). CATCH zcx_abapgit_exception INTO lx_ex. - cl_abap_unit_assert=>assert_equals( act = get_exc_text( lx_ex ) exp = lv_text ). + cl_abap_unit_assert=>assert_equals( act = get_exc_text( lx_ex ) + exp = lv_text ). ENDTRY. ENDMETHOD. @@ -229,7 +236,8 @@ CLASS ltcl_test IMPLEMENTATION. zcx_abapgit_exception=>raise_t100( ). cl_abap_unit_assert=>fail( ). CATCH zcx_abapgit_exception INTO lx_ex. - cl_abap_unit_assert=>assert_equals( act = get_exc_text( lx_ex ) exp = lv_text ). + cl_abap_unit_assert=>assert_equals( act = get_exc_text( lx_ex ) + exp = lv_text ). ENDTRY. ENDMETHOD. @@ -252,7 +260,8 @@ CLASS ltcl_test IMPLEMENTATION. zcx_abapgit_exception=>raise_t100( ). cl_abap_unit_assert=>fail( ). CATCH zcx_abapgit_exception INTO lx_ex. - cl_abap_unit_assert=>assert_equals( act = get_exc_text( lx_ex ) exp = lv_text ). + cl_abap_unit_assert=>assert_equals( act = get_exc_text( lx_ex ) + exp = lv_text ). ENDTRY. ENDMETHOD. @@ -275,7 +284,8 @@ CLASS ltcl_test IMPLEMENTATION. zcx_abapgit_exception=>raise_t100( ). cl_abap_unit_assert=>fail( ). CATCH zcx_abapgit_exception INTO lx_ex. - cl_abap_unit_assert=>assert_equals( act = get_exc_text( lx_ex ) exp = lv_text ). + cl_abap_unit_assert=>assert_equals( act = get_exc_text( lx_ex ) + exp = lv_text ). ENDTRY. ENDMETHOD.