SAP/abapGit
1
0
Fork 0
mirror of https://github.com/abapGit/abapGit.git synced 2025-05-01 12:20:51 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

delete method ZCL_ABAPGIT_HTML=>CREATE (#3736)

Browse Source
This commit is contained in:
Lars Hvam 2020-08-18 06:54:20 +02:00 committed by GitHub
parent 138172ffda
commit d5e5baa7d8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 16 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/ui/core/zcl_abapgit_html.clas.abap
View File

@ -24,9 +24,6 @@ CLASS zcl_abapgit_html DEFINITION
CONSTANTS c_indent_size TYPE i VALUE 2 ##NO_TEXT.
CLASS-METHODS class_constructor .
CLASS-METHODS create
RETURNING
VALUE(ro_html) TYPE REF TO zcl_abapgit_html .
PROTECTED SECTION.
PRIVATE SECTION.
@ -201,11 +198,6 @@ CLASS ZCL_ABAPGIT_HTML IMPLEMENTATION.
ENDMETHOD.
METHOD create.
CREATE OBJECT ro_html.
ENDMETHOD.
METHOD icon.
DATA: lv_hint TYPE string,

21
src/ui/zcl_abapgit_gui_chunk_lib.clas.abap
View File

@ -150,7 +150,7 @@ ENDCLASS.
CLASS zcl_abapgit_gui_chunk_lib IMPLEMENTATION.
CLASS ZCL_ABAPGIT_GUI_CHUNK_LIB IMPLEMENTATION.
METHOD advanced_submenu.
@ -640,7 +640,7 @@ CLASS zcl_abapgit_gui_chunk_lib IMPLEMENTATION.
lt_repo_list = zcl_abapgit_persist_factory=>get_repo( )->list( ).
lv_size = lines( lt_repo_list ).
ri_html = zcl_abapgit_html=>create( ).
CREATE OBJECT ri_html TYPE zcl_abapgit_html.
ri_html->add( 'var repoCatalog = [' ). " Maybe separate this into another method if needed in more places
LOOP AT lt_repo_list ASSIGNING <ls_repo>.
@ -780,14 +780,6 @@ CLASS zcl_abapgit_gui_chunk_lib IMPLEMENTATION.
ENDMETHOD.
METHOD render_warning_banner.
CREATE OBJECT ro_html.
ro_html->add( '<div class="dummydiv warning">' ).
ro_html->add( |{ zcl_abapgit_html=>icon( 'exclamation-triangle/yellow' ) }| && | { iv_text }| ).
ro_html->add( '</div>' ).
ENDMETHOD.
METHOD render_repo_top_commit_hash.
DATA: lv_commit_hash TYPE zif_abapgit_definitions=>ty_sha1,
@ -817,4 +809,13 @@ CLASS zcl_abapgit_gui_chunk_lib IMPLEMENTATION.
ENDMETHOD.
METHOD render_warning_banner.
CREATE OBJECT ro_html.
ro_html->add( '<div class="dummydiv warning">' ).
ro_html->add( |{ zcl_abapgit_html=>icon( 'exclamation-triangle/yellow' ) }| && | { iv_text }| ).
ro_html->add( '</div>' ).
ENDMETHOD.
ENDCLASS.

2
src/ui/zcl_abapgit_gui_page_addonline.clas.abap
View File

@ -249,7 +249,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_ADDONLINE IMPLEMENTATION.
gui_services( )->register_event_handler( me ).
ri_html = zcl_abapgit_html=>create( ).
CREATE OBJECT ri_html TYPE zcl_abapgit_html.
lo_form = zcl_abapgit_html_form=>create( iv_form_id = 'add-repo-online-form' ).
lo_form->text(

2
src/ui/zcl_abapgit_html_form.clas.abap
View File

@ -225,7 +225,7 @@ CLASS ZCL_ABAPGIT_HTML_FORM IMPLEMENTATION.
ls_form_id = | id="{ mv_form_id }"|.
ENDIF.
ri_html = zcl_abapgit_html=>create( ).
CREATE OBJECT ri_html TYPE zcl_abapgit_html.
ri_html->add( |<div class="{ iv_form_class }">| ).
ri_html->add( |<form method="post"{ ls_form_id }>| ).

6
src/ui/zcl_abapgit_html_toolbar.clas.abap
View File

@ -202,13 +202,13 @@ CLASS ZCL_ABAPGIT_HTML_TOOLBAR IMPLEMENTATION.
IF lv_has_icons = abap_true.
IF <ls_item>-chk = abap_true.
lv_icon = zcl_abapgit_html=>icon( 'check/blue' ).
lv_icon = ri_html->icon( 'check/blue' ).
lv_check = ' data-check="X"'.
ELSEIF <ls_item>-chk = abap_false.
lv_icon = zcl_abapgit_html=>icon( 'check/grey' ).
lv_icon = ri_html->icon( 'check/grey' ).
lv_check = ' data-check=""'.
ELSE. " abap_undefined -> not a check box
lv_icon = zcl_abapgit_html=>icon( <ls_item>-ico ).
lv_icon = ri_html->icon( <ls_item>-ico ).
ENDIF.
ENDIF.