From d7f74bd49c28779fec09148851fffac064e14f82 Mon Sep 17 00:00:00 2001 From: Lars Hvam Date: Sun, 7 Mar 2021 12:15:26 +0100 Subject: [PATCH] zif_abapgit_poups cleanup (#4608) * zif_abapgit_poups cleanup delete method POPUP_TO_INFORM * delete method POPUP_PROXY_BYPASS --- ...pgit_html_form_utils.clas.testclasses.abap | 6 --- src/ui/zcl_abapgit_popups.clas.abap | 47 +------------------ ...apgit_services_basis.clas.testclasses.abap | 8 ---- ..._abapgit_ui_injector.clas.testclasses.abap | 8 ---- src/ui/zif_abapgit_popups.intf.abap | 15 +----- 5 files changed, 2 insertions(+), 82 deletions(-) diff --git a/src/ui/zcl_abapgit_html_form_utils.clas.testclasses.abap b/src/ui/zcl_abapgit_html_form_utils.clas.testclasses.abap index 252459a05..b9622cec8 100644 --- a/src/ui/zcl_abapgit_html_form_utils.clas.testclasses.abap +++ b/src/ui/zcl_abapgit_html_form_utils.clas.testclasses.abap @@ -59,9 +59,6 @@ CLASS ltcl_popups_mock IMPLEMENTATION. METHOD zif_abapgit_popups~popup_perf_test_parameters. ENDMETHOD. - METHOD zif_abapgit_popups~popup_proxy_bypass. - ENDMETHOD. - METHOD zif_abapgit_popups~popup_search_help. ENDMETHOD. @@ -86,9 +83,6 @@ CLASS ltcl_popups_mock IMPLEMENTATION. METHOD zif_abapgit_popups~popup_to_create_transp_branch. ENDMETHOD. - METHOD zif_abapgit_popups~popup_to_inform. - ENDMETHOD. - METHOD zif_abapgit_popups~popup_to_select_from_list. ENDMETHOD. diff --git a/src/ui/zcl_abapgit_popups.clas.abap b/src/ui/zcl_abapgit_popups.clas.abap index e729ae72f..b9545171c 100644 --- a/src/ui/zcl_abapgit_popups.clas.abap +++ b/src/ui/zcl_abapgit_popups.clas.abap @@ -89,7 +89,7 @@ ENDCLASS. -CLASS zcl_abapgit_popups IMPLEMENTATION. +CLASS ZCL_ABAPGIT_POPUPS IMPLEMENTATION. METHOD add_field. @@ -864,32 +864,6 @@ CLASS zcl_abapgit_popups IMPLEMENTATION. ENDMETHOD. - METHOD zif_abapgit_popups~popup_proxy_bypass. - rt_proxy_bypass = it_proxy_bypass. - CALL FUNCTION 'COMPLEX_SELECTIONS_DIALOG' - EXPORTING - title = 'Bypass proxy settings for these Hosts & Domains' - signed = abap_false - lower_case = abap_true - no_interval_check = abap_true - TABLES - range = rt_proxy_bypass - EXCEPTIONS - no_range_tab = 1 - cancelled = 2 - internal_error = 3 - invalid_fieldname = 4 - OTHERS = 5. - CASE sy-subrc. - WHEN 0. - WHEN 2. - RAISE EXCEPTION TYPE zcx_abapgit_cancel. - WHEN OTHERS. - zcx_abapgit_exception=>raise( 'Error from COMPLEX_SELECTIONS_DIALOG' ). - ENDCASE. - ENDMETHOD. - - METHOD zif_abapgit_popups~popup_search_help. DATA lt_ret TYPE TABLE OF ddshretval. @@ -1019,25 +993,6 @@ CLASS zcl_abapgit_popups IMPLEMENTATION. ENDMETHOD. - METHOD zif_abapgit_popups~popup_to_inform. - - DATA: lv_line1 TYPE c LENGTH 70, - lv_line2 TYPE c LENGTH 70. - - lv_line1 = iv_text_message. - IF strlen( iv_text_message ) > 70. - lv_line2 = iv_text_message+70. - ENDIF. - - CALL FUNCTION 'POPUP_TO_INFORM' - EXPORTING - titel = iv_titlebar - txt1 = lv_line1 - txt2 = lv_line2. - - ENDMETHOD. - - METHOD zif_abapgit_popups~popup_to_select_from_list. DATA: lv_pfstatus TYPE sypfkey, diff --git a/src/ui/zcl_abapgit_services_basis.clas.testclasses.abap b/src/ui/zcl_abapgit_services_basis.clas.testclasses.abap index ca9f55071..d710ed48c 100644 --- a/src/ui/zcl_abapgit_services_basis.clas.testclasses.abap +++ b/src/ui/zcl_abapgit_services_basis.clas.testclasses.abap @@ -362,10 +362,6 @@ CLASS ltcl_popups_mock IMPLEMENTATION. ENDMETHOD. - METHOD zif_abapgit_popups~popup_proxy_bypass. - - ENDMETHOD. - METHOD zif_abapgit_popups~popup_search_help. ENDMETHOD. @@ -393,10 +389,6 @@ CLASS ltcl_popups_mock IMPLEMENTATION. ENDMETHOD. - METHOD zif_abapgit_popups~popup_to_inform. - - ENDMETHOD. - METHOD zif_abapgit_popups~popup_to_select_from_list. ENDMETHOD. diff --git a/src/ui/zcl_abapgit_ui_injector.clas.testclasses.abap b/src/ui/zcl_abapgit_ui_injector.clas.testclasses.abap index 6bba0e73a..73a7be3f5 100644 --- a/src/ui/zcl_abapgit_ui_injector.clas.testclasses.abap +++ b/src/ui/zcl_abapgit_ui_injector.clas.testclasses.abap @@ -64,10 +64,6 @@ CLASS ltcl_abapgit_popups_mock IMPLEMENTATION. ENDMETHOD. - METHOD zif_abapgit_popups~popup_to_inform. - - ENDMETHOD. - METHOD zif_abapgit_popups~popup_to_select_from_list. ENDMETHOD. @@ -84,10 +80,6 @@ CLASS ltcl_abapgit_popups_mock IMPLEMENTATION. ENDMETHOD. - METHOD zif_abapgit_popups~popup_proxy_bypass. - - ENDMETHOD. - METHOD zif_abapgit_popups~popup_search_help. ENDMETHOD. diff --git a/src/ui/zif_abapgit_popups.intf.abap b/src/ui/zif_abapgit_popups.intf.abap index 9ca88b71c..940ca1321 100644 --- a/src/ui/zif_abapgit_popups.intf.abap +++ b/src/ui/zif_abapgit_popups.intf.abap @@ -73,7 +73,7 @@ INTERFACE zif_abapgit_popups RETURNING VALUE(rs_popup) TYPE ty_popup RAISING - zcx_abapgit_exception ##NO_TEXT. + zcx_abapgit_exception ##NO_TEXT. METHODS popup_to_confirm IMPORTING !iv_titlebar TYPE clike @@ -88,12 +88,6 @@ INTERFACE zif_abapgit_popups VALUE(rv_answer) TYPE char1 RAISING zcx_abapgit_exception . - METHODS popup_to_inform - IMPORTING - !iv_titlebar TYPE clike - !iv_text_message TYPE clike - RAISING - zcx_abapgit_exception . METHODS popup_to_create_package EXPORTING !es_package_data TYPE scompkdtln @@ -144,13 +138,6 @@ INTERFACE zif_abapgit_popups VALUE(rv_transport) TYPE trkorr RAISING zcx_abapgit_exception . - METHODS popup_proxy_bypass - IMPORTING - !it_proxy_bypass TYPE zif_abapgit_definitions=>ty_range_proxy_bypass_url - RETURNING - VALUE(rt_proxy_bypass) TYPE zif_abapgit_definitions=>ty_range_proxy_bypass_url - RAISING - zcx_abapgit_exception . METHODS choose_pr_popup IMPORTING !it_pulls TYPE zif_abapgit_pr_enum_provider=>ty_pull_requests