From d80e1ec3c26b8a638318d711c08a0a4c9b19e477 Mon Sep 17 00:00:00 2001 From: Marc Bernard Date: Wed, 27 Nov 2024 23:57:14 +0000 Subject: [PATCH] Fix extended check issues - Part 1 Ref #5210 --- src/apack/zcl_abapgit_apack_migration.clas.abap | 2 +- src/cts/zcl_abapgit_cts_api.clas.abap | 2 +- src/data/zcl_abapgit_data_utils.clas.abap | 4 ++-- src/git_platform/zcl_abapgit_pr_enumerator.clas.abap | 2 +- src/inspect/zcl_abapgit_where_used_tools.clas.abap | 6 +++--- src/persist/zcl_abapgit_persist_migrate.clas.abap | 4 ++-- src/repo/utils/zcl_abapgit_repo_labels.clas.abap | 4 ++-- src/zabapgit_forms.prog.abap | 10 +++++----- src/zabapgit_password_dialog.prog.abap | 2 +- 9 files changed, 18 insertions(+), 18 deletions(-) diff --git a/src/apack/zcl_abapgit_apack_migration.clas.abap b/src/apack/zcl_abapgit_apack_migration.clas.abap index 885b479af..e3ac8239e 100644 --- a/src/apack/zcl_abapgit_apack_migration.clas.abap +++ b/src/apack/zcl_abapgit_apack_migration.clas.abap @@ -178,7 +178,7 @@ CLASS zcl_abapgit_apack_migration IMPLEMENTATION. component_error = 4 no_access = 5 other = 6 - OTHERS = 7. + OTHERS = 7 ##FM_SUBRC_OK. CATCH cx_sy_dyn_call_param_not_found. CALL FUNCTION 'SEO_INTERFACE_CREATE_COMPLETE' EXPORTING diff --git a/src/cts/zcl_abapgit_cts_api.clas.abap b/src/cts/zcl_abapgit_cts_api.clas.abap index 0892d56f5..0ef490902 100644 --- a/src/cts/zcl_abapgit_cts_api.clas.abap +++ b/src/cts/zcl_abapgit_cts_api.clas.abap @@ -623,7 +623,7 @@ CLASS zcl_abapgit_cts_api IMPLEMENTATION. ev_object = ls_list-object ev_obj_name = ls_list-obj_name ). INSERT ls_list INTO TABLE rt_list. - CATCH zcx_abapgit_exception. + CATCH zcx_abapgit_exception ##NO_HANDLER. ENDTRY. ENDCASE. ENDLOOP. diff --git a/src/data/zcl_abapgit_data_utils.clas.abap b/src/data/zcl_abapgit_data_utils.clas.abap index 91da50dd8..b205f93d4 100644 --- a/src/data/zcl_abapgit_data_utils.clas.abap +++ b/src/data/zcl_abapgit_data_utils.clas.abap @@ -49,7 +49,7 @@ ENDCLASS. -CLASS ZCL_ABAPGIT_DATA_UTILS IMPLEMENTATION. +CLASS zcl_abapgit_data_utils IMPLEMENTATION. METHOD build_config_filename. @@ -196,7 +196,7 @@ CLASS ZCL_ABAPGIT_DATA_UTILS IMPLEMENTATION. db_not_exists = 3 no_permission = 4 no_change_allowed = 5 - table_is_gtt = 6 +* table_is_gtt = 6 " not in lower releases OTHERS = 7. IF sy-subrc <> 0. zcx_abapgit_exception=>raise( |Table { is_item-obj_name } cannot be displayed| ). diff --git a/src/git_platform/zcl_abapgit_pr_enumerator.clas.abap b/src/git_platform/zcl_abapgit_pr_enumerator.clas.abap index 6d731a02f..dadea98c5 100644 --- a/src/git_platform/zcl_abapgit_pr_enumerator.clas.abap +++ b/src/git_platform/zcl_abapgit_pr_enumerator.clas.abap @@ -50,7 +50,7 @@ CLASS zcl_abapgit_pr_enumerator IMPLEMENTATION. mv_repo_url = to_lower( iv_url ). TRY. mi_enum_provider = create_provider( mv_repo_url ). - CATCH zcx_abapgit_exception. + CATCH zcx_abapgit_exception ##NO_HANDLER. ENDTRY. ENDMETHOD. diff --git a/src/inspect/zcl_abapgit_where_used_tools.clas.abap b/src/inspect/zcl_abapgit_where_used_tools.clas.abap index d99572336..14d13ef11 100644 --- a/src/inspect/zcl_abapgit_where_used_tools.clas.abap +++ b/src/inspect/zcl_abapgit_where_used_tools.clas.abap @@ -124,7 +124,7 @@ ENDCLASS. -CLASS ZCL_ABAPGIT_WHERE_USED_TOOLS IMPLEMENTATION. +CLASS zcl_abapgit_where_used_tools IMPLEMENTATION. METHOD build_package_scope. @@ -311,7 +311,7 @@ CLASS ZCL_ABAPGIT_WHERE_USED_TOOLS IMPLEMENTATION. not_enough_input = 1 no_function_pool = 2 delimiter_wrong_position = 3 - OTHERS = 4. + OTHERS = 4 ##FM_SUBRC_OK. IF lv_area IS INITIAL. SELECT SINGLE master FROM d010inc INTO lv_program @@ -325,7 +325,7 @@ CLASS ZCL_ABAPGIT_WHERE_USED_TOOLS IMPLEMENTATION. not_enough_input = 1 no_function_pool = 2 delimiter_wrong_position = 3 - OTHERS = 4. + OTHERS = 4 ##FM_SUBRC_OK. ENDIF. IF lv_area IS NOT INITIAL. diff --git a/src/persist/zcl_abapgit_persist_migrate.clas.abap b/src/persist/zcl_abapgit_persist_migrate.clas.abap index 77ef0989d..c2f0a53ef 100644 --- a/src/persist/zcl_abapgit_persist_migrate.clas.abap +++ b/src/persist/zcl_abapgit_persist_migrate.clas.abap @@ -53,7 +53,7 @@ CLASS zcl_abapgit_persist_migrate IMPLEMENTATION. TRY. lcl_cua_interface=>new( )->put_own_cua( ls_cua ). - CATCH zcx_abapgit_exception. + CATCH zcx_abapgit_exception ##NO_HANDLER. ENDTRY. ENDMETHOD. @@ -70,7 +70,7 @@ CLASS zcl_abapgit_persist_migrate IMPLEMENTATION. TRY. ls_own_cua = lcl_cua_interface=>new( )->get_own_cua( ). - CATCH zcx_abapgit_exception. + CATCH zcx_abapgit_exception ##NO_HANDLER. ENDTRY. IF ls_own_cua IS INITIAL. diff --git a/src/repo/utils/zcl_abapgit_repo_labels.clas.abap b/src/repo/utils/zcl_abapgit_repo_labels.clas.abap index f76a21936..5793913ec 100644 --- a/src/repo/utils/zcl_abapgit_repo_labels.clas.abap +++ b/src/repo/utils/zcl_abapgit_repo_labels.clas.abap @@ -136,7 +136,7 @@ CLASS zcl_abapgit_repo_labels IMPLEMENTATION. TRY. validate_one_label_color( ). APPEND TO lt_normalized. - CATCH zcx_abapgit_exception. + CATCH zcx_abapgit_exception ##NO_HANDLER. ENDTRY. ENDLOOP. @@ -225,7 +225,7 @@ CLASS zcl_abapgit_repo_labels IMPLEMENTATION. ro_map->set( iv_key = -label iv_val = -color ). - CATCH zcx_abapgit_exception. + CATCH zcx_abapgit_exception ##NO_HANDLER. ENDTRY. ENDLOOP. diff --git a/src/zabapgit_forms.prog.abap b/src/zabapgit_forms.prog.abap index 5b1b241af..b966f61f7 100644 --- a/src/zabapgit_forms.prog.abap +++ b/src/zabapgit_forms.prog.abap @@ -81,18 +81,18 @@ CLASS lcl_startup IMPLEMENTATION. " - open a specific repo by package name provided by ADT " These overrule the last shown repo - GET PARAMETER ID zif_abapgit_definitions=>c_spagpa_param_repo_key FIELD lv_repo_key. - GET PARAMETER ID zif_abapgit_definitions=>c_spagpa_param_package FIELD lv_package. + GET PARAMETER ID zif_abapgit_definitions=>c_spagpa_param_repo_key FIELD lv_repo_key ##EXISTS. + GET PARAMETER ID zif_abapgit_definitions=>c_spagpa_param_package FIELD lv_package ##EXISTS. lv_package_adt = get_package_from_adt( ). IF lv_repo_key IS NOT INITIAL. - SET PARAMETER ID zif_abapgit_definitions=>c_spagpa_param_repo_key FIELD ''. + SET PARAMETER ID zif_abapgit_definitions=>c_spagpa_param_repo_key FIELD '' ##EXISTS. zcl_abapgit_persistence_user=>get_instance( )->set_repo_show( lv_repo_key ). ELSEIF lv_package IS NOT INITIAL. - SET PARAMETER ID zif_abapgit_definitions=>c_spagpa_param_package FIELD ''. + SET PARAMETER ID zif_abapgit_definitions=>c_spagpa_param_package FIELD '' ##EXISTS. set_start_repo_from_package( lv_package ). ELSEIF lv_package_adt IS NOT INITIAL. @@ -198,7 +198,7 @@ CLASS lcl_startup IMPLEMENTATION. ENDIF. - CATCH cx_root. + CATCH cx_root ##NO_HANDLER. " Some problems with dynamic ADT access. " Let's ignore it for now and fail silently ENDTRY. diff --git a/src/zabapgit_password_dialog.prog.abap b/src/zabapgit_password_dialog.prog.abap index 85224b8d8..79562e80f 100644 --- a/src/zabapgit_password_dialog.prog.abap +++ b/src/zabapgit_password_dialog.prog.abap @@ -181,7 +181,7 @@ FORM password_popup pv_repo_url TYPE string CHANGING cv_user TYPE string - cv_pass TYPE string. + cv_pass TYPE string ##CALLED. lcl_password_dialog=>popup( EXPORTING