From d840aceefa0f0be6f060f8038d3fc252ed0ba08f Mon Sep 17 00:00:00 2001 From: Marc Bernard <59966492+mbtools@users.noreply.github.com> Date: Tue, 24 Oct 2023 12:26:33 -0400 Subject: [PATCH] Fix "lines between methods" (#6563) --- src/objects/aff/zcl_abapgit_object_eeec.clas.abap | 3 ++- .../ecatt/zcl_abapgit_ecatt_config_downl.clas.abap | 3 +-- src/objects/ecatt/zcl_abapgit_ecatt_data_downl.clas.abap | 3 +-- .../ecatt/zcl_abapgit_ecatt_data_upload.clas.abap | 4 ++++ .../ecatt/zcl_abapgit_ecatt_sp_download.clas.abap | 1 - src/objects/ecatt/zcl_abapgit_ecatt_system_upl.clas.abap | 4 ++-- src/objects/sap/zcl_abapgit_sap_namespace.clas.abap | 3 +-- src/objects/zcl_abapgit_object_pdxx_super.clas.abap | 4 +++- src/objects/zcl_abapgit_objects_factory.clas.abap | 4 ++-- src/objects/zcl_abapgit_objects_injector.clas.abap | 4 ++-- src/persist/zcl_abapgit_persist_factory.clas.abap | 2 ++ src/persist/zcl_abapgit_persist_injector.clas.abap | 2 ++ src/repo/zcl_abapgit_object_filter_tran.clas.abap | 9 ++++++++- src/ui/core/zcl_abapgit_gui_event.clas.abap | 6 +++++- src/ui/popups/zcl_abapgit_popup_branch_list.clas.abap | 6 +++++- src/ui/popups/zcl_abapgit_popup_pull_request.clas.abap | 5 ++++- src/ui/popups/zcl_abapgit_popup_tag_list.clas.abap | 5 ++++- 17 files changed, 48 insertions(+), 20 deletions(-) diff --git a/src/objects/aff/zcl_abapgit_object_eeec.clas.abap b/src/objects/aff/zcl_abapgit_object_eeec.clas.abap index e2d2807d1..ed603d0da 100644 --- a/src/objects/aff/zcl_abapgit_object_eeec.clas.abap +++ b/src/objects/aff/zcl_abapgit_object_eeec.clas.abap @@ -16,6 +16,7 @@ ENDCLASS. CLASS zcl_abapgit_object_eeec IMPLEMENTATION. + METHOD zif_abapgit_object~changed_by. DATA: lr_data TYPE REF TO data, @@ -60,6 +61,7 @@ CLASS zcl_abapgit_object_eeec IMPLEMENTATION. ENDMETHOD. + METHOD get_object_handler. DATA lx_error TYPE REF TO cx_root. @@ -76,5 +78,4 @@ CLASS zcl_abapgit_object_eeec IMPLEMENTATION. ENDIF. ENDMETHOD. - ENDCLASS. diff --git a/src/objects/ecatt/zcl_abapgit_ecatt_config_downl.clas.abap b/src/objects/ecatt/zcl_abapgit_ecatt_config_downl.clas.abap index e9f99bfb6..063d84a1d 100644 --- a/src/objects/ecatt/zcl_abapgit_ecatt_config_downl.clas.abap +++ b/src/objects/ecatt/zcl_abapgit_ecatt_config_downl.clas.abap @@ -22,7 +22,7 @@ ENDCLASS. -CLASS zcl_abapgit_ecatt_config_downl IMPLEMENTATION. +CLASS ZCL_ABAPGIT_ECATT_CONFIG_DOWNL IMPLEMENTATION. METHOD download. @@ -88,5 +88,4 @@ CLASS zcl_abapgit_ecatt_config_downl IMPLEMENTATION. rv_xml_stream = mv_xml_stream. ENDMETHOD. - ENDCLASS. diff --git a/src/objects/ecatt/zcl_abapgit_ecatt_data_downl.clas.abap b/src/objects/ecatt/zcl_abapgit_ecatt_data_downl.clas.abap index 63ea44c54..c489dca42 100644 --- a/src/objects/ecatt/zcl_abapgit_ecatt_data_downl.clas.abap +++ b/src/objects/ecatt/zcl_abapgit_ecatt_data_downl.clas.abap @@ -23,7 +23,7 @@ ENDCLASS. -CLASS zcl_abapgit_ecatt_data_downl IMPLEMENTATION. +CLASS ZCL_ABAPGIT_ECATT_DATA_DOWNL IMPLEMENTATION. METHOD download. @@ -88,5 +88,4 @@ CLASS zcl_abapgit_ecatt_data_downl IMPLEMENTATION. rv_xml_stream = mv_xml_stream. ENDMETHOD. - ENDCLASS. diff --git a/src/objects/ecatt/zcl_abapgit_ecatt_data_upload.clas.abap b/src/objects/ecatt/zcl_abapgit_ecatt_data_upload.clas.abap index 4579cdc5d..3dddb7bfe 100644 --- a/src/objects/ecatt/zcl_abapgit_ecatt_data_upload.clas.abap +++ b/src/objects/ecatt/zcl_abapgit_ecatt_data_upload.clas.abap @@ -28,6 +28,8 @@ ENDCLASS. CLASS zcl_abapgit_ecatt_data_upload IMPLEMENTATION. + + METHOD upload. SET HANDLER on_ev_object_saved FOR ALL INSTANCES. @@ -47,6 +49,7 @@ CLASS zcl_abapgit_ecatt_data_upload IMPLEMENTATION. ENDIF. ENDMETHOD. + METHOD upload_data_from_stream. " Downport @@ -62,6 +65,7 @@ CLASS zcl_abapgit_ecatt_data_upload IMPLEMENTATION. ENDMETHOD. + METHOD on_ev_object_saved. DATA lo_ecatt_td TYPE REF TO cl_apl_ecatt_test_data. diff --git a/src/objects/ecatt/zcl_abapgit_ecatt_sp_download.clas.abap b/src/objects/ecatt/zcl_abapgit_ecatt_sp_download.clas.abap index b4660f569..03b6a0eeb 100644 --- a/src/objects/ecatt/zcl_abapgit_ecatt_sp_download.clas.abap +++ b/src/objects/ecatt/zcl_abapgit_ecatt_sp_download.clas.abap @@ -113,5 +113,4 @@ CLASS ZCL_ABAPGIT_ECATT_SP_DOWNLOAD IMPLEMENTATION. rv_xml_stream = mv_xml_stream. ENDMETHOD. - ENDCLASS. diff --git a/src/objects/ecatt/zcl_abapgit_ecatt_system_upl.clas.abap b/src/objects/ecatt/zcl_abapgit_ecatt_system_upl.clas.abap index 3515cca8a..403fe323f 100644 --- a/src/objects/ecatt/zcl_abapgit_ecatt_system_upl.clas.abap +++ b/src/objects/ecatt/zcl_abapgit_ecatt_system_upl.clas.abap @@ -19,7 +19,8 @@ ENDCLASS. -CLASS zcl_abapgit_ecatt_system_upl IMPLEMENTATION. +CLASS ZCL_ABAPGIT_ECATT_SYSTEM_UPL IMPLEMENTATION. + METHOD upload_data_from_stream. @@ -35,5 +36,4 @@ CLASS zcl_abapgit_ecatt_system_upl IMPLEMENTATION. mv_external_xml = iv_xml. ENDMETHOD. - ENDCLASS. diff --git a/src/objects/sap/zcl_abapgit_sap_namespace.clas.abap b/src/objects/sap/zcl_abapgit_sap_namespace.clas.abap index ffb81f3a9..d4fae0493 100644 --- a/src/objects/sap/zcl_abapgit_sap_namespace.clas.abap +++ b/src/objects/sap/zcl_abapgit_sap_namespace.clas.abap @@ -11,7 +11,7 @@ ENDCLASS. -CLASS zcl_abapgit_sap_namespace IMPLEMENTATION. +CLASS ZCL_ABAPGIT_SAP_NAMESPACE IMPLEMENTATION. METHOD zif_abapgit_sap_namespace~exists. @@ -90,5 +90,4 @@ CLASS zcl_abapgit_sap_namespace IMPLEMENTATION. |Object without namespace { rs_obj_namespace-obj_without_namespace } contains a '/'| ). ENDIF. ENDMETHOD. - ENDCLASS. diff --git a/src/objects/zcl_abapgit_object_pdxx_super.clas.abap b/src/objects/zcl_abapgit_object_pdxx_super.clas.abap index b934948a6..c80112c82 100644 --- a/src/objects/zcl_abapgit_object_pdxx_super.clas.abap +++ b/src/objects/zcl_abapgit_object_pdxx_super.clas.abap @@ -20,8 +20,10 @@ CLASS zcl_abapgit_object_pdxx_super DEFINITION ENDCLASS. + CLASS zcl_abapgit_object_pdxx_super IMPLEMENTATION. + METHOD check_subrc_for. IF sy-subrc <> 0. zcx_abapgit_exception=>raise( iv_call && ' returned ' && sy-subrc ). @@ -49,6 +51,7 @@ CLASS zcl_abapgit_object_pdxx_super IMPLEMENTATION. ENDMETHOD. + METHOD zif_abapgit_object~changed_by. SELECT SINGLE uname @@ -147,5 +150,4 @@ CLASS zcl_abapgit_object_pdxx_super IMPLEMENTATION. ms_objkey-objid = ms_item-obj_name. ENDMETHOD. - ENDCLASS. diff --git a/src/objects/zcl_abapgit_objects_factory.clas.abap b/src/objects/zcl_abapgit_objects_factory.clas.abap index 314085526..11a781863 100644 --- a/src/objects/zcl_abapgit_objects_factory.clas.abap +++ b/src/objects/zcl_abapgit_objects_factory.clas.abap @@ -15,7 +15,8 @@ ENDCLASS. -CLASS zcl_abapgit_objects_factory IMPLEMENTATION. +CLASS ZCL_ABAPGIT_OBJECTS_FACTORY IMPLEMENTATION. + METHOD get_gui_jumper. @@ -26,5 +27,4 @@ CLASS zcl_abapgit_objects_factory IMPLEMENTATION. ri_gui_jumper = gi_gui_jumper. ENDMETHOD. - ENDCLASS. diff --git a/src/objects/zcl_abapgit_objects_injector.clas.abap b/src/objects/zcl_abapgit_objects_injector.clas.abap index 62c0383ff..6fc9132a4 100644 --- a/src/objects/zcl_abapgit_objects_injector.clas.abap +++ b/src/objects/zcl_abapgit_objects_injector.clas.abap @@ -13,12 +13,12 @@ ENDCLASS. -CLASS zcl_abapgit_objects_injector IMPLEMENTATION. +CLASS ZCL_ABAPGIT_OBJECTS_INJECTOR IMPLEMENTATION. + METHOD set_gui_jumper. zcl_abapgit_objects_factory=>gi_gui_jumper = ii_gui_jumper. ENDMETHOD. - ENDCLASS. diff --git a/src/persist/zcl_abapgit_persist_factory.clas.abap b/src/persist/zcl_abapgit_persist_factory.clas.abap index d00148e1c..64d82b806 100644 --- a/src/persist/zcl_abapgit_persist_factory.clas.abap +++ b/src/persist/zcl_abapgit_persist_factory.clas.abap @@ -37,6 +37,7 @@ CLASS ZCL_ABAPGIT_PERSIST_FACTORY IMPLEMENTATION. ENDMETHOD. + METHOD get_repo_cs. IF gi_repo_cs IS INITIAL. @@ -47,6 +48,7 @@ CLASS ZCL_ABAPGIT_PERSIST_FACTORY IMPLEMENTATION. ENDMETHOD. + METHOD get_settings. IF gi_settings IS INITIAL. diff --git a/src/persist/zcl_abapgit_persist_injector.clas.abap b/src/persist/zcl_abapgit_persist_injector.clas.abap index 30161cc12..f1729ea9e 100644 --- a/src/persist/zcl_abapgit_persist_injector.clas.abap +++ b/src/persist/zcl_abapgit_persist_injector.clas.abap @@ -34,12 +34,14 @@ CLASS ZCL_ABAPGIT_PERSIST_INJECTOR IMPLEMENTATION. ENDMETHOD. + METHOD set_repo_cs. zcl_abapgit_persist_factory=>gi_repo_cs = ii_repo_cs. ENDMETHOD. + METHOD set_settings. zcl_abapgit_persist_factory=>gi_settings = ii_settings. diff --git a/src/repo/zcl_abapgit_object_filter_tran.clas.abap b/src/repo/zcl_abapgit_object_filter_tran.clas.abap index a0d65f2d9..2e9ce26a2 100644 --- a/src/repo/zcl_abapgit_object_filter_tran.clas.abap +++ b/src/repo/zcl_abapgit_object_filter_tran.clas.abap @@ -58,6 +58,8 @@ CLASS zcl_abapgit_object_filter_tran DEFINITION VALUE(rt_filter) TYPE zif_abapgit_definitions=>ty_tadir_tt. ENDCLASS. + + CLASS zcl_abapgit_object_filter_tran IMPLEMENTATION. @@ -78,21 +80,25 @@ CLASS zcl_abapgit_object_filter_tran IMPLEMENTATION. it_e071_filter = lt_e071_filter ). ENDMETHOD. + METHOD get_filter_values. et_r_trkorr = mt_r_trkorr. ev_package = mv_package. ENDMETHOD. + METHOD zif_abapgit_object_filter~get_filter. rt_filter = mt_filter. ENDMETHOD. + METHOD init. CLEAR mt_filter. CLEAR mt_r_trkorr. CLEAR mv_package. ENDMETHOD. + METHOD set_filter_values. init( ). mt_r_trkorr = it_r_trkorr. @@ -105,6 +111,7 @@ CLASS zcl_abapgit_object_filter_tran IMPLEMENTATION. ENDIF. ENDMETHOD. + METHOD adjust_local_filter. DATA lt_e071_filter TYPE ty_e071_filter_tt. @@ -170,6 +177,7 @@ CLASS zcl_abapgit_object_filter_tran IMPLEMENTATION. ENDMETHOD. + METHOD get_all_sub_packages. DATA li_package TYPE REF TO zif_abapgit_sap_package. @@ -187,5 +195,4 @@ CLASS zcl_abapgit_object_filter_tran IMPLEMENTATION. ENDLOOP. ENDMETHOD. - ENDCLASS. diff --git a/src/ui/core/zcl_abapgit_gui_event.clas.abap b/src/ui/core/zcl_abapgit_gui_event.clas.abap index 791496761..d174b0836 100644 --- a/src/ui/core/zcl_abapgit_gui_event.clas.abap +++ b/src/ui/core/zcl_abapgit_gui_event.clas.abap @@ -137,6 +137,7 @@ CLASS zcl_abapgit_gui_event IMPLEMENTATION. ENDMETHOD. + METHOD parse_fields_upper_case_name. rt_fields = parse_fields( @@ -159,6 +160,7 @@ CLASS zcl_abapgit_gui_event IMPLEMENTATION. ENDMETHOD. + METHOD parse_fields. DATA: @@ -224,6 +226,7 @@ CLASS zcl_abapgit_gui_event IMPLEMENTATION. ENDMETHOD. + METHOD field_keys_to_upper. FIELD-SYMBOLS LIKE LINE OF ct_fields. @@ -234,6 +237,7 @@ CLASS zcl_abapgit_gui_event IMPLEMENTATION. ENDMETHOD. + METHOD unescape. * do not use cl_http_utility as it does strange things with the encoding @@ -250,6 +254,7 @@ CLASS zcl_abapgit_gui_event IMPLEMENTATION. ENDMETHOD. + METHOD class_constructor. CONSTANTS lc_nbsp TYPE xstring VALUE 'C2A0'. "   @@ -261,5 +266,4 @@ CLASS zcl_abapgit_gui_event IMPLEMENTATION. ENDTRY. ENDMETHOD. - ENDCLASS. diff --git a/src/ui/popups/zcl_abapgit_popup_branch_list.clas.abap b/src/ui/popups/zcl_abapgit_popup_branch_list.clas.abap index e7a40f2a6..4eef26a1a 100644 --- a/src/ui/popups/zcl_abapgit_popup_branch_list.clas.abap +++ b/src/ui/popups/zcl_abapgit_popup_branch_list.clas.abap @@ -40,6 +40,7 @@ ENDCLASS. CLASS zcl_abapgit_popup_branch_list IMPLEMENTATION. + METHOD create. CREATE OBJECT ri_popup TYPE zcl_abapgit_popup_branch_list EXPORTING @@ -48,12 +49,14 @@ CLASS zcl_abapgit_popup_branch_list IMPLEMENTATION. iv_show_new_option = iv_show_new_option. ENDMETHOD. + METHOD constructor. mv_repo_url = iv_url. mv_default_branch = zif_abapgit_git_definitions=>c_git_branch-heads_prefix && iv_default_branch. mv_show_new_option = iv_show_new_option. ENDMETHOD. + METHOD zif_abapgit_html_popup~create_picklist. CREATE OBJECT ro_picklist @@ -64,6 +67,7 @@ CLASS zcl_abapgit_popup_branch_list IMPLEMENTATION. ENDMETHOD. + METHOD fetch_branch_list. DATA lo_branches TYPE REF TO zcl_abapgit_git_branch_list. @@ -98,6 +102,7 @@ CLASS zcl_abapgit_popup_branch_list IMPLEMENTATION. ENDMETHOD. + METHOD zif_abapgit_gui_render_item~render. DATA lv_head_marker TYPE string. @@ -115,5 +120,4 @@ CLASS zcl_abapgit_popup_branch_list IMPLEMENTATION. ri_html = zcl_abapgit_html=>create( |{ -display_name }{ lv_head_marker }| ). ENDMETHOD. - ENDCLASS. diff --git a/src/ui/popups/zcl_abapgit_popup_pull_request.clas.abap b/src/ui/popups/zcl_abapgit_popup_pull_request.clas.abap index 7610be25a..05cf2a7a4 100644 --- a/src/ui/popups/zcl_abapgit_popup_pull_request.clas.abap +++ b/src/ui/popups/zcl_abapgit_popup_pull_request.clas.abap @@ -33,6 +33,7 @@ ENDCLASS. CLASS zcl_abapgit_popup_pull_request IMPLEMENTATION. + METHOD create. CREATE OBJECT ri_popup TYPE zcl_abapgit_popup_pull_request @@ -41,10 +42,12 @@ CLASS zcl_abapgit_popup_pull_request IMPLEMENTATION. ENDMETHOD. + METHOD constructor. mv_repo_url = iv_url. ENDMETHOD. + METHOD zif_abapgit_html_popup~create_picklist. CREATE OBJECT ro_picklist @@ -55,6 +58,7 @@ CLASS zcl_abapgit_popup_pull_request IMPLEMENTATION. ENDMETHOD. + METHOD fetch_pull_request_list. rt_pulls = zcl_abapgit_pr_enumerator=>new( mv_repo_url )->get_pulls( ). @@ -76,5 +80,4 @@ CLASS zcl_abapgit_popup_pull_request IMPLEMENTATION. ri_html = zcl_abapgit_html=>create( |{ -number } - { -title } @{ -user }| ). ENDMETHOD. - ENDCLASS. diff --git a/src/ui/popups/zcl_abapgit_popup_tag_list.clas.abap b/src/ui/popups/zcl_abapgit_popup_tag_list.clas.abap index e9ab6c904..285a8d730 100644 --- a/src/ui/popups/zcl_abapgit_popup_tag_list.clas.abap +++ b/src/ui/popups/zcl_abapgit_popup_tag_list.clas.abap @@ -33,16 +33,19 @@ ENDCLASS. CLASS zcl_abapgit_popup_tag_list IMPLEMENTATION. + METHOD create. CREATE OBJECT ri_popup TYPE zcl_abapgit_popup_tag_list EXPORTING iv_url = iv_url. ENDMETHOD. + METHOD constructor. mv_repo_url = iv_url. ENDMETHOD. + METHOD zif_abapgit_html_popup~create_picklist. CREATE OBJECT ro_picklist @@ -53,6 +56,7 @@ CLASS zcl_abapgit_popup_tag_list IMPLEMENTATION. ENDMETHOD. + METHOD fetch_tag_list. DATA lo_branches TYPE REF TO zcl_abapgit_git_branch_list. @@ -81,5 +85,4 @@ CLASS zcl_abapgit_popup_tag_list IMPLEMENTATION. ri_html = zcl_abapgit_html=>create( |{ -display_name }| ). ENDMETHOD. - ENDCLASS.