Fix "lines between methods" (#6563)

This commit is contained in:
Marc Bernard 2023-10-24 12:26:33 -04:00 committed by GitHub
parent 376b10e6f3
commit d840aceefa
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
17 changed files with 48 additions and 20 deletions

View File

@ -16,6 +16,7 @@ ENDCLASS.
CLASS zcl_abapgit_object_eeec IMPLEMENTATION. CLASS zcl_abapgit_object_eeec IMPLEMENTATION.
METHOD zif_abapgit_object~changed_by. METHOD zif_abapgit_object~changed_by.
DATA: lr_data TYPE REF TO data, DATA: lr_data TYPE REF TO data,
@ -60,6 +61,7 @@ CLASS zcl_abapgit_object_eeec IMPLEMENTATION.
ENDMETHOD. ENDMETHOD.
METHOD get_object_handler. METHOD get_object_handler.
DATA lx_error TYPE REF TO cx_root. DATA lx_error TYPE REF TO cx_root.
@ -76,5 +78,4 @@ CLASS zcl_abapgit_object_eeec IMPLEMENTATION.
ENDIF. ENDIF.
ENDMETHOD. ENDMETHOD.
ENDCLASS. ENDCLASS.

View File

@ -22,7 +22,7 @@ ENDCLASS.
CLASS zcl_abapgit_ecatt_config_downl IMPLEMENTATION. CLASS ZCL_ABAPGIT_ECATT_CONFIG_DOWNL IMPLEMENTATION.
METHOD download. METHOD download.
@ -88,5 +88,4 @@ CLASS zcl_abapgit_ecatt_config_downl IMPLEMENTATION.
rv_xml_stream = mv_xml_stream. rv_xml_stream = mv_xml_stream.
ENDMETHOD. ENDMETHOD.
ENDCLASS. ENDCLASS.

View File

@ -23,7 +23,7 @@ ENDCLASS.
CLASS zcl_abapgit_ecatt_data_downl IMPLEMENTATION. CLASS ZCL_ABAPGIT_ECATT_DATA_DOWNL IMPLEMENTATION.
METHOD download. METHOD download.
@ -88,5 +88,4 @@ CLASS zcl_abapgit_ecatt_data_downl IMPLEMENTATION.
rv_xml_stream = mv_xml_stream. rv_xml_stream = mv_xml_stream.
ENDMETHOD. ENDMETHOD.
ENDCLASS. ENDCLASS.

View File

@ -28,6 +28,8 @@ ENDCLASS.
CLASS zcl_abapgit_ecatt_data_upload IMPLEMENTATION. CLASS zcl_abapgit_ecatt_data_upload IMPLEMENTATION.
METHOD upload. METHOD upload.
SET HANDLER on_ev_object_saved FOR ALL INSTANCES. SET HANDLER on_ev_object_saved FOR ALL INSTANCES.
@ -47,6 +49,7 @@ CLASS zcl_abapgit_ecatt_data_upload IMPLEMENTATION.
ENDIF. ENDIF.
ENDMETHOD. ENDMETHOD.
METHOD upload_data_from_stream. METHOD upload_data_from_stream.
" Downport " Downport
@ -62,6 +65,7 @@ CLASS zcl_abapgit_ecatt_data_upload IMPLEMENTATION.
ENDMETHOD. ENDMETHOD.
METHOD on_ev_object_saved. METHOD on_ev_object_saved.
DATA lo_ecatt_td TYPE REF TO cl_apl_ecatt_test_data. DATA lo_ecatt_td TYPE REF TO cl_apl_ecatt_test_data.

View File

@ -113,5 +113,4 @@ CLASS ZCL_ABAPGIT_ECATT_SP_DOWNLOAD IMPLEMENTATION.
rv_xml_stream = mv_xml_stream. rv_xml_stream = mv_xml_stream.
ENDMETHOD. ENDMETHOD.
ENDCLASS. ENDCLASS.

View File

@ -19,7 +19,8 @@ ENDCLASS.
CLASS zcl_abapgit_ecatt_system_upl IMPLEMENTATION. CLASS ZCL_ABAPGIT_ECATT_SYSTEM_UPL IMPLEMENTATION.
METHOD upload_data_from_stream. METHOD upload_data_from_stream.
@ -35,5 +36,4 @@ CLASS zcl_abapgit_ecatt_system_upl IMPLEMENTATION.
mv_external_xml = iv_xml. mv_external_xml = iv_xml.
ENDMETHOD. ENDMETHOD.
ENDCLASS. ENDCLASS.

View File

@ -11,7 +11,7 @@ ENDCLASS.
CLASS zcl_abapgit_sap_namespace IMPLEMENTATION. CLASS ZCL_ABAPGIT_SAP_NAMESPACE IMPLEMENTATION.
METHOD zif_abapgit_sap_namespace~exists. METHOD zif_abapgit_sap_namespace~exists.
@ -90,5 +90,4 @@ CLASS zcl_abapgit_sap_namespace IMPLEMENTATION.
|Object without namespace { rs_obj_namespace-obj_without_namespace } contains a '/'| ). |Object without namespace { rs_obj_namespace-obj_without_namespace } contains a '/'| ).
ENDIF. ENDIF.
ENDMETHOD. ENDMETHOD.
ENDCLASS. ENDCLASS.

View File

@ -20,8 +20,10 @@ CLASS zcl_abapgit_object_pdxx_super DEFINITION
ENDCLASS. ENDCLASS.
CLASS zcl_abapgit_object_pdxx_super IMPLEMENTATION. CLASS zcl_abapgit_object_pdxx_super IMPLEMENTATION.
METHOD check_subrc_for. METHOD check_subrc_for.
IF sy-subrc <> 0. IF sy-subrc <> 0.
zcx_abapgit_exception=>raise( iv_call && ' returned ' && sy-subrc ). zcx_abapgit_exception=>raise( iv_call && ' returned ' && sy-subrc ).
@ -49,6 +51,7 @@ CLASS zcl_abapgit_object_pdxx_super IMPLEMENTATION.
ENDMETHOD. ENDMETHOD.
METHOD zif_abapgit_object~changed_by. METHOD zif_abapgit_object~changed_by.
SELECT SINGLE uname SELECT SINGLE uname
@ -147,5 +150,4 @@ CLASS zcl_abapgit_object_pdxx_super IMPLEMENTATION.
ms_objkey-objid = ms_item-obj_name. ms_objkey-objid = ms_item-obj_name.
ENDMETHOD. ENDMETHOD.
ENDCLASS. ENDCLASS.

View File

@ -15,7 +15,8 @@ ENDCLASS.
CLASS zcl_abapgit_objects_factory IMPLEMENTATION. CLASS ZCL_ABAPGIT_OBJECTS_FACTORY IMPLEMENTATION.
METHOD get_gui_jumper. METHOD get_gui_jumper.
@ -26,5 +27,4 @@ CLASS zcl_abapgit_objects_factory IMPLEMENTATION.
ri_gui_jumper = gi_gui_jumper. ri_gui_jumper = gi_gui_jumper.
ENDMETHOD. ENDMETHOD.
ENDCLASS. ENDCLASS.

View File

@ -13,12 +13,12 @@ ENDCLASS.
CLASS zcl_abapgit_objects_injector IMPLEMENTATION. CLASS ZCL_ABAPGIT_OBJECTS_INJECTOR IMPLEMENTATION.
METHOD set_gui_jumper. METHOD set_gui_jumper.
zcl_abapgit_objects_factory=>gi_gui_jumper = ii_gui_jumper. zcl_abapgit_objects_factory=>gi_gui_jumper = ii_gui_jumper.
ENDMETHOD. ENDMETHOD.
ENDCLASS. ENDCLASS.

View File

@ -37,6 +37,7 @@ CLASS ZCL_ABAPGIT_PERSIST_FACTORY IMPLEMENTATION.
ENDMETHOD. ENDMETHOD.
METHOD get_repo_cs. METHOD get_repo_cs.
IF gi_repo_cs IS INITIAL. IF gi_repo_cs IS INITIAL.
@ -47,6 +48,7 @@ CLASS ZCL_ABAPGIT_PERSIST_FACTORY IMPLEMENTATION.
ENDMETHOD. ENDMETHOD.
METHOD get_settings. METHOD get_settings.
IF gi_settings IS INITIAL. IF gi_settings IS INITIAL.

View File

@ -34,12 +34,14 @@ CLASS ZCL_ABAPGIT_PERSIST_INJECTOR IMPLEMENTATION.
ENDMETHOD. ENDMETHOD.
METHOD set_repo_cs. METHOD set_repo_cs.
zcl_abapgit_persist_factory=>gi_repo_cs = ii_repo_cs. zcl_abapgit_persist_factory=>gi_repo_cs = ii_repo_cs.
ENDMETHOD. ENDMETHOD.
METHOD set_settings. METHOD set_settings.
zcl_abapgit_persist_factory=>gi_settings = ii_settings. zcl_abapgit_persist_factory=>gi_settings = ii_settings.

View File

@ -58,6 +58,8 @@ CLASS zcl_abapgit_object_filter_tran DEFINITION
VALUE(rt_filter) TYPE zif_abapgit_definitions=>ty_tadir_tt. VALUE(rt_filter) TYPE zif_abapgit_definitions=>ty_tadir_tt.
ENDCLASS. ENDCLASS.
CLASS zcl_abapgit_object_filter_tran IMPLEMENTATION. CLASS zcl_abapgit_object_filter_tran IMPLEMENTATION.
@ -78,21 +80,25 @@ CLASS zcl_abapgit_object_filter_tran IMPLEMENTATION.
it_e071_filter = lt_e071_filter ). it_e071_filter = lt_e071_filter ).
ENDMETHOD. ENDMETHOD.
METHOD get_filter_values. METHOD get_filter_values.
et_r_trkorr = mt_r_trkorr. et_r_trkorr = mt_r_trkorr.
ev_package = mv_package. ev_package = mv_package.
ENDMETHOD. ENDMETHOD.
METHOD zif_abapgit_object_filter~get_filter. METHOD zif_abapgit_object_filter~get_filter.
rt_filter = mt_filter. rt_filter = mt_filter.
ENDMETHOD. ENDMETHOD.
METHOD init. METHOD init.
CLEAR mt_filter. CLEAR mt_filter.
CLEAR mt_r_trkorr. CLEAR mt_r_trkorr.
CLEAR mv_package. CLEAR mv_package.
ENDMETHOD. ENDMETHOD.
METHOD set_filter_values. METHOD set_filter_values.
init( ). init( ).
mt_r_trkorr = it_r_trkorr. mt_r_trkorr = it_r_trkorr.
@ -105,6 +111,7 @@ CLASS zcl_abapgit_object_filter_tran IMPLEMENTATION.
ENDIF. ENDIF.
ENDMETHOD. ENDMETHOD.
METHOD adjust_local_filter. METHOD adjust_local_filter.
DATA lt_e071_filter TYPE ty_e071_filter_tt. DATA lt_e071_filter TYPE ty_e071_filter_tt.
@ -170,6 +177,7 @@ CLASS zcl_abapgit_object_filter_tran IMPLEMENTATION.
ENDMETHOD. ENDMETHOD.
METHOD get_all_sub_packages. METHOD get_all_sub_packages.
DATA li_package TYPE REF TO zif_abapgit_sap_package. DATA li_package TYPE REF TO zif_abapgit_sap_package.
@ -187,5 +195,4 @@ CLASS zcl_abapgit_object_filter_tran IMPLEMENTATION.
ENDLOOP. ENDLOOP.
ENDMETHOD. ENDMETHOD.
ENDCLASS. ENDCLASS.

View File

@ -137,6 +137,7 @@ CLASS zcl_abapgit_gui_event IMPLEMENTATION.
ENDMETHOD. ENDMETHOD.
METHOD parse_fields_upper_case_name. METHOD parse_fields_upper_case_name.
rt_fields = parse_fields( rt_fields = parse_fields(
@ -159,6 +160,7 @@ CLASS zcl_abapgit_gui_event IMPLEMENTATION.
ENDMETHOD. ENDMETHOD.
METHOD parse_fields. METHOD parse_fields.
DATA: DATA:
@ -224,6 +226,7 @@ CLASS zcl_abapgit_gui_event IMPLEMENTATION.
ENDMETHOD. ENDMETHOD.
METHOD field_keys_to_upper. METHOD field_keys_to_upper.
FIELD-SYMBOLS <ls_field> LIKE LINE OF ct_fields. FIELD-SYMBOLS <ls_field> LIKE LINE OF ct_fields.
@ -234,6 +237,7 @@ CLASS zcl_abapgit_gui_event IMPLEMENTATION.
ENDMETHOD. ENDMETHOD.
METHOD unescape. METHOD unescape.
* do not use cl_http_utility as it does strange things with the encoding * do not use cl_http_utility as it does strange things with the encoding
@ -250,6 +254,7 @@ CLASS zcl_abapgit_gui_event IMPLEMENTATION.
ENDMETHOD. ENDMETHOD.
METHOD class_constructor. METHOD class_constructor.
CONSTANTS lc_nbsp TYPE xstring VALUE 'C2A0'. " &nbsp; CONSTANTS lc_nbsp TYPE xstring VALUE 'C2A0'. " &nbsp;
@ -261,5 +266,4 @@ CLASS zcl_abapgit_gui_event IMPLEMENTATION.
ENDTRY. ENDTRY.
ENDMETHOD. ENDMETHOD.
ENDCLASS. ENDCLASS.

View File

@ -40,6 +40,7 @@ ENDCLASS.
CLASS zcl_abapgit_popup_branch_list IMPLEMENTATION. CLASS zcl_abapgit_popup_branch_list IMPLEMENTATION.
METHOD create. METHOD create.
CREATE OBJECT ri_popup TYPE zcl_abapgit_popup_branch_list CREATE OBJECT ri_popup TYPE zcl_abapgit_popup_branch_list
EXPORTING EXPORTING
@ -48,12 +49,14 @@ CLASS zcl_abapgit_popup_branch_list IMPLEMENTATION.
iv_show_new_option = iv_show_new_option. iv_show_new_option = iv_show_new_option.
ENDMETHOD. ENDMETHOD.
METHOD constructor. METHOD constructor.
mv_repo_url = iv_url. mv_repo_url = iv_url.
mv_default_branch = zif_abapgit_git_definitions=>c_git_branch-heads_prefix && iv_default_branch. mv_default_branch = zif_abapgit_git_definitions=>c_git_branch-heads_prefix && iv_default_branch.
mv_show_new_option = iv_show_new_option. mv_show_new_option = iv_show_new_option.
ENDMETHOD. ENDMETHOD.
METHOD zif_abapgit_html_popup~create_picklist. METHOD zif_abapgit_html_popup~create_picklist.
CREATE OBJECT ro_picklist CREATE OBJECT ro_picklist
@ -64,6 +67,7 @@ CLASS zcl_abapgit_popup_branch_list IMPLEMENTATION.
ENDMETHOD. ENDMETHOD.
METHOD fetch_branch_list. METHOD fetch_branch_list.
DATA lo_branches TYPE REF TO zcl_abapgit_git_branch_list. DATA lo_branches TYPE REF TO zcl_abapgit_git_branch_list.
@ -98,6 +102,7 @@ CLASS zcl_abapgit_popup_branch_list IMPLEMENTATION.
ENDMETHOD. ENDMETHOD.
METHOD zif_abapgit_gui_render_item~render. METHOD zif_abapgit_gui_render_item~render.
DATA lv_head_marker TYPE string. DATA lv_head_marker TYPE string.
@ -115,5 +120,4 @@ CLASS zcl_abapgit_popup_branch_list IMPLEMENTATION.
ri_html = zcl_abapgit_html=>create( |{ <ls_b>-display_name }{ lv_head_marker }| ). ri_html = zcl_abapgit_html=>create( |{ <ls_b>-display_name }{ lv_head_marker }| ).
ENDMETHOD. ENDMETHOD.
ENDCLASS. ENDCLASS.

View File

@ -33,6 +33,7 @@ ENDCLASS.
CLASS zcl_abapgit_popup_pull_request IMPLEMENTATION. CLASS zcl_abapgit_popup_pull_request IMPLEMENTATION.
METHOD create. METHOD create.
CREATE OBJECT ri_popup TYPE zcl_abapgit_popup_pull_request CREATE OBJECT ri_popup TYPE zcl_abapgit_popup_pull_request
@ -41,10 +42,12 @@ CLASS zcl_abapgit_popup_pull_request IMPLEMENTATION.
ENDMETHOD. ENDMETHOD.
METHOD constructor. METHOD constructor.
mv_repo_url = iv_url. mv_repo_url = iv_url.
ENDMETHOD. ENDMETHOD.
METHOD zif_abapgit_html_popup~create_picklist. METHOD zif_abapgit_html_popup~create_picklist.
CREATE OBJECT ro_picklist CREATE OBJECT ro_picklist
@ -55,6 +58,7 @@ CLASS zcl_abapgit_popup_pull_request IMPLEMENTATION.
ENDMETHOD. ENDMETHOD.
METHOD fetch_pull_request_list. METHOD fetch_pull_request_list.
rt_pulls = zcl_abapgit_pr_enumerator=>new( mv_repo_url )->get_pulls( ). rt_pulls = zcl_abapgit_pr_enumerator=>new( mv_repo_url )->get_pulls( ).
@ -76,5 +80,4 @@ CLASS zcl_abapgit_popup_pull_request IMPLEMENTATION.
ri_html = zcl_abapgit_html=>create( |<b>{ <ls_pr>-number }</b> - { <ls_pr>-title } @{ <ls_pr>-user }| ). ri_html = zcl_abapgit_html=>create( |<b>{ <ls_pr>-number }</b> - { <ls_pr>-title } @{ <ls_pr>-user }| ).
ENDMETHOD. ENDMETHOD.
ENDCLASS. ENDCLASS.

View File

@ -33,16 +33,19 @@ ENDCLASS.
CLASS zcl_abapgit_popup_tag_list IMPLEMENTATION. CLASS zcl_abapgit_popup_tag_list IMPLEMENTATION.
METHOD create. METHOD create.
CREATE OBJECT ri_popup TYPE zcl_abapgit_popup_tag_list CREATE OBJECT ri_popup TYPE zcl_abapgit_popup_tag_list
EXPORTING EXPORTING
iv_url = iv_url. iv_url = iv_url.
ENDMETHOD. ENDMETHOD.
METHOD constructor. METHOD constructor.
mv_repo_url = iv_url. mv_repo_url = iv_url.
ENDMETHOD. ENDMETHOD.
METHOD zif_abapgit_html_popup~create_picklist. METHOD zif_abapgit_html_popup~create_picklist.
CREATE OBJECT ro_picklist CREATE OBJECT ro_picklist
@ -53,6 +56,7 @@ CLASS zcl_abapgit_popup_tag_list IMPLEMENTATION.
ENDMETHOD. ENDMETHOD.
METHOD fetch_tag_list. METHOD fetch_tag_list.
DATA lo_branches TYPE REF TO zcl_abapgit_git_branch_list. DATA lo_branches TYPE REF TO zcl_abapgit_git_branch_list.
@ -81,5 +85,4 @@ CLASS zcl_abapgit_popup_tag_list IMPLEMENTATION.
ri_html = zcl_abapgit_html=>create( |{ <ls_tag>-display_name }| ). ri_html = zcl_abapgit_html=>create( |{ <ls_tag>-display_name }| ).
ENDMETHOD. ENDMETHOD.
ENDCLASS. ENDCLASS.