SAP/abapGit
1
0
Fork 0
mirror of https://github.com/abapGit/abapGit.git synced 2025-05-01 12:20:51 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

syntax check page, show variant used (#3790)

Browse Source 
* syntax check page, show variant used

closes #3660

* unify variant rendering
This commit is contained in:
Lars Hvam 2020-08-25 07:05:32 +02:00 committed by GitHub
parent 408485dfce
commit dcc655eccf
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 23 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/ui/zcl_abapgit_gui_page_code_insp.clas.abap
View File

@ -186,8 +186,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_CODE_INSP IMPLEMENTATION.
gui_services( )->get_hotkeys_ctl( )->register_hotkeys( me ).
ri_html->add( '<div class="ci-head">' ).
ri_html->add( |Code inspector check variant: <span class="ci-variant">{ mv_check_variant }</span>| ).
ri_html->add( render_variant( mv_check_variant ) ).
IF lines( mt_result ) = 0.
ri_html->add( '<div class="dummydiv success">' ).

17
src/ui/zcl_abapgit_gui_page_codi_base.clas.abap
View File

@ -15,10 +15,14 @@ CLASS zcl_abapgit_gui_page_codi_base DEFINITION PUBLIC ABSTRACT INHERITING FROM
stage TYPE string VALUE 'stage' ##NO_TEXT,
commit TYPE string VALUE 'commit' ##NO_TEXT,
END OF c_actions .
DATA mo_repo TYPE REF TO zcl_abapgit_repo .
DATA mt_result TYPE scit_alvlist .
METHODS render_variant
IMPORTING
!iv_variant TYPE sci_chkv
RETURNING
VALUE(ri_html) TYPE REF TO zif_abapgit_html .
METHODS render_result
IMPORTING
!ii_html TYPE REF TO zif_abapgit_html
@ -260,6 +264,17 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_CODI_BASE IMPLEMENTATION.
ENDMETHOD.
METHOD render_variant.
CREATE OBJECT ri_html TYPE zcl_abapgit_html.
ri_html->add( '<div class="ci-head">' ).
ri_html->add( |Code inspector check variant: <span class="ci-variant">{ iv_variant }</span>| ).
ri_html->add( `</div>` ).
ENDMETHOD.
METHOD zif_abapgit_gui_event_handler~on_event.
DATA: ls_item TYPE zif_abapgit_definitions=>ty_item,
ls_sub_item TYPE zif_abapgit_definitions=>ty_item,

8
src/ui/zcl_abapgit_gui_page_syntax.clas.abap
View File

@ -17,6 +17,7 @@ CLASS zcl_abapgit_gui_page_syntax DEFINITION PUBLIC FINAL CREATE PUBLIC
REDEFINITION.
PROTECTED SECTION.
CONSTANTS: c_variant TYPE sci_chkv VALUE 'SYNTAX_CHECK'.
METHODS:
render_content REDEFINITION.
@ -64,17 +65,18 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_SYNTAX IMPLEMENTATION.
ri_html->add( '<div class="toc">' ).
ri_html->add( render_variant( c_variant ) ).
IF lines( mt_result ) = 0.
ri_html->add( '<div class="dummydiv success">' ).
ri_html->add( zcl_abapgit_html=>icon( 'check' ) ).
ri_html->add( 'No syntax errors' ).
ri_html->add( '</div>' ).
ELSE.
render_result( ii_html = ri_html
it_result = mt_result ).
ENDIF.
ri_html->add( '</div>' ).
ENDMETHOD.
@ -83,7 +85,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_SYNTAX IMPLEMENTATION.
DATA: li_syntax_check TYPE REF TO zif_abapgit_code_inspector.
li_syntax_check = zcl_abapgit_factory=>get_code_inspector( mo_repo->get_package( ) ).
mt_result = li_syntax_check->run( 'SYNTAX_CHECK' ).
mt_result = li_syntax_check->run( c_variant ).
ENDMETHOD.