From dd37881589780ca8579d1b379c6dbcba564ec540 Mon Sep 17 00:00:00 2001 From: Marc Bernard <59966492+mbtools@users.noreply.github.com> Date: Mon, 2 Nov 2020 03:29:09 -0500 Subject: [PATCH] 702: Fix syntax error and missing check variant (#4117) * 702: Downport No chaining with CHANGING * 702: Downport * Syntax check variant * Too many fields warning Co-authored-by: Lars Hvam --- src/objects/zcl_abapgit_objects_ci_tests.clas.abap | 4 +++- src/ui/zcl_abapgit_gui_page_syntax.clas.abap | 8 +++++++- src/utils/zcl_abapgit_string_map.clas.testclasses.abap | 5 ++++- src/zcl_abapgit_code_inspector.clas.abap | 2 +- 4 files changed, 15 insertions(+), 4 deletions(-) diff --git a/src/objects/zcl_abapgit_objects_ci_tests.clas.abap b/src/objects/zcl_abapgit_objects_ci_tests.clas.abap index eb01de356..1fa89f717 100644 --- a/src/objects/zcl_abapgit_objects_ci_tests.clas.abap +++ b/src/objects/zcl_abapgit_objects_ci_tests.clas.abap @@ -27,6 +27,7 @@ CLASS zcl_abapgit_objects_ci_tests IMPLEMENTATION. DATA: ls_repo TYPE zif_abapgit_exit=>ty_ci_repo, lt_repos TYPE zif_abapgit_exit=>ty_ci_repos, + li_exit TYPE REF TO zif_abapgit_exit, lo_ci_repos TYPE REF TO object, ld_options TYPE REF TO data, ld_results TYPE REF TO data, @@ -52,7 +53,8 @@ CLASS zcl_abapgit_objects_ci_tests IMPLEMENTATION. APPEND ls_repo TO lt_repos. " Get list of repos via exit - zcl_abapgit_exit=>get_instance( )->get_ci_tests( + li_exit = zcl_abapgit_exit=>get_instance( ). + li_exit->get_ci_tests( EXPORTING iv_object = iv_object CHANGING diff --git a/src/ui/zcl_abapgit_gui_page_syntax.clas.abap b/src/ui/zcl_abapgit_gui_page_syntax.clas.abap index 18e6a9fa6..6186a6eed 100644 --- a/src/ui/zcl_abapgit_gui_page_syntax.clas.abap +++ b/src/ui/zcl_abapgit_gui_page_syntax.clas.abap @@ -86,7 +86,13 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_SYNTAX IMPLEMENTATION. DATA: li_syntax_check TYPE REF TO zif_abapgit_code_inspector. li_syntax_check = zcl_abapgit_factory=>get_code_inspector( mo_repo->get_package( ) ). - mt_result = li_syntax_check->run( c_variant ). + + TRY. + mt_result = li_syntax_check->run( c_variant ). + CATCH zcx_abapgit_exception. + " Variant SYNTAX_CHECK does not exist in 702 + mt_result = li_syntax_check->run( 'VERI_' && c_variant ). + ENDTRY. ENDMETHOD. diff --git a/src/utils/zcl_abapgit_string_map.clas.testclasses.abap b/src/utils/zcl_abapgit_string_map.clas.testclasses.abap index 14776bdee..e2db5c64b 100644 --- a/src/utils/zcl_abapgit_string_map.clas.testclasses.abap +++ b/src/utils/zcl_abapgit_string_map.clas.testclasses.abap @@ -108,6 +108,8 @@ CLASS ltcl_sm_test IMPLEMENTATION. DATA ls_struc_exp TYPE ty_struc. DATA lo_x TYPE REF TO cx_root. DATA lo_cut TYPE REF TO zcl_abapgit_string_map. + DATA lo_map TYPE REF TO zcl_abapgit_string_map. + lo_cut = zcl_abapgit_string_map=>create( ). lo_cut->set( @@ -136,7 +138,8 @@ CLASS ltcl_sm_test IMPLEMENTATION. act = lo_x->get_text( ) ). ENDTRY. - lo_cut->strict( abap_false )->to_abap( CHANGING cs_container = ls_struc_act ). + lo_map = lo_cut->strict( abap_false ). + lo_map->to_abap( CHANGING cs_container = ls_struc_act ). cl_abap_unit_assert=>assert_equals( exp = ls_struc_exp diff --git a/src/zcl_abapgit_code_inspector.clas.abap b/src/zcl_abapgit_code_inspector.clas.abap index ebb19789d..34dfb384b 100644 --- a/src/zcl_abapgit_code_inspector.clas.abap +++ b/src/zcl_abapgit_code_inspector.clas.abap @@ -189,7 +189,7 @@ CLASS ZCL_ABAPGIT_CODE_INSPECTOR IMPLEMENTATION. FOR ALL ENTRIES IN lt_packages WHERE devclass = lt_packages-table_line AND delflag = abap_false - AND pgmid = 'R3TR'. "#EC CI_GENBUFF + AND pgmid = 'R3TR' ##TOO_MANY_ITAB_FIELDS. "#EC CI_GENBUFF LOOP AT lt_objs INTO ls_obj.