SAP/abapGit
1
0
Fork 0
mirror of https://github.com/abapGit/abapGit.git synced 2025-05-02 13:03:01 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

702: Fix syntax error and missing check variant (#4117)

Browse Source 
* 702: Downport 

No chaining with CHANGING

* 702: Downport

* Syntax check variant

* Too many fields warning

Co-authored-by: Lars Hvam <larshp@hotmail.com>
This commit is contained in:
Marc Bernard 2020-11-02 03:29:09 -05:00 committed by GitHub
parent bdc44f7476
commit dd37881589
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 15 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/objects/zcl_abapgit_objects_ci_tests.clas.abap
View File

@ -27,6 +27,7 @@ CLASS zcl_abapgit_objects_ci_tests IMPLEMENTATION.
DATA: DATA:
ls_repo TYPE zif_abapgit_exit=>ty_ci_repo, ls_repo TYPE zif_abapgit_exit=>ty_ci_repo,
lt_repos TYPE zif_abapgit_exit=>ty_ci_repos, lt_repos TYPE zif_abapgit_exit=>ty_ci_repos,
li_exit TYPE REF TO zif_abapgit_exit,
lo_ci_repos TYPE REF TO object, lo_ci_repos TYPE REF TO object,
ld_options TYPE REF TO data, ld_options TYPE REF TO data,
ld_results TYPE REF TO data, ld_results TYPE REF TO data,
@ -52,7 +53,8 @@ CLASS zcl_abapgit_objects_ci_tests IMPLEMENTATION.
APPEND ls_repo TO lt_repos. APPEND ls_repo TO lt_repos.
" Get list of repos via exit " Get list of repos via exit
zcl_abapgit_exit=>get_instance( )->get_ci_tests( li_exit = zcl_abapgit_exit=>get_instance( ).
li_exit->get_ci_tests(
EXPORTING EXPORTING
iv_object = iv_object iv_object = iv_object
CHANGING CHANGING

6
src/ui/zcl_abapgit_gui_page_syntax.clas.abap
View File

@ -86,7 +86,13 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_SYNTAX IMPLEMENTATION.
DATA: li_syntax_check TYPE REF TO zif_abapgit_code_inspector. DATA: li_syntax_check TYPE REF TO zif_abapgit_code_inspector.
li_syntax_check = zcl_abapgit_factory=>get_code_inspector( mo_repo->get_package( ) ). li_syntax_check = zcl_abapgit_factory=>get_code_inspector( mo_repo->get_package( ) ).
TRY.
mt_result = li_syntax_check->run( c_variant ). mt_result = li_syntax_check->run( c_variant ).
CATCH zcx_abapgit_exception.
" Variant SYNTAX_CHECK does not exist in 702
mt_result = li_syntax_check->run( 'VERI_' && c_variant ).
ENDTRY.
ENDMETHOD. ENDMETHOD.

5
src/utils/zcl_abapgit_string_map.clas.testclasses.abap
View File

@ -108,6 +108,8 @@ CLASS ltcl_sm_test IMPLEMENTATION.
DATA ls_struc_exp TYPE ty_struc. DATA ls_struc_exp TYPE ty_struc.
DATA lo_x TYPE REF TO cx_root. DATA lo_x TYPE REF TO cx_root.
DATA lo_cut TYPE REF TO zcl_abapgit_string_map. DATA lo_cut TYPE REF TO zcl_abapgit_string_map.
DATA lo_map TYPE REF TO zcl_abapgit_string_map.
lo_cut = zcl_abapgit_string_map=>create( ). lo_cut = zcl_abapgit_string_map=>create( ).
lo_cut->set( lo_cut->set(
@ -136,7 +138,8 @@ CLASS ltcl_sm_test IMPLEMENTATION.
act = lo_x->get_text( ) ). act = lo_x->get_text( ) ).
ENDTRY. ENDTRY.
lo_cut->strict( abap_false )->to_abap( CHANGING cs_container = ls_struc_act ). lo_map = lo_cut->strict( abap_false ).
lo_map->to_abap( CHANGING cs_container = ls_struc_act ).
cl_abap_unit_assert=>assert_equals( cl_abap_unit_assert=>assert_equals(
exp = ls_struc_exp exp = ls_struc_exp

2
src/zcl_abapgit_code_inspector.clas.abap
View File

@ -189,7 +189,7 @@ CLASS ZCL_ABAPGIT_CODE_INSPECTOR IMPLEMENTATION.
FOR ALL ENTRIES IN lt_packages FOR ALL ENTRIES IN lt_packages
WHERE devclass = lt_packages-table_line WHERE devclass = lt_packages-table_line
AND delflag = abap_false AND delflag = abap_false
AND pgmid = 'R3TR'. "#EC CI_GENBUFF AND pgmid = 'R3TR' ##TOO_MANY_ITAB_FIELDS. "#EC CI_GENBUFF
LOOP AT lt_objs INTO ls_obj. LOOP AT lt_objs INTO ls_obj.