Clearer error message for no branch (#3605)

* CI Update

* Raise exception when no .abapgit.xml is found (#3512)

Update

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Updated documentation for repo settings & icons (#3499)

* Completed to-dos

- Updated abapgit.xml example
- Completed missing docu for local settings

* screenshots

* screenshots

* Delete repo_settings_local.png

* screenshots

* Delete repo_settings_local.png

* screenshots

* screenshots

* Combine write-protect setting

* Merged to repo settings

* screenshots

* screenshots

* merged to repo settings

* merged to repo settings

* Adding details

* Added links

* links

* icons

* icons

* icons

* icons

* icons

* icons

* icons

* Update ref-icons.md

* icons

* icons

* Update docs/ref-dot-abapgit.md

Co-authored-by: Lars Hvam <larshp@hotmail.com>

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Fix icon display in docs (#3517)

Icons showed on github.com but not on docs.abapgit.org

* +On/offline: If package already in other repo, nav to repo (#3525)

* New method to get repo from package

If package already exists in a repo and it returns the repo and reason why the package can't be used in a new repo

* UI: If package exists in repo, nav to repo

+Online, +Offline - if repo is already versioned, navigate to repo and show message why package could not be used in new repo

Closes https://github.com/larshp/abapGit/issues/3452

Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>

* Update eslint requirement from ^7.2.0 to ^7.3.0 (#3534)

* Update @abaplint/cli requirement from ^2.36.6 to ^2.36.9 (#3535)

* Fix syntax errors in 702 (#3548)

Caused by https://github.com/larshp/abapGit/pull/3525

* SCP1 Import Order (#3543)

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Update .gitlab-ci.yml

* Update eslint requirement from ^7.3.0 to ^7.3.1 (#3556)

* Update @abaplint/cli requirement from ^2.36.9 to ^2.37.2 (#3557)

* Repo overview as main page (#3498)

* Add main menu, toggle favorites

* Make abapgit logo go to overview

* Remove favorite repo links

* Fix remember filter

* Separator between filters

* Remove unused code

* Repo overview to main page

* Fix errors

* Fix naming

* Downport js

* Add separator

* remove unrelated changes

* Fix spacing

* Add package link

* Fix orderby dumping

* Only show tutorial with no favorites

Still have to do something about empty table

* Move abapgit installation info to debug info

* Improve tutorial, resolves #3497

* Add branch switch link

* Reduce line length

* Revert temporary hack

* Working version of removing logo

* No longer show tutorial in repositories

* Code cleanup

* More cleanup, rename tutorial to page

* Fix

* Force order by favorite

* Add checkmark icons

* View repo to page, rework menu

* Fix build

* Return logo

* Fix hotkeys on repo page, rename to page

* Fix show last repo, cleanup

* Abaplint

* Rollback js reformat

* Fix tutorial title, hotkeys

* Try resolve strange situation with PR

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Remove unused method (#3554)

* Remove unused method

* whitespace

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* 1.97.0 (#3561)

* 1.97.0

whitespace

* 1.97.0

* v1.97.0

* fix for apply_order_by (#3566)

* Update zcl_abapgit_repo.clas.abap (#3570)

* Dialogs: add online repo HTML form (#3533)

* first draft

* progress ...

* html->create()

* more progress

* and more

* getting closer

* wiring

* refactor popup_search_help

* refactor create_package to services

* fix services->new_online after rebase

* linter fixes

* more linter fixes

* straing map util

* error handling

* submits for side actions (ugly ... but ...)

* cleanups

* linter fixes

* refactor form values logic

* linter fix

* review fixes

* remove unused var after rebase

* review fixes, better side action layout

* linter fix

* minor css tweaks

* Fix user settings containing invalid repo key (#3569)

* Update zcl_abapgit_persistence_user.clas.abap

* Fix dump when last repo is invalid

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* UI: Fixes for dark theme (#3540)

* Add logo for dark theme

* Dark theme fixes

* Dark theme fixes

* Solve conflict

* Remove logo changes

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>

* Missing objects in overwrite confirmation popup (#3558)

* Missing objects in overwrite confirmation popup

Closes https://github.com/larshp/abapGit/issues/3550

* Unit tests

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Fix open url in repo view (#3581)

* Fix open url in repo view

* Move call_browser to gui_router

* CSS and logo fixes (#3578)

* css cleanups

* orange logo

* Revert "orange logo"

This reverts commit b9aa45bbd0.

* update font

* css improvements

* remove logo png

* re-layout page title and footer

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Html form improvements and docs (#3582)

* auto id

* fix html validation (form in ul)

* form groups

* move colors to theme

* docs for html form component

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Generate news instance (#3585)

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Update @abaplint/cli requirement from ^2.37.2 to ^2.37.5 (#3588)

* Update eslint requirement from ^7.3.1 to ^7.4.0 (#3589)

* Update .gitlab-ci.yml

* fix repo palette (#3580)

* fix repo palette

* fix page_view_repo after rebase

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Adjust new logo color for dark theme (#3592)

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Add deleted objects to overwrite confirm popup (#3591)

* Add deleted objects to overwrite confirm popup

Closes https://github.com/larshp/abapGit/issues/2845

* Pretty print

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Top menu improvements (#3590)

* Use icons, add back menu to repo show page

* Event handling

* Abaplint

* Add menu to tutorial page

* Lint

* More icons

* Update tutorial, reorganize button code

* Move icon css

* Fix error

* Fix menu

* Update .gitlab-ci.yml

* Fix rebase issue

* Fix rebase mess up

* Raise exception when no .abapgit.xml is found (#3512)

Update

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Updated documentation for repo settings & icons (#3499)

* Completed to-dos

- Updated abapgit.xml example
- Completed missing docu for local settings

* screenshots

* screenshots

* Delete repo_settings_local.png

* screenshots

* Delete repo_settings_local.png

* screenshots

* screenshots

* Combine write-protect setting

* Merged to repo settings

* screenshots

* screenshots

* merged to repo settings

* merged to repo settings

* Adding details

* Added links

* links

* icons

* icons

* icons

* icons

* icons

* icons

* icons

* Update ref-icons.md

* icons

* icons

* Update docs/ref-dot-abapgit.md

Co-authored-by: Lars Hvam <larshp@hotmail.com>

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Fix icon display in docs (#3517)

Icons showed on github.com but not on docs.abapgit.org

* +On/offline: If package already in other repo, nav to repo (#3525)

* New method to get repo from package

If package already exists in a repo and it returns the repo and reason why the package can't be used in a new repo

* UI: If package exists in repo, nav to repo

+Online, +Offline - if repo is already versioned, navigate to repo and show message why package could not be used in new repo

Closes https://github.com/larshp/abapGit/issues/3452

Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>

* Update eslint requirement from ^7.2.0 to ^7.3.0 (#3534)

* Update @abaplint/cli requirement from ^2.36.6 to ^2.36.9 (#3535)

* Fix syntax errors in 702 (#3548)

Caused by https://github.com/larshp/abapGit/pull/3525

* SCP1 Import Order (#3543)

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Update .gitlab-ci.yml

* Update eslint requirement from ^7.3.0 to ^7.3.1 (#3556)

* Update @abaplint/cli requirement from ^2.36.9 to ^2.37.2 (#3557)

* Repo overview as main page (#3498)

* Add main menu, toggle favorites

* Make abapgit logo go to overview

* Remove favorite repo links

* Fix remember filter

* Separator between filters

* Remove unused code

* Repo overview to main page

* Fix errors

* Fix naming

* Downport js

* Add separator

* remove unrelated changes

* Fix spacing

* Add package link

* Fix orderby dumping

* Only show tutorial with no favorites

Still have to do something about empty table

* Move abapgit installation info to debug info

* Improve tutorial, resolves #3497

* Add branch switch link

* Reduce line length

* Revert temporary hack

* Working version of removing logo

* No longer show tutorial in repositories

* Code cleanup

* More cleanup, rename tutorial to page

* Fix

* Force order by favorite

* Add checkmark icons

* View repo to page, rework menu

* Fix build

* Return logo

* Fix hotkeys on repo page, rename to page

* Fix show last repo, cleanup

* Abaplint

* Rollback js reformat

* Fix tutorial title, hotkeys

* Try resolve strange situation with PR

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Remove unused method (#3554)

* Remove unused method

* whitespace

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* 1.97.0 (#3561)

* 1.97.0

whitespace

* 1.97.0

* v1.97.0

* fix for apply_order_by (#3566)

* Update zcl_abapgit_repo.clas.abap (#3570)

* Dialogs: add online repo HTML form (#3533)

* first draft

* progress ...

* html->create()

* more progress

* and more

* getting closer

* wiring

* refactor popup_search_help

* refactor create_package to services

* fix services->new_online after rebase

* linter fixes

* more linter fixes

* straing map util

* error handling

* submits for side actions (ugly ... but ...)

* cleanups

* linter fixes

* refactor form values logic

* linter fix

* review fixes

* remove unused var after rebase

* review fixes, better side action layout

* linter fix

* minor css tweaks

* Fix user settings containing invalid repo key (#3569)

* Update zcl_abapgit_persistence_user.clas.abap

* Fix dump when last repo is invalid

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* UI: Fixes for dark theme (#3540)

* Add logo for dark theme

* Dark theme fixes

* Dark theme fixes

* Solve conflict

* Remove logo changes

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>

* Missing objects in overwrite confirmation popup (#3558)

* Missing objects in overwrite confirmation popup

Closes https://github.com/larshp/abapGit/issues/3550

* Unit tests

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Fix open url in repo view (#3581)

* Fix open url in repo view

* Move call_browser to gui_router

* CSS and logo fixes (#3578)

* css cleanups

* orange logo

* Revert "orange logo"

This reverts commit b9aa45bbd0.

* update font

* css improvements

* remove logo png

* re-layout page title and footer

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Html form improvements and docs (#3582)

* auto id

* fix html validation (form in ul)

* form groups

* move colors to theme

* docs for html form component

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Generate news instance (#3585)

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Update @abaplint/cli requirement from ^2.37.2 to ^2.37.5 (#3588)

* Update eslint requirement from ^7.3.1 to ^7.4.0 (#3589)

* Improve message when no branches selectable

* Update .gitlab-ci.yml

* Fix linter issues

* Fix rebase mess up

* Enhanced Error message

* Delete .gitlab-ci.yml

Co-authored-by: Ed Wenmakers <ed.wenmakers@redwood.com>
Co-authored-by: Christian Günter <christianguenter@googlemail.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Rakshith Gore <58498218+goreraks@users.noreply.github.com>
Co-authored-by: Lukáš Novák <lthenovi@gmail.com>
Co-authored-by: Alexander Tsybulsky <sbcgua@users.noreply.github.com>
Co-authored-by: Jaime Rodriguez Capote <jrodriguez@resultoconsultoria.com>

.abapgit.xml

@@ -17,6 +17,7 @@
     <item>/CODE_OF_CONDUCT.md</item>
     <item>/abaplint.json</item>
     <item>/.eslintrc.yaml</item>
+    <item>/.gitlab-ci.yml</item>
    </IGNORE>
   </DATA>
  </asx:values>

src/ui/zcl_abapgit_popups.clas.abap

@@ -384,6 +384,7 @@ CLASS ZCL_ABAPGIT_POPUPS IMPLEMENTATION.
           lv_default     TYPE i,
           lv_head_suffix TYPE string,
           lv_head_symref TYPE string,
+          lv_text        TYPE string,
           lt_selection   TYPE TABLE OF spopli.
 
     FIELD-SYMBOLS: <ls_sel>    LIKE LINE OF lt_selection,
@@ -405,7 +406,23 @@ CLASS ZCL_ABAPGIT_POPUPS IMPLEMENTATION.
     ENDIF.
 
     IF lt_branches IS INITIAL.
-      zcx_abapgit_exception=>raise( 'No branch to select' ).
+      IF iv_hide_head IS NOT INITIAL.
+        lv_text = 'master'.
+      ENDIF.
+      IF iv_hide_branch IS NOT INITIAL AND iv_hide_branch <> 'refs/heads/master'.
+        IF lv_text IS INITIAL.
+          lv_text = iv_hide_branch && ' is'.
+        ELSE.
+          CONCATENATE lv_text 'and' iv_hide_branch 'are' INTO lv_text SEPARATED BY space.
+        ENDIF.
+      ELSE.
+        lv_text = lv_text && ' is'.
+      ENDIF.
+      IF lv_text IS NOT INITIAL.
+        zcx_abapgit_exception=>raise( 'No branches available to select (' && lv_text && ' hidden)' ).
+      ELSE.
+        zcx_abapgit_exception=>raise( 'No branches are available to select' ).
+      ENDIF.
     ENDIF.
 
     LOOP AT lt_branches ASSIGNING <ls_branch>.