move type defintiion to zif_abapgit_definitions

This commit is contained in:
Christian Guenter 2018-05-05 12:35:04 +00:00
parent 9ba92f319b
commit e1551c3941
5 changed files with 14 additions and 13 deletions

View File

@ -66,7 +66,7 @@ CLASS zcl_abapgit_persist_migrate IMPLEMENTATION.
DATA: lt_abapgit_users TYPE STANDARD TABLE OF char12 DATA: lt_abapgit_users TYPE STANDARD TABLE OF char12
WITH NON-UNIQUE DEFAULT KEY, WITH NON-UNIQUE DEFAULT KEY,
ls_user_settings TYPE zcl_abapgit_settings=>ty_s_user_settings, ls_user_settings TYPE zif_abapgit_definitions=>ty_s_user_settings,
lo_user_persistence TYPE REF TO zcl_abapgit_persistence_user. lo_user_persistence TYPE REF TO zcl_abapgit_persistence_user.
FIELD-SYMBOLS: <ls_user> LIKE LINE OF lt_abapgit_users, FIELD-SYMBOLS: <ls_user> LIKE LINE OF lt_abapgit_users,

View File

@ -23,7 +23,7 @@ ENDCLASS.
CLASS ZCL_ABAPGIT_PERSIST_SETTINGS IMPLEMENTATION. CLASS zcl_abapgit_persist_settings IMPLEMENTATION.
METHOD get_instance. METHOD get_instance.
@ -39,7 +39,7 @@ CLASS ZCL_ABAPGIT_PERSIST_SETTINGS IMPLEMENTATION.
METHOD modify. METHOD modify.
DATA: lv_settings TYPE string, DATA: lv_settings TYPE string,
ls_user_settings TYPE zcl_abapgit_settings=>ty_s_user_settings. ls_user_settings TYPE zif_abapgit_definitions=>ty_s_user_settings.
lv_settings = io_settings->get_settings_xml( ). lv_settings = io_settings->get_settings_xml( ).

View File

@ -142,12 +142,12 @@ CLASS zcl_abapgit_persistence_user DEFINITION
zcx_abapgit_exception . zcx_abapgit_exception .
METHODS get_settings METHODS get_settings
RETURNING RETURNING
VALUE(rs_user_settings) TYPE zcl_abapgit_settings=>ty_s_user_settings VALUE(rs_user_settings) TYPE zif_abapgit_definitions=>ty_s_user_settings
RAISING RAISING
zcx_abapgit_exception. zcx_abapgit_exception.
METHODS set_settings METHODS set_settings
IMPORTING IMPORTING
is_user_settings TYPE zcl_abapgit_settings=>ty_s_user_settings is_user_settings TYPE zif_abapgit_definitions=>ty_s_user_settings
RAISING RAISING
zcx_abapgit_exception. zcx_abapgit_exception.
PRIVATE SECTION. PRIVATE SECTION.
@ -170,7 +170,7 @@ CLASS zcl_abapgit_persistence_user DEFINITION
diff_unified TYPE abap_bool, diff_unified TYPE abap_bool,
favorites TYPE tt_favorites, favorites TYPE tt_favorites,
repo_config TYPE ty_repo_config_tt, repo_config TYPE ty_repo_config_tt,
settings TYPE zcl_abapgit_settings=>ty_s_user_settings, settings TYPE zif_abapgit_definitions=>ty_s_user_settings,
END OF ty_user . END OF ty_user .
DATA mv_user TYPE xubname . DATA mv_user TYPE xubname .

View File

@ -1,10 +1,6 @@
CLASS zcl_abapgit_settings DEFINITION PUBLIC CREATE PUBLIC. CLASS zcl_abapgit_settings DEFINITION PUBLIC CREATE PUBLIC.
PUBLIC SECTION. PUBLIC SECTION.
TYPES: BEGIN OF ty_s_user_settings,
max_lines TYPE i,
adt_jump_enabled TYPE abap_bool,
END OF ty_s_user_settings.
CONSTANTS: c_commitmsg_comment_length_dft TYPE i VALUE 50. CONSTANTS: c_commitmsg_comment_length_dft TYPE i VALUE 50.
CONSTANTS: c_commitmsg_body_size_dft TYPE i VALUE 72. CONSTANTS: c_commitmsg_body_size_dft TYPE i VALUE 72.
@ -69,7 +65,7 @@ CLASS zcl_abapgit_settings DEFINITION PUBLIC CREATE PUBLIC.
zcx_abapgit_exception, zcx_abapgit_exception,
get_user_settings get_user_settings
RETURNING RETURNING
VALUE(rs_settings) TYPE zcl_abapgit_settings=>ty_s_user_settings VALUE(rs_settings) TYPE zif_abapgit_definitions=>ty_s_user_settings
RAISING RAISING
zcx_abapgit_exception, zcx_abapgit_exception,
set_xml_settings set_xml_settings
@ -80,7 +76,7 @@ CLASS zcl_abapgit_settings DEFINITION PUBLIC CREATE PUBLIC.
set_defaults, set_defaults,
set_user_settings set_user_settings
IMPORTING IMPORTING
is_user_settings TYPE ty_s_user_settings. is_user_settings TYPE zif_abapgit_definitions=>ty_s_user_settings.
PRIVATE SECTION. PRIVATE SECTION.
TYPES: BEGIN OF ty_s_settings, TYPES: BEGIN OF ty_s_settings,
@ -93,7 +89,7 @@ CLASS zcl_abapgit_settings DEFINITION PUBLIC CREATE PUBLIC.
commitmsg_body_size TYPE i, commitmsg_body_size TYPE i,
END OF ty_s_settings. END OF ty_s_settings.
DATA: ms_settings TYPE ty_s_settings, DATA: ms_settings TYPE ty_s_settings,
ms_user_settings TYPE ty_s_user_settings. ms_user_settings TYPE zif_abapgit_definitions=>ty_s_user_settings.
ENDCLASS. ENDCLASS.

View File

@ -278,6 +278,11 @@ INTERFACE zif_abapgit_definitions PUBLIC.
END OF ty_repo_item. END OF ty_repo_item.
TYPES tt_repo_items TYPE STANDARD TABLE OF ty_repo_item WITH DEFAULT KEY. TYPES tt_repo_items TYPE STANDARD TABLE OF ty_repo_item WITH DEFAULT KEY.
TYPES: BEGIN OF ty_s_user_settings,
max_lines TYPE i,
adt_jump_enabled TYPE abap_bool,
END OF ty_s_user_settings.
CONSTANTS gc_xml_version TYPE string VALUE 'v1.0.0' ##NO_TEXT. CONSTANTS gc_xml_version TYPE string VALUE 'v1.0.0' ##NO_TEXT.
CONSTANTS gc_abap_version TYPE string VALUE 'v1.64.0' ##NO_TEXT. CONSTANTS gc_abap_version TYPE string VALUE 'v1.64.0' ##NO_TEXT.
CONSTANTS: CONSTANTS: