remove class prefixes if its current class (#3137)

* remove class prefixes if its current class

* Update abaplint.json
This commit is contained in:
Lars Hvam 2020-01-06 13:20:19 +01:00 committed by GitHub
parent a256a0b406
commit e201bf566f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
17 changed files with 22 additions and 22 deletions

View File

@ -56,6 +56,7 @@
"globalMacros": []
},
"rules": {
"prefix_is_current_class": true,
"allowed_object_naming": true,
"check_comments": false,
"fully_type_constants": true,

View File

@ -523,7 +523,7 @@ CLASS ZCL_ABAPGIT_OBJECT_FORM IMPLEMENTATION.
METHOD _sort_tdlines_by_windows.
DATA lt_lines TYPE zcl_abapgit_object_form=>tyt_lines.
DATA lt_lines TYPE tyt_lines.
DATA ls_lines LIKE LINE OF lt_lines.
DATA ls_form_windows LIKE LINE OF ct_form_windows.
DATA lv_elt_windows TYPE tdformat VALUE '/W'.

View File

@ -600,7 +600,7 @@ CLASS ZCL_ABAPGIT_OBJECT_FUGR IMPLEMENTATION.
METHOD is_any_function_module_locked.
DATA: lt_functions TYPE zcl_abapgit_object_fugr=>ty_rs38l_incl_tt.
DATA: lt_functions TYPE ty_rs38l_incl_tt.
FIELD-SYMBOLS: <ls_function> TYPE rs38l_incl.

View File

@ -150,7 +150,7 @@ CLASS ZCL_ABAPGIT_OBJECT_PRAG IMPLEMENTATION.
METHOD zif_abapgit_object~serialize.
DATA: lo_pragma TYPE REF TO cl_abap_pragma,
ls_pragma TYPE zcl_abapgit_object_prag=>ty_pragma.
ls_pragma TYPE ty_pragma.
TRY.
lo_pragma = cl_abap_pragma=>get_ref( ms_item-obj_name ).

View File

@ -166,8 +166,7 @@ CLASS ZCL_ABAPGIT_OBJECT_SSFO IMPLEMENTATION.
CHANGING cv_within_code_section = cv_within_code_section ).
* for downwards compatibility, this code can be removed sometime in the future
lv_leading_spaces = li_element->get_attribute_ns(
name = zcl_abapgit_object_ssfo=>attrib_abapgit_leadig_spaces ).
lv_leading_spaces = li_element->get_attribute_ns( name = attrib_abapgit_leadig_spaces ).
lv_coding_line = li_element->get_value( ).
IF strlen( lv_coding_line ) >= 1 AND lv_coding_line(1) <> | |.

View File

@ -89,7 +89,7 @@ CLASS ZCL_ABAPGIT_OBJECT_SUSC IMPLEMENTATION.
CALL FUNCTION 'SUSR_COMMEDITCHECK'
EXPORTING
objectname = lv_tr_object_name
transobjecttype = zcl_abapgit_object_susc=>transobjecttype_class
transobjecttype = transobjecttype_class
IMPORTING
return_from_korr = lv_tr_return.
@ -172,7 +172,7 @@ CLASS ZCL_ABAPGIT_OBJECT_SUSC IMPLEMENTATION.
CALL FUNCTION 'SUSR_COMMEDITCHECK'
EXPORTING
objectname = lv_objectname
transobjecttype = zcl_abapgit_object_susc=>transobjecttype_class.
transobjecttype = transobjecttype_class.
INSERT tobc FROM ls_tobc. "#EC CI_SUBRC
* ignore sy-subrc as all fields are key fields

View File

@ -400,7 +400,7 @@ CLASS ZCL_ABAPGIT_OBJECT_WAPA IMPLEMENTATION.
lo_page TYPE REF TO cl_o2_api_pages,
lt_pages_info TYPE ty_pages_tt,
ls_pagekey TYPE o2pagkey,
ls_local_page TYPE zcl_abapgit_object_wapa=>ty_page,
ls_local_page TYPE ty_page,
lt_remote_content TYPE o2pageline_table,
lt_local_content TYPE o2pageline_table,
lt_local_pages TYPE o2pagelist.

View File

@ -636,10 +636,10 @@ CLASS ZCL_ABAPGIT_OBJECTS_PROGRAM IMPLEMENTATION.
METHOD is_any_dynpro_locked.
DATA: lt_dynpros TYPE zcl_abapgit_objects_program=>ty_dynpro_tt,
DATA: lt_dynpros TYPE ty_dynpro_tt,
lv_object TYPE seqg3-garg.
FIELD-SYMBOLS: <ls_dynpro> TYPE zcl_abapgit_objects_program=>ty_dynpro.
FIELD-SYMBOLS: <ls_dynpro> TYPE ty_dynpro.
lt_dynpros = serialize_dynpros( iv_program ).

View File

@ -70,7 +70,7 @@ CLASS ZCL_ABAPGIT_PERSIST_MIGRATE IMPLEMENTATION.
li_user_persistence TYPE REF TO zif_abapgit_persist_user.
FIELD-SYMBOLS: <lv_user> LIKE LINE OF lt_abapgit_users,
<ls_setting_to_migrate> TYPE zcl_abapgit_persist_migrate=>ty_settings_to_migrate,
<ls_setting_to_migrate> TYPE ty_settings_to_migrate,
<lg_user_specific_setting_val> TYPE data.
" distribute settings to all abapGit users

View File

@ -476,7 +476,7 @@ CLASS zcl_abapgit_gui_page IMPLEMENTATION.
METHOD zif_abapgit_gui_renderable~render.
DATA: lo_script TYPE REF TO zcl_abapgit_html,
lt_events TYPE zcl_abapgit_gui_page=>tt_events.
lt_events TYPE tt_events.
FIELD-SYMBOLS:
<ls_event> LIKE LINE OF lt_events.

View File

@ -261,7 +261,7 @@ CLASS zcl_abapgit_gui_page_diff IMPLEMENTATION.
lv_patch TYPE xstring,
lo_git_add_patch TYPE REF TO zcl_abapgit_git_add_patch.
FIELD-SYMBOLS: <ls_diff_file> TYPE zcl_abapgit_gui_page_diff=>ty_file_diff.
FIELD-SYMBOLS: <ls_diff_file> TYPE ty_file_diff.
lo_repo ?= zcl_abapgit_repo_srv=>get_instance( )->get( mv_repo_key ).

View File

@ -196,7 +196,7 @@ CLASS ZCL_ABAPGIT_LOG_VIEWER IMPLEMENTATION.
METHOD on_link_click.
DATA: lx_error TYPE REF TO zcx_abapgit_exception.
FIELD-SYMBOLS: <ls_log> TYPE zcl_abapgit_log_viewer=>ty_log_out.
FIELD-SYMBOLS: <ls_log> TYPE ty_log_out.
IF row IS INITIAL
OR column IS INITIAL.

View File

@ -79,7 +79,7 @@ CLASS ZCL_ABAPGIT_TAG_POPUPS IMPLEMENTATION.
METHOD on_double_click.
FIELD-SYMBOLS: <ls_tag> TYPE zcl_abapgit_tag_popups=>ty_tag_out.
FIELD-SYMBOLS: <ls_tag> TYPE ty_tag_out.
READ TABLE mt_tags ASSIGNING <ls_tag>
INDEX row.

View File

@ -80,7 +80,7 @@ CLASS ZCL_ABAPGIT_FACTORY IMPLEMENTATION.
METHOD get_code_inspector.
DATA: ls_code_inspector LIKE LINE OF gt_code_inspector.
FIELD-SYMBOLS: <ls_code_inspector> TYPE zcl_abapgit_factory=>ty_code_inspector.
FIELD-SYMBOLS: <ls_code_inspector> TYPE ty_code_inspector.
READ TABLE gt_code_inspector ASSIGNING <ls_code_inspector>
WITH TABLE KEY package = iv_package.

View File

@ -265,13 +265,13 @@ CLASS ZCL_ABAPGIT_MESSAGE_HELPER IMPLEMENTATION.
CASE cs_itf-tdline.
WHEN gc_section_token-cause.
cs_itf-tdline = zcl_abapgit_message_helper=>gc_section_text-cause.
cs_itf-tdline = gc_section_text-cause.
WHEN gc_section_token-system_response.
cs_itf-tdline = zcl_abapgit_message_helper=>gc_section_text-system_response.
cs_itf-tdline = gc_section_text-system_response.
WHEN gc_section_token-what_to_do.
cs_itf-tdline = zcl_abapgit_message_helper=>gc_section_text-what_to_do.
cs_itf-tdline = gc_section_text-what_to_do.
WHEN gc_section_token-sys_admin.
cs_itf-tdline = zcl_abapgit_message_helper=>gc_section_text-sys_admin.
cs_itf-tdline = gc_section_text-sys_admin.
ENDCASE.
ENDMETHOD.

View File

@ -1170,7 +1170,7 @@ CLASS ZCL_ABAPGIT_OBJECTS IMPLEMENTATION.
LOOP AT lt_objects ASSIGNING <ls_object> WHERE pgmid = 'R3TR'.
ls_item-obj_type = <ls_object>-object.
lv_supported = zcl_abapgit_objects=>is_supported(
lv_supported = is_supported(
is_item = ls_item
iv_native_only = abap_true ).

View File

@ -439,7 +439,7 @@ CLASS zcl_abapgit_repo_srv IMPLEMENTATION.
lt_repos = zcl_abapgit_persist_factory=>get_repo( )->list( ).
READ TABLE lt_repos WITH KEY package = iv_package ASSIGNING <ls_repo>.
IF sy-subrc = 0.
lv_name = zcl_abapgit_repo_srv=>get_instance( )->get( <ls_repo>-key )->get_name( ).
lv_name = get_instance( )->get( <ls_repo>-key )->get_name( ).
lv_owner = <ls_repo>-created_by.
zcx_abapgit_exception=>raise( |Package { iv_package } already versioned as { lv_name } by { lv_owner }| ).
ENDIF.