From e35df57646a0f0e7b6b892dbcad69b867e456f17 Mon Sep 17 00:00:00 2001
From: Lars Hvam <larshp@hotmail.com>
Date: Tue, 10 Nov 2020 14:21:42 +0100
Subject: [PATCH] Change TY_SVAL_TT location (#4155)

---
 src/ui/zcl_abapgit_popups.clas.abap   | 9 +++------
 src/ui/zif_abapgit_popups.intf.abap   | 4 +++-
 src/zabapgit_forms.prog.abap          | 2 +-
 src/zif_abapgit_definitions.intf.abap | 2 --
 4 files changed, 7 insertions(+), 10 deletions(-)

diff --git a/src/ui/zcl_abapgit_popups.clas.abap b/src/ui/zcl_abapgit_popups.clas.abap
index a51eff2c4..cd344dd84 100644
--- a/src/ui/zcl_abapgit_popups.clas.abap
+++ b/src/ui/zcl_abapgit_popups.clas.abap
@@ -12,9 +12,6 @@ CLASS zcl_abapgit_popups DEFINITION
   PROTECTED SECTION.
   PRIVATE SECTION.
 
-    TYPES:
-      ty_sval_tt TYPE STANDARD TABLE OF sval WITH DEFAULT KEY.
-
     CONSTANTS c_fieldname_selected TYPE lvc_fname VALUE `SELECTED` ##NO_TEXT.
     CONSTANTS c_answer_cancel      TYPE c LENGTH 1 VALUE 'A' ##NO_TEXT.
 
@@ -32,7 +29,7 @@ CLASS zcl_abapgit_popups DEFINITION
         !iv_field_attr TYPE sval-field_attr DEFAULT ''
         !iv_obligatory TYPE spo_obl OPTIONAL
       CHANGING
-        !ct_fields     TYPE ty_sval_tt .
+        !ct_fields     TYPE zif_abapgit_popups=>ty_sval_tt .
     METHODS create_new_table
       IMPORTING
         !it_list TYPE STANDARD TABLE .
@@ -55,7 +52,7 @@ CLASS zcl_abapgit_popups DEFINITION
           !column .
     METHODS extract_field_values
       IMPORTING
-        it_fields           TYPE ty_sval_tt
+        it_fields           TYPE zif_abapgit_popups=>ty_sval_tt
       EXPORTING
         ev_url              TYPE abaptxt255-line
         ev_package          TYPE tdevc-devclass
@@ -92,7 +89,7 @@ ENDCLASS.
 
 
 
-CLASS zcl_abapgit_popups IMPLEMENTATION.
+CLASS ZCL_ABAPGIT_POPUPS IMPLEMENTATION.
 
 
   METHOD add_field.
diff --git a/src/ui/zif_abapgit_popups.intf.abap b/src/ui/zif_abapgit_popups.intf.abap
index f2207daba..b7ead5e11 100644
--- a/src/ui/zif_abapgit_popups.intf.abap
+++ b/src/ui/zif_abapgit_popups.intf.abap
@@ -1,6 +1,8 @@
 INTERFACE zif_abapgit_popups
   PUBLIC .
 
+  TYPES:
+    ty_sval_tt TYPE STANDARD TABLE OF sval WITH DEFAULT KEY.
 
   TYPES:
     BEGIN OF ty_popup, " TODO remove, use zif_abapgit_services_repo=>ty_repo_params instead
@@ -130,7 +132,7 @@ INTERFACE zif_abapgit_popups
     IMPORTING
       !iv_code       TYPE clike
     CHANGING
-      !ct_fields     TYPE zif_abapgit_definitions=>ty_sval_tt
+      !ct_fields     TYPE ty_sval_tt
       !cs_error      TYPE svale
       !cv_show_popup TYPE char01
     RAISING
diff --git a/src/zabapgit_forms.prog.abap b/src/zabapgit_forms.prog.abap
index e77d530f0..9e9c89107 100644
--- a/src/zabapgit_forms.prog.abap
+++ b/src/zabapgit_forms.prog.abap
@@ -46,7 +46,7 @@ ENDFORM.
 *      -->##CALLED       text
 *      -->##NEEDED       text
 *----------------------------------------------------------------------*
-FORM branch_popup TABLES   tt_fields TYPE zif_abapgit_definitions=>ty_sval_tt
+FORM branch_popup TABLES   tt_fields TYPE zif_abapgit_popups=>ty_sval_tt
                   USING    pv_code TYPE clike
                   CHANGING cs_error TYPE svale
                            cv_show_popup TYPE c
diff --git a/src/zif_abapgit_definitions.intf.abap b/src/zif_abapgit_definitions.intf.abap
index 610e1e33d..415c034e2 100644
--- a/src/zif_abapgit_definitions.intf.abap
+++ b/src/zif_abapgit_definitions.intf.abap
@@ -211,8 +211,6 @@ INTERFACE zif_abapgit_definitions
       remote TYPE ty_files_tt,
       status TYPE ty_results_ts_path,
     END OF ty_stage_files .
-  TYPES:
-    ty_sval_tt TYPE STANDARD TABLE OF sval WITH DEFAULT KEY .
   TYPES:
     ty_seocompotx_tt TYPE STANDARD TABLE OF seocompotx WITH DEFAULT KEY .
   TYPES: