From e3df6fe4c2b48239281bfe0dc9d3d903e6c4b999 Mon Sep 17 00:00:00 2001 From: larshp Date: Sun, 12 Aug 2018 08:51:51 +0000 Subject: [PATCH] PROG: add guard for bad TADIR EIMP entries --- src/objects/zcl_abapgit_object_prog.clas.abap | 57 ++++++++++--------- 1 file changed, 30 insertions(+), 27 deletions(-) diff --git a/src/objects/zcl_abapgit_object_prog.clas.abap b/src/objects/zcl_abapgit_object_prog.clas.abap index 2f5e76ce7..1119cd3bb 100644 --- a/src/objects/zcl_abapgit_object_prog.clas.abap +++ b/src/objects/zcl_abapgit_object_prog.clas.abap @@ -28,7 +28,7 @@ ENDCLASS. -CLASS zcl_abapgit_object_prog IMPLEMENTATION. +CLASS ZCL_ABAPGIT_OBJECT_PROG IMPLEMENTATION. METHOD deserialize_texts. @@ -52,6 +52,14 @@ CLASS zcl_abapgit_object_prog IMPLEMENTATION. ENDMETHOD. + METHOD is_program_locked. + + rv_is_program_locked = exists_a_lock_entry_for( iv_lock_object = 'ESRDIRE' + iv_argument = |{ ms_item-obj_name }| ). + + ENDMETHOD. + + METHOD serialize_texts. DATA: lt_tpool_i18n TYPE tt_tpool_i18n, @@ -196,29 +204,6 @@ CLASS zcl_abapgit_object_prog IMPLEMENTATION. ENDMETHOD. - METHOD zif_abapgit_object~jump. - - CALL FUNCTION 'RS_TOOL_ACCESS' - EXPORTING - operation = 'SHOW' - object_name = ms_item-obj_name - object_type = 'PROG' - in_new_window = abap_true. - - ENDMETHOD. - - - METHOD zif_abapgit_object~serialize. - - serialize_program( io_xml = io_xml - is_item = ms_item - io_files = mo_files ). - - " Texts serializing (translations) - serialize_texts( io_xml ). - - ENDMETHOD. - METHOD zif_abapgit_object~is_locked. IF is_program_locked( ) = abap_true @@ -233,11 +218,29 @@ CLASS zcl_abapgit_object_prog IMPLEMENTATION. ENDMETHOD. - METHOD is_program_locked. + METHOD zif_abapgit_object~jump. - rv_is_program_locked = exists_a_lock_entry_for( iv_lock_object = 'ESRDIRE' - iv_argument = |{ ms_item-obj_name }| ). + CALL FUNCTION 'RS_TOOL_ACCESS' + EXPORTING + operation = 'SHOW' + object_name = ms_item-obj_name + object_type = 'PROG' + in_new_window = abap_true. ENDMETHOD. + + METHOD zif_abapgit_object~serialize. + +* see SAP note 1025291, run report DELETE_TADIR_FOR_EIMP_INCLUDE to clean bad TADIR entries + ASSERT NOT ms_item-obj_name CP '*=E'. + + serialize_program( io_xml = io_xml + is_item = ms_item + io_files = mo_files ). + + " Texts serializing (translations) + serialize_texts( io_xml ). + + ENDMETHOD. ENDCLASS.