diff --git a/src/ui/zabapgit_css_common.w3mi.data.css b/src/ui/zabapgit_css_common.w3mi.data.css index ec9b356dc..0b29de329 100644 --- a/src/ui/zabapgit_css_common.w3mi.data.css +++ b/src/ui/zabapgit_css_common.w3mi.data.css @@ -1043,6 +1043,15 @@ settings_tab tr:first-child td { border-top: 0px; } border-radius: 6px; text-align: left; } +.dialog-form { + margin: 1em 1em 1em 1em; + width: 600px; +} +.dialog-form-center { + margin: 1em auto 1em; + max-width: 600px; + width: 100%; +} .dialog ul { padding: 0; margin: 0; diff --git a/src/ui/zcl_abapgit_gui_page_addofflin.clas.abap b/src/ui/zcl_abapgit_gui_page_addofflin.clas.abap index 142aa7be3..efcb609ff 100644 --- a/src/ui/zcl_abapgit_gui_page_addofflin.clas.abap +++ b/src/ui/zcl_abapgit_gui_page_addofflin.clas.abap @@ -58,7 +58,7 @@ ENDCLASS. -CLASS ZCL_ABAPGIT_GUI_PAGE_ADDOFFLIN IMPLEMENTATION. +CLASS zcl_abapgit_gui_page_addofflin IMPLEMENTATION. METHOD constructor. @@ -222,7 +222,6 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_ADDOFFLIN IMPLEMENTATION. CREATE OBJECT ri_html TYPE zcl_abapgit_html. ri_html->add( mo_form->render( - iv_form_class = 'dialog w600px m-em5-sides margin-v1' " to center add wmax600px and auto-center instead io_values = mo_form_data io_validation_log = mo_validation_log ) ). diff --git a/src/ui/zcl_abapgit_gui_page_addonline.clas.abap b/src/ui/zcl_abapgit_gui_page_addonline.clas.abap index a8d6dcd7b..877f65177 100644 --- a/src/ui/zcl_abapgit_gui_page_addonline.clas.abap +++ b/src/ui/zcl_abapgit_gui_page_addonline.clas.abap @@ -279,7 +279,6 @@ CLASS zcl_abapgit_gui_page_addonline IMPLEMENTATION. CREATE OBJECT ri_html TYPE zcl_abapgit_html. ri_html->add( mo_form->render( - iv_form_class = 'dialog w600px m-em5-sides margin-v1' " to center add wmax600px and auto-center instead io_values = mo_form_data io_validation_log = mo_validation_log ) ). diff --git a/src/ui/zcl_abapgit_gui_page_data.clas.abap b/src/ui/zcl_abapgit_gui_page_data.clas.abap index 4a1910c41..343935270 100644 --- a/src/ui/zcl_abapgit_gui_page_data.clas.abap +++ b/src/ui/zcl_abapgit_gui_page_data.clas.abap @@ -60,7 +60,7 @@ ENDCLASS. -CLASS ZCL_ABAPGIT_GUI_PAGE_DATA IMPLEMENTATION. +CLASS zcl_abapgit_gui_page_data IMPLEMENTATION. METHOD constructor. @@ -142,9 +142,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_DATA IMPLEMENTATION. iv_label = 'Add' iv_cmd_type = zif_abapgit_html_form=>c_cmd_type-input_main iv_action = c_event-add ). - ri_html->add( lo_form->render( - iv_form_class = 'dialog w600px m-em5-sides margin-v1' - io_values = lo_form_data ) ). + ri_html->add( lo_form->render( lo_form_data ) ). ENDMETHOD. @@ -199,9 +197,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_DATA IMPLEMENTATION. iv_label = 'Remove' iv_cmd_type = zif_abapgit_html_form=>c_cmd_type-input_main iv_action = c_event-remove ). - ri_html->add( lo_form->render( - iv_form_class = 'dialog w600px m-em5-sides margin-v1' - io_values = lo_form_data ) ). + ri_html->add( lo_form->render( lo_form_data ) ). ENDLOOP. ENDMETHOD. diff --git a/src/ui/zcl_abapgit_gui_page_sett_glob.clas.abap b/src/ui/zcl_abapgit_gui_page_sett_glob.clas.abap index 5e51264e4..e04740379 100644 --- a/src/ui/zcl_abapgit_gui_page_sett_glob.clas.abap +++ b/src/ui/zcl_abapgit_gui_page_sett_glob.clas.abap @@ -77,7 +77,7 @@ ENDCLASS. -CLASS ZCL_ABAPGIT_GUI_PAGE_SETT_GLOB IMPLEMENTATION. +CLASS zcl_abapgit_gui_page_sett_glob IMPLEMENTATION. METHOD constructor. @@ -360,7 +360,6 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_SETT_GLOB IMPLEMENTATION. CREATE OBJECT ri_html TYPE zcl_abapgit_html. ri_html->add( mo_form->render( - iv_form_class = 'dialog w600px m-em5-sides margin-v1' io_values = mo_form_data io_validation_log = mo_validation_log ) ). diff --git a/src/ui/zcl_abapgit_gui_page_sett_pers.clas.abap b/src/ui/zcl_abapgit_gui_page_sett_pers.clas.abap index e694d1eeb..29a99ad60 100644 --- a/src/ui/zcl_abapgit_gui_page_sett_pers.clas.abap +++ b/src/ui/zcl_abapgit_gui_page_sett_pers.clas.abap @@ -73,7 +73,7 @@ ENDCLASS. -CLASS ZCL_ABAPGIT_GUI_PAGE_SETT_PERS IMPLEMENTATION. +CLASS zcl_abapgit_gui_page_sett_pers IMPLEMENTATION. METHOD constructor. @@ -321,7 +321,6 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_SETT_PERS IMPLEMENTATION. CREATE OBJECT ri_html TYPE zcl_abapgit_html. ri_html->add( mo_form->render( - iv_form_class = 'dialog w600px m-em5-sides margin-v1' io_values = mo_form_data io_validation_log = mo_validation_log ) ). diff --git a/src/ui/zcl_abapgit_html_form.clas.abap b/src/ui/zcl_abapgit_html_form.clas.abap index e8ebe52a9..1835c44e6 100644 --- a/src/ui/zcl_abapgit_html_form.clas.abap +++ b/src/ui/zcl_abapgit_html_form.clas.abap @@ -15,7 +15,7 @@ CLASS zcl_abapgit_html_form DEFINITION VALUE(ro_form) TYPE REF TO zcl_abapgit_html_form . METHODS render IMPORTING - !iv_form_class TYPE csequence + !iv_form_class TYPE csequence DEFAULT 'dialog-form' !io_values TYPE REF TO zcl_abapgit_string_map !io_validation_log TYPE REF TO zcl_abapgit_string_map OPTIONAL RETURNING @@ -345,7 +345,7 @@ CLASS zcl_abapgit_html_form IMPLEMENTATION. CREATE OBJECT ri_html TYPE zcl_abapgit_html. - ri_html->add( |
| ). + ri_html->add( |
| ). " to center use 'dialog-form-center' ri_html->add( |
| ). " Add hidden button that triggers main command when pressing enter @@ -731,6 +731,7 @@ CLASS zcl_abapgit_html_form IMPLEMENTATION. METHOD render_field_textarea. DATA lv_rows TYPE i. + DATA lv_html TYPE string. ii_html->add( || ). @@ -741,11 +742,13 @@ CLASS zcl_abapgit_html_form IMPLEMENTATION. lv_rows = lines( zcl_abapgit_convert=>split_string( is_attr-value ) ). - ii_html->add( || ). + " Avoid adding line-breaks inside textarea tag (except for the actual value) + lv_html = ||. + + ii_html->add( lv_html ). ENDMETHOD.