SAP/abapGit
1
0
Fork 0
mirror of https://github.com/abapGit/abapGit.git synced 2025-05-01 12:20:51 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Move ty_deserialization, ty_step_data, ty_repo_ref_tt (#4181)

Browse Source 
* Move ty_deserialization, ty_step_data

Remove dependencies from `zif_abapgit_definitions` (see https://github.com/abapGit/abapGit/issues/4179)

* Move to interface

* Move ty_repo_ref_tt
This commit is contained in:
Marc Bernard 2020-11-16 02:34:29 -05:00 committed by GitHub
parent 26e8dcbde2
commit e93cbc5a1f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
10 changed files with 65 additions and 44 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/objects/zcl_abapgit_objects.clas.abap
View File

@ -172,7 +172,7 @@ CLASS zcl_abapgit_objects DEFINITION
zcx_abapgit_exception . zcx_abapgit_exception .
CLASS-METHODS deserialize_objects CLASS-METHODS deserialize_objects
IMPORTING IMPORTING
!is_step TYPE zif_abapgit_definitions=>ty_step_data !is_step TYPE zif_abapgit_objects=>ty_step_data
!ii_log TYPE REF TO zif_abapgit_log !ii_log TYPE REF TO zif_abapgit_log
CHANGING CHANGING
!ct_files TYPE zif_abapgit_definitions=>ty_file_signatures_tt !ct_files TYPE zif_abapgit_definitions=>ty_file_signatures_tt
@ -217,12 +217,12 @@ CLASS zcl_abapgit_objects DEFINITION
VALUE(rt_results) TYPE zif_abapgit_definitions=>ty_results_tt . VALUE(rt_results) TYPE zif_abapgit_definitions=>ty_results_tt .
CLASS-METHODS get_deserialize_steps CLASS-METHODS get_deserialize_steps
RETURNING RETURNING
VALUE(rt_steps) TYPE zif_abapgit_definitions=>ty_step_data_tt . VALUE(rt_steps) TYPE zif_abapgit_objects=>ty_step_data_tt .
ENDCLASS. ENDCLASS.
CLASS ZCL_ABAPGIT_OBJECTS IMPLEMENTATION. CLASS zcl_abapgit_objects IMPLEMENTATION.
METHOD adjust_namespaces. METHOD adjust_namespaces.
@ -582,14 +582,14 @@ CLASS ZCL_ABAPGIT_OBJECTS IMPLEMENTATION.
lv_path TYPE string, lv_path TYPE string,
lt_items TYPE zif_abapgit_definitions=>ty_items_tt, lt_items TYPE zif_abapgit_definitions=>ty_items_tt,
lt_steps_id TYPE zif_abapgit_definitions=>ty_deserialization_step_tt, lt_steps_id TYPE zif_abapgit_definitions=>ty_deserialization_step_tt,
lt_steps TYPE zif_abapgit_definitions=>ty_step_data_tt, lt_steps TYPE zif_abapgit_objects=>ty_step_data_tt,
lx_exc TYPE REF TO zcx_abapgit_exception. lx_exc TYPE REF TO zcx_abapgit_exception.
DATA: lo_folder_logic TYPE REF TO zcl_abapgit_folder_logic. DATA: lo_folder_logic TYPE REF TO zcl_abapgit_folder_logic.
FIELD-SYMBOLS: <ls_result> TYPE zif_abapgit_definitions=>ty_result, FIELD-SYMBOLS: <ls_result> TYPE zif_abapgit_definitions=>ty_result,
<lv_step_id> TYPE LINE OF zif_abapgit_definitions=>ty_deserialization_step_tt, <lv_step_id> TYPE LINE OF zif_abapgit_definitions=>ty_deserialization_step_tt,
<ls_step> TYPE LINE OF zif_abapgit_definitions=>ty_step_data_tt, <ls_step> TYPE LINE OF zif_abapgit_objects=>ty_step_data_tt,
<ls_deser> TYPE LINE OF zif_abapgit_definitions=>ty_deserialization_tt. <ls_deser> TYPE LINE OF zif_abapgit_objects=>ty_deserialization_tt.
lt_steps = get_deserialize_steps( ). lt_steps = get_deserialize_steps( ).
@ -910,7 +910,7 @@ CLASS ZCL_ABAPGIT_OBJECTS IMPLEMENTATION.
METHOD get_deserialize_steps. METHOD get_deserialize_steps.
FIELD-SYMBOLS: <ls_step> TYPE LINE OF zif_abapgit_definitions=>ty_step_data_tt. FIELD-SYMBOLS: <ls_step> TYPE LINE OF zif_abapgit_objects=>ty_step_data_tt.
APPEND INITIAL LINE TO rt_steps ASSIGNING <ls_step>. APPEND INITIAL LINE TO rt_steps ASSIGNING <ls_step>.
<ls_step>-step_id = zif_abapgit_object=>gc_step_id-ddic. <ls_step>-step_id = zif_abapgit_object=>gc_step_id-ddic.

26
src/objects/zif_abapgit_objects.intf.abap Normal file
View File

@ -0,0 +1,26 @@
INTERFACE zif_abapgit_objects
PUBLIC.
TYPES:
BEGIN OF ty_deserialization,
obj TYPE REF TO zif_abapgit_object,
xml TYPE REF TO zif_abapgit_xml_input,
package TYPE devclass,
item TYPE zif_abapgit_definitions=>ty_item,
END OF ty_deserialization .
TYPES:
ty_deserialization_tt TYPE STANDARD TABLE OF ty_deserialization WITH DEFAULT KEY .
TYPES:
BEGIN OF ty_step_data,
step_id TYPE zif_abapgit_definitions=>ty_deserialization_step,
order TYPE i,
descr TYPE string,
is_ddic TYPE abap_bool,
syntax_check TYPE abap_bool,
objects TYPE ty_deserialization_tt,
END OF ty_step_data .
TYPES:
ty_step_data_tt TYPE STANDARD TABLE OF ty_step_data
WITH DEFAULT KEY .
ENDINTERFACE.

15
src/objects/zif_abapgit_objects.intf.xml Normal file
View File

@ -0,0 +1,15 @@
<?xml version="1.0" encoding="utf-8"?>
<abapGit version="v1.0.0" serializer="LCL_OBJECT_INTF" serializer_version="v1.0.0">
<asx:abap xmlns:asx="http://www.sap.com/abapxml" version="1.0">
<asx:values>
<VSEOINTERF>
<CLSNAME>ZIF_ABAPGIT_OBJECTS</CLSNAME>
<LANGU>E</LANGU>
<DESCRIPT>abapGit: Objects</DESCRIPT>
<EXPOSURE>2</EXPOSURE>
<STATE>1</STATE>
<UNICODE>X</UNICODE>
</VSEOINTERF>
</asx:values>
</asx:abap>
</abapGit>

6
src/ui/zcl_abapgit_gui_router.clas.abap
View File

@ -127,7 +127,7 @@ ENDCLASS.
CLASS zcl_abapgit_gui_router IMPLEMENTATION. CLASS ZCL_ABAPGIT_GUI_ROUTER IMPLEMENTATION.
METHOD abapgit_services_actions. METHOD abapgit_services_actions.
@ -226,7 +226,7 @@ CLASS zcl_abapgit_gui_router IMPLEMENTATION.
DATA: lv_key TYPE zif_abapgit_persistence=>ty_repo-key, DATA: lv_key TYPE zif_abapgit_persistence=>ty_repo-key,
lv_last_repo_key TYPE zif_abapgit_persistence=>ty_repo-key, lv_last_repo_key TYPE zif_abapgit_persistence=>ty_repo-key,
lt_repo_list TYPE zif_abapgit_definitions=>ty_repo_ref_tt. lt_repo_list TYPE zif_abapgit_persistence=>ty_repos.
lv_key = ii_event->query( )->get( 'KEY' ). lv_key = ii_event->query( )->get( 'KEY' ).
@ -234,7 +234,7 @@ CLASS zcl_abapgit_gui_router IMPLEMENTATION.
CASE ii_event->mv_action. CASE ii_event->mv_action.
WHEN zcl_abapgit_gui=>c_action-go_home. WHEN zcl_abapgit_gui=>c_action-go_home.
lv_last_repo_key = zcl_abapgit_persistence_user=>get_instance( )->get_repo_show( ). lv_last_repo_key = zcl_abapgit_persistence_user=>get_instance( )->get_repo_show( ).
lt_repo_list = zcl_abapgit_repo_srv=>get_instance( )->list( ). lt_repo_list = zcl_abapgit_persist_factory=>get_repo( )->list( ).
IF lv_last_repo_key IS NOT INITIAL. IF lv_last_repo_key IS NOT INITIAL.
CREATE OBJECT rs_handled-page TYPE zcl_abapgit_gui_page_repo_view CREATE OBJECT rs_handled-page TYPE zcl_abapgit_gui_page_repo_view

6
src/ui/zcl_abapgit_services_abapgit.clas.abap
View File

@ -60,7 +60,7 @@ ENDCLASS.
CLASS ZCL_ABAPGIT_SERVICES_ABAPGIT IMPLEMENTATION. CLASS zcl_abapgit_services_abapgit IMPLEMENTATION.
METHOD check_sapgui. METHOD check_sapgui.
@ -329,9 +329,9 @@ CLASS ZCL_ABAPGIT_SERVICES_ABAPGIT IMPLEMENTATION.
ls_r_package LIKE LINE OF lt_r_package, ls_r_package LIKE LINE OF lt_r_package,
lt_superpackages TYPE zif_abapgit_sap_package=>ty_devclass_tt, lt_superpackages TYPE zif_abapgit_sap_package=>ty_devclass_tt,
li_package TYPE REF TO zif_abapgit_sap_package, li_package TYPE REF TO zif_abapgit_sap_package,
lt_repo_list TYPE zif_abapgit_definitions=>ty_repo_ref_tt. lt_repo_list TYPE zif_abapgit_repo_srv=>ty_repo_list.
FIELD-SYMBOLS: <lo_repo> TYPE LINE OF zif_abapgit_definitions=>ty_repo_ref_tt, FIELD-SYMBOLS: <lo_repo> TYPE LINE OF zif_abapgit_repo_srv=>ty_repo_list,
<lv_superpackage> LIKE LINE OF lt_superpackages. <lv_superpackage> LIKE LINE OF lt_superpackages.
li_package = zcl_abapgit_factory=>get_sap_package( iv_package ). li_package = zcl_abapgit_factory=>get_sap_package( iv_package ).

4
src/zcl_abapgit_migrations.clas.abap
View File

@ -17,12 +17,12 @@ ENDCLASS.
CLASS ZCL_ABAPGIT_MIGRATIONS IMPLEMENTATION. CLASS zcl_abapgit_migrations IMPLEMENTATION.
METHOD local_dot_abapgit. METHOD local_dot_abapgit.
DATA: lt_repos TYPE zif_abapgit_definitions=>ty_repo_ref_tt, DATA: lt_repos TYPE zif_abapgit_repo_srv=>ty_repo_list,
lo_dot_abapgit TYPE REF TO zcl_abapgit_dot_abapgit. lo_dot_abapgit TYPE REF TO zcl_abapgit_dot_abapgit.
FIELD-SYMBOLS: <lo_repo> LIKE LINE OF lt_repos. FIELD-SYMBOLS: <lo_repo> LIKE LINE OF lt_repos.

6
src/zcl_abapgit_repo_srv.clas.abap
View File

@ -28,7 +28,7 @@ CLASS zcl_abapgit_repo_srv DEFINITION
CLASS-DATA gi_ref TYPE REF TO zif_abapgit_repo_srv . CLASS-DATA gi_ref TYPE REF TO zif_abapgit_repo_srv .
DATA mv_init TYPE abap_bool VALUE abap_false ##NO_TEXT. DATA mv_init TYPE abap_bool VALUE abap_false ##NO_TEXT.
DATA mt_list TYPE zif_abapgit_definitions=>ty_repo_ref_tt . DATA mt_list TYPE zif_abapgit_repo_srv=>ty_repo_list .
METHODS determine_branch_name METHODS determine_branch_name
IMPORTING IMPORTING
@ -76,7 +76,7 @@ ENDCLASS.
CLASS ZCL_ABAPGIT_REPO_SRV IMPLEMENTATION. CLASS zcl_abapgit_repo_srv IMPLEMENTATION.
METHOD add. METHOD add.
@ -336,7 +336,7 @@ CLASS ZCL_ABAPGIT_REPO_SRV IMPLEMENTATION.
METHOD zif_abapgit_repo_srv~is_repo_installed. METHOD zif_abapgit_repo_srv~is_repo_installed.
DATA: lt_repo TYPE zif_abapgit_definitions=>ty_repo_ref_tt, DATA: lt_repo TYPE zif_abapgit_repo_srv=>ty_repo_list,
lo_repo TYPE REF TO zcl_abapgit_repo, lo_repo TYPE REF TO zcl_abapgit_repo,
lv_url TYPE string, lv_url TYPE string,
lv_package TYPE devclass, lv_package TYPE devclass,

23
src/zif_abapgit_definitions.intf.abap
View File

@ -32,8 +32,6 @@ INTERFACE zif_abapgit_definitions
ty_files_tt TYPE STANDARD TABLE OF ty_file WITH DEFAULT KEY . ty_files_tt TYPE STANDARD TABLE OF ty_file WITH DEFAULT KEY .
TYPES: TYPES:
ty_string_tt TYPE STANDARD TABLE OF string WITH DEFAULT KEY . ty_string_tt TYPE STANDARD TABLE OF string WITH DEFAULT KEY .
TYPES:
ty_repo_ref_tt TYPE STANDARD TABLE OF REF TO zcl_abapgit_repo WITH DEFAULT KEY .
TYPES ty_git_branch_type TYPE c LENGTH 2 . TYPES ty_git_branch_type TYPE c LENGTH 2 .
TYPES: TYPES:
BEGIN OF ty_git_branch, BEGIN OF ty_git_branch,
@ -359,32 +357,11 @@ INTERFACE zif_abapgit_definitions
length TYPE lvc_outlen, length TYPE lvc_outlen,
END OF ty_alv_column, END OF ty_alv_column,
ty_alv_column_tt TYPE TABLE OF ty_alv_column WITH DEFAULT KEY. ty_alv_column_tt TYPE TABLE OF ty_alv_column WITH DEFAULT KEY.
TYPES:
BEGIN OF ty_deserialization,
obj TYPE REF TO zif_abapgit_object,
xml TYPE REF TO zif_abapgit_xml_input,
package TYPE devclass,
item TYPE ty_item,
END OF ty_deserialization .
TYPES:
ty_deserialization_tt TYPE STANDARD TABLE OF ty_deserialization WITH DEFAULT KEY .
TYPES: TYPES:
ty_deserialization_step TYPE string. ty_deserialization_step TYPE string.
TYPES: TYPES:
ty_deserialization_step_tt TYPE STANDARD TABLE OF ty_deserialization_step ty_deserialization_step_tt TYPE STANDARD TABLE OF ty_deserialization_step
WITH DEFAULT KEY . WITH DEFAULT KEY .
TYPES:
BEGIN OF ty_step_data,
step_id TYPE ty_deserialization_step,
order TYPE i,
descr TYPE string,
is_ddic TYPE abap_bool,
syntax_check TYPE abap_bool,
objects TYPE ty_deserialization_tt,
END OF ty_step_data .
TYPES:
ty_step_data_tt TYPE STANDARD TABLE OF ty_step_data
WITH DEFAULT KEY .
TYPES: TYPES:
ty_object_type_range TYPE RANGE OF trobjtype, ty_object_type_range TYPE RANGE OF trobjtype,
ty_object_name_range TYPE RANGE OF sobj_name. ty_object_name_range TYPE RANGE OF sobj_name.

2
src/zif_abapgit_exit.intf.abap
View File

@ -62,7 +62,7 @@ INTERFACE zif_abapgit_exit
zcx_abapgit_exception . zcx_abapgit_exception .
METHODS deserialize_postprocess METHODS deserialize_postprocess
IMPORTING IMPORTING
!is_step TYPE zif_abapgit_definitions=>ty_step_data !is_step TYPE zif_abapgit_objects=>ty_step_data
!ii_log TYPE REF TO zif_abapgit_log . !ii_log TYPE REF TO zif_abapgit_log .
METHODS get_ci_tests METHODS get_ci_tests
IMPORTING IMPORTING

7
src/zif_abapgit_repo_srv.intf.abap
View File

@ -1,5 +1,8 @@
INTERFACE zif_abapgit_repo_srv INTERFACE zif_abapgit_repo_srv
PUBLIC . PUBLIC.
TYPES:
ty_repo_list TYPE STANDARD TABLE OF REF TO zcl_abapgit_repo WITH DEFAULT KEY.
METHODS delete METHODS delete
IMPORTING IMPORTING
@ -23,7 +26,7 @@ INTERFACE zif_abapgit_repo_srv
zcx_abapgit_exception . zcx_abapgit_exception .
METHODS list METHODS list
RETURNING RETURNING
VALUE(rt_list) TYPE zif_abapgit_definitions=>ty_repo_ref_tt VALUE(rt_list) TYPE ty_repo_list
RAISING RAISING
zcx_abapgit_exception . zcx_abapgit_exception .
METHODS new_offline METHODS new_offline