SAP/abapGit
1
0
Fork 0
mirror of https://github.com/abapGit/abapGit.git synced 2025-04-30 20:03:20 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Adjustments to Debug Info (#4459)

Browse Source 
* Adjustments to Debug Info

- Fix display of abapGit installation package (side-effect of changed package assignment)
- Clarify that list of supported objects is relevant for the local system only (since it's release dependent)
- Add link to complete list of supported objects

* Remove pragmas
This commit is contained in:
Marc Bernard 2021-01-27 03:23:44 -05:00 committed by GitHub
parent 212f9f8da2
commit eb4986389e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 20 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/ui/zcl_abapgit_gui_page_debuginfo.clas.abap
View File

@ -37,7 +37,7 @@ ENDCLASS.
CLASS ZCL_ABAPGIT_GUI_PAGE_DEBUGINFO IMPLEMENTATION.
CLASS zcl_abapgit_gui_page_debuginfo IMPLEMENTATION.
METHOD constructor.
@ -116,13 +116,13 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_DEBUGINFO IMPLEMENTATION.
ri_html->add( 'abapGit installed in package ' ).
ri_html->add( lv_devclass ).
ELSE.
ri_html->add_a( iv_txt = 'install abapGit repo'
ri_html->add_a( iv_txt = 'Install abapGit repository'
iv_act = zif_abapgit_definitions=>c_action-abapgit_install ).
ri_html->add( ' - To keep abapGit up-to-date (or also to contribute) you need to' ).
ri_html->add( 'install it as a repository.' ).
ENDIF.
ri_html->add( |<br>| ).
ri_html->add( |<br><br>| ).
ENDMETHOD.
@ -141,6 +141,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_DEBUGINFO IMPLEMENTATION.
METHOD render_supported_object_types.
DATA: lv_list TYPE string,
li_html TYPE REF TO zif_abapgit_html,
lt_types TYPE zcl_abapgit_objects=>ty_types_tt,
lv_type LIKE LINE OF lt_types,
lt_obj TYPE STANDARD TABLE OF ko100 WITH DEFAULT KEY,
@ -159,7 +160,14 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_DEBUGINFO IMPLEMENTATION.
lt_types = zcl_abapgit_objects=>supported_list( ).
rv_html = |<p>Supported objects: { lv_list }</p>|.
CREATE OBJECT li_html TYPE zcl_abapgit_html.
rv_html = li_html->a(
iv_txt = 'Complete list of object types supported by abapGit'
iv_act = 'https://docs.abapgit.org/ref-supported.html'
iv_typ = zif_abapgit_html=>c_action_type-url ).
rv_html = rv_html && |<br><br>Supported object types in <strong>this</strong> system:<br><br>|.
rv_html = rv_html && |<table border="1px"><thead><tr>|.
rv_html = rv_html && |<td>Object</td><td>Description</td><td>Class</td><td>Version</td><td>DDIC</td>|.

16
src/ui/zcl_abapgit_services_abapgit.clas.abap
View File

@ -5,13 +5,13 @@ CLASS zcl_abapgit_services_abapgit DEFINITION
PUBLIC SECTION.
CONSTANTS: c_abapgit_repo TYPE string VALUE 'https://github.com/abapGit/abapGit' ##NO_TEXT,
c_abapgit_homepage TYPE string VALUE 'https://www.abapgit.org' ##NO_TEXT,
c_abapgit_wikipage TYPE string VALUE 'https://docs.abapgit.org' ##NO_TEXT,
c_dotabap_homepage TYPE string VALUE 'https://dotabap.org' ##NO_TEXT,
c_abapgit_package TYPE devclass VALUE '$ABAPGIT' ##NO_TEXT,
c_abapgit_url TYPE string VALUE 'https://github.com/abapGit/abapGit.git' ##NO_TEXT,
c_abapgit_class TYPE tcode VALUE `ZCL_ABAPGIT_REPO` ##NO_TEXT.
CONSTANTS c_abapgit_repo TYPE string VALUE 'https://github.com/abapGit/abapGit'.
CONSTANTS c_abapgit_homepage TYPE string VALUE 'https://www.abapgit.org'.
CONSTANTS c_abapgit_wikipage TYPE string VALUE 'https://docs.abapgit.org'.
CONSTANTS c_dotabap_homepage TYPE string VALUE 'https://dotabap.org'.
CONSTANTS c_abapgit_package TYPE devclass VALUE '$ABAPGIT'.
CONSTANTS c_abapgit_url TYPE string VALUE 'https://github.com/abapGit/abapGit.git'.
CONSTANTS c_abapgit_class TYPE seoclsname VALUE `ZCX_ABAPGIT_EXCEPTION`.
CLASS-METHODS open_abapgit_homepage
RAISING
@ -205,7 +205,7 @@ CLASS zcl_abapgit_services_abapgit IMPLEMENTATION.
DATA lv_text TYPE c LENGTH 100.
IF NOT is_installed( ) IS INITIAL.
lv_text = 'Seems like abapGit package is already installed. No changes to be done'.
lv_text = 'Seems like abapGit (developer version) is already installed. No changes to be done'.
zcl_abapgit_ui_factory=>get_popups( )->popup_to_inform(
iv_titlebar = lc_title
iv_text_message = lv_text ).