mirror of
https://github.com/abapGit/abapGit.git
synced 2025-05-02 04:36:49 +08:00
refactoring, delete unused variables and methods (#3203)
* zlib * xml * processor * shi5 * remove unused filter parameter * pinf cleanup * ssfo delete empty method * highlighter * gui page res, remove unused * remove unused in diff class * adt link * gui, remove 2 unused parameters * branch overview
This commit is contained in:
parent
136dfaf8d3
commit
eb7e819b25
|
@ -31,7 +31,6 @@ CLASS zcl_abapgit_git_transport DEFINITION
|
||||||
CLASS-METHODS branches
|
CLASS-METHODS branches
|
||||||
IMPORTING
|
IMPORTING
|
||||||
!iv_url TYPE string
|
!iv_url TYPE string
|
||||||
!iv_filter TYPE abap_bool DEFAULT abap_true
|
|
||||||
RETURNING
|
RETURNING
|
||||||
VALUE(ro_branch_list) TYPE REF TO zcl_abapgit_git_branch_list
|
VALUE(ro_branch_list) TYPE REF TO zcl_abapgit_git_branch_list
|
||||||
RAISING
|
RAISING
|
||||||
|
|
|
@ -2,8 +2,6 @@ INTERFACE lif_package_interface_facade.
|
||||||
|
|
||||||
METHODS:
|
METHODS:
|
||||||
get_elements
|
get_elements
|
||||||
IMPORTING
|
|
||||||
iv_with_deleted_elements TYPE flag DEFAULT 'X'
|
|
||||||
EXPORTING
|
EXPORTING
|
||||||
et_elements TYPE tpak_package_interf_elem_list
|
et_elements TYPE tpak_package_interf_elem_list
|
||||||
RAISING
|
RAISING
|
||||||
|
@ -16,9 +14,6 @@ INTERFACE lif_package_interface_facade.
|
||||||
zcx_abapgit_exception,
|
zcx_abapgit_exception,
|
||||||
|
|
||||||
save_elements
|
save_elements
|
||||||
IMPORTING
|
|
||||||
iv_transport_request TYPE trkorr OPTIONAL
|
|
||||||
iv_suppress_dialog TYPE flag DEFAULT ' '
|
|
||||||
RAISING
|
RAISING
|
||||||
zcx_abapgit_exception,
|
zcx_abapgit_exception,
|
||||||
|
|
||||||
|
@ -35,15 +30,10 @@ INTERFACE lif_package_interface_facade.
|
||||||
zcx_abapgit_exception,
|
zcx_abapgit_exception,
|
||||||
|
|
||||||
delete
|
delete
|
||||||
IMPORTING
|
|
||||||
iv_suppress_dialog TYPE flag DEFAULT abap_false
|
|
||||||
RAISING
|
RAISING
|
||||||
zcx_abapgit_exception,
|
zcx_abapgit_exception,
|
||||||
|
|
||||||
save
|
save
|
||||||
IMPORTING
|
|
||||||
iv_transport_request TYPE trkorr OPTIONAL
|
|
||||||
iv_suppress_dialog TYPE flag DEFAULT ' '
|
|
||||||
RAISING
|
RAISING
|
||||||
zcx_abapgit_exception,
|
zcx_abapgit_exception,
|
||||||
|
|
||||||
|
|
|
@ -26,7 +26,7 @@ ENDCLASS.
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
CLASS zcl_abapgit_object_shi5 IMPLEMENTATION.
|
CLASS ZCL_ABAPGIT_OBJECT_SHI5 IMPLEMENTATION.
|
||||||
|
|
||||||
|
|
||||||
METHOD constructor.
|
METHOD constructor.
|
||||||
|
@ -138,12 +138,7 @@ CLASS zcl_abapgit_object_shi5 IMPLEMENTATION.
|
||||||
|
|
||||||
METHOD zif_abapgit_object~serialize.
|
METHOD zif_abapgit_object~serialize.
|
||||||
|
|
||||||
DATA: ls_extension TYPE ty_extension,
|
DATA: ls_extension TYPE ty_extension.
|
||||||
lt_struc_id TYPE STANDARD TABLE OF hier_guid,
|
|
||||||
lv_struc_id TYPE hier_guid,
|
|
||||||
lt_nodes TYPE TABLE OF hier_iface,
|
|
||||||
lt_texts TYPE TABLE OF hier_texts,
|
|
||||||
lt_refs TYPE TABLE OF hier_ref.
|
|
||||||
|
|
||||||
CALL FUNCTION 'STREE_EXTENSION_EXISTS'
|
CALL FUNCTION 'STREE_EXTENSION_EXISTS'
|
||||||
EXPORTING
|
EXPORTING
|
||||||
|
@ -163,6 +158,4 @@ CLASS zcl_abapgit_object_shi5 IMPLEMENTATION.
|
||||||
ig_data = ls_extension ).
|
ig_data = ls_extension ).
|
||||||
|
|
||||||
ENDMETHOD.
|
ENDMETHOD.
|
||||||
|
|
||||||
|
|
||||||
ENDCLASS.
|
ENDCLASS.
|
||||||
|
|
|
@ -6,24 +6,35 @@ CLASS zcl_abapgit_object_ssfo DEFINITION PUBLIC INHERITING FROM zcl_abapgit_obje
|
||||||
|
|
||||||
PROTECTED SECTION.
|
PROTECTED SECTION.
|
||||||
PRIVATE SECTION.
|
PRIVATE SECTION.
|
||||||
TYPES: ty_string_range TYPE RANGE OF string.
|
|
||||||
|
|
||||||
CLASS-DATA: gt_range_node_codes TYPE ty_string_range.
|
TYPES:
|
||||||
CONSTANTS: attrib_abapgit_leadig_spaces TYPE string VALUE 'abapgit-leadig-spaces' ##NO_TEXT.
|
ty_string_range TYPE RANGE OF string .
|
||||||
|
|
||||||
METHODS fix_ids IMPORTING ii_xml_doc TYPE REF TO if_ixml_document.
|
CLASS-DATA gt_range_node_codes TYPE ty_string_range .
|
||||||
METHODS set_attribute_leading_spaces IMPORTING iv_name TYPE string
|
CONSTANTS attrib_abapgit_leadig_spaces TYPE string VALUE 'abapgit-leadig-spaces' ##NO_TEXT.
|
||||||
ii_node TYPE REF TO if_ixml_node
|
|
||||||
CHANGING cv_within_code_section TYPE abap_bool.
|
METHODS fix_ids
|
||||||
METHODS handle_attrib_leading_spaces IMPORTING iv_name TYPE string
|
IMPORTING
|
||||||
ii_node TYPE REF TO if_ixml_node
|
!ii_xml_doc TYPE REF TO if_ixml_document .
|
||||||
CHANGING cv_within_code_section TYPE abap_bool.
|
METHODS handle_attrib_leading_spaces
|
||||||
METHODS get_range_node_codes RETURNING VALUE(rt_range_node_codes) TYPE ty_string_range.
|
IMPORTING
|
||||||
METHODS code_item_section_handling IMPORTING iv_name TYPE string
|
!iv_name TYPE string
|
||||||
ii_node TYPE REF TO if_ixml_node
|
!ii_node TYPE REF TO if_ixml_node
|
||||||
EXPORTING ei_code_item_element TYPE REF TO if_ixml_element
|
CHANGING
|
||||||
CHANGING cv_within_code_section TYPE abap_bool
|
!cv_within_code_section TYPE abap_bool .
|
||||||
RAISING zcx_abapgit_exception.
|
METHODS get_range_node_codes
|
||||||
|
RETURNING
|
||||||
|
VALUE(rt_range_node_codes) TYPE ty_string_range .
|
||||||
|
METHODS code_item_section_handling
|
||||||
|
IMPORTING
|
||||||
|
!iv_name TYPE string
|
||||||
|
!ii_node TYPE REF TO if_ixml_node
|
||||||
|
EXPORTING
|
||||||
|
!ei_code_item_element TYPE REF TO if_ixml_element
|
||||||
|
CHANGING
|
||||||
|
!cv_within_code_section TYPE abap_bool
|
||||||
|
RAISING
|
||||||
|
zcx_abapgit_exception .
|
||||||
ENDCLASS.
|
ENDCLASS.
|
||||||
|
|
||||||
|
|
||||||
|
@ -179,13 +190,6 @@ CLASS ZCL_ABAPGIT_OBJECT_SSFO IMPLEMENTATION.
|
||||||
ENDMETHOD.
|
ENDMETHOD.
|
||||||
|
|
||||||
|
|
||||||
METHOD set_attribute_leading_spaces.
|
|
||||||
|
|
||||||
RETURN.
|
|
||||||
|
|
||||||
ENDMETHOD.
|
|
||||||
|
|
||||||
|
|
||||||
METHOD zif_abapgit_object~changed_by.
|
METHOD zif_abapgit_object~changed_by.
|
||||||
|
|
||||||
SELECT SINGLE lastuser FROM stxfadm INTO rv_user
|
SELECT SINGLE lastuser FROM stxfadm INTO rv_user
|
||||||
|
@ -439,10 +443,6 @@ CLASS ZCL_ABAPGIT_OBJECT_SSFO IMPLEMENTATION.
|
||||||
OR lv_name = 'LASTUSER'.
|
OR lv_name = 'LASTUSER'.
|
||||||
li_node->set_value( 'DUMMY' ).
|
li_node->set_value( 'DUMMY' ).
|
||||||
ENDIF.
|
ENDIF.
|
||||||
set_attribute_leading_spaces( EXPORTING iv_name = lv_name
|
|
||||||
ii_node = li_node
|
|
||||||
CHANGING cv_within_code_section = lv_within_code_section ).
|
|
||||||
|
|
||||||
li_node = li_iterator->get_next( ).
|
li_node = li_iterator->get_next( ).
|
||||||
ENDWHILE.
|
ENDWHILE.
|
||||||
|
|
||||||
|
|
|
@ -85,11 +85,12 @@ CLASS zcl_abapgit_objects_super DEFINITION PUBLIC ABSTRACT.
|
||||||
RAISING
|
RAISING
|
||||||
zcx_abapgit_exception .
|
zcx_abapgit_exception .
|
||||||
|
|
||||||
|
PRIVATE SECTION.
|
||||||
ENDCLASS.
|
ENDCLASS.
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
CLASS zcl_abapgit_objects_super IMPLEMENTATION.
|
CLASS ZCL_ABAPGIT_OBJECTS_SUPER IMPLEMENTATION.
|
||||||
|
|
||||||
|
|
||||||
METHOD check_timestamp.
|
METHOD check_timestamp.
|
||||||
|
@ -205,7 +206,6 @@ CLASS zcl_abapgit_objects_super IMPLEMENTATION.
|
||||||
ENDMETHOD.
|
ENDMETHOD.
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
METHOD get_metadata.
|
METHOD get_metadata.
|
||||||
|
|
||||||
DATA: lv_class TYPE string.
|
DATA: lv_class TYPE string.
|
||||||
|
@ -251,17 +251,16 @@ CLASS zcl_abapgit_objects_super IMPLEMENTATION.
|
||||||
|
|
||||||
METHOD jump_adt.
|
METHOD jump_adt.
|
||||||
|
|
||||||
DATA: lv_adt_link TYPE string,
|
DATA: lv_adt_link TYPE string,
|
||||||
lx_error TYPE REF TO cx_root.
|
lx_error TYPE REF TO cx_root.
|
||||||
|
|
||||||
TRY.
|
TRY.
|
||||||
|
|
||||||
lv_adt_link = zcl_abapgit_adt_link=>generate(
|
lv_adt_link = zcl_abapgit_adt_link=>generate(
|
||||||
iv_obj_name = iv_obj_name
|
iv_obj_name = iv_obj_name
|
||||||
iv_obj_type = iv_obj_type
|
iv_obj_type = iv_obj_type
|
||||||
iv_sub_obj_name = iv_sub_obj_name
|
iv_sub_obj_name = iv_sub_obj_name
|
||||||
iv_sub_obj_type = iv_sub_obj_type
|
iv_line_number = iv_line_number ).
|
||||||
iv_line_number = iv_line_number ).
|
|
||||||
|
|
||||||
cl_gui_frontend_services=>execute(
|
cl_gui_frontend_services=>execute(
|
||||||
EXPORTING document = lv_adt_link
|
EXPORTING document = lv_adt_link
|
||||||
|
|
|
@ -12,8 +12,7 @@ CLASS ltcl_syntax_cases DEFINITION FINAL FOR TESTING RISK LEVEL HARMLESS
|
||||||
DATA:
|
DATA:
|
||||||
mt_after_parse TYPE zcl_abapgit_syntax_highlighter=>ty_match_tt,
|
mt_after_parse TYPE zcl_abapgit_syntax_highlighter=>ty_match_tt,
|
||||||
mt_after_order TYPE zcl_abapgit_syntax_highlighter=>ty_match_tt,
|
mt_after_order TYPE zcl_abapgit_syntax_highlighter=>ty_match_tt,
|
||||||
mt_after_extend TYPE zcl_abapgit_syntax_highlighter=>ty_match_tt,
|
mt_after_extend TYPE zcl_abapgit_syntax_highlighter=>ty_match_tt.
|
||||||
ms_match TYPE zcl_abapgit_syntax_highlighter=>ty_match.
|
|
||||||
|
|
||||||
METHODS:
|
METHODS:
|
||||||
do_test IMPORTING iv_line TYPE string
|
do_test IMPORTING iv_line TYPE string
|
||||||
|
|
|
@ -106,20 +106,17 @@ CLASS zcl_abapgit_gui DEFINITION
|
||||||
METHODS handle_action
|
METHODS handle_action
|
||||||
IMPORTING
|
IMPORTING
|
||||||
iv_action TYPE c
|
iv_action TYPE c
|
||||||
iv_frame TYPE c OPTIONAL
|
|
||||||
iv_getdata TYPE c OPTIONAL
|
iv_getdata TYPE c OPTIONAL
|
||||||
it_postdata TYPE cnht_post_data_tab OPTIONAL
|
it_postdata TYPE cnht_post_data_tab OPTIONAL.
|
||||||
it_query_table TYPE cnht_query_table OPTIONAL.
|
|
||||||
|
|
||||||
METHODS handle_error
|
METHODS handle_error
|
||||||
IMPORTING
|
IMPORTING
|
||||||
ix_exception TYPE REF TO zcx_abapgit_exception.
|
ix_exception TYPE REF TO zcx_abapgit_exception.
|
||||||
|
|
||||||
ENDCLASS.
|
ENDCLASS.
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
CLASS zcl_abapgit_gui IMPLEMENTATION.
|
CLASS ZCL_ABAPGIT_GUI IMPLEMENTATION.
|
||||||
|
|
||||||
|
|
||||||
METHOD back.
|
METHOD back.
|
||||||
|
@ -154,6 +151,45 @@ CLASS zcl_abapgit_gui IMPLEMENTATION.
|
||||||
ENDMETHOD.
|
ENDMETHOD.
|
||||||
|
|
||||||
|
|
||||||
|
METHOD cache_asset.
|
||||||
|
|
||||||
|
DATA: lv_xstr TYPE xstring,
|
||||||
|
lt_xdata TYPE lvc_t_mime,
|
||||||
|
lv_size TYPE int4.
|
||||||
|
|
||||||
|
ASSERT iv_text IS SUPPLIED OR iv_xdata IS SUPPLIED.
|
||||||
|
|
||||||
|
IF iv_text IS SUPPLIED. " String input
|
||||||
|
lv_xstr = zcl_abapgit_convert=>string_to_xstring( iv_text ).
|
||||||
|
ELSE. " Raw input
|
||||||
|
lv_xstr = iv_xdata.
|
||||||
|
ENDIF.
|
||||||
|
|
||||||
|
zcl_abapgit_convert=>xstring_to_bintab(
|
||||||
|
EXPORTING
|
||||||
|
iv_xstr = lv_xstr
|
||||||
|
IMPORTING
|
||||||
|
ev_size = lv_size
|
||||||
|
et_bintab = lt_xdata ).
|
||||||
|
|
||||||
|
mo_html_viewer->load_data(
|
||||||
|
EXPORTING
|
||||||
|
type = iv_type
|
||||||
|
subtype = iv_subtype
|
||||||
|
size = lv_size
|
||||||
|
url = iv_url
|
||||||
|
IMPORTING
|
||||||
|
assigned_url = rv_url
|
||||||
|
CHANGING
|
||||||
|
data_table = lt_xdata
|
||||||
|
EXCEPTIONS
|
||||||
|
OTHERS = 1 ) ##NO_TEXT.
|
||||||
|
|
||||||
|
ASSERT sy-subrc = 0. " Image data error
|
||||||
|
|
||||||
|
ENDMETHOD.
|
||||||
|
|
||||||
|
|
||||||
METHOD cache_html.
|
METHOD cache_html.
|
||||||
|
|
||||||
rv_url = cache_asset(
|
rv_url = cache_asset(
|
||||||
|
@ -314,14 +350,35 @@ CLASS zcl_abapgit_gui IMPLEMENTATION.
|
||||||
ENDMETHOD.
|
ENDMETHOD.
|
||||||
|
|
||||||
|
|
||||||
|
METHOD handle_error.
|
||||||
|
|
||||||
|
DATA: li_gui_error_handler TYPE REF TO zif_abapgit_gui_error_handler,
|
||||||
|
lx_exception TYPE REF TO cx_root.
|
||||||
|
|
||||||
|
TRY.
|
||||||
|
li_gui_error_handler ?= mi_cur_page.
|
||||||
|
|
||||||
|
IF li_gui_error_handler->handle_error( ix_exception ) = abap_true.
|
||||||
|
" We rerender the current page to display the error box
|
||||||
|
render( ).
|
||||||
|
ELSE.
|
||||||
|
MESSAGE ix_exception TYPE 'S' DISPLAY LIKE 'E'.
|
||||||
|
ENDIF.
|
||||||
|
|
||||||
|
CATCH zcx_abapgit_exception cx_sy_move_cast_error INTO lx_exception.
|
||||||
|
" In case of fire we just fallback to plain old message
|
||||||
|
MESSAGE lx_exception TYPE 'S' DISPLAY LIKE 'E'.
|
||||||
|
ENDTRY.
|
||||||
|
|
||||||
|
ENDMETHOD.
|
||||||
|
|
||||||
|
|
||||||
METHOD on_event.
|
METHOD on_event.
|
||||||
|
|
||||||
handle_action(
|
handle_action(
|
||||||
iv_action = action
|
iv_action = action
|
||||||
iv_frame = frame
|
iv_getdata = getdata
|
||||||
iv_getdata = getdata
|
it_postdata = postdata ).
|
||||||
it_postdata = postdata
|
|
||||||
it_query_table = query_table ).
|
|
||||||
|
|
||||||
ENDMETHOD.
|
ENDMETHOD.
|
||||||
|
|
||||||
|
@ -382,66 +439,4 @@ CLASS zcl_abapgit_gui IMPLEMENTATION.
|
||||||
SET HANDLER me->on_event FOR mo_html_viewer.
|
SET HANDLER me->on_event FOR mo_html_viewer.
|
||||||
|
|
||||||
ENDMETHOD.
|
ENDMETHOD.
|
||||||
|
|
||||||
|
|
||||||
METHOD cache_asset.
|
|
||||||
|
|
||||||
DATA: lv_xstr TYPE xstring,
|
|
||||||
lt_xdata TYPE lvc_t_mime,
|
|
||||||
lv_size TYPE int4.
|
|
||||||
|
|
||||||
ASSERT iv_text IS SUPPLIED OR iv_xdata IS SUPPLIED.
|
|
||||||
|
|
||||||
IF iv_text IS SUPPLIED. " String input
|
|
||||||
lv_xstr = zcl_abapgit_convert=>string_to_xstring( iv_text ).
|
|
||||||
ELSE. " Raw input
|
|
||||||
lv_xstr = iv_xdata.
|
|
||||||
ENDIF.
|
|
||||||
|
|
||||||
zcl_abapgit_convert=>xstring_to_bintab(
|
|
||||||
EXPORTING
|
|
||||||
iv_xstr = lv_xstr
|
|
||||||
IMPORTING
|
|
||||||
ev_size = lv_size
|
|
||||||
et_bintab = lt_xdata ).
|
|
||||||
|
|
||||||
mo_html_viewer->load_data(
|
|
||||||
EXPORTING
|
|
||||||
type = iv_type
|
|
||||||
subtype = iv_subtype
|
|
||||||
size = lv_size
|
|
||||||
url = iv_url
|
|
||||||
IMPORTING
|
|
||||||
assigned_url = rv_url
|
|
||||||
CHANGING
|
|
||||||
data_table = lt_xdata
|
|
||||||
EXCEPTIONS
|
|
||||||
OTHERS = 1 ) ##NO_TEXT.
|
|
||||||
|
|
||||||
ASSERT sy-subrc = 0. " Image data error
|
|
||||||
|
|
||||||
ENDMETHOD.
|
|
||||||
|
|
||||||
METHOD handle_error.
|
|
||||||
|
|
||||||
DATA: li_gui_error_handler TYPE REF TO zif_abapgit_gui_error_handler,
|
|
||||||
lx_exception TYPE REF TO cx_root.
|
|
||||||
|
|
||||||
TRY.
|
|
||||||
li_gui_error_handler ?= mi_cur_page.
|
|
||||||
|
|
||||||
IF li_gui_error_handler->handle_error( ix_exception ) = abap_true.
|
|
||||||
" We rerender the current page to display the error box
|
|
||||||
render( ).
|
|
||||||
ELSE.
|
|
||||||
MESSAGE ix_exception TYPE 'S' DISPLAY LIKE 'E'.
|
|
||||||
ENDIF.
|
|
||||||
|
|
||||||
CATCH zcx_abapgit_exception cx_sy_move_cast_error INTO lx_exception.
|
|
||||||
" In case of fire we just fallback to plain old message
|
|
||||||
MESSAGE lx_exception TYPE 'S' DISPLAY LIKE 'E'.
|
|
||||||
ENDTRY.
|
|
||||||
|
|
||||||
ENDMETHOD.
|
|
||||||
|
|
||||||
ENDCLASS.
|
ENDCLASS.
|
||||||
|
|
|
@ -26,8 +26,6 @@ CLASS ltcl_test_base IMPLEMENTATION.
|
||||||
ENDMETHOD.
|
ENDMETHOD.
|
||||||
|
|
||||||
METHOD add_file.
|
METHOD add_file.
|
||||||
DATA: ls_asset TYPE zif_abapgit_gui_asset_manager=>ty_web_asset.
|
|
||||||
|
|
||||||
mo_asset_manager->register_asset(
|
mo_asset_manager->register_asset(
|
||||||
iv_url = iv_url
|
iv_url = iv_url
|
||||||
iv_type = 'text/css'
|
iv_type = 'text/css'
|
||||||
|
@ -75,7 +73,7 @@ CLASS ltcl_single_file IMPLEMENTATION.
|
||||||
TRY.
|
TRY.
|
||||||
mo_cut->process( ).
|
mo_cut->process( ).
|
||||||
cl_abap_unit_assert=>fail( ). " Assetman fails on empty content
|
cl_abap_unit_assert=>fail( ). " Assetman fails on empty content
|
||||||
CATCH zcx_abapgit_exception.
|
CATCH zcx_abapgit_exception ##NO_HANDLER.
|
||||||
ENDTRY.
|
ENDTRY.
|
||||||
ENDMETHOD.
|
ENDMETHOD.
|
||||||
|
|
||||||
|
|
|
@ -61,8 +61,6 @@ CLASS zcl_abapgit_gui_page_merge_res DEFINITION
|
||||||
RAISING
|
RAISING
|
||||||
zcx_abapgit_exception .
|
zcx_abapgit_exception .
|
||||||
METHODS build_menu
|
METHODS build_menu
|
||||||
IMPORTING
|
|
||||||
VALUE(iv_with_conflict) TYPE abap_bool OPTIONAL
|
|
||||||
RETURNING
|
RETURNING
|
||||||
VALUE(ro_menu) TYPE REF TO zcl_abapgit_html_toolbar .
|
VALUE(ro_menu) TYPE REF TO zcl_abapgit_html_toolbar .
|
||||||
METHODS is_binary
|
METHODS is_binary
|
||||||
|
@ -97,7 +95,6 @@ CLASS zcl_abapgit_gui_page_merge_res DEFINITION
|
||||||
METHODS render_line_split
|
METHODS render_line_split
|
||||||
IMPORTING
|
IMPORTING
|
||||||
!is_diff_line TYPE zif_abapgit_definitions=>ty_diff
|
!is_diff_line TYPE zif_abapgit_definitions=>ty_diff
|
||||||
!iv_fstate TYPE char1
|
|
||||||
RETURNING
|
RETURNING
|
||||||
VALUE(ro_html) TYPE REF TO zcl_abapgit_html .
|
VALUE(ro_html) TYPE REF TO zcl_abapgit_html .
|
||||||
METHODS render_table_head
|
METHODS render_table_head
|
||||||
|
@ -394,8 +391,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_MERGE_RES IMPLEMENTATION.
|
||||||
CONDENSE <ls_diff>-new_num. "get rid of leading spaces
|
CONDENSE <ls_diff>-new_num. "get rid of leading spaces
|
||||||
CONDENSE <ls_diff>-old_num.
|
CONDENSE <ls_diff>-old_num.
|
||||||
|
|
||||||
ro_html->add( render_line_split( is_diff_line = <ls_diff>
|
ro_html->add( render_line_split( is_diff_line = <ls_diff> ) ).
|
||||||
iv_fstate = is_diff-fstate ) ).
|
|
||||||
|
|
||||||
ENDLOOP.
|
ENDLOOP.
|
||||||
|
|
||||||
|
|
|
@ -1,17 +1,20 @@
|
||||||
CLASS zcl_abapgit_adt_link DEFINITION
|
CLASS zcl_abapgit_adt_link DEFINITION
|
||||||
PUBLIC FINAL.
|
PUBLIC
|
||||||
|
FINAL
|
||||||
|
CREATE PUBLIC .
|
||||||
|
|
||||||
PUBLIC SECTION.
|
PUBLIC SECTION.
|
||||||
CLASS-METHODS:
|
|
||||||
generate
|
|
||||||
IMPORTING iv_obj_name TYPE zif_abapgit_definitions=>ty_item-obj_name
|
|
||||||
iv_obj_type TYPE zif_abapgit_definitions=>ty_item-obj_type
|
|
||||||
iv_sub_obj_name TYPE zif_abapgit_definitions=>ty_item-obj_name OPTIONAL
|
|
||||||
iv_sub_obj_type TYPE zif_abapgit_definitions=>ty_item-obj_type OPTIONAL
|
|
||||||
iv_line_number TYPE i OPTIONAL
|
|
||||||
RETURNING VALUE(rv_result) TYPE string
|
|
||||||
RAISING zcx_abapgit_exception.
|
|
||||||
|
|
||||||
|
CLASS-METHODS generate
|
||||||
|
IMPORTING
|
||||||
|
!iv_obj_name TYPE zif_abapgit_definitions=>ty_item-obj_name
|
||||||
|
!iv_obj_type TYPE zif_abapgit_definitions=>ty_item-obj_type
|
||||||
|
!iv_sub_obj_name TYPE zif_abapgit_definitions=>ty_item-obj_name OPTIONAL
|
||||||
|
!iv_line_number TYPE i OPTIONAL
|
||||||
|
RETURNING
|
||||||
|
VALUE(rv_result) TYPE string
|
||||||
|
RAISING
|
||||||
|
zcx_abapgit_exception .
|
||||||
PROTECTED SECTION.
|
PROTECTED SECTION.
|
||||||
PRIVATE SECTION.
|
PRIVATE SECTION.
|
||||||
CLASS-METHODS:
|
CLASS-METHODS:
|
||||||
|
@ -37,7 +40,8 @@ ENDCLASS.
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
CLASS zcl_abapgit_adt_link IMPLEMENTATION.
|
CLASS ZCL_ABAPGIT_ADT_LINK IMPLEMENTATION.
|
||||||
|
|
||||||
|
|
||||||
METHOD generate.
|
METHOD generate.
|
||||||
|
|
||||||
|
@ -154,6 +158,7 @@ CLASS zcl_abapgit_adt_link IMPLEMENTATION.
|
||||||
|
|
||||||
ENDMETHOD.
|
ENDMETHOD.
|
||||||
|
|
||||||
|
|
||||||
METHOD is_adt_jump_possible.
|
METHOD is_adt_jump_possible.
|
||||||
|
|
||||||
DATA: lo_wb_request TYPE REF TO cl_wb_request,
|
DATA: lo_wb_request TYPE REF TO cl_wb_request,
|
||||||
|
@ -196,5 +201,4 @@ CLASS zcl_abapgit_adt_link IMPLEMENTATION.
|
||||||
ENDTRY.
|
ENDTRY.
|
||||||
|
|
||||||
ENDMETHOD.
|
ENDMETHOD.
|
||||||
|
|
||||||
ENDCLASS.
|
ENDCLASS.
|
||||||
|
|
|
@ -6,8 +6,7 @@ CLASS ltcl_diff DEFINITION FOR TESTING
|
||||||
PRIVATE SECTION.
|
PRIVATE SECTION.
|
||||||
DATA: mt_new TYPE TABLE OF string,
|
DATA: mt_new TYPE TABLE OF string,
|
||||||
mt_old TYPE TABLE OF string,
|
mt_old TYPE TABLE OF string,
|
||||||
mt_expected TYPE zif_abapgit_definitions=>ty_diffs_tt,
|
mt_expected TYPE zif_abapgit_definitions=>ty_diffs_tt.
|
||||||
ms_expected LIKE LINE OF mt_expected.
|
|
||||||
|
|
||||||
METHODS:
|
METHODS:
|
||||||
add_new IMPORTING iv_new TYPE string,
|
add_new IMPORTING iv_new TYPE string,
|
||||||
|
|
|
@ -74,7 +74,6 @@ CLASS ltcl_xml IMPLEMENTATION.
|
||||||
|
|
||||||
DATA: li_element TYPE REF TO if_ixml_element,
|
DATA: li_element TYPE REF TO if_ixml_element,
|
||||||
li_ostream TYPE REF TO if_ixml_ostream,
|
li_ostream TYPE REF TO if_ixml_ostream,
|
||||||
li_renderer TYPE REF TO if_ixml_renderer,
|
|
||||||
li_streamfactory TYPE REF TO if_ixml_stream_factory.
|
li_streamfactory TYPE REF TO if_ixml_stream_factory.
|
||||||
|
|
||||||
li_element = mo_xml->mi_xml_doc->find_from_path( |/{ mo_xml->c_abapgit_tag }/{ iv_name }| ).
|
li_element = mo_xml->mi_xml_doc->find_from_path( |/{ mo_xml->c_abapgit_tag }/{ iv_name }| ).
|
||||||
|
|
|
@ -459,11 +459,8 @@ CLASS ZCL_ABAPGIT_BRANCH_OVERVIEW IMPLEMENTATION.
|
||||||
lv_name TYPE string,
|
lv_name TYPE string,
|
||||||
lt_temp LIKE it_commits.
|
lt_temp LIKE it_commits.
|
||||||
|
|
||||||
FIELD-SYMBOLS: <ls_branch> LIKE LINE OF mt_branches,
|
FIELD-SYMBOLS: <ls_branch> LIKE LINE OF mt_branches,
|
||||||
<ls_new> LIKE LINE OF rt_commits,
|
<ls_commit> LIKE LINE OF it_commits.
|
||||||
<ls_temp> LIKE LINE OF lt_temp,
|
|
||||||
<ls_temp_end> LIKE LINE OF lt_temp,
|
|
||||||
<ls_commit> LIKE LINE OF it_commits.
|
|
||||||
|
|
||||||
LOOP AT mt_branches ASSIGNING <ls_branch>.
|
LOOP AT mt_branches ASSIGNING <ls_branch>.
|
||||||
|
|
||||||
|
|
|
@ -133,9 +133,7 @@ CLASS ZCL_ABAPGIT_ZLIB IMPLEMENTATION.
|
||||||
|
|
||||||
METHOD decompress.
|
METHOD decompress.
|
||||||
|
|
||||||
DATA: lv_x TYPE x LENGTH 1,
|
DATA: lv_bfinal TYPE c LENGTH 1,
|
||||||
lv_symbol TYPE i,
|
|
||||||
lv_bfinal TYPE c LENGTH 1,
|
|
||||||
lv_btype TYPE c LENGTH 2.
|
lv_btype TYPE c LENGTH 2.
|
||||||
|
|
||||||
|
|
||||||
|
@ -447,7 +445,7 @@ CLASS ZCL_ABAPGIT_ZLIB IMPLEMENTATION.
|
||||||
METHOD not_compressed.
|
METHOD not_compressed.
|
||||||
|
|
||||||
DATA: lv_len TYPE i,
|
DATA: lv_len TYPE i,
|
||||||
lv_nlen TYPE i.
|
lv_nlen TYPE i ##NEEDED.
|
||||||
|
|
||||||
go_stream->take_bits( 5 ).
|
go_stream->take_bits( 5 ).
|
||||||
|
|
||||||
|
|
|
@ -50,10 +50,9 @@ CLASS ltcl_zlib IMPLEMENTATION.
|
||||||
|
|
||||||
METHOD dynamic.
|
METHOD dynamic.
|
||||||
|
|
||||||
DATA: ls_data TYPE zcl_abapgit_zlib=>ty_decompress,
|
DATA: ls_data TYPE zcl_abapgit_zlib=>ty_decompress,
|
||||||
lv_compressed TYPE xstring,
|
lv_compressed TYPE xstring,
|
||||||
lv_decoded TYPE xstring,
|
lv_decoded TYPE xstring.
|
||||||
lv_hex TYPE xstring.
|
|
||||||
|
|
||||||
|
|
||||||
lv_compressed = |75555D6FE246147DF7AFB8521F1610A0AA8F911A| &&
|
lv_compressed = |75555D6FE246147DF7AFB8521F1610A0AA8F911A| &&
|
||||||
|
|
Loading…
Reference in New Issue
Block a user