From ecdd17162a2c5e14d4feae99ef2f6f9b157db7b7 Mon Sep 17 00:00:00 2001
From: Marc Bernard <59966492+mbtools@users.noreply.github.com>
Date: Wed, 10 Apr 2024 16:30:33 +0200
Subject: [PATCH] SOTS: Remove from TADIR selection (#6906)

---
 src/objects/core/zcl_abapgit_tadir.clas.abap | 47 +-------------------
 1 file changed, 2 insertions(+), 45 deletions(-)

diff --git a/src/objects/core/zcl_abapgit_tadir.clas.abap b/src/objects/core/zcl_abapgit_tadir.clas.abap
index 30d00f5c9..27e30854c 100644
--- a/src/objects/core/zcl_abapgit_tadir.clas.abap
+++ b/src/objects/core/zcl_abapgit_tadir.clas.abap
@@ -68,11 +68,6 @@ CLASS zcl_abapgit_tadir DEFINITION
         !ct_tadir   TYPE zif_abapgit_definitions=>ty_tadir_tt
       RAISING
         zcx_abapgit_exception .
-    METHODS is_sots_excluded
-      IMPORTING
-        !it_packages      TYPE zif_abapgit_sap_package=>ty_devclass_tt
-      RETURNING
-        VALUE(rv_exclude) TYPE abap_bool.
 ENDCLASS.
 
 
@@ -267,41 +262,6 @@ CLASS zcl_abapgit_tadir IMPLEMENTATION.
   ENDMETHOD.
 
 
-  METHOD is_sots_excluded.
-
-    " Todo: once all OTR longtexts are handled by object-specific class,
-    " we can exclude SOTS completely (just like SOTR)
-    " Until then, we need an object-type specific check here
-
-    DATA:
-      lt_concepts TYPE STANDARD TABLE OF sotr_headu-concept,
-      lv_count    TYPE i.
-
-    ASSERT it_packages IS NOT INITIAL.
-
-    rv_exclude = abap_false.
-
-    " Get all OTR longtexts
-    SELECT concept FROM sotr_headu INTO TABLE lt_concepts
-      FOR ALL ENTRIES IN it_packages WHERE paket = it_packages-table_line.
-    IF lines( lt_concepts ) > 0.
-      " Check if there are any texts related to objects that do not serialize these texts (yet)
-      " If yes, we need to keep processing SOTS
-      SELECT COUNT(*) FROM sotr_useu INTO lv_count
-        FOR ALL ENTRIES IN lt_concepts WHERE concept = lt_concepts-table_line
-        AND NOT ( pgmid = 'R3TR' AND object = 'SICF' )
-        AND NOT ( pgmid = 'LIMU' AND object = 'CPUB' ).
-      IF lv_count > 0.
-        RETURN.
-      ENDIF.
-    ENDIF.
-
-    " If no, SOTS can be excluded from the TADIR selection
-    rv_exclude = abap_true.
-
-  ENDMETHOD.
-
-
   METHOD select_objects.
 
     DATA:
@@ -321,6 +281,8 @@ CLASS zcl_abapgit_tadir IMPLEMENTATION.
     ls_exclude-option = 'EQ'.
     ls_exclude-low    = 'SOTR'. " automatically created for SAP packages (DEVC)
     APPEND ls_exclude TO lt_excludes.
+    ls_exclude-low    = 'SOTS'. " automatically created for SAP packages (DEVC)
+    APPEND ls_exclude TO lt_excludes.
     ls_exclude-low    = 'SFB1'. " covered by business function sets (SFBS)
     APPEND ls_exclude TO lt_excludes.
     ls_exclude-low    = 'SFB2'. " covered by business functions (SFBF)
@@ -328,11 +290,6 @@ CLASS zcl_abapgit_tadir IMPLEMENTATION.
     ls_exclude-low    = 'STOB'. " auto generated by core data services (DDLS)
     APPEND ls_exclude TO lt_excludes.
 
-    IF is_sots_excluded( et_packages ) = abap_true.
-      ls_exclude-low = 'SOTS'.
-      APPEND ls_exclude TO lt_excludes.
-    ENDIF.
-
     " Limit to objects belonging to this system
     IF iv_only_local_objects = abap_true.
       ls_srcsystem-sign   = 'I'.