TADIR performance

TADIR performance #1756

All usages of TADIR aligned to use the same structure. 
DELFLAG added in the structure.
2 identical structure definitions deleted.

todo: test this PR works after abapmerge has run
This commit is contained in:
larshp 2018-08-06 15:36:03 +02:00 committed by Lars Hvam
parent 400846e036
commit f0fb0f0470
17 changed files with 237 additions and 253 deletions

View File

@ -16,7 +16,7 @@ CLASS zcl_abapgit_object_sicf DEFINITION
!iv_pgmid TYPE tadir-pgmid DEFAULT 'R3TR' !iv_pgmid TYPE tadir-pgmid DEFAULT 'R3TR'
!iv_obj_name TYPE tadir-obj_name !iv_obj_name TYPE tadir-obj_name
RETURNING RETURNING
VALUE(rs_tadir) TYPE tadir VALUE(rs_tadir) TYPE zif_abapgit_definitions=>ty_tadir
RAISING RAISING
zcx_abapgit_exception . zcx_abapgit_exception .
CLASS-METHODS read_sicf_url CLASS-METHODS read_sicf_url
@ -322,7 +322,7 @@ CLASS ZCL_ABAPGIT_OBJECT_SICF IMPLEMENTATION.
METHOD read_tadir_sicf. METHOD read_tadir_sicf.
DATA: lt_tadir TYPE STANDARD TABLE OF tadir WITH DEFAULT KEY, DATA: lt_tadir TYPE zif_abapgit_definitions=>ty_tadir_tt,
lv_hash TYPE text25, lv_hash TYPE text25,
lv_obj_name TYPE tadir-obj_name. lv_obj_name TYPE tadir-obj_name.
@ -332,11 +332,11 @@ CLASS ZCL_ABAPGIT_OBJECT_SICF IMPLEMENTATION.
lv_hash = iv_obj_name+15. lv_hash = iv_obj_name+15.
CONCATENATE iv_obj_name(15) '%' INTO lv_obj_name. CONCATENATE iv_obj_name(15) '%' INTO lv_obj_name.
SELECT * FROM tadir INTO TABLE lt_tadir SELECT * FROM tadir INTO CORRESPONDING FIELDS OF TABLE lt_tadir
WHERE pgmid = iv_pgmid WHERE pgmid = iv_pgmid
AND object = 'SICF' AND object = 'SICF'
AND obj_name LIKE lv_obj_name AND obj_name LIKE lv_obj_name
ORDER BY PRIMARY KEY. "#EC CI_GENBUFF ORDER BY PRIMARY KEY. "#EC CI_GENBUFF
LOOP AT lt_tadir ASSIGNING <ls_tadir>. LOOP AT lt_tadir ASSIGNING <ls_tadir>.
IF read_sicf_url( <ls_tadir>-obj_name ) = lv_hash. IF read_sicf_url( <ls_tadir>-obj_name ) = lv_hash.
@ -481,7 +481,7 @@ CLASS ZCL_ABAPGIT_OBJECT_SICF IMPLEMENTATION.
METHOD zif_abapgit_object~exists. METHOD zif_abapgit_object~exists.
DATA: ls_tadir TYPE tadir, DATA: ls_tadir TYPE zif_abapgit_definitions=>ty_tadir,
ls_key TYPE ty_sicf_key. ls_key TYPE ty_sicf_key.
ls_tadir = read_tadir_sicf( ms_item-obj_name ). ls_tadir = read_tadir_sicf( ms_item-obj_name ).
@ -509,6 +509,13 @@ CLASS ZCL_ABAPGIT_OBJECT_SICF IMPLEMENTATION.
ENDMETHOD. ENDMETHOD.
METHOD zif_abapgit_object~is_locked.
rv_is_locked = abap_false.
ENDMETHOD.
METHOD zif_abapgit_object~jump. METHOD zif_abapgit_object~jump.
DATA: ls_bcdata TYPE bdcdata, DATA: ls_bcdata TYPE bdcdata,
@ -579,11 +586,4 @@ CLASS ZCL_ABAPGIT_OBJECT_SICF IMPLEMENTATION.
ig_data = lt_icfhandler ). ig_data = lt_icfhandler ).
ENDMETHOD. ENDMETHOD.
METHOD zif_abapgit_object~is_locked.
rv_is_locked = abap_false.
ENDMETHOD.
ENDCLASS. ENDCLASS.

View File

@ -286,7 +286,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_MAIN IMPLEMENTATION.
METHOD test_changed_by. METHOD test_changed_by.
DATA: ls_tadir TYPE tadir, DATA: ls_tadir TYPE zif_abapgit_definitions=>ty_tadir,
lv_user TYPE xubname, lv_user TYPE xubname,
ls_item TYPE zif_abapgit_definitions=>ty_item. ls_item TYPE zif_abapgit_definitions=>ty_item.

View File

@ -504,7 +504,7 @@ CLASS ZCL_ABAPGIT_SERVICES_REPO IMPLEMENTATION.
lo_repository TYPE REF TO zcl_abapgit_repo_online, lo_repository TYPE REF TO zcl_abapgit_repo_online,
lo_transport_to_branch TYPE REF TO zcl_abapgit_transport_2_branch, lo_transport_to_branch TYPE REF TO zcl_abapgit_transport_2_branch,
lt_transport_headers TYPE trwbo_request_headers, lt_transport_headers TYPE trwbo_request_headers,
lt_transport_objects TYPE scts_tadir, lt_transport_objects TYPE zif_abapgit_definitions=>ty_tadir_tt,
ls_transport_to_branch TYPE zif_abapgit_definitions=>ty_transport_to_branch. ls_transport_to_branch TYPE zif_abapgit_definitions=>ty_transport_to_branch.

View File

@ -1,6 +1,7 @@
INTERFACE zif_abapgit_popups INTERFACE zif_abapgit_popups
PUBLIC . PUBLIC .
TYPES: TYPES:
BEGIN OF ty_popup, BEGIN OF ty_popup,
url TYPE string, url TYPE string,
@ -9,153 +10,134 @@ INTERFACE zif_abapgit_popups
cancel TYPE abap_bool, cancel TYPE abap_bool,
END OF ty_popup . END OF ty_popup .
CONSTANTS: CONSTANTS c_new_branch_label TYPE string VALUE '+ create new ...' ##NO_TEXT.
c_new_branch_label TYPE string VALUE '+ create new ...' ##NO_TEXT.
METHODS:
popup_package_export
EXPORTING
ev_package TYPE devclass
ev_folder_logic TYPE string
RAISING
zcx_abapgit_exception,
popup_folder_logic
RETURNING
VALUE(rv_folder_logic) TYPE string
RAISING
zcx_abapgit_exception,
popup_object
RETURNING
VALUE(rs_tadir) TYPE tadir
RAISING
zcx_abapgit_exception,
create_branch_popup
EXPORTING
ev_name TYPE string
ev_cancel TYPE abap_bool
RAISING
zcx_abapgit_exception,
run_page_class_popup
EXPORTING
ev_name TYPE string
ev_cancel TYPE abap_bool
RAISING
zcx_abapgit_exception,
repo_new_offline
RETURNING
VALUE(rs_popup) TYPE zif_abapgit_popups=>ty_popup
RAISING
zcx_abapgit_exception,
branch_list_popup
IMPORTING
iv_url TYPE string
iv_default_branch TYPE string OPTIONAL
iv_show_new_option TYPE abap_bool OPTIONAL
RETURNING
VALUE(rs_branch) TYPE zif_abapgit_definitions=>ty_git_branch
RAISING
zcx_abapgit_exception,
repo_popup
IMPORTING
iv_url TYPE string
iv_package TYPE devclass OPTIONAL
iv_branch TYPE string DEFAULT 'refs/heads/master'
iv_freeze_package TYPE abap_bool OPTIONAL
iv_freeze_url TYPE abap_bool OPTIONAL
iv_title TYPE clike DEFAULT 'Clone repository ...'
RETURNING
VALUE(rs_popup) TYPE zif_abapgit_popups=>ty_popup
RAISING
zcx_abapgit_exception ##NO_TEXT,
popup_to_confirm
IMPORTING
titlebar TYPE clike
text_question TYPE clike
text_button_1 TYPE clike DEFAULT 'Yes'
icon_button_1 TYPE icon-name DEFAULT space
text_button_2 TYPE clike DEFAULT 'No'
icon_button_2 TYPE icon-name DEFAULT space
default_button TYPE char1 DEFAULT '1'
display_cancel_button TYPE char1 DEFAULT abap_true
RETURNING
VALUE(rv_answer) TYPE char1
RAISING
zcx_abapgit_exception,
popup_to_inform
IMPORTING
titlebar TYPE clike
text_message TYPE clike
RAISING
zcx_abapgit_exception,
popup_to_create_package
EXPORTING
es_package_data TYPE scompkdtln
ev_create TYPE boolean
RAISING
zcx_abapgit_exception,
popup_to_create_transp_branch
IMPORTING
it_transport_headers TYPE trwbo_request_headers
RETURNING
VALUE(rs_transport_branch) TYPE zif_abapgit_definitions=>ty_transport_to_branch
RAISING
zcx_abapgit_exception
zcx_abapgit_cancel,
popup_to_select_transports
RETURNING
VALUE(rt_trkorr) TYPE trwbo_request_headers,
popup_to_select_from_list
IMPORTING
it_list TYPE STANDARD TABLE
i_header_text TYPE csequence
i_select_column_text TYPE csequence
it_columns_to_display TYPE stringtab
EXPORTING
VALUE(et_list) TYPE STANDARD TABLE
RAISING
zcx_abapgit_cancel
zcx_abapgit_exception,
branch_popup_callback
IMPORTING
iv_code TYPE clike
CHANGING
ct_fields TYPE zif_abapgit_definitions=>ty_sval_tt
cs_error TYPE svale
cv_show_popup TYPE char01
RAISING
zcx_abapgit_exception,
package_popup_callback
IMPORTING
iv_code TYPE clike
CHANGING
ct_fields TYPE zif_abapgit_definitions=>ty_sval_tt
cs_error TYPE svale
cv_show_popup TYPE char01
RAISING
zcx_abapgit_exception,
popup_transport_request
IMPORTING
is_transport_type TYPE zif_abapgit_definitions=>ty_transport_type
RETURNING
VALUE(rv_transport) TYPE trkorr
RAISING
zcx_abapgit_exception
zcx_abapgit_cancel.
METHODS popup_package_export
EXPORTING
!ev_package TYPE devclass
!ev_folder_logic TYPE string
RAISING
zcx_abapgit_exception .
METHODS popup_folder_logic
RETURNING
VALUE(rv_folder_logic) TYPE string
RAISING
zcx_abapgit_exception .
METHODS popup_object
RETURNING
VALUE(rs_tadir) TYPE zif_abapgit_definitions=>ty_tadir
RAISING
zcx_abapgit_exception .
METHODS create_branch_popup
EXPORTING
!ev_name TYPE string
!ev_cancel TYPE abap_bool
RAISING
zcx_abapgit_exception .
METHODS run_page_class_popup
EXPORTING
!ev_name TYPE string
!ev_cancel TYPE abap_bool
RAISING
zcx_abapgit_exception .
METHODS repo_new_offline
RETURNING
VALUE(rs_popup) TYPE zif_abapgit_popups=>ty_popup
RAISING
zcx_abapgit_exception .
METHODS branch_list_popup
IMPORTING
!iv_url TYPE string
!iv_default_branch TYPE string OPTIONAL
!iv_show_new_option TYPE abap_bool OPTIONAL
RETURNING
VALUE(rs_branch) TYPE zif_abapgit_definitions=>ty_git_branch
RAISING
zcx_abapgit_exception .
METHODS repo_popup
IMPORTING
!iv_url TYPE string
!iv_package TYPE devclass OPTIONAL
!iv_branch TYPE string DEFAULT 'refs/heads/master'
!iv_freeze_package TYPE abap_bool OPTIONAL
!iv_freeze_url TYPE abap_bool OPTIONAL
!iv_title TYPE clike DEFAULT 'Clone repository ...'
RETURNING
VALUE(rs_popup) TYPE zif_abapgit_popups=>ty_popup
RAISING
zcx_abapgit_exception ##NO_TEXT.
METHODS popup_to_confirm
IMPORTING
!titlebar TYPE clike
!text_question TYPE clike
!text_button_1 TYPE clike DEFAULT 'Yes'
!icon_button_1 TYPE icon-name DEFAULT space
!text_button_2 TYPE clike DEFAULT 'No'
!icon_button_2 TYPE icon-name DEFAULT space
!default_button TYPE char1 DEFAULT '1'
!display_cancel_button TYPE char1 DEFAULT abap_true
RETURNING
VALUE(rv_answer) TYPE char1
RAISING
zcx_abapgit_exception .
METHODS popup_to_inform
IMPORTING
!titlebar TYPE clike
!text_message TYPE clike
RAISING
zcx_abapgit_exception .
METHODS popup_to_create_package
EXPORTING
!es_package_data TYPE scompkdtln
!ev_create TYPE boolean
RAISING
zcx_abapgit_exception .
METHODS popup_to_create_transp_branch
IMPORTING
!it_transport_headers TYPE trwbo_request_headers
RETURNING
VALUE(rs_transport_branch) TYPE zif_abapgit_definitions=>ty_transport_to_branch
RAISING
zcx_abapgit_exception
zcx_abapgit_cancel .
METHODS popup_to_select_transports
RETURNING
VALUE(rt_trkorr) TYPE trwbo_request_headers .
METHODS popup_to_select_from_list
IMPORTING
!it_list TYPE STANDARD TABLE
!i_header_text TYPE csequence
!i_select_column_text TYPE csequence
!it_columns_to_display TYPE stringtab
EXPORTING
VALUE(et_list) TYPE STANDARD TABLE
RAISING
zcx_abapgit_cancel
zcx_abapgit_exception .
METHODS branch_popup_callback
IMPORTING
!iv_code TYPE clike
CHANGING
!ct_fields TYPE zif_abapgit_definitions=>ty_sval_tt
!cs_error TYPE svale
!cv_show_popup TYPE char01
RAISING
zcx_abapgit_exception .
METHODS package_popup_callback
IMPORTING
!iv_code TYPE clike
CHANGING
!ct_fields TYPE zif_abapgit_definitions=>ty_sval_tt
!cs_error TYPE svale
!cv_show_popup TYPE char01
RAISING
zcx_abapgit_exception .
METHODS popup_transport_request
IMPORTING
!is_transport_type TYPE zif_abapgit_definitions=>ty_transport_type
RETURNING
VALUE(rv_transport) TYPE trkorr
RAISING
zcx_abapgit_exception
zcx_abapgit_cancel .
ENDINTERFACE. ENDINTERFACE.

View File

@ -5,21 +5,9 @@ CLASS zcl_abapgit_dependencies DEFINITION
PUBLIC SECTION. PUBLIC SECTION.
TYPES:
BEGIN OF ty_tadir,
pgmid TYPE tadir-pgmid,
object TYPE tadir-object,
obj_name TYPE tadir-obj_name,
devclass TYPE tadir-devclass,
korrnum TYPE tadir-korrnum,
path TYPE string,
END OF ty_tadir .
TYPES:
ty_tadir_tt TYPE STANDARD TABLE OF ty_tadir WITH DEFAULT KEY .
CLASS-METHODS resolve CLASS-METHODS resolve
CHANGING CHANGING
!ct_tadir TYPE ty_tadir_tt !ct_tadir TYPE zif_abapgit_definitions=>ty_tadir_tt
RAISING RAISING
zcx_abapgit_exception . zcx_abapgit_exception .
PRIVATE SECTION. PRIVATE SECTION.
@ -45,7 +33,7 @@ CLASS zcl_abapgit_dependencies DEFINITION
CLASS-METHODS resolve_ddic CLASS-METHODS resolve_ddic
CHANGING CHANGING
!ct_tadir TYPE ty_tadir_tt !ct_tadir TYPE zif_abapgit_definitions=>ty_tadir_tt
RAISING RAISING
zcx_abapgit_exception . zcx_abapgit_exception .
CLASS-METHODS get_ddls_dependencies CLASS-METHODS get_ddls_dependencies
@ -55,12 +43,12 @@ CLASS zcl_abapgit_dependencies DEFINITION
VALUE(rt_dependency) TYPE tty_dedenpency . VALUE(rt_dependency) TYPE tty_dedenpency .
CLASS-METHODS resolve_packages CLASS-METHODS resolve_packages
CHANGING CHANGING
ct_tadir TYPE zcl_abapgit_dependencies=>ty_tadir_tt. ct_tadir TYPE zif_abapgit_definitions=>ty_tadir_tt.
ENDCLASS. ENDCLASS.
CLASS zcl_abapgit_dependencies IMPLEMENTATION. CLASS ZCL_ABAPGIT_DEPENDENCIES IMPLEMENTATION.
METHOD get_ddls_dependencies. METHOD get_ddls_dependencies.
@ -171,9 +159,9 @@ CLASS zcl_abapgit_dependencies IMPLEMENTATION.
lt_scope TYPE STANDARD TABLE OF seu_obj, lt_scope TYPE STANDARD TABLE OF seu_obj,
lt_dependency TYPE tty_dedenpency. lt_dependency TYPE tty_dedenpency.
FIELD-SYMBOLS: <ls_tadir_ddls> TYPE ty_tadir, FIELD-SYMBOLS: <ls_tadir_ddls> TYPE zif_abapgit_definitions=>ty_tadir,
<ls_dependency> TYPE ty_dependency, <ls_dependency> TYPE ty_dependency,
<ls_tadir_dependent> TYPE ty_tadir, <ls_tadir_dependent> TYPE zif_abapgit_definitions=>ty_tadir,
<ls_tadir> LIKE LINE OF ct_tadir, <ls_tadir> LIKE LINE OF ct_tadir,
<ls_edge> LIKE LINE OF lt_edges, <ls_edge> LIKE LINE OF lt_edges,
<ls_found> LIKE LINE OF lt_founds, <ls_found> LIKE LINE OF lt_founds,
@ -331,5 +319,4 @@ CLASS zcl_abapgit_dependencies IMPLEMENTATION.
ENDLOOP. ENDLOOP.
ENDMETHOD. ENDMETHOD.
ENDCLASS. ENDCLASS.

View File

@ -90,7 +90,7 @@ CLASS ltcl_resolve_packages DEFINITION FOR TESTING
PRIVATE SECTION. PRIVATE SECTION.
DATA: DATA:
mt_tadir TYPE zcl_abapgit_dependencies=>ty_tadir_tt, mt_tadir TYPE zif_abapgit_definitions=>ty_tadir_tt,
mt_sub_packages TYPE ltd_sap_package=>tty_package. mt_sub_packages TYPE ltd_sap_package=>tty_package.
METHODS: METHODS:

View File

@ -206,7 +206,7 @@ ENDCLASS.
CLASS zcl_abapgit_objects IMPLEMENTATION. CLASS ZCL_ABAPGIT_OBJECTS IMPLEMENTATION.
METHOD changed_by. METHOD changed_by.
@ -995,7 +995,8 @@ CLASS zcl_abapgit_objects IMPLEMENTATION.
lt_overwrite_uniqe TYPE HASHED TABLE OF zif_abapgit_definitions=>ty_overwrite lt_overwrite_uniqe TYPE HASHED TABLE OF zif_abapgit_definitions=>ty_overwrite
WITH UNIQUE KEY obj_type obj_name devclass, WITH UNIQUE KEY obj_type obj_name devclass,
ls_overwrite LIKE LINE OF rt_overwrite, ls_overwrite LIKE LINE OF rt_overwrite,
ls_tadir TYPE tadir. ls_tadir TYPE zif_abapgit_definitions=>ty_tadir.
DATA: lo_folder_logic TYPE REF TO zcl_abapgit_folder_logic. DATA: lo_folder_logic TYPE REF TO zcl_abapgit_folder_logic.
FIELD-SYMBOLS: <ls_result> LIKE LINE OF it_results. FIELD-SYMBOLS: <ls_result> LIKE LINE OF it_results.
@ -1026,5 +1027,4 @@ CLASS zcl_abapgit_objects IMPLEMENTATION.
rt_overwrite = lt_overwrite_uniqe. rt_overwrite = lt_overwrite_uniqe.
ENDMETHOD. ENDMETHOD.
ENDCLASS. ENDCLASS.

View File

@ -31,7 +31,7 @@ CLASS zcl_abapgit_repo DEFINITION
METHODS get_files_local METHODS get_files_local
IMPORTING IMPORTING
!io_log TYPE REF TO zcl_abapgit_log OPTIONAL !io_log TYPE REF TO zcl_abapgit_log OPTIONAL
!it_filter TYPE scts_tadir OPTIONAL !it_filter TYPE zif_abapgit_definitions=>ty_tadir_tt OPTIONAL
RETURNING RETURNING
VALUE(rt_files) TYPE zif_abapgit_definitions=>ty_files_item_tt VALUE(rt_files) TYPE zif_abapgit_definitions=>ty_files_item_tt
RAISING RAISING
@ -63,7 +63,7 @@ CLASS zcl_abapgit_repo DEFINITION
zcx_abapgit_exception . zcx_abapgit_exception .
METHODS deserialize METHODS deserialize
IMPORTING IMPORTING
is_checks TYPE zif_abapgit_definitions=>ty_deserialize_checks !is_checks TYPE zif_abapgit_definitions=>ty_deserialize_checks
RAISING RAISING
zcx_abapgit_exception . zcx_abapgit_exception .
METHODS refresh METHODS refresh
@ -99,16 +99,14 @@ CLASS zcl_abapgit_repo DEFINITION
VALUE(rs_settings) TYPE zif_abapgit_persistence=>ty_repo-local_settings . VALUE(rs_settings) TYPE zif_abapgit_persistence=>ty_repo-local_settings .
METHODS set_local_settings METHODS set_local_settings
IMPORTING IMPORTING
is_settings TYPE zif_abapgit_persistence=>ty_repo-local_settings !is_settings TYPE zif_abapgit_persistence=>ty_repo-local_settings
RAISING RAISING
zcx_abapgit_exception . zcx_abapgit_exception .
METHODS run_code_inspector METHODS run_code_inspector
RETURNING RETURNING
value(rt_list) TYPE scit_alvlist VALUE(rt_list) TYPE scit_alvlist
RAISING RAISING
zcx_abapgit_exception . zcx_abapgit_exception .
PROTECTED SECTION. PROTECTED SECTION.
DATA mt_local TYPE zif_abapgit_definitions=>ty_files_item_tt . DATA mt_local TYPE zif_abapgit_definitions=>ty_files_item_tt .
DATA mt_remote TYPE zif_abapgit_definitions=>ty_files_tt . DATA mt_remote TYPE zif_abapgit_definitions=>ty_files_tt .
@ -265,7 +263,7 @@ CLASS ZCL_ABAPGIT_REPO IMPLEMENTATION.
lt_cache TYPE SORTED TABLE OF zif_abapgit_definitions=>ty_file_item lt_cache TYPE SORTED TABLE OF zif_abapgit_definitions=>ty_file_item
WITH NON-UNIQUE KEY item. WITH NON-UNIQUE KEY item.
DATA: lt_filter TYPE SORTED TABLE OF tadir DATA: lt_filter TYPE SORTED TABLE OF zif_abapgit_definitions=>ty_tadir
WITH NON-UNIQUE KEY object obj_name, WITH NON-UNIQUE KEY object obj_name,
lv_filter_exist TYPE abap_bool. lv_filter_exist TYPE abap_bool.

View File

@ -38,7 +38,7 @@ ENDCLASS.
CLASS zcl_abapgit_tadir IMPLEMENTATION. CLASS ZCL_ABAPGIT_TADIR IMPLEMENTATION.
METHOD build. METHOD build.
@ -197,7 +197,7 @@ CLASS zcl_abapgit_tadir IMPLEMENTATION.
METHOD zif_abapgit_tadir~get_object_package. METHOD zif_abapgit_tadir~get_object_package.
DATA: ls_tadir TYPE tadir, DATA: ls_tadir TYPE zif_abapgit_definitions=>ty_tadir,
ls_item TYPE zif_abapgit_definitions=>ty_item. ls_item TYPE zif_abapgit_definitions=>ty_item.
ls_tadir = zif_abapgit_tadir~read_single( ls_tadir = zif_abapgit_tadir~read_single(
@ -251,7 +251,7 @@ CLASS zcl_abapgit_tadir IMPLEMENTATION.
iv_pgmid = iv_pgmid iv_pgmid = iv_pgmid
iv_obj_name = iv_obj_name ). iv_obj_name = iv_obj_name ).
ELSE. ELSE.
SELECT SINGLE * FROM tadir INTO rs_tadir SELECT SINGLE * FROM tadir INTO CORRESPONDING FIELDS OF rs_tadir
WHERE pgmid = iv_pgmid WHERE pgmid = iv_pgmid
AND object = iv_object AND object = iv_object
AND obj_name = iv_obj_name. "#EC CI_SUBRC AND obj_name = iv_obj_name. "#EC CI_SUBRC

View File

@ -1,26 +1,41 @@
CLASS zcl_abapgit_transport DEFINITION PUBLIC FINAL CREATE PUBLIC. CLASS zcl_abapgit_transport DEFINITION
PUBLIC
FINAL
CREATE PUBLIC .
PUBLIC SECTION. PUBLIC SECTION.
CLASS-METHODS:
zip RAISING zcx_abapgit_exception,
to_tadir IMPORTING it_transport_headers TYPE trwbo_request_headers
RETURNING VALUE(rt_tadir) TYPE scts_tadir
RAISING zcx_abapgit_exception.
CLASS-METHODS zip
RAISING
zcx_abapgit_exception .
CLASS-METHODS to_tadir
IMPORTING
!it_transport_headers TYPE trwbo_request_headers
RETURNING
VALUE(rt_tadir) TYPE zif_abapgit_definitions=>ty_tadir_tt
RAISING
zcx_abapgit_exception .
PRIVATE SECTION. PRIVATE SECTION.
CLASS-METHODS:
read_requests
IMPORTING it_trkorr TYPE trwbo_request_headers
RETURNING VALUE(rt_requests) TYPE trwbo_requests
RAISING zcx_abapgit_exception,
find_top_package
IMPORTING it_tadir TYPE scts_tadir
RETURNING VALUE(rv_package) TYPE devclass,
resolve
IMPORTING it_requests TYPE trwbo_requests
RETURNING VALUE(rt_tadir) TYPE scts_tadir
RAISING zcx_abapgit_exception.
CLASS-METHODS read_requests
IMPORTING
!it_trkorr TYPE trwbo_request_headers
RETURNING
VALUE(rt_requests) TYPE trwbo_requests
RAISING
zcx_abapgit_exception .
CLASS-METHODS find_top_package
IMPORTING
!it_tadir TYPE zif_abapgit_definitions=>ty_tadir_tt
RETURNING
VALUE(rv_package) TYPE devclass .
CLASS-METHODS resolve
IMPORTING
!it_requests TYPE trwbo_requests
RETURNING
VALUE(rt_tadir) TYPE zif_abapgit_definitions=>ty_tadir_tt
RAISING
zcx_abapgit_exception .
ENDCLASS. ENDCLASS.
@ -87,7 +102,7 @@ CLASS ZCL_ABAPGIT_TRANSPORT IMPLEMENTATION.
DATA: lv_object TYPE tadir-object, DATA: lv_object TYPE tadir-object,
lv_obj_name TYPE tadir-obj_name, lv_obj_name TYPE tadir-obj_name,
lv_trobj_name TYPE trobj_name, lv_trobj_name TYPE trobj_name,
ls_tadir TYPE tadir. ls_tadir TYPE zif_abapgit_definitions=>ty_tadir.
FIELD-SYMBOLS: <ls_request> LIKE LINE OF it_requests, FIELD-SYMBOLS: <ls_request> LIKE LINE OF it_requests,
<ls_object> LIKE LINE OF <ls_request>-objects. <ls_object> LIKE LINE OF <ls_request>-objects.
@ -145,7 +160,7 @@ CLASS ZCL_ABAPGIT_TRANSPORT IMPLEMENTATION.
METHOD zip. METHOD zip.
DATA: lt_requests TYPE trwbo_requests, DATA: lt_requests TYPE trwbo_requests,
lt_tadir TYPE scts_tadir, lt_tadir TYPE zif_abapgit_definitions=>ty_tadir_tt,
lv_package TYPE devclass, lv_package TYPE devclass,
ls_data TYPE zif_abapgit_persistence=>ty_repo, ls_data TYPE zif_abapgit_persistence=>ty_repo,
lo_repo TYPE REF TO zcl_abapgit_repo_offline, lo_repo TYPE REF TO zcl_abapgit_repo_offline,
@ -179,6 +194,6 @@ CLASS ZCL_ABAPGIT_TRANSPORT IMPLEMENTATION.
is_data = ls_data. is_data = ls_data.
zcl_abapgit_zip=>export( io_repo = lo_repo zcl_abapgit_zip=>export( io_repo = lo_repo
it_filter = lt_tadir ). it_filter = lt_tadir ).
ENDMETHOD. ENDMETHOD.
ENDCLASS. ENDCLASS.

View File

@ -1,12 +1,17 @@
CLASS zcl_abapgit_transport_2_branch DEFINITION PUBLIC FINAL CREATE PUBLIC. CLASS zcl_abapgit_transport_2_branch DEFINITION
PUBLIC
FINAL
CREATE PUBLIC .
PUBLIC SECTION. PUBLIC SECTION.
METHODS:
create METHODS create
IMPORTING io_repository TYPE REF TO zcl_abapgit_repo_online IMPORTING
is_transport_to_branch TYPE zif_abapgit_definitions=>ty_transport_to_branch !io_repository TYPE REF TO zcl_abapgit_repo_online
it_transport_objects TYPE scts_tadir !is_transport_to_branch TYPE zif_abapgit_definitions=>ty_transport_to_branch
RAISING zcx_abapgit_exception. !it_transport_objects TYPE zif_abapgit_definitions=>ty_tadir_tt
RAISING
zcx_abapgit_exception .
PROTECTED SECTION. PROTECTED SECTION.
METHODS generate_commit_message METHODS generate_commit_message
@ -16,7 +21,7 @@ CLASS zcl_abapgit_transport_2_branch DEFINITION PUBLIC FINAL CREATE PUBLIC.
VALUE(rs_comment) TYPE zif_abapgit_definitions=>ty_comment . VALUE(rs_comment) TYPE zif_abapgit_definitions=>ty_comment .
METHODS stage_transport_objects METHODS stage_transport_objects
IMPORTING IMPORTING
!it_transport_objects TYPE scts_tadir !it_transport_objects TYPE zif_abapgit_definitions=>ty_tadir_tt
!io_stage TYPE REF TO zcl_abapgit_stage !io_stage TYPE REF TO zcl_abapgit_stage
!is_stage_objects TYPE zif_abapgit_definitions=>ty_stage_files !is_stage_objects TYPE zif_abapgit_definitions=>ty_stage_files
!it_object_statuses TYPE zif_abapgit_definitions=>ty_results_tt !it_object_statuses TYPE zif_abapgit_definitions=>ty_results_tt

View File

@ -7,7 +7,7 @@ CLASS zcl_abapgit_transport_objects DEFINITION
METHODS constructor METHODS constructor
IMPORTING IMPORTING
!it_transport_objects TYPE scts_tadir . !it_transport_objects TYPE zif_abapgit_definitions=>ty_tadir_tt .
METHODS to_stage METHODS to_stage
IMPORTING IMPORTING
!io_stage TYPE REF TO zcl_abapgit_stage !io_stage TYPE REF TO zcl_abapgit_stage
@ -16,8 +16,8 @@ CLASS zcl_abapgit_transport_objects DEFINITION
RAISING RAISING
zcx_abapgit_exception . zcx_abapgit_exception .
PRIVATE SECTION. PRIVATE SECTION.
DATA mt_transport_objects TYPE scts_tadir.
DATA mt_transport_objects TYPE zif_abapgit_definitions=>ty_tadir_tt .
ENDCLASS. ENDCLASS.
@ -31,7 +31,7 @@ CLASS ZCL_ABAPGIT_TRANSPORT_OBJECTS IMPLEMENTATION.
METHOD to_stage. METHOD to_stage.
DATA: ls_transport_object TYPE tadir, DATA: ls_transport_object LIKE LINE OF mt_transport_objects,
ls_local_file TYPE zif_abapgit_definitions=>ty_file_item, ls_local_file TYPE zif_abapgit_definitions=>ty_file_item,
ls_object_status TYPE zif_abapgit_definitions=>ty_result. ls_object_status TYPE zif_abapgit_definitions=>ty_result.

View File

@ -46,7 +46,7 @@ CLASS ltcl_transport_objects DEFINITION FOR TESTING DURATION SHORT RISK LEVEL HA
iv_path TYPE string. iv_path TYPE string.
DATA: mo_transport_objects TYPE REF TO zcl_abapgit_transport_objects, DATA: mo_transport_objects TYPE REF TO zcl_abapgit_transport_objects,
mt_transport_objects TYPE scts_tadir, mt_transport_objects TYPE zif_abapgit_definitions=>ty_tadir_tt,
mt_object_statuses TYPE zif_abapgit_definitions=>ty_results_tt, mt_object_statuses TYPE zif_abapgit_definitions=>ty_results_tt,
ms_stage_objects TYPE zif_abapgit_definitions=>ty_stage_files, ms_stage_objects TYPE zif_abapgit_definitions=>ty_stage_files,
mo_stage TYPE REF TO zcl_abapgit_stage. mo_stage TYPE REF TO zcl_abapgit_stage.
@ -282,7 +282,7 @@ CLASS ltcl_transport_objects IMPLEMENTATION.
ENDMETHOD. ENDMETHOD.
METHOD given_the_transport_object. METHOD given_the_transport_object.
DATA ls_transport_object TYPE tadir. DATA ls_transport_object TYPE zif_abapgit_definitions=>ty_tadir.
ls_transport_object-obj_name = iv_obj_name. ls_transport_object-obj_name = iv_obj_name.
ls_transport_object-object = iv_obj_type. ls_transport_object-object = iv_obj_type.
ls_transport_object-delflag = iv_delflag. ls_transport_object-delflag = iv_delflag.

View File

@ -3,21 +3,26 @@ CLASS zcl_abapgit_zip DEFINITION
CREATE PUBLIC . CREATE PUBLIC .
PUBLIC SECTION. PUBLIC SECTION.
CLASS-METHODS import CLASS-METHODS import
IMPORTING iv_key TYPE zif_abapgit_persistence=>ty_value IMPORTING
RAISING zcx_abapgit_exception. !iv_key TYPE zif_abapgit_persistence=>ty_value
RAISING
zcx_abapgit_exception .
CLASS-METHODS export CLASS-METHODS export
IMPORTING io_repo TYPE REF TO zcl_abapgit_repo IMPORTING
it_filter TYPE scts_tadir OPTIONAL !io_repo TYPE REF TO zcl_abapgit_repo
RAISING zcx_abapgit_exception. !it_filter TYPE zif_abapgit_definitions=>ty_tadir_tt OPTIONAL
RAISING
zcx_abapgit_exception .
CLASS-METHODS export_package CLASS-METHODS export_package
RAISING zcx_abapgit_exception zcx_abapgit_cancel. RAISING
zcx_abapgit_exception
zcx_abapgit_cancel .
CLASS-METHODS export_object CLASS-METHODS export_object
RAISING zcx_abapgit_exception zcx_abapgit_cancel. RAISING
zcx_abapgit_exception
zcx_abapgit_cancel .
PRIVATE SECTION. PRIVATE SECTION.
CLASS-METHODS file_upload CLASS-METHODS file_upload
RETURNING VALUE(rv_xstr) TYPE xstring RETURNING VALUE(rv_xstr) TYPE xstring
@ -52,7 +57,7 @@ ENDCLASS.
CLASS zcl_abapgit_zip IMPLEMENTATION. CLASS ZCL_ABAPGIT_ZIP IMPLEMENTATION.
METHOD encode_files. METHOD encode_files.
@ -106,7 +111,7 @@ CLASS zcl_abapgit_zip IMPLEMENTATION.
METHOD export_object. METHOD export_object.
DATA: ls_tadir TYPE tadir, DATA: ls_tadir TYPE zif_abapgit_definitions=>ty_tadir,
ls_item TYPE zif_abapgit_definitions=>ty_item, ls_item TYPE zif_abapgit_definitions=>ty_item,
lv_folder TYPE string, lv_folder TYPE string,
lv_fullpath TYPE string, lv_fullpath TYPE string,

View File

@ -182,6 +182,7 @@ INTERFACE zif_abapgit_definitions PUBLIC.
obj_name TYPE tadir-obj_name, obj_name TYPE tadir-obj_name,
devclass TYPE tadir-devclass, devclass TYPE tadir-devclass,
korrnum TYPE tadir-korrnum, korrnum TYPE tadir-korrnum,
delflag TYPE tadir-delflag,
path TYPE string, path TYPE string,
END OF ty_tadir . END OF ty_tadir .
TYPES: TYPES:

View File

@ -1,15 +1,6 @@
INTERFACE zif_abapgit_exit PUBLIC. INTERFACE zif_abapgit_exit PUBLIC.
TYPES: TYPES:
BEGIN OF ty_tadir,
pgmid TYPE tadir-pgmid,
object TYPE tadir-object,
obj_name TYPE tadir-obj_name,
devclass TYPE tadir-devclass,
korrnum TYPE tadir-korrnum,
path TYPE string,
END OF ty_tadir,
ty_tadir_tt TYPE STANDARD TABLE OF ty_tadir WITH DEFAULT KEY,
ty_icm_sinfo2_tt TYPE STANDARD TABLE OF icm_sinfo2 WITH DEFAULT KEY. ty_icm_sinfo2_tt TYPE STANDARD TABLE OF icm_sinfo2 WITH DEFAULT KEY.
METHODS: METHODS:
@ -34,6 +25,6 @@ INTERFACE zif_abapgit_exit PUBLIC.
iv_package TYPE devclass iv_package TYPE devclass
io_log TYPE REF TO zcl_abapgit_log io_log TYPE REF TO zcl_abapgit_log
CHANGING CHANGING
ct_tadir TYPE ty_tadir_tt. ct_tadir TYPE zif_abapgit_definitions=>ty_tadir_tt.
ENDINTERFACE. ENDINTERFACE.

View File

@ -28,7 +28,7 @@ INTERFACE zif_abapgit_tadir
!iv_object TYPE tadir-object !iv_object TYPE tadir-object
!iv_obj_name TYPE tadir-obj_name !iv_obj_name TYPE tadir-obj_name
RETURNING RETURNING
VALUE(rs_tadir) TYPE tadir VALUE(rs_tadir) TYPE zif_abapgit_definitions=>ty_tadir
RAISING RAISING
zcx_abapgit_exception . zcx_abapgit_exception .
ENDINTERFACE. ENDINTERFACE.