fix some naming convention

https://github.com/larshp/abapGit/issues/1132
This commit is contained in:
Johannes Konings 2018-08-07 11:50:30 +02:00 committed by Lars Hvam
parent 0fa4ed299e
commit f214fab73d
11 changed files with 71 additions and 71 deletions

View File

@ -50,7 +50,7 @@ CLASS ZCL_ABAPGIT_PROXY_CONFIG IMPLEMENTATION.
EXPORTING
iv_repo_url = iv_repo_url
CHANGING
c_proxy_authentication = rv_auth ).
cv_proxy_authentication = rv_auth ).
ENDMETHOD.
@ -63,7 +63,7 @@ CLASS ZCL_ABAPGIT_PROXY_CONFIG IMPLEMENTATION.
EXPORTING
iv_repo_url = iv_repo_url
CHANGING
c_proxy_port = rv_port ).
cv_proxy_port = rv_port ).
ENDMETHOD.
@ -76,7 +76,7 @@ CLASS ZCL_ABAPGIT_PROXY_CONFIG IMPLEMENTATION.
EXPORTING
iv_repo_url = iv_repo_url
CHANGING
c_proxy_url = rv_proxy_url ).
cv_proxy_url = rv_proxy_url ).
ENDMETHOD.
ENDCLASS.

View File

@ -18,7 +18,7 @@ CLASS zcl_abapgit_object_clas IMPLEMENTATION.
super->constructor( is_item = is_item
iv_language = iv_language ).
CREATE OBJECT mo_object_oriented_object_fct TYPE zcl_abapgit_oo_class_new.
CREATE OBJECT mi_object_oriented_object_fct TYPE zcl_abapgit_oo_class_new.
ENDMETHOD.
METHOD deserialize_abap.
@ -53,13 +53,13 @@ CLASS zcl_abapgit_object_clas IMPLEMENTATION.
io_xml->read( EXPORTING iv_name = 'VSEOCLASS'
CHANGING cg_data = ls_vseoclass ).
mo_object_oriented_object_fct->create(
mi_object_oriented_object_fct->create(
EXPORTING
iv_package = iv_package
CHANGING
is_properties = ls_vseoclass ).
cg_properties = ls_vseoclass ).
mo_object_oriented_object_fct->generate_locals(
mi_object_oriented_object_fct->generate_locals(
is_key = ls_class_key
iv_force = seox_true
it_local_definitions = lt_local_definitions
@ -67,14 +67,14 @@ CLASS zcl_abapgit_object_clas IMPLEMENTATION.
it_local_macros = lt_local_macros
it_local_test_classes = lt_test_classes ).
mo_object_oriented_object_fct->deserialize_source(
mi_object_oriented_object_fct->deserialize_source(
is_key = ls_class_key
it_source = lt_source ).
io_xml->read( EXPORTING iv_name = 'DESCRIPTIONS'
CHANGING cg_data = lt_descriptions ).
mo_object_oriented_object_fct->update_descriptions(
mi_object_oriented_object_fct->update_descriptions(
is_key = ls_class_key
it_descriptions = lt_descriptions ).

View File

@ -9,7 +9,7 @@ CLASS zcl_abapgit_object_clas_old DEFINITION PUBLIC INHERITING FROM zcl_abapgit_
iv_language TYPE spras.
PROTECTED SECTION.
DATA: mo_object_oriented_object_fct TYPE REF TO zif_abapgit_oo_object_fnc,
DATA: mi_object_oriented_object_fct TYPE REF TO zif_abapgit_oo_object_fnc,
mv_skip_testclass TYPE abap_bool.
METHODS:
@ -47,7 +47,7 @@ CLASS zcl_abapgit_object_clas_old IMPLEMENTATION.
super->constructor(
is_item = is_item
iv_language = iv_language ).
mo_object_oriented_object_fct = zcl_abapgit_oo_factory=>make( ms_item-obj_type ).
mi_object_oriented_object_fct = zcl_abapgit_oo_factory=>make( ms_item-obj_type ).
ENDMETHOD.
@ -82,13 +82,13 @@ CLASS zcl_abapgit_object_clas_old IMPLEMENTATION.
io_xml->read( EXPORTING iv_name = 'VSEOCLASS'
CHANGING cg_data = ls_vseoclass ).
mo_object_oriented_object_fct->create(
mi_object_oriented_object_fct->create(
EXPORTING
iv_package = iv_package
CHANGING
is_properties = ls_vseoclass ).
cg_properties = ls_vseoclass ).
mo_object_oriented_object_fct->generate_locals(
mi_object_oriented_object_fct->generate_locals(
is_key = ls_class_key
iv_force = seox_true
it_local_definitions = lt_local_definitions
@ -96,18 +96,18 @@ CLASS zcl_abapgit_object_clas_old IMPLEMENTATION.
it_local_macros = lt_local_macros
it_local_test_classes = lt_test_classes ).
mo_object_oriented_object_fct->deserialize_source(
mi_object_oriented_object_fct->deserialize_source(
is_key = ls_class_key
it_source = lt_source ).
io_xml->read( EXPORTING iv_name = 'DESCRIPTIONS'
CHANGING cg_data = lt_descriptions ).
mo_object_oriented_object_fct->update_descriptions(
mi_object_oriented_object_fct->update_descriptions(
is_key = ls_class_key
it_descriptions = lt_descriptions ).
mo_object_oriented_object_fct->add_to_activation_list( ms_item ).
mi_object_oriented_object_fct->add_to_activation_list( ms_item ).
ENDMETHOD.
@ -125,7 +125,7 @@ CLASS zcl_abapgit_object_clas_old IMPLEMENTATION.
lv_object = ms_item-obj_name.
mo_object_oriented_object_fct->create_documentation(
mi_object_oriented_object_fct->create_documentation(
it_lines = lt_lines
iv_object_name = lv_object
iv_language = mv_language ).
@ -143,7 +143,7 @@ CLASS zcl_abapgit_object_clas_old IMPLEMENTATION.
RETURN.
ENDIF.
mo_object_oriented_object_fct->create_sotr(
mi_object_oriented_object_fct->create_sotr(
iv_package = iv_package
it_sotr = lt_sotr ).
ENDMETHOD.
@ -166,7 +166,7 @@ CLASS zcl_abapgit_object_clas_old IMPLEMENTATION.
lv_clsname = ms_item-obj_name.
mo_object_oriented_object_fct->insert_text_pool(
mi_object_oriented_object_fct->insert_text_pool(
iv_class_name = lv_clsname
it_text_pool = lt_tpool
iv_language = mv_language ).
@ -191,7 +191,7 @@ CLASS zcl_abapgit_object_clas_old IMPLEMENTATION.
zcl_abapgit_language=>set_current_language( mv_language ).
TRY.
ls_vseoclass = mo_object_oriented_object_fct->get_class_properties( ls_clskey ).
ls_vseoclass = mi_object_oriented_object_fct->get_class_properties( ls_clskey ).
CLEANUP.
zcl_abapgit_language=>restore_login_language( ).
@ -216,21 +216,21 @@ CLASS zcl_abapgit_object_clas_old IMPLEMENTATION.
io_xml->add( iv_name = 'VSEOCLASS'
ig_data = ls_vseoclass ).
lt_tpool = mo_object_oriented_object_fct->read_text_pool(
lt_tpool = mi_object_oriented_object_fct->read_text_pool(
iv_class_name = ls_clskey-clsname
iv_language = mv_language ).
io_xml->add( iv_name = 'TPOOL'
ig_data = add_tpool( lt_tpool ) ).
IF ls_vseoclass-category = seoc_category_exception.
lt_sotr = mo_object_oriented_object_fct->read_sotr( ms_item-obj_name ).
lt_sotr = mi_object_oriented_object_fct->read_sotr( ms_item-obj_name ).
IF lines( lt_sotr ) > 0.
io_xml->add( iv_name = 'SOTR'
ig_data = lt_sotr ).
ENDIF.
ENDIF.
lt_lines = mo_object_oriented_object_fct->read_documentation(
lt_lines = mi_object_oriented_object_fct->read_documentation(
iv_class_name = ls_clskey-clsname
iv_language = mv_language ).
IF lines( lt_lines ) > 0.
@ -238,7 +238,7 @@ CLASS zcl_abapgit_object_clas_old IMPLEMENTATION.
ig_data = lt_lines ).
ENDIF.
lt_descriptions = mo_object_oriented_object_fct->read_descriptions( ls_clskey-clsname ).
lt_descriptions = mi_object_oriented_object_fct->read_descriptions( ls_clskey-clsname ).
IF lines( lt_descriptions ) > 0.
io_xml->add( iv_name = 'DESCRIPTIONS'
ig_data = lt_descriptions ).
@ -263,7 +263,7 @@ CLASS zcl_abapgit_object_clas_old IMPLEMENTATION.
ls_reposrc LIKE LINE OF lt_reposrc,
lt_includes TYPE STANDARD TABLE OF ty_includes.
lt_includes = mo_object_oriented_object_fct->get_includes( ms_item-obj_name ).
lt_includes = mi_object_oriented_object_fct->get_includes( ms_item-obj_name ).
ASSERT lines( lt_includes ) > 0.
SELECT unam udat utime FROM reposrc
@ -292,7 +292,7 @@ CLASS zcl_abapgit_object_clas_old IMPLEMENTATION.
DATA: ls_clskey TYPE seoclskey.
ls_clskey-clsname = ms_item-obj_name.
mo_object_oriented_object_fct->delete( ls_clskey ).
mi_object_oriented_object_fct->delete( ls_clskey ).
ENDMETHOD.
@ -313,7 +313,7 @@ CLASS zcl_abapgit_object_clas_old IMPLEMENTATION.
DATA: ls_class_key TYPE seoclskey.
ls_class_key-clsname = ms_item-obj_name.
rv_bool = mo_object_oriented_object_fct->exists( ls_class_key ).
rv_bool = mi_object_oriented_object_fct->exists( ls_class_key ).
ENDMETHOD.
@ -328,7 +328,7 @@ CLASS zcl_abapgit_object_clas_old IMPLEMENTATION.
FIELD-SYMBOLS <lv_incl> LIKE LINE OF lt_includes.
lt_includes = mo_object_oriented_object_fct->get_includes( ms_item-obj_name ).
lt_includes = mi_object_oriented_object_fct->get_includes( ms_item-obj_name ).
LOOP AT lt_includes ASSIGNING <lv_incl>.
rv_changed = check_prog_changed_since(
iv_program = <lv_incl>
@ -372,11 +372,11 @@ CLASS zcl_abapgit_object_clas_old IMPLEMENTATION.
version = seoc_version_inactive
force = seox_true.
lt_source = mo_object_oriented_object_fct->serialize_abap( ls_class_key ).
lt_source = mi_object_oriented_object_fct->serialize_abap( ls_class_key ).
mo_files->add_abap( lt_source ).
lt_source = mo_object_oriented_object_fct->serialize_abap(
lt_source = mi_object_oriented_object_fct->serialize_abap(
is_class_key = ls_class_key
iv_type = seop_ext_class_locals_def ).
IF lines( lt_source ) > 0.
@ -384,7 +384,7 @@ CLASS zcl_abapgit_object_clas_old IMPLEMENTATION.
it_abap = lt_source ). "#EC NOTEXT
ENDIF.
lt_source = mo_object_oriented_object_fct->serialize_abap(
lt_source = mi_object_oriented_object_fct->serialize_abap(
is_class_key = ls_class_key
iv_type = seop_ext_class_locals_imp ).
IF lines( lt_source ) > 0.
@ -392,17 +392,17 @@ CLASS zcl_abapgit_object_clas_old IMPLEMENTATION.
it_abap = lt_source ). "#EC NOTEXT
ENDIF.
lt_source = mo_object_oriented_object_fct->serialize_abap(
lt_source = mi_object_oriented_object_fct->serialize_abap(
is_class_key = ls_class_key
iv_type = seop_ext_class_testclasses ).
mv_skip_testclass = mo_object_oriented_object_fct->get_skip_test_classes( ).
mv_skip_testclass = mi_object_oriented_object_fct->get_skip_test_classes( ).
IF lines( lt_source ) > 0 AND mv_skip_testclass = abap_false.
mo_files->add_abap( iv_extra = 'testclasses'
it_abap = lt_source ). "#EC NOTEXT
ENDIF.
lt_source = mo_object_oriented_object_fct->serialize_abap(
lt_source = mi_object_oriented_object_fct->serialize_abap(
is_class_key = ls_class_key
iv_type = seop_ext_class_macros ).
IF lines( lt_source ) > 0.

View File

@ -17,7 +17,7 @@ CLASS zcl_abapgit_object_intf DEFINITION PUBLIC FINAL INHERITING FROM zcl_abapgi
RAISING zcx_abapgit_exception.
PRIVATE SECTION.
DATA mo_object_oriented_object_fct TYPE REF TO zif_abapgit_oo_object_fnc.
DATA mi_object_oriented_object_fct TYPE REF TO zif_abapgit_oo_object_fnc.
METHODS serialize_xml
IMPORTING io_xml TYPE REF TO zcl_abapgit_xml_output
@ -34,7 +34,7 @@ CLASS ZCL_ABAPGIT_OBJECT_INTF IMPLEMENTATION.
super->constructor(
is_item = is_item
iv_language = iv_language ).
mo_object_oriented_object_fct = zcl_abapgit_oo_factory=>make( ms_item-obj_type ).
mi_object_oriented_object_fct = zcl_abapgit_oo_factory=>make( ms_item-obj_type ).
ENDMETHOD.
@ -50,24 +50,24 @@ CLASS ZCL_ABAPGIT_OBJECT_INTF IMPLEMENTATION.
io_xml->read( EXPORTING iv_name = 'VSEOINTERF'
CHANGING cg_data = ls_vseointerf ).
mo_object_oriented_object_fct->create(
mi_object_oriented_object_fct->create(
EXPORTING
iv_package = iv_package
CHANGING
is_properties = ls_vseointerf ).
cg_properties = ls_vseointerf ).
mo_object_oriented_object_fct->deserialize_source(
mi_object_oriented_object_fct->deserialize_source(
is_key = ls_clskey
it_source = lt_source ).
io_xml->read( EXPORTING iv_name = 'DESCRIPTIONS'
CHANGING cg_data = lt_descriptions ).
mo_object_oriented_object_fct->update_descriptions(
mi_object_oriented_object_fct->update_descriptions(
is_key = ls_clskey
it_descriptions = lt_descriptions ).
mo_object_oriented_object_fct->add_to_activation_list( ms_item ).
mi_object_oriented_object_fct->add_to_activation_list( ms_item ).
ENDMETHOD.
@ -85,7 +85,7 @@ CLASS ZCL_ABAPGIT_OBJECT_INTF IMPLEMENTATION.
lv_object = ms_item-obj_name.
mo_object_oriented_object_fct->create_documentation(
mi_object_oriented_object_fct->create_documentation(
it_lines = lt_lines
iv_object_name = lv_object
iv_language = mv_language ).
@ -102,7 +102,7 @@ CLASS ZCL_ABAPGIT_OBJECT_INTF IMPLEMENTATION.
ls_clskey-clsname = ms_item-obj_name.
ls_vseointerf = mo_object_oriented_object_fct->get_interface_properties( ls_clskey ).
ls_vseointerf = mi_object_oriented_object_fct->get_interface_properties( ls_clskey ).
CLEAR: ls_vseointerf-uuid,
ls_vseointerf-author,
@ -116,7 +116,7 @@ CLASS ZCL_ABAPGIT_OBJECT_INTF IMPLEMENTATION.
io_xml->add( iv_name = 'VSEOINTERF'
ig_data = ls_vseointerf ).
lt_lines = mo_object_oriented_object_fct->read_documentation(
lt_lines = mi_object_oriented_object_fct->read_documentation(
iv_class_name = ls_clskey-clsname
iv_language = mv_language ).
IF lines( lt_lines ) > 0.
@ -124,7 +124,7 @@ CLASS ZCL_ABAPGIT_OBJECT_INTF IMPLEMENTATION.
ig_data = lt_lines ).
ENDIF.
lt_descriptions = mo_object_oriented_object_fct->read_descriptions( ls_clskey-clsname ).
lt_descriptions = mi_object_oriented_object_fct->read_descriptions( ls_clskey-clsname ).
IF lines( lt_descriptions ) > 0.
io_xml->add( iv_name = 'DESCRIPTIONS'
ig_data = lt_descriptions ).
@ -147,7 +147,7 @@ CLASS ZCL_ABAPGIT_OBJECT_INTF IMPLEMENTATION.
ls_reposrc LIKE LINE OF lt_reposrc,
lt_includes TYPE STANDARD TABLE OF ty_includes.
lt_includes = mo_object_oriented_object_fct->get_includes( ms_item-obj_name ).
lt_includes = mi_object_oriented_object_fct->get_includes( ms_item-obj_name ).
ASSERT lines( lt_includes ) > 0.
SELECT unam udat utime FROM reposrc
@ -175,7 +175,7 @@ CLASS ZCL_ABAPGIT_OBJECT_INTF IMPLEMENTATION.
DATA: ls_clskey TYPE seoclskey.
ls_clskey-clsname = ms_item-obj_name.
mo_object_oriented_object_fct->delete( ls_clskey ).
mi_object_oriented_object_fct->delete( ls_clskey ).
ENDMETHOD.
@ -194,7 +194,7 @@ CLASS ZCL_ABAPGIT_OBJECT_INTF IMPLEMENTATION.
ls_class_key-clsname = ms_item-obj_name.
rv_bool = mo_object_oriented_object_fct->exists( ls_class_key ).
rv_bool = mi_object_oriented_object_fct->exists( ls_class_key ).
IF rv_bool = abap_true.
SELECT SINGLE category FROM seoclassdf INTO lv_category
@ -219,7 +219,7 @@ CLASS ZCL_ABAPGIT_OBJECT_INTF IMPLEMENTATION.
lv_program TYPE program,
lt_includes TYPE seoincl_t.
lt_includes = mo_object_oriented_object_fct->get_includes( ms_item-obj_name ).
lt_includes = mi_object_oriented_object_fct->get_includes( ms_item-obj_name ).
READ TABLE lt_includes INDEX 1 INTO lv_program.
"lv_program = cl_oo_classname_service=>get_interfacepool_name( lv_clsname ).
rv_changed = check_prog_changed_since(
@ -259,7 +259,7 @@ CLASS ZCL_ABAPGIT_OBJECT_INTF IMPLEMENTATION.
version = seoc_version_inactive
force = seox_true.
lt_source = mo_object_oriented_object_fct->serialize_abap( ls_interface_key ).
lt_source = mi_object_oriented_object_fct->serialize_abap( ls_interface_key ).
mo_files->add_abap( lt_source ).

View File

@ -162,7 +162,7 @@ CLASS ZCL_ABAPGIT_OO_BASE IMPLEMENTATION.
METHOD zif_abapgit_oo_object_fnc~exists.
CALL FUNCTION 'SEO_CLASS_EXISTENCE_CHECK'
EXPORTING
clskey = iv_object_name
clskey = is_object_name
EXCEPTIONS
not_specified = 1
not_existing = 2

View File

@ -21,7 +21,7 @@ CLASS zcl_abapgit_oo_class IMPLEMENTATION.
devclass = iv_package
overwrite = iv_overwrite
CHANGING
class = is_properties
class = cg_properties
EXCEPTIONS
existing = 1
is_interface = 2

View File

@ -304,25 +304,25 @@ CLASS zcl_abapgit_oo_class_new IMPLEMENTATION.
METHOD update_source_index.
CONSTANTS:
co_version_active TYPE r3state VALUE 'A', "#EC NOTEXT
co_version_inactive TYPE r3state VALUE 'I'. "#EC NOTEXT
lc_version_active TYPE r3state VALUE 'A', "#EC NOTEXT
lc_version_inactive TYPE r3state VALUE 'I'. "#EC NOTEXT
" dynamic invocation, IF_OO_SOURCE_POS_INDEX_HELPER doesn't exist in 702.
DATA li_index_helper TYPE REF TO object.
DATA lo_index_helper TYPE REF TO object.
TRY.
CREATE OBJECT li_index_helper TYPE ('CL_OO_SOURCE_POS_INDEX_HELPER').
CREATE OBJECT lo_index_helper TYPE ('CL_OO_SOURCE_POS_INDEX_HELPER').
CALL METHOD li_index_helper->('IF_OO_SOURCE_POS_INDEX_HELPER~CREATE_INDEX_WITH_SCANNER')
CALL METHOD lo_index_helper->('IF_OO_SOURCE_POS_INDEX_HELPER~CREATE_INDEX_WITH_SCANNER')
EXPORTING
class_name = iv_clsname
version = co_version_active
version = lc_version_active
scanner = io_scanner.
CALL METHOD li_index_helper->('IF_OO_SOURCE_POS_INDEX_HELPER~DELETE_INDEX')
CALL METHOD lo_index_helper->('IF_OO_SOURCE_POS_INDEX_HELPER~DELETE_INDEX')
EXPORTING
class_name = iv_clsname
version = co_version_inactive.
version = lc_version_inactive.
CATCH cx_root.
" it's probably okay to no update the index
@ -341,7 +341,7 @@ CLASS zcl_abapgit_oo_class_new IMPLEMENTATION.
overwrite = iv_overwrite
version = seoc_version_active
CHANGING
class = is_properties
class = cg_properties
EXCEPTIONS
existing = 1
is_interface = 2

View File

@ -15,7 +15,7 @@ CLASS zcl_abapgit_oo_interface IMPLEMENTATION.
devclass = iv_package
overwrite = iv_overwrite
CHANGING
interface = is_properties
interface = cg_properties
EXCEPTIONS
existing = 1
is_class = 2

View File

@ -11,7 +11,7 @@ INTERFACE zif_abapgit_oo_object_fnc PUBLIC.
iv_package TYPE devclass
iv_overwrite TYPE seox_boolean DEFAULT seox_true
CHANGING
is_properties TYPE any
cg_properties TYPE any
RAISING
zcx_abapgit_exception,
generate_locals
@ -69,7 +69,7 @@ INTERFACE zif_abapgit_oo_object_fnc PUBLIC.
zcx_abapgit_exception,
exists
IMPORTING
iv_object_name TYPE seoclskey
is_object_name TYPE seoclskey
RETURNING
VALUE(rv_exists) TYPE abap_bool,
serialize_abap

View File

@ -58,7 +58,7 @@ CLASS zcl_abapgit_exit IMPLEMENTATION.
EXPORTING
iv_repo_url = iv_repo_url
CHANGING
c_proxy_authentication = c_proxy_authentication ).
cv_proxy_authentication = cv_proxy_authentication ).
CATCH cx_sy_ref_is_initial cx_sy_dyn_call_illegal_method.
ENDTRY.
@ -72,7 +72,7 @@ CLASS zcl_abapgit_exit IMPLEMENTATION.
EXPORTING
iv_repo_url = iv_repo_url
CHANGING
c_proxy_port = c_proxy_port ).
cv_proxy_port = cv_proxy_port ).
CATCH cx_sy_ref_is_initial cx_sy_dyn_call_illegal_method.
ENDTRY.
@ -86,7 +86,7 @@ CLASS zcl_abapgit_exit IMPLEMENTATION.
EXPORTING
iv_repo_url = iv_repo_url
CHANGING
c_proxy_url = c_proxy_url ).
cv_proxy_url = cv_proxy_url ).
CATCH cx_sy_ref_is_initial cx_sy_dyn_call_illegal_method.
ENDTRY.

View File

@ -10,13 +10,13 @@ INTERFACE zif_abapgit_exit PUBLIC.
RETURNING VALUE(rv_allowed) TYPE abap_bool,
change_proxy_url
IMPORTING iv_repo_url TYPE csequence
CHANGING c_proxy_url TYPE string,
CHANGING cv_proxy_url TYPE string,
change_proxy_port
IMPORTING iv_repo_url TYPE csequence
CHANGING c_proxy_port TYPE string,
CHANGING cv_proxy_port TYPE string,
change_proxy_authentication
IMPORTING iv_repo_url TYPE csequence
CHANGING c_proxy_authentication TYPE abap_bool,
CHANGING cv_proxy_authentication TYPE abap_bool,
http_client
IMPORTING
ii_client TYPE REF TO if_http_client,