CI Tests: Small improvements (#4618)

- Allow passing of longer test repo names (len > 4)
- Raise errors after each test phase
This commit is contained in:
Marc Bernard 2021-03-09 17:00:36 +01:00 committed by GitHub
parent 0f2020b5c1
commit f28d3e9441
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -7,12 +7,11 @@ CLASS zcl_abapgit_objects_ci_tests DEFINITION
RISK LEVEL CRITICAL . RISK LEVEL CRITICAL .
PUBLIC SECTION. PUBLIC SECTION.
CLASS-METHODS:
run
IMPORTING
iv_object TYPE tadir-object
iv_url TYPE string OPTIONAL.
CLASS-METHODS run
IMPORTING
!iv_object TYPE string
!iv_url TYPE string OPTIONAL .
PROTECTED SECTION. PROTECTED SECTION.
PRIVATE SECTION. PRIVATE SECTION.
ENDCLASS. ENDCLASS.
@ -56,7 +55,7 @@ CLASS zcl_abapgit_objects_ci_tests IMPLEMENTATION.
li_exit = zcl_abapgit_exit=>get_instance( ). li_exit = zcl_abapgit_exit=>get_instance( ).
li_exit->get_ci_tests( li_exit->get_ci_tests(
EXPORTING EXPORTING
iv_object = iv_object iv_object = |{ iv_object }|
CHANGING CHANGING
ct_ci_repos = lt_repos ). ct_ci_repos = lt_repos ).
@ -127,20 +126,11 @@ CLASS zcl_abapgit_objects_ci_tests IMPLEMENTATION.
ENDCASE. ENDCASE.
ASSIGN COMPONENT lv_check OF STRUCTURE <ls_repo_result> TO <lv_result>. ASSIGN COMPONENT lv_check OF STRUCTURE <ls_repo_result> TO <lv_result>.
ASSERT sy-subrc = 0. ASSERT sy-subrc = 0.
IF <lv_result> <> 'OK'. cl_abap_unit_assert=>assert_equals(
IF lv_msg IS INITIAL. exp = 'OK'
lv_msg = |{ lv_check }:{ <lv_result> }|. act = <lv_result>
ELSE. msg = |{ <lv_repo> }: { lv_check } = { <lv_result> }| ).
lv_msg = |{ lv_msg } { lv_check }:{ <lv_result> }|.
ENDIF.
ENDIF.
ENDDO. ENDDO.
cl_abap_unit_assert=>assert_equals(
exp = ''
act = lv_msg
msg = |{ <lv_repo> } { lv_msg }| ).
ENDLOOP. ENDLOOP.
CATCH zcx_abapgit_exception INTO lx_error. CATCH zcx_abapgit_exception INTO lx_error.