From f2f82278e754c8e61cff4beff89164f1b42365ec Mon Sep 17 00:00:00 2001 From: Alexander Tsybulsky Date: Tue, 8 Oct 2019 09:03:57 +0300 Subject: [PATCH] Serialize master lang only + settings UI improvements (#2954) * repo settings ui improvements * serialize_master_lang_only UI * downport * connect settings and serialization (MSAG) * dtel doma tran prog fugr * linter fixes --- src/objects/zcl_abapgit_object_doma.clas.abap | 3 + src/objects/zcl_abapgit_object_dtel.clas.abap | 3 + src/objects/zcl_abapgit_object_fugr.clas.abap | 5 + src/objects/zcl_abapgit_object_msag.clas.abap | 4 + src/objects/zcl_abapgit_object_prog.clas.abap | 3 + src/objects/zcl_abapgit_object_tran.clas.abap | 4 + src/persist/zif_abapgit_persistence.intf.abap | 1 + src/ui/zabapgit_css_common.w3mi.data.css | 11 +- .../zcl_abapgit_gui_page_repo_sett.clas.abap | 180 +++++++++++------- src/xml/zcl_abapgit_xml_output.clas.abap | 23 +++ src/zabapgit_parallel.fugr.xml | 16 +- ...lel.fugr.z_abapgit_serialize_parallel.abap | 2 + src/zcl_abapgit_objects.clas.abap | 6 + src/zcl_abapgit_repo.clas.abap | 4 +- src/zcl_abapgit_serialize.clas.abap | 8 +- src/zcl_abapgit_zip.clas.abap | 4 +- 16 files changed, 201 insertions(+), 76 deletions(-) diff --git a/src/objects/zcl_abapgit_object_doma.clas.abap b/src/objects/zcl_abapgit_object_doma.clas.abap index 23bc34def..831caa536 100644 --- a/src/objects/zcl_abapgit_object_doma.clas.abap +++ b/src/objects/zcl_abapgit_object_doma.clas.abap @@ -125,6 +125,9 @@ CLASS ZCL_ABAPGIT_OBJECT_DOMA IMPLEMENTATION. LIKE LINE OF lt_dd01_texts, LIKE LINE OF lt_dd07_texts. + IF io_xml->i18n_params( )-serialize_master_lang_only = abap_true. + RETURN. + ENDIF. lv_name = ms_item-obj_name. diff --git a/src/objects/zcl_abapgit_object_dtel.clas.abap b/src/objects/zcl_abapgit_object_dtel.clas.abap index c971b8d7d..e83c57fbf 100644 --- a/src/objects/zcl_abapgit_object_dtel.clas.abap +++ b/src/objects/zcl_abapgit_object_dtel.clas.abap @@ -95,6 +95,9 @@ CLASS ZCL_ABAPGIT_OBJECT_DTEL IMPLEMENTATION. FIELD-SYMBOLS: LIKE LINE OF lt_i18n_langs, LIKE LINE OF lt_dd04_texts. + IF io_xml->i18n_params( )-serialize_master_lang_only = abap_true. + RETURN. + ENDIF. lv_name = ms_item-obj_name. diff --git a/src/objects/zcl_abapgit_object_fugr.clas.abap b/src/objects/zcl_abapgit_object_fugr.clas.abap index 47efb22cf..9586e9495 100644 --- a/src/objects/zcl_abapgit_object_fugr.clas.abap +++ b/src/objects/zcl_abapgit_object_fugr.clas.abap @@ -794,6 +794,11 @@ CLASS ZCL_ABAPGIT_OBJECT_FUGR IMPLEMENTATION. lt_tpool TYPE textpool_table. FIELD-SYMBOLS LIKE LINE OF lt_tpool_i18n. + + IF io_xml->i18n_params( )-serialize_master_lang_only = abap_true. + RETURN. + ENDIF. + " Table d010tinf stores info. on languages in which program is maintained " Select all active translations of program texts " Skip master language - it was already serialized diff --git a/src/objects/zcl_abapgit_object_msag.clas.abap b/src/objects/zcl_abapgit_object_msag.clas.abap index 7e034523a..ccdf952d8 100644 --- a/src/objects/zcl_abapgit_object_msag.clas.abap +++ b/src/objects/zcl_abapgit_object_msag.clas.abap @@ -205,6 +205,10 @@ CLASS ZCL_ABAPGIT_OBJECT_MSAG IMPLEMENTATION. lv_msg_id = ms_item-obj_name. + IF io_xml->i18n_params( )-serialize_master_lang_only = abap_true. + RETURN. " skip + ENDIF. + " Collect additional languages " Skip master lang - it has been already serialized SELECT DISTINCT sprsl AS langu INTO TABLE lt_i18n_langs diff --git a/src/objects/zcl_abapgit_object_prog.clas.abap b/src/objects/zcl_abapgit_object_prog.clas.abap index 167337344..059d83276 100644 --- a/src/objects/zcl_abapgit_object_prog.clas.abap +++ b/src/objects/zcl_abapgit_object_prog.clas.abap @@ -69,6 +69,9 @@ CLASS ZCL_ABAPGIT_OBJECT_PROG IMPLEMENTATION. FIELD-SYMBOLS LIKE LINE OF lt_tpool_i18n. + IF io_xml->i18n_params( )-serialize_master_lang_only = abap_true. + RETURN. + ENDIF. " Table d010tinf stores info. on languages in which program is maintained " Select all active translations of program texts diff --git a/src/objects/zcl_abapgit_object_tran.clas.abap b/src/objects/zcl_abapgit_object_tran.clas.abap index 7f946f150..a06da1f79 100644 --- a/src/objects/zcl_abapgit_object_tran.clas.abap +++ b/src/objects/zcl_abapgit_object_tran.clas.abap @@ -319,6 +319,10 @@ CLASS ZCL_ABAPGIT_OBJECT_TRAN IMPLEMENTATION. DATA lt_tpool_i18n TYPE TABLE OF tstct. + IF io_xml->i18n_params( )-serialize_master_lang_only = abap_true. + RETURN. + ENDIF. + " Skip master language - it was already serialized " Don't serialize t-code itself SELECT sprsl ttext diff --git a/src/persist/zif_abapgit_persistence.intf.abap b/src/persist/zif_abapgit_persistence.intf.abap index 13b7c45d1..3a3a13f23 100644 --- a/src/persist/zif_abapgit_persistence.intf.abap +++ b/src/persist/zif_abapgit_persistence.intf.abap @@ -26,6 +26,7 @@ INTERFACE zif_abapgit_persistence PUBLIC. only_local_objects TYPE abap_bool, code_inspector_check_variant TYPE sci_chkv, block_commit TYPE abap_bool, + serialize_master_lang_only TYPE abap_bool, END OF ty_local_settings. TYPES: ty_local_checksum_tt TYPE STANDARD TABLE OF ty_local_checksum WITH DEFAULT KEY. diff --git a/src/ui/zabapgit_css_common.w3mi.data.css b/src/ui/zabapgit_css_common.w3mi.data.css index 38da21386..0d9cd80b3 100644 --- a/src/ui/zabapgit_css_common.w3mi.data.css +++ b/src/ui/zabapgit_css_common.w3mi.data.css @@ -304,7 +304,7 @@ form.aligned-form span.cell { display: table-cell; } /* SETTINGS STYLES */ div.settings_container { - padding: 0.5em; + padding: 0.5em 0.5em 1em; font-size: 10pt; } @@ -312,6 +312,15 @@ div.settings_section { margin-left:50px } +table.settings td:first-child { + padding-left: 1em; + padding-right: 1em; +} + +table.settings-package-requirements { + /*max-width: 300px;*/ +} + /* DIFF */ div.diff { padding: 0.7em diff --git a/src/ui/zcl_abapgit_gui_page_repo_sett.clas.abap b/src/ui/zcl_abapgit_gui_page_repo_sett.clas.abap index 067458f90..32ee16a46 100644 --- a/src/ui/zcl_abapgit_gui_page_repo_sett.clas.abap +++ b/src/ui/zcl_abapgit_gui_page_repo_sett.clas.abap @@ -50,6 +50,17 @@ CLASS zcl_abapgit_gui_page_repo_sett DEFINITION !it_postdata TYPE cnht_post_data_tab RETURNING VALUE(rt_post_fields) TYPE tihttpnvp . + METHODS render_dot_abapgit_reqs + IMPORTING + io_html TYPE REF TO zcl_abapgit_html + it_requirements TYPE zif_abapgit_dot_abapgit=>ty_requirement_tt. + METHODS render_table_row + IMPORTING + iv_name TYPE string + iv_value TYPE string + RETURNING + VALUE(rv_html) TYPE string. + METHODS render_content REDEFINITION . @@ -84,13 +95,12 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_REPO_SETT IMPLEMENTATION. CREATE OBJECT ro_html. ro_html->add( '
' ). - ro_html->add( '
' ). + ro_html->add( || ). render_dot_abapgit( ro_html ). render_local_settings( ro_html ). - ro_html->add( '
' ). + ro_html->add( '' ). ro_html->add( '
' ). ro_html->add( '
' ). @@ -99,60 +109,76 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_REPO_SETT IMPLEMENTATION. METHOD render_dot_abapgit. - CONSTANTS: lc_requirement_edit_count TYPE i VALUE 5. DATA: ls_dot TYPE zif_abapgit_dot_abapgit=>ty_dot_abapgit, + lv_select_html TYPE string, lv_selected TYPE string, - lt_folder_logic TYPE string_table, - lv_req_index TYPE i, - lv_requirement_count TYPE i. + lt_folder_logic TYPE string_table. - FIELD-SYMBOLS: TYPE LINE OF string_table, - TYPE zif_abapgit_dot_abapgit=>ty_requirement. + FIELD-SYMBOLS: TYPE LINE OF string_table. ls_dot = mo_repo->get_dot_abapgit( )->get_data( ). - lv_requirement_count = lines( ls_dot-requirements ). - IF lv_requirement_count < lc_requirement_edit_count. - DO - lv_requirement_count + lc_requirement_edit_count TIMES. - INSERT INITIAL LINE INTO TABLE ls_dot-requirements. - ENDDO. - ENDIF. - - INSERT zif_abapgit_dot_abapgit=>c_folder_logic-full - INTO TABLE lt_folder_logic. - - INSERT zif_abapgit_dot_abapgit=>c_folder_logic-prefix - INTO TABLE lt_folder_logic. + APPEND zif_abapgit_dot_abapgit=>c_folder_logic-full TO lt_folder_logic. + APPEND zif_abapgit_dot_abapgit=>c_folder_logic-prefix TO lt_folder_logic. io_html->add( '

.abapgit.xml

' ). - io_html->add( 'Folder logic: '. LOOP AT lt_folder_logic ASSIGNING . IF ls_dot-folder_logic = . - lv_selected = 'selected'. + lv_selected = ' selected'. ELSE. CLEAR: lv_selected. ENDIF. - io_html->add( || ). + lv_select_html = lv_select_html + && ||. ENDLOOP. + lv_select_html = lv_select_html && ''. - io_html->add( '' ). - io_html->add( '
' ). + io_html->add( render_table_row( + iv_name = 'Folder logic' + iv_value = lv_select_html + ) ). - io_html->add( 'Starting folder: ' ). - io_html->add( '
' ). + io_html->add( render_table_row( + iv_name = 'Starting folder' + iv_value = || + ) ). + + io_html->add( '' ). + + render_dot_abapgit_reqs( + it_requirements = ls_dot-requirements + io_html = io_html ). + + ENDMETHOD. + + + METHOD render_dot_abapgit_reqs. + + CONSTANTS: lc_requirement_edit_min_count TYPE i VALUE 5. + DATA lv_req_index TYPE i. + DATA lv_requirement_count TYPE i. + DATA lt_requirements LIKE it_requirements. + FIELD-SYMBOLS TYPE zif_abapgit_dot_abapgit=>ty_requirement. + + lt_requirements = it_requirements. + lv_requirement_count = lines( lt_requirements ). + IF lv_requirement_count < lc_requirement_edit_min_count. + DO - lv_requirement_count + lc_requirement_edit_min_count TIMES. + APPEND INITIAL LINE TO lt_requirements. + ENDDO. + ENDIF. io_html->add( '

Requirements

' ). - io_html->add( '' ). + io_html->add( '
' ). io_html->add( '' ). - LOOP AT ls_dot-requirements ASSIGNING . + LOOP AT lt_requirements ASSIGNING . lv_req_index = sy-tabix. io_html->add( '' ). @@ -175,17 +201,16 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_REPO_SETT IMPLEMENTATION. DATA: lv_checked TYPE string, ls_settings TYPE zif_abapgit_persistence=>ty_repo-local_settings. - - ls_settings = mo_repo->get_local_settings( ). io_html->add( '

Local settings

' ). + io_html->add( '
Software ComponentMin ReleaseMin Patch
' ). IF mo_repo->is_offline( ) = abap_false. - io_html->add( '
' ). - io_html->add( 'Display name: ' ). - io_html->add( '
' ). + io_html->add( render_table_row( + iv_name = 'Display name' + iv_value = || + ) ). ENDIF. CLEAR lv_checked. @@ -196,32 +221,64 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_REPO_SETT IMPLEMENTATION. lv_checked = | checked disabled|. ENDIF. ENDIF. - io_html->add( |Write protected
| ). + io_html->add( render_table_row( + iv_name = 'Write protected' + iv_value = || + ) ). CLEAR lv_checked. IF ls_settings-ignore_subpackages = abap_true. lv_checked = | checked|. ENDIF. - io_html->add( |Ignore subpackages
| ). + io_html->add( render_table_row( + iv_name = 'Ignore subpackages' + iv_value = || + ) ). CLEAR lv_checked. IF ls_settings-only_local_objects = abap_true. lv_checked = | checked|. ENDIF. - io_html->add( |Only local objects
| ). + io_html->add( render_table_row( + iv_name = 'Only local objects' + iv_value = || + ) ). - io_html->add( '
' ). - io_html->add( 'Code inspector check variant: ' ). - io_html->add( '
' ). + io_html->add( render_table_row( + iv_name = 'Code inspector check variant' + iv_value = || + ) ). CLEAR lv_checked. IF ls_settings-block_commit = abap_true. lv_checked = | checked|. ENDIF. - io_html->add( |Block commit commit/push if code inspection has erros: | - && |
| ). + io_html->add( render_table_row( + iv_name = 'Block commit if code inspection has errors' + iv_value = || + ) ). + CLEAR lv_checked. + IF ls_settings-serialize_master_lang_only = abap_true. + lv_checked = | checked|. + ENDIF. + io_html->add( render_table_row( + iv_name = 'Serialize master language only' + iv_value = || + ) ). + + io_html->add( '
' ). + + ENDMETHOD. + + + METHOD render_table_row. + + rv_html = '' + && |{ iv_name }| + && |{ iv_value }| + && ''. ENDMETHOD. @@ -293,25 +350,13 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_REPO_SETT IMPLEMENTATION. ENDIF. READ TABLE it_post_fields INTO ls_post_field WITH KEY name = 'write_protected' value = 'on'. - IF sy-subrc = 0. - ls_settings-write_protected = abap_true. - ELSE. - ls_settings-write_protected = abap_false. - ENDIF. + ls_settings-write_protected = boolc( sy-subrc = 0 ). READ TABLE it_post_fields INTO ls_post_field WITH KEY name = 'ignore_subpackages' value = 'on'. - IF sy-subrc = 0. - ls_settings-ignore_subpackages = abap_true. - ELSE. - ls_settings-ignore_subpackages = abap_false. - ENDIF. + ls_settings-ignore_subpackages = boolc( sy-subrc = 0 ). READ TABLE it_post_fields INTO ls_post_field WITH KEY name = 'only_local_objects' value = 'on'. - IF sy-subrc = 0. - ls_settings-only_local_objects = abap_true. - ELSE. - ls_settings-only_local_objects = abap_false. - ENDIF. + ls_settings-only_local_objects = boolc( sy-subrc = 0 ). READ TABLE it_post_fields INTO ls_post_field WITH KEY name = 'check_variant'. ASSERT sy-subrc = 0. @@ -322,17 +367,16 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_REPO_SETT IMPLEMENTATION. ls_settings-code_inspector_check_variant = lv_check_variant. READ TABLE it_post_fields INTO ls_post_field WITH KEY name = 'block_commit' value = 'on'. - IF sy-subrc = 0. - ls_settings-block_commit = abap_true. - ELSE. - ls_settings-block_commit = abap_false. - ENDIF. + ls_settings-block_commit = boolc( sy-subrc = 0 ). IF ls_settings-block_commit = abap_true AND ls_settings-code_inspector_check_variant IS INITIAL. zcx_abapgit_exception=>raise( |If block commit is active, a check variant has to be maintained.| ). ENDIF. + READ TABLE it_post_fields INTO ls_post_field WITH KEY name = 'serialize_master_lang_only' value = 'on'. + ls_settings-serialize_master_lang_only = boolc( sy-subrc = 0 ). + mo_repo->set_local_settings( ls_settings ). ENDMETHOD. diff --git a/src/xml/zcl_abapgit_xml_output.clas.abap b/src/xml/zcl_abapgit_xml_output.clas.abap index 86b215dcf..8f3f0343c 100644 --- a/src/xml/zcl_abapgit_xml_output.clas.abap +++ b/src/xml/zcl_abapgit_xml_output.clas.abap @@ -5,6 +5,11 @@ CLASS zcl_abapgit_xml_output DEFINITION PUBLIC SECTION. + TYPES: + BEGIN OF ty_i18n_params, + serialize_master_lang_only TYPE abap_bool, + END OF ty_i18n_params. + METHODS add IMPORTING !iv_name TYPE clike @@ -24,10 +29,17 @@ CLASS zcl_abapgit_xml_output DEFINITION !is_metadata TYPE zif_abapgit_definitions=>ty_metadata OPTIONAL RETURNING VALUE(rv_xml) TYPE string . + METHODS i18n_params + IMPORTING + iv_serialize_master_lang_only TYPE ty_i18n_params-serialize_master_lang_only OPTIONAL + RETURNING + VALUE(rs_params) TYPE ty_i18n_params. + PROTECTED SECTION. PRIVATE SECTION. DATA mi_raw TYPE REF TO if_ixml_element . + DATA ms_i18n_params TYPE ty_i18n_params . METHODS build_asx_node RETURNING @@ -110,6 +122,17 @@ CLASS ZCL_ABAPGIT_XML_OUTPUT IMPLEMENTATION. ENDMETHOD. + METHOD i18n_params. + + IF iv_serialize_master_lang_only IS SUPPLIED. + ms_i18n_params-serialize_master_lang_only = iv_serialize_master_lang_only. + ENDIF. + + rs_params = ms_i18n_params. + + ENDMETHOD. + + METHOD render. DATA: li_git TYPE REF TO if_ixml_element, diff --git a/src/zabapgit_parallel.fugr.xml b/src/zabapgit_parallel.fugr.xml index 5474e28a9..954240caa 100644 --- a/src/zabapgit_parallel.fugr.xml +++ b/src/zabapgit_parallel.fugr.xml @@ -33,6 +33,10 @@ IV_PATH STRING + + IV_SERIALIZE_MASTER_LANG_ONLY + CHAR1 + @@ -80,19 +84,25 @@ 005 - EV_RESULT + IV_SERIALIZE_MASTER_LANG_ONLY P + Single-Character Indicator 006 - EV_PATH + EV_RESULT P 007 + + EV_PATH + P + 008 + ERROR X - 008 + 009 diff --git a/src/zabapgit_parallel.fugr.z_abapgit_serialize_parallel.abap b/src/zabapgit_parallel.fugr.z_abapgit_serialize_parallel.abap index 66a6364cf..c925b50fc 100644 --- a/src/zabapgit_parallel.fugr.z_abapgit_serialize_parallel.abap +++ b/src/zabapgit_parallel.fugr.z_abapgit_serialize_parallel.abap @@ -7,6 +7,7 @@ FUNCTION z_abapgit_serialize_parallel. *" VALUE(IV_DEVCLASS) TYPE TADIR-DEVCLASS *" VALUE(IV_LANGUAGE) TYPE SY-LANGU *" VALUE(IV_PATH) TYPE STRING +*" VALUE(IV_SERIALIZE_MASTER_LANG_ONLY) TYPE CHAR1 *" EXPORTING *" VALUE(EV_RESULT) TYPE XSTRING *" VALUE(EV_PATH) TYPE STRING @@ -27,6 +28,7 @@ FUNCTION z_abapgit_serialize_parallel. lt_files = zcl_abapgit_objects=>serialize( is_item = ls_item + iv_serialize_master_lang_only = iv_serialize_master_lang_only iv_language = iv_language ). EXPORT data = lt_files TO DATA BUFFER ev_result. diff --git a/src/zcl_abapgit_objects.clas.abap b/src/zcl_abapgit_objects.clas.abap index d856a11fd..607145fae 100644 --- a/src/zcl_abapgit_objects.clas.abap +++ b/src/zcl_abapgit_objects.clas.abap @@ -37,6 +37,7 @@ CLASS zcl_abapgit_objects DEFINITION IMPORTING !is_item TYPE zif_abapgit_definitions=>ty_item !iv_language TYPE spras + !iv_serialize_master_lang_only TYPE abap_bool DEFAULT abap_false RETURNING VALUE(rs_files_and_item) TYPE zcl_abapgit_objects=>ty_serialization RAISING @@ -1108,6 +1109,11 @@ CLASS ZCL_ABAPGIT_OBJECTS IMPLEMENTATION. iv_language = iv_language ). li_obj->mo_files = lo_files. CREATE OBJECT lo_xml. + + IF iv_serialize_master_lang_only = abap_true. + lo_xml->i18n_params( iv_serialize_master_lang_only = abap_true ). + ENDIF. + li_obj->serialize( lo_xml ). lo_files->add_xml( io_xml = lo_xml is_metadata = li_obj->get_metadata( ) ). diff --git a/src/zcl_abapgit_repo.clas.abap b/src/zcl_abapgit_repo.clas.abap index 04d25f947..2d522eeb0 100644 --- a/src/zcl_abapgit_repo.clas.abap +++ b/src/zcl_abapgit_repo.clas.abap @@ -407,7 +407,9 @@ CLASS ZCL_ABAPGIT_REPO IMPLEMENTATION. apply_filter( EXPORTING it_filter = it_filter CHANGING ct_tadir = lt_tadir ). - CREATE OBJECT lo_serialize. + CREATE OBJECT lo_serialize + EXPORTING + iv_serialize_master_lang_only = ms_data-local_settings-serialize_master_lang_only. * if there are less than 10 objects run in single thread * this helps a lot when debugging, plus performance gain diff --git a/src/zcl_abapgit_serialize.clas.abap b/src/zcl_abapgit_serialize.clas.abap index da5dc1fa3..61bd13ad3 100644 --- a/src/zcl_abapgit_serialize.clas.abap +++ b/src/zcl_abapgit_serialize.clas.abap @@ -4,7 +4,9 @@ CLASS zcl_abapgit_serialize DEFINITION PUBLIC SECTION. - METHODS constructor. + METHODS constructor + IMPORTING + iv_serialize_master_lang_only TYPE abap_bool DEFAULT abap_false. METHODS on_end_of_task IMPORTING !p_task TYPE clike . @@ -26,6 +28,7 @@ CLASS zcl_abapgit_serialize DEFINITION DATA mv_free TYPE i . DATA mi_log TYPE REF TO zif_abapgit_log . DATA mv_group TYPE rzlli_apcl . + DATA mv_serialize_master_lang_only TYPE abap_bool. METHODS add_to_return IMPORTING @@ -89,6 +92,7 @@ CLASS ZCL_ABAPGIT_SERIALIZE IMPLEMENTATION. ENDIF. mv_group = 'parallel_generators' ##NO_TEXT. + mv_serialize_master_lang_only = iv_serialize_master_lang_only. ENDMETHOD. @@ -209,6 +213,7 @@ CLASS ZCL_ABAPGIT_SERIALIZE IMPLEMENTATION. iv_devclass = is_tadir-devclass iv_language = iv_language iv_path = is_tadir-path + iv_serialize_master_lang_only = mv_serialize_master_lang_only EXCEPTIONS system_failure = 1 MESSAGE lv_msg communication_failure = 2 MESSAGE lv_msg @@ -242,6 +247,7 @@ CLASS ZCL_ABAPGIT_SERIALIZE IMPLEMENTATION. TRY. ls_fils_item = zcl_abapgit_objects=>serialize( is_item = ls_fils_item-item + iv_serialize_master_lang_only = mv_serialize_master_lang_only iv_language = iv_language ). add_to_return( is_fils_item = ls_fils_item diff --git a/src/zcl_abapgit_zip.clas.abap b/src/zcl_abapgit_zip.clas.abap index 3a655d538..42b7fe657 100644 --- a/src/zcl_abapgit_zip.clas.abap +++ b/src/zcl_abapgit_zip.clas.abap @@ -70,7 +70,7 @@ ENDCLASS. -CLASS zcl_abapgit_zip IMPLEMENTATION. +CLASS ZCL_ABAPGIT_ZIP IMPLEMENTATION. METHOD encode_files. @@ -136,7 +136,7 @@ CLASS zcl_abapgit_zip IMPLEMENTATION. ls_tadir = zcl_abapgit_ui_factory=>get_popups( )->popup_object( ). IF ls_tadir IS INITIAL. - MESSAGE |Object couldn't be found| TYPE 'S' DISPLAY LIKE 'E'. + MESSAGE 'Object couldn''t be found' TYPE 'S' DISPLAY LIKE 'E'. ENDIF. ENDWHILE.