diff --git a/abaplint.json b/abaplint.json index d09fd9af7..a443067b4 100644 --- a/abaplint.json +++ b/abaplint.json @@ -439,15 +439,19 @@ "unreachable_code": true, "use_new": true, "when_others_last": true, + "omit_parameter_name": { + "exclude": ["/json/"] + }, "whitespace_end": true }, "targetRules": { "double_space": true, - "omit_parameter_name": true, "unnecessary_pragma": { "allowNoTextGlobal": true }, - "select_add_order_by": true, + "select_add_order_by": { + "skipForAllEntries": true + }, "slow_parameter_passing": true, "select_single_full_key": true, "unused_variables": true diff --git a/package.json b/package.json index 42ed8355b..9ba611920 100644 --- a/package.json +++ b/package.json @@ -27,7 +27,7 @@ ] }, "devDependencies": { - "@abaplint/cli": "^2.102.57", + "@abaplint/cli": "^2.102.58", "@abaplint/database-sqlite": "^2.7.101", "@abaplint/runtime": "^2.7.105", "@abaplint/transpiler-cli": "^2.7.105", diff --git a/src/cts/zcl_abapgit_transport_mass.clas.locals_imp.abap b/src/cts/zcl_abapgit_transport_mass.clas.locals_imp.abap index 2b2e4eb79..b2245c755 100644 --- a/src/cts/zcl_abapgit_transport_mass.clas.locals_imp.abap +++ b/src/cts/zcl_abapgit_transport_mass.clas.locals_imp.abap @@ -165,7 +165,7 @@ CLASS lcl_transport_zipper IMPLEMENTATION. ENDMETHOD. METHOD does_folder_exist. - rv_folder_exist = zcl_abapgit_ui_factory=>get_frontend_services( )->directory_exist( iv_directory = iv_folder ). + rv_folder_exist = zcl_abapgit_ui_factory=>get_frontend_services( )->directory_exist( iv_folder ). ENDMETHOD. METHOD get_full_folder. diff --git a/src/git/zcl_abapgit_git_branch_list.clas.testclasses.abap b/src/git/zcl_abapgit_git_branch_list.clas.testclasses.abap index a5fa838bc..a749a6781 100644 --- a/src/git/zcl_abapgit_git_branch_list.clas.testclasses.abap +++ b/src/git/zcl_abapgit_git_branch_list.clas.testclasses.abap @@ -110,7 +110,7 @@ CLASS ltcl_parse IMPLEMENTATION. APPEND '000000f7e6e5b066fb4177bf0780bf343ab2de06368dd973 refs/heads/main' TO mt_data. APPEND '0000' TO mt_data. - parse( iv_expected_lines = 1 ). + parse( 1 ). ENDMETHOD. diff --git a/src/git/zcl_abapgit_git_commit.clas.testclasses.abap b/src/git/zcl_abapgit_git_commit.clas.testclasses.abap index 4290359c9..22daf8f84 100644 --- a/src/git/zcl_abapgit_git_commit.clas.testclasses.abap +++ b/src/git/zcl_abapgit_git_commit.clas.testclasses.abap @@ -171,7 +171,7 @@ CLASS ltc_parent_handling IMPLEMENTATION. DATA ls_commit TYPE zif_abapgit_git_definitions=>ty_commit. - given_commit( iv_sha1 = 'F00' ). + given_commit( 'F00' ). given_commit( iv_sha1 = 'BA5' iv_parent1 = 'F00' ). diff --git a/src/objects/aff/zcl_abapgit_aff_registry.clas.abap b/src/objects/aff/zcl_abapgit_aff_registry.clas.abap index ffdf3620b..eed73f343 100644 --- a/src/objects/aff/zcl_abapgit_aff_registry.clas.abap +++ b/src/objects/aff/zcl_abapgit_aff_registry.clas.abap @@ -52,17 +52,17 @@ CLASS zcl_abapgit_aff_registry IMPLEMENTATION. METHOD initialize_registry_table. - register( iv_obj_type = 'CHKC' ). - register( iv_obj_type = 'CHKO' ). - register( iv_obj_type = 'CHKV' ). - register( iv_obj_type = 'EVTB' ). - register( iv_obj_type = 'EEEC' ). - register( iv_obj_type = 'GSMP' ). + register( 'CHKC' ). + register( 'CHKO' ). + register( 'CHKV' ). + register( 'EVTB' ). + register( 'EEEC' ). + register( 'GSMP' ). register( iv_obj_type = 'INTF' iv_experimental = abap_true ). - register( iv_obj_type = 'SMBC' ). - register( iv_obj_type = 'NONT' ). - register( iv_obj_type = 'RONT' ). + register( 'SMBC' ). + register( 'NONT' ). + register( 'RONT' ). ENDMETHOD. diff --git a/src/objects/aff/zcl_abapgit_json_handler.clas.abap b/src/objects/aff/zcl_abapgit_json_handler.clas.abap index a5a7a0747..a87fe251f 100644 --- a/src/objects/aff/zcl_abapgit_json_handler.clas.abap +++ b/src/objects/aff/zcl_abapgit_json_handler.clas.abap @@ -106,7 +106,7 @@ CLASS zcl_abapgit_json_handler IMPLEMENTATION. lv_json = zcl_abapgit_convert=>xstring_to_string_utf8( iv_content ). - lo_ajson = zcl_abapgit_ajson=>parse( iv_json = lv_json + lo_ajson = zcl_abapgit_ajson=>parse( lv_json )->map( zcl_abapgit_ajson_mapping=>create_to_snake_case( ) ). map2abap_original_language( CHANGING co_ajson = lo_ajson ). diff --git a/src/objects/aff/zcl_abapgit_object_common_aff.clas.abap b/src/objects/aff/zcl_abapgit_object_common_aff.clas.abap index e781dfcb6..88e2ca2b0 100644 --- a/src/objects/aff/zcl_abapgit_object_common_aff.clas.abap +++ b/src/objects/aff/zcl_abapgit_object_common_aff.clas.abap @@ -234,7 +234,7 @@ CLASS zcl_abapgit_object_common_aff IMPLEMENTATION. TYPE symsg, LIKE LINE OF ls_additional_extensions. - lv_json_as_xstring = zif_abapgit_object~mo_files->read_raw( iv_ext = 'json' ). + lv_json_as_xstring = zif_abapgit_object~mo_files->read_raw( 'json' ). lv_name = ms_item-obj_name. " beyond here there will be dragons.... @@ -290,7 +290,7 @@ CLASS zcl_abapgit_object_common_aff IMPLEMENTATION. LOOP AT ls_additional_extensions ASSIGNING . - lv_file_as_xstring = zif_abapgit_object~mo_files->read_raw( iv_ext = -extension ). + lv_file_as_xstring = zif_abapgit_object~mo_files->read_raw( -extension ). CALL METHOD -file_name_mapper->('IF_AFF_FILE_NAME_MAPPER~GET_FILE_NAME_FROM_OBJECT') EXPORTING @@ -631,13 +631,13 @@ CLASS zcl_abapgit_object_common_aff IMPLEMENTATION. DATA lv_json_wo_alv TYPE string. DATA li_json TYPE REF TO zif_abapgit_ajson. - lv_json = zcl_abapgit_convert=>xstring_to_string_utf8( iv_data = iv_json_as_xstring ). + lv_json = zcl_abapgit_convert=>xstring_to_string_utf8( iv_json_as_xstring ). TRY. li_json = zcl_abapgit_ajson=>parse( iv_json = lv_json iv_keep_item_order = abap_true ). li_json->delete( '/header/abapLanguageVersion' ). - lv_json_wo_alv = li_json->stringify( iv_indent = 2 ). + lv_json_wo_alv = li_json->stringify( 2 ). rv_json_as_xstring_wo_alv = zcl_abapgit_convert=>string_to_xstring_utf8( lv_json_wo_alv ). diff --git a/src/objects/ecatt/zcl_abapgit_ecatt_data_upload.clas.abap b/src/objects/ecatt/zcl_abapgit_ecatt_data_upload.clas.abap index 12e9e95c1..4579cdc5d 100644 --- a/src/objects/ecatt/zcl_abapgit_ecatt_data_upload.clas.abap +++ b/src/objects/ecatt/zcl_abapgit_ecatt_data_upload.clas.abap @@ -27,7 +27,7 @@ ENDCLASS. -CLASS ZCL_ABAPGIT_ECATT_DATA_UPLOAD IMPLEMENTATION. +CLASS zcl_abapgit_ecatt_data_upload IMPLEMENTATION. METHOD upload. SET HANDLER on_ev_object_saved FOR ALL INSTANCES. diff --git a/src/objects/ecatt/zcl_abapgit_ecatt_script_downl.clas.abap b/src/objects/ecatt/zcl_abapgit_ecatt_script_downl.clas.abap index 90d924a60..263be9617 100644 --- a/src/objects/ecatt/zcl_abapgit_ecatt_script_downl.clas.abap +++ b/src/objects/ecatt/zcl_abapgit_ecatt_script_downl.clas.abap @@ -201,7 +201,7 @@ CLASS zcl_abapgit_ecatt_script_downl IMPLEMENTATION. free_text = lv_errmsg ). ENDIF. - lv_rc = li_artmp_node->set_value( value = lv_text ). + lv_rc = li_artmp_node->set_value( lv_text ). IF lv_rc <> 0. raise_download_exception( textid = cx_ecatt_apl_util=>download_processing @@ -237,7 +237,7 @@ CLASS zcl_abapgit_ecatt_script_downl IMPLEMENTATION. IMPORTING ex_xml_blob = lv_text ). - lv_rc = li_blob_node->set_value( value = lv_text ). + lv_rc = li_blob_node->set_value( lv_text ). IF lv_rc <> 0. raise_download_exception( textid = cx_ecatt_apl_util=>download_processing @@ -368,7 +368,7 @@ CLASS zcl_abapgit_ecatt_script_downl IMPLEMENTATION. ENDIF. * Ast in Hauptbaum haengen - lv_rc = li_deep_tcd->append_child( new_child = li_element ). + lv_rc = li_deep_tcd->append_child( li_element ). IF lv_rc <> 0. raise_download_exception( diff --git a/src/objects/ecatt/zcl_abapgit_ecatt_sp_download.clas.abap b/src/objects/ecatt/zcl_abapgit_ecatt_sp_download.clas.abap index df71ad701..b4660f569 100644 --- a/src/objects/ecatt/zcl_abapgit_ecatt_sp_download.clas.abap +++ b/src/objects/ecatt/zcl_abapgit_ecatt_sp_download.clas.abap @@ -103,7 +103,7 @@ CLASS ZCL_ABAPGIT_ECATT_SP_DOWNLOAD IMPLEMENTATION. document = li_dom. li_element = li_dom->get_root_element( ). - li_start_profile_data_node->append_child( new_child = li_element ). + li_start_profile_data_node->append_child( li_element ). ENDMETHOD. diff --git a/src/objects/ecatt/zcl_abapgit_ecatt_sp_upload.clas.abap b/src/objects/ecatt/zcl_abapgit_ecatt_sp_upload.clas.abap index 9c7d5de1c..1e43b95ac 100644 --- a/src/objects/ecatt/zcl_abapgit_ecatt_sp_upload.clas.abap +++ b/src/objects/ecatt/zcl_abapgit_ecatt_sp_upload.clas.abap @@ -27,7 +27,7 @@ ENDCLASS. -CLASS zcl_abapgit_ecatt_sp_upload IMPLEMENTATION. +CLASS ZCL_ABAPGIT_ECATT_SP_UPLOAD IMPLEMENTATION. METHOD get_ecatt_sp. @@ -51,7 +51,7 @@ CLASS zcl_abapgit_ecatt_sp_upload IMPLEMENTATION. li_ixml = cl_ixml=>create( ). li_dom = li_ixml->create_document( ). li_root ?= li_section->clone( ). - li_dom->append_child( new_child = li_root ). + li_dom->append_child( li_root ). CALL FUNCTION 'SDIXML_DOM_TO_XML' EXPORTING document = li_dom diff --git a/src/objects/ecatt/zcl_abapgit_ecatt_system_downl.clas.abap b/src/objects/ecatt/zcl_abapgit_ecatt_system_downl.clas.abap index e2923823f..1d3a32c9c 100644 --- a/src/objects/ecatt/zcl_abapgit_ecatt_system_downl.clas.abap +++ b/src/objects/ecatt/zcl_abapgit_ecatt_system_downl.clas.abap @@ -106,7 +106,7 @@ CLASS zcl_abapgit_ecatt_system_downl IMPLEMENTATION. OTHERS = 2. ASSERT sy-subrc = 0. - etpar_node->append_child( new_child = li_item ). + etpar_node->append_child( li_item ). ENDLOOP. diff --git a/src/objects/ecatt/zcl_abapgit_ecatt_val_obj_down.clas.abap b/src/objects/ecatt/zcl_abapgit_ecatt_val_obj_down.clas.abap index 458f6047b..b4a5d6371 100644 --- a/src/objects/ecatt/zcl_abapgit_ecatt_val_obj_down.clas.abap +++ b/src/objects/ecatt/zcl_abapgit_ecatt_val_obj_down.clas.abap @@ -146,7 +146,7 @@ CLASS ZCL_ABAPGIT_ECATT_VAL_OBJ_DOWN IMPLEMENTATION. li_insert_objects ?= template_over_all->find_from_name( 'BUSINESS_MESSAGES' ). - li_insert_objects->append_child( new_child = li_element ). + li_insert_objects->append_child( li_element ). ENDMETHOD. @@ -193,7 +193,7 @@ CLASS ZCL_ABAPGIT_ECATT_VAL_OBJ_DOWN IMPLEMENTATION. li_insert_objects ?= template_over_all->find_from_name( 'VO_FLAGS' ). - li_insert_objects->append_child( new_child = li_element ). + li_insert_objects->append_child( li_element ). CALL METHOD lo_ecatt_vo->('GET_ERROR_PRIORITY') RECEIVING @@ -217,7 +217,7 @@ CLASS ZCL_ABAPGIT_ECATT_VAL_OBJ_DOWN IMPLEMENTATION. li_insert_objects = template_over_all->find_from_name( 'VO_FLAGS' ). - li_insert_objects->append_child( new_child = li_element ). + li_insert_objects->append_child( li_element ). ENDMETHOD. @@ -264,7 +264,7 @@ CLASS ZCL_ABAPGIT_ECATT_VAL_OBJ_DOWN IMPLEMENTATION. li_insert_objects = template_over_all->find_from_name( 'IMPL_DETAILS' ). - li_insert_objects->append_child( new_child = li_element ). + li_insert_objects->append_child( li_element ). ENDMETHOD. diff --git a/src/objects/ecatt/zcl_abapgit_ecatt_val_obj_upl.clas.abap b/src/objects/ecatt/zcl_abapgit_ecatt_val_obj_upl.clas.abap index 284b6917a..a666d7803 100644 --- a/src/objects/ecatt/zcl_abapgit_ecatt_val_obj_upl.clas.abap +++ b/src/objects/ecatt/zcl_abapgit_ecatt_val_obj_upl.clas.abap @@ -35,7 +35,7 @@ ENDCLASS. -CLASS ZCL_ABAPGIT_ECATT_VAL_OBJ_UPL IMPLEMENTATION. +CLASS zcl_abapgit_ecatt_val_obj_upl IMPLEMENTATION. METHOD get_business_msgs_from_dom. diff --git a/src/objects/zcl_abapgit_object_area.clas.abap b/src/objects/zcl_abapgit_object_area.clas.abap index ef834cf23..0a3f69b21 100644 --- a/src/objects/zcl_abapgit_object_area.clas.abap +++ b/src/objects/zcl_abapgit_object_area.clas.abap @@ -189,7 +189,7 @@ CLASS zcl_abapgit_object_area IMPLEMENTATION. METHOD zif_abapgit_object~is_locked. - rv_is_locked = exists_a_lock_entry_for( iv_lock_object = 'ERSDAREA' ). + rv_is_locked = exists_a_lock_entry_for( 'ERSDAREA' ). ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_ecatt_super.clas.testclasses.abap b/src/objects/zcl_abapgit_object_ecatt_super.clas.testclasses.abap index 56dcd99ee..101629294 100644 --- a/src/objects/zcl_abapgit_object_ecatt_super.clas.testclasses.abap +++ b/src/objects/zcl_abapgit_object_ecatt_super.clas.testclasses.abap @@ -54,7 +54,7 @@ CLASS ltcl_changed_by IMPLEMENTATION. when_changed_is_checked( ). - then_should_be( iv_exp_change_more_recent = abap_true ). + then_should_be( abap_true ). ENDMETHOD. @@ -69,7 +69,7 @@ CLASS ltcl_changed_by IMPLEMENTATION. when_changed_is_checked( ). - then_should_be( iv_exp_change_more_recent = abap_false ). + then_should_be( abap_false ). ENDMETHOD. @@ -84,7 +84,7 @@ CLASS ltcl_changed_by IMPLEMENTATION. when_changed_is_checked( ). - then_should_be( iv_exp_change_more_recent = abap_true ). + then_should_be( abap_true ). ENDMETHOD. @@ -99,7 +99,7 @@ CLASS ltcl_changed_by IMPLEMENTATION. when_changed_is_checked( ). - then_should_be( iv_exp_change_more_recent = abap_false ). + then_should_be( abap_false ). ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_fdt0.clas.abap b/src/objects/zcl_abapgit_object_fdt0.clas.abap index 626c2cb70..1e5e2d48f 100644 --- a/src/objects/zcl_abapgit_object_fdt0.clas.abap +++ b/src/objects/zcl_abapgit_object_fdt0.clas.abap @@ -70,7 +70,7 @@ CLASS zcl_abapgit_object_fdt0 IMPLEMENTATION. name = 'DevelopmentPackage' namespace = 'FDTNS' ). IF lo_node_package IS BOUND. - lo_node_package->set_value( value = |{ iv_package }| ). + lo_node_package->set_value( |{ iv_package }| ). ENDIF. lo_node_id = co_dom_tree->find_from_name( @@ -231,7 +231,7 @@ CLASS zcl_abapgit_object_fdt0 IMPLEMENTATION. lo_components_node = co_ixml_element->find_from_name( name = 'ComponentReleases' namespace = 'FDTNS' ). IF lo_components_node IS BOUND. - co_ixml_element->remove_child( old_child = lo_components_node ). + co_ixml_element->remove_child( lo_components_node ). ENDIF. " Clear user/time/system-specific fields diff --git a/src/objects/zcl_abapgit_object_iatu.clas.abap b/src/objects/zcl_abapgit_object_iatu.clas.abap index d524f1b62..b58719937 100644 --- a/src/objects/zcl_abapgit_object_iatu.clas.abap +++ b/src/objects/zcl_abapgit_object_iatu.clas.abap @@ -64,16 +64,16 @@ CLASS zcl_abapgit_object_iatu IMPLEMENTATION. ls_name = ms_item-obj_name. - li_template = w3_api_load( is_name = ls_name ). + li_template = w3_api_load( ls_name ). - es_attr = w3_api_get_attributes( ii_template = li_template ). + es_attr = w3_api_get_attributes( li_template ). CLEAR: es_attr-chname, es_attr-tdate, es_attr-ttime, es_attr-devclass. - lt_source = w3_api_get_source( ii_template = li_template ). + lt_source = w3_api_get_source( li_template ). CONCATENATE LINES OF lt_source INTO ev_source RESPECTING BLANKS. @@ -87,7 +87,7 @@ CLASS zcl_abapgit_object_iatu IMPLEMENTATION. li_template TYPE REF TO if_w3_api_template. - li_template = w3_api_create_new( is_template_data = is_attr ). + li_template = w3_api_create_new( is_attr ). w3_api_set_attributes( ii_template = li_template is_attr = is_attr ). @@ -314,14 +314,14 @@ CLASS zcl_abapgit_object_iatu IMPLEMENTATION. ls_name = ms_item-obj_name. - li_template = w3_api_load( is_name = ls_name ). + li_template = w3_api_load( ls_name ). w3_api_set_changeable( ii_template = li_template iv_changeable = abap_true ). - w3_api_delete( ii_template = li_template ). + w3_api_delete( li_template ). - w3_api_save( ii_template = li_template ). + w3_api_save( li_template ). ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_iaxu.clas.abap b/src/objects/zcl_abapgit_object_iaxu.clas.abap index c691341fe..6fc193a72 100644 --- a/src/objects/zcl_abapgit_object_iaxu.clas.abap +++ b/src/objects/zcl_abapgit_object_iaxu.clas.abap @@ -64,9 +64,9 @@ CLASS zcl_abapgit_object_iaxu IMPLEMENTATION. DATA: lo_xml_api TYPE REF TO object. - lo_xml_api = w3_api_create_new( is_attr = is_attr ). + lo_xml_api = w3_api_create_new( is_attr ). - w3_api_save( io_xml_api = lo_xml_api ). + w3_api_save( lo_xml_api ). w3_api_set_changeable( io_xml_api = lo_xml_api iv_changeable = abap_false ). @@ -222,9 +222,9 @@ CLASS zcl_abapgit_object_iaxu IMPLEMENTATION. w3_api_set_changeable( io_xml_api = lo_xml_api iv_changeable = abap_true ). - w3_api_delete( io_xml_api = lo_xml_api ). + w3_api_delete( lo_xml_api ). - w3_api_save( io_xml_api = lo_xml_api ). + w3_api_save( lo_xml_api ). ENDMETHOD. @@ -244,7 +244,7 @@ CLASS zcl_abapgit_object_iaxu IMPLEMENTATION. iv_transport = iv_transport ). ENDIF. - save( is_attr = ls_attr ). + save( ls_attr ). ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_pdts.clas.abap b/src/objects/zcl_abapgit_object_pdts.clas.abap index 35aab1675..07296c784 100644 --- a/src/objects/zcl_abapgit_object_pdts.clas.abap +++ b/src/objects/zcl_abapgit_object_pdts.clas.abap @@ -108,7 +108,7 @@ CLASS zcl_abapgit_object_pdts IMPLEMENTATION. check_subrc_for( `TO_XML` ). ri_first_element ?= li_xml_dom->get_first_child( ). - li_elements = ri_first_element->get_elements_by_tag_name( name = 'ELEMENTS' ). + li_elements = ri_first_element->get_elements_by_tag_name( 'ELEMENTS' ). li_iterator = li_elements->create_iterator( ). DO. @@ -131,14 +131,14 @@ CLASS zcl_abapgit_object_pdts IMPLEMENTATION. "Remove system container elements - causing too much trouble "Todo: This is a bad hack, but obsolete if we can fix todo above li_attributes = li_element->get_attributes( ). - lv_name = li_attributes->get_named_item( name = 'NAME' )->get_value( ). + lv_name = li_attributes->get_named_item( 'NAME' )->get_value( ). IF lv_name(1) = '_'. li_element->remove_node( ). li_child_iterator->reset( ). CONTINUE. ENDIF. - li_attributes->remove_named_item( name = 'CHGDTA' ). + li_attributes->remove_named_item( 'CHGDTA' ). ENDDO. diff --git a/src/objects/zcl_abapgit_object_pers.clas.abap b/src/objects/zcl_abapgit_object_pers.clas.abap index df2067636..0435491a0 100644 --- a/src/objects/zcl_abapgit_object_pers.clas.abap +++ b/src/objects/zcl_abapgit_object_pers.clas.abap @@ -172,7 +172,7 @@ CLASS zcl_abapgit_object_pers IMPLEMENTATION. METHOD zif_abapgit_object~is_locked. " There's no object specific locking. Just a global one. - rv_is_locked = exists_a_lock_entry_for( iv_lock_object = 'E_SPERSREG' ). + rv_is_locked = exists_a_lock_entry_for( 'E_SPERSREG' ). ENDMETHOD. diff --git a/src/objects/zcl_abapgit_object_scvi.clas.abap b/src/objects/zcl_abapgit_object_scvi.clas.abap index faa68e0ee..93efe4992 100644 --- a/src/objects/zcl_abapgit_object_scvi.clas.abap +++ b/src/objects/zcl_abapgit_object_scvi.clas.abap @@ -84,7 +84,7 @@ CLASS zcl_abapgit_object_scvi IMPLEMENTATION. zcx_abapgit_exception=>raise_t100( ). ENDIF. - corr_insert( iv_package = iv_package ). + corr_insert( iv_package ). * Populate user details ls_screen_variant-shdsvci-crdate = sy-datum. diff --git a/src/objects/zcl_abapgit_object_stvi.clas.abap b/src/objects/zcl_abapgit_object_stvi.clas.abap index 5ac6b7c21..dd174d6e1 100644 --- a/src/objects/zcl_abapgit_object_stvi.clas.abap +++ b/src/objects/zcl_abapgit_object_stvi.clas.abap @@ -83,7 +83,7 @@ CLASS zcl_abapgit_object_stvi IMPLEMENTATION. zcx_abapgit_exception=>raise_t100( ). ENDIF. - corr_insert( iv_package = iv_package ). + corr_insert( iv_package ). * Populate user details ls_transaction_variant-shdtvciu-crdate = sy-datum. diff --git a/src/objects/zcl_abapgit_object_ueno.clas.abap b/src/objects/zcl_abapgit_object_ueno.clas.abap index 560d2c8f4..12a568365 100644 --- a/src/objects/zcl_abapgit_object_ueno.clas.abap +++ b/src/objects/zcl_abapgit_object_ueno.clas.abap @@ -534,7 +534,7 @@ CLASS zcl_abapgit_object_ueno IMPLEMENTATION. DATA lv_objname TYPE lxeobjname. - ls_dokvl-object = build_text_name( iv_id = iv_id ). + ls_dokvl-object = build_text_name( iv_id ). SELECT id object langu FROM dokvl diff --git a/src/objects/zcl_abapgit_object_wdca.clas.abap b/src/objects/zcl_abapgit_object_wdca.clas.abap index 9df8a8e23..507ca1f2e 100644 --- a/src/objects/zcl_abapgit_object_wdca.clas.abap +++ b/src/objects/zcl_abapgit_object_wdca.clas.abap @@ -297,7 +297,7 @@ CLASS zcl_abapgit_object_wdca IMPLEMENTATION. WITH ''. ASSERT sy-subrc = 0. - lv_xml_xstring = zcl_abapgit_convert=>string_to_xstring( iv_str = lv_xml_string ). + lv_xml_xstring = zcl_abapgit_convert=>string_to_xstring( lv_xml_string ). UPDATE wdy_config_appl SET xcontent = lv_xml_xstring WHERE config_id = ls_outline-config_id @@ -411,7 +411,7 @@ CLASS zcl_abapgit_object_wdca IMPLEMENTATION. WHERE config_id = ls_outline-config_id AND config_type = ls_outline-config_type AND config_var = ls_outline-config_var. - lv_xml_string = zcl_abapgit_convert=>xstring_to_string_utf8( iv_data = lv_xml_xstring ). + lv_xml_string = zcl_abapgit_convert=>xstring_to_string_utf8( lv_xml_xstring ). IF lv_xml_string IS NOT INITIAL. TRY. lv_xml_string = zcl_abapgit_xml_pretty=>print( diff --git a/src/objects/zcl_abapgit_object_wdcc.clas.abap b/src/objects/zcl_abapgit_object_wdcc.clas.abap index c2c62b078..6d46e1a70 100644 --- a/src/objects/zcl_abapgit_object_wdcc.clas.abap +++ b/src/objects/zcl_abapgit_object_wdcc.clas.abap @@ -136,7 +136,7 @@ CLASS zcl_abapgit_object_wdcc IMPLEMENTATION. WITH ''. ASSERT sy-subrc = 0. - lv_xml_xstring = zcl_abapgit_convert=>string_to_xstring( iv_str = lv_xml_string ). + lv_xml_xstring = zcl_abapgit_convert=>string_to_xstring( lv_xml_string ). ls_orig_config-xcontent = lv_xml_xstring. ASSIGN COMPONENT 'PARENT' OF STRUCTURE ls_orig_config TO . @@ -403,7 +403,7 @@ CLASS zcl_abapgit_object_wdcc IMPLEMENTATION. io_xml->add( iv_name = 'RELID' ig_data = ls_orig_config-relid ). - lv_xml_string = zcl_abapgit_convert=>xstring_to_string_utf8( iv_data = lv_xml_xstring ). + lv_xml_string = zcl_abapgit_convert=>xstring_to_string_utf8( lv_xml_xstring ). IF lv_xml_string IS NOT INITIAL. TRY. lv_xml_string = zcl_abapgit_xml_pretty=>print( diff --git a/src/persist/zcl_abapgit_persist_migrate.clas.locals_imp.abap b/src/persist/zcl_abapgit_persist_migrate.clas.locals_imp.abap index e834860bd..1a58e69f8 100644 --- a/src/persist/zcl_abapgit_persist_migrate.clas.locals_imp.abap +++ b/src/persist/zcl_abapgit_persist_migrate.clas.locals_imp.abap @@ -36,7 +36,7 @@ CLASS lcl_cua_interface IMPLEMENTATION. METHOD get_own_cua. - rs_cua = serialize_cua( iv_program_name = sy-cprog ). + rs_cua = serialize_cua( sy-cprog ). ENDMETHOD. @@ -49,7 +49,7 @@ CLASS lcl_cua_interface IMPLEMENTATION. iv_program_name = ms_item-obj_name ). CREATE OBJECT li_log TYPE zcl_abapgit_log. - zcl_abapgit_objects_activation=>activate( ii_log = li_log ). + zcl_abapgit_objects_activation=>activate( li_log ). zcl_abapgit_objects_activation=>clear( ). ENDMETHOD. diff --git a/src/repo/zcl_abapgit_object_filter_tran.clas.abap b/src/repo/zcl_abapgit_object_filter_tran.clas.abap index 63e1c1468..a0d65f2d9 100644 --- a/src/repo/zcl_abapgit_object_filter_tran.clas.abap +++ b/src/repo/zcl_abapgit_object_filter_tran.clas.abap @@ -177,7 +177,7 @@ CLASS zcl_abapgit_object_filter_tran IMPLEMENTATION. DATA lr_list TYPE REF TO devclass. DATA ls_filter TYPE zif_abapgit_definitions=>ty_tadir. - li_package = zcl_abapgit_factory=>get_sap_package( iv_package = iv_package ). + li_package = zcl_abapgit_factory=>get_sap_package( iv_package ). lt_list = li_package->list_subpackages( ). LOOP AT lt_list REFERENCE INTO lr_list. ls_filter-pgmid = 'R3TR'. diff --git a/src/repo/zcl_abapgit_repo.clas.abap b/src/repo/zcl_abapgit_repo.clas.abap index 3ec52771a..07a8a1f8b 100644 --- a/src/repo/zcl_abapgit_repo.clas.abap +++ b/src/repo/zcl_abapgit_repo.clas.abap @@ -204,7 +204,7 @@ CLASS zcl_abapgit_repo IMPLEMENTATION. IF lo_abapgit_abap_language_vers->is_import_allowed( ms_data-package ) = abap_false. lv_text = |Repository cannot be imported. | && |ABAP Language Version of linked package is not compatible with repository settings.|. - zcx_abapgit_exception=>raise( iv_text = lv_text ). + zcx_abapgit_exception=>raise( lv_text ). ENDIF. ENDMETHOD. diff --git a/src/repo/zcl_abapgit_repo_checksums.clas.abap b/src/repo/zcl_abapgit_repo_checksums.clas.abap index b3d5741f9..f0008c63b 100644 --- a/src/repo/zcl_abapgit_repo_checksums.clas.abap +++ b/src/repo/zcl_abapgit_repo_checksums.clas.abap @@ -162,7 +162,7 @@ CLASS ZCL_ABAPGIT_REPO_CHECKSUMS IMPLEMENTATION. DATA lv_cs_blob TYPE string. TRY. - lv_cs_blob = zcl_abapgit_persist_factory=>get_repo_cs( )->read( iv_key = mv_repo_key ). + lv_cs_blob = zcl_abapgit_persist_factory=>get_repo_cs( )->read( mv_repo_key ). CATCH zcx_abapgit_exception zcx_abapgit_not_found. " Ignore currently, it's not critical for execution, just return empty RETURN. diff --git a/src/repo/zcl_abapgit_repo_status.clas.testclasses.abap b/src/repo/zcl_abapgit_repo_status.clas.testclasses.abap index 196e3ca1c..7ef4bd286 100644 --- a/src/repo/zcl_abapgit_repo_status.clas.testclasses.abap +++ b/src/repo/zcl_abapgit_repo_status.clas.testclasses.abap @@ -1041,7 +1041,7 @@ CLASS ltcl_calculate_status IMPLEMENTATION. iv_obj_name = '$$ZDOMA1' iv_devclass = 'FOO' ). - mo_result = mo_helper->run( iv_devclass = 'FOO' ). + mo_result = mo_helper->run( 'FOO' ). mo_result->assert_lines( iv_lines = 2 @@ -1443,7 +1443,7 @@ CLASS ltcl_calculate_status IMPLEMENTATION. iv_filename = 'zcl_clas.clas.locals_imp.abap' iv_sha1 = '1111' ). - mo_result = mo_helper->run( iv_devclass = '$DIFFERENT' ). + mo_result = mo_helper->run( '$DIFFERENT' ). mo_result->assert_lines( 2 ). @@ -1478,7 +1478,7 @@ CLASS ltcl_calculate_status IMPLEMENTATION. iv_filename = 'package.devc.xml' iv_sha1 = '112233' ). - mo_result = mo_helper->run( iv_devclass = '$DIFFERENT' ). + mo_result = mo_helper->run( '$DIFFERENT' ). mo_result->assert_lines( 2 ). diff --git a/src/ui/core/zcl_abapgit_gui_html_processor.clas.testclasses.abap b/src/ui/core/zcl_abapgit_gui_html_processor.clas.testclasses.abap index 7822a85ea..8715032ae 100644 --- a/src/ui/core/zcl_abapgit_gui_html_processor.clas.testclasses.abap +++ b/src/ui/core/zcl_abapgit_gui_html_processor.clas.testclasses.abap @@ -217,7 +217,7 @@ CLASS ltcl_html_processor_test IMPLEMENTATION. "when TRY. - lv_head_end = mo_cut->find_head_offset( iv_html = lv_html ). + lv_head_end = mo_cut->find_head_offset( lv_html ). CATCH zcx_abapgit_exception. cl_abap_unit_assert=>fail( msg = 'HEAD closing tag could not be found' ). ENDTRY. diff --git a/src/ui/core/zcl_abapgit_html.clas.testclasses.abap b/src/ui/core/zcl_abapgit_html.clas.testclasses.abap index cda950ec8..90a06277b 100644 --- a/src/ui/core/zcl_abapgit_html.clas.testclasses.abap +++ b/src/ui/core/zcl_abapgit_html.clas.testclasses.abap @@ -192,7 +192,7 @@ CLASS ltcl_html IMPLEMENTATION. METHOD wrap. - mo_html->wrap( iv_tag = 'td' ). + mo_html->wrap( 'td' ). mo_html->wrap( iv_tag = 'td' iv_content = 'Hello' ). diff --git a/src/ui/lib/zcl_abapgit_gui_chunk_lib.clas.abap b/src/ui/lib/zcl_abapgit_gui_chunk_lib.clas.abap index 524a336ab..b60bb540e 100644 --- a/src/ui/lib/zcl_abapgit_gui_chunk_lib.clas.abap +++ b/src/ui/lib/zcl_abapgit_gui_chunk_lib.clas.abap @@ -662,7 +662,7 @@ CLASS zcl_abapgit_gui_chunk_lib IMPLEMENTATION. APPEND `` TO lt_fragments. APPEND `` TO lt_fragments. - rv_html = concat_lines_of( table = lt_fragments ). + rv_html = concat_lines_of( lt_fragments ). ENDMETHOD. @@ -810,7 +810,7 @@ CLASS zcl_abapgit_gui_chunk_lib IMPLEMENTATION. APPEND `` TO lt_fragments. - rv_html = concat_lines_of( table = lt_fragments ). + rv_html = concat_lines_of( lt_fragments ). ENDMETHOD. diff --git a/src/ui/lib/zcl_abapgit_html_table.clas.abap b/src/ui/lib/zcl_abapgit_html_table.clas.abap index b772b9ad9..3bdf3816e 100644 --- a/src/ui/lib/zcl_abapgit_html_table.clas.abap +++ b/src/ui/lib/zcl_abapgit_html_table.clas.abap @@ -193,7 +193,7 @@ CLASS ZCL_ABAPGIT_HTML_TABLE IMPLEMENTATION. mi_html->add( '' ). LOOP AT mt_columns ASSIGNING . - mi_html->th( iv_content = -column_title ). + mi_html->th( -column_title ). ENDLOOP. mi_html->add( '' ). diff --git a/src/ui/lib/zcl_abapgit_html_table.clas.testclasses.abap b/src/ui/lib/zcl_abapgit_html_table.clas.testclasses.abap index 701bfe545..f2a663d4d 100644 --- a/src/ui/lib/zcl_abapgit_html_table.clas.testclasses.abap +++ b/src/ui/lib/zcl_abapgit_html_table.clas.testclasses.abap @@ -42,7 +42,7 @@ CLASS ltcl_test_simple_table IMPLEMENTATION. DATA li_html_exp TYPE REF TO zif_abapgit_html. FIELD-SYMBOLS LIKE LINE OF lt_dummy_data. - lo_tab = zcl_abapgit_html_table=>create( ii_renderer = me + lo_tab = zcl_abapgit_html_table=>create( me )->define_column( iv_column_id = 'col1' iv_column_title = 'Col 1' diff --git a/src/ui/pages/zcl_abapgit_gui_page_db.clas.abap b/src/ui/pages/zcl_abapgit_gui_page_db.clas.abap index c9c18fb98..a1781e131 100644 --- a/src/ui/pages/zcl_abapgit_gui_page_db.clas.abap +++ b/src/ui/pages/zcl_abapgit_gui_page_db.clas.abap @@ -479,7 +479,7 @@ CLASS zcl_abapgit_gui_page_db IMPLEMENTATION. METHOD render_table. - ri_html = zcl_abapgit_html_table=>create( ii_renderer = me + ri_html = zcl_abapgit_html_table=>create( me )->define_column( iv_column_id = 'type' iv_column_title = 'Type' diff --git a/src/ui/pages/zcl_abapgit_gui_page_patch.clas.abap b/src/ui/pages/zcl_abapgit_gui_page_patch.clas.abap index d7497ee44..143223633 100644 --- a/src/ui/pages/zcl_abapgit_gui_page_patch.clas.abap +++ b/src/ui/pages/zcl_abapgit_gui_page_patch.clas.abap @@ -441,7 +441,7 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_PATCH IMPLEMENTATION. mv_section_count = mv_section_count + 1. ii_html->add( || ). - ii_html->add_checkbox( iv_id = |patch_section_{ get_normalized_fname_with_path( is_diff ) }_{ mv_section_count }| ). + ii_html->add_checkbox( |patch_section_{ get_normalized_fname_with_path( is_diff ) }_{ mv_section_count }| ). ii_html->add( '' ). ENDMETHOD. diff --git a/src/ui/pages/zcl_abapgit_gui_page_stage.clas.abap b/src/ui/pages/zcl_abapgit_gui_page_stage.clas.abap index 21c9b8cc8..8b458a18b 100644 --- a/src/ui/pages/zcl_abapgit_gui_page_stage.clas.abap +++ b/src/ui/pages/zcl_abapgit_gui_page_stage.clas.abap @@ -769,7 +769,7 @@ CLASS zcl_abapgit_gui_page_stage IMPLEMENTATION. filename = ls_file-filename. IF sy-subrc <> 0. * see https://github.com/abapGit/abapGit/issues/3073 - zcx_abapgit_exception=>raise( iv_text = + zcx_abapgit_exception=>raise( |Unable to stage { ls_file-filename }. If the filename contains spaces, this is a known issue.| && | Consider ignoring or staging the file at a later time.| ). ENDIF. diff --git a/src/utils/zcl_abapgit_string_buffer.clas.abap b/src/utils/zcl_abapgit_string_buffer.clas.abap index 73711bd5b..8f556449c 100644 --- a/src/utils/zcl_abapgit_string_buffer.clas.abap +++ b/src/utils/zcl_abapgit_string_buffer.clas.abap @@ -40,7 +40,7 @@ CLASS ZCL_ABAPGIT_STRING_BUFFER IMPLEMENTATION. METHOD join_and_flush. - rv_str = concat_lines_of( table = mt_buffer ). + rv_str = concat_lines_of( mt_buffer ). CLEAR mt_buffer. ENDMETHOD. diff --git a/src/utils/zcl_abapgit_string_map.clas.testclasses.abap b/src/utils/zcl_abapgit_string_map.clas.testclasses.abap index e2db5c64b..ca418b39f 100644 --- a/src/utils/zcl_abapgit_string_map.clas.testclasses.abap +++ b/src/utils/zcl_abapgit_string_map.clas.testclasses.abap @@ -150,7 +150,7 @@ CLASS ltcl_sm_test IMPLEMENTATION. METHOD case_insensitive. DATA lo_cut TYPE REF TO zcl_abapgit_string_map. - lo_cut = zcl_abapgit_string_map=>create( iv_case_insensitive = abap_true ). + lo_cut = zcl_abapgit_string_map=>create( abap_true ). lo_cut->set( iv_key = 'A' diff --git a/src/xml/zcl_abapgit_xml.clas.testclasses.abap b/src/xml/zcl_abapgit_xml.clas.testclasses.abap index 613a7e44d..250518cae 100644 --- a/src/xml/zcl_abapgit_xml.clas.testclasses.abap +++ b/src/xml/zcl_abapgit_xml.clas.testclasses.abap @@ -52,7 +52,7 @@ CLASS ltcl_xml IMPLEMENTATION. && iv_xml && |c_abapgit_tag }>|. - mo_xml->parse( iv_xml = lv_xml ). + mo_xml->parse( lv_xml ). ENDMETHOD. @@ -105,7 +105,7 @@ CLASS ltcl_xml IMPLEMENTATION. && |c_abapgit_tag }>|. TRY. - mo_xml->parse( iv_xml = lv_xml ). + mo_xml->parse( lv_xml ). cl_abap_unit_assert=>fail( msg = 'Exception not raised' ). CATCH zcx_abapgit_exception INTO lo_error. @@ -129,7 +129,7 @@ CLASS ltcl_xml IMPLEMENTATION. && |c_abapgit_tag }>|. TRY. - mo_xml->parse( iv_xml = lv_xml ). + mo_xml->parse( lv_xml ). cl_abap_unit_assert=>fail( msg = 'Exception not raised' ). CATCH zcx_abapgit_exception INTO lo_error.