setup linting of the compiled report (#3408)

* lint the compiled report

* change

* Update ci.yml
This commit is contained in:
Lars Hvam 2020-05-24 10:36:14 +02:00 committed by GitHub
parent 411c703e0e
commit f431d30140
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 86 additions and 4 deletions

View File

@ -19,6 +19,7 @@ jobs:
npm run eslint
npm run abaplint
npm run merge
npm run merge.ci
- name: deploy-merged-build
if: github.ref == 'refs/heads/master' && github.repository == 'larshp/abapGit'
env:

1
.gitignore vendored
View File

@ -4,3 +4,4 @@ package-lock.json
zabapgit.abap
.vscode
deps
ci/*.abap

View File

@ -68,7 +68,8 @@
"globalMacros": []
},
"rules": {
"unknown_types": false,
"unknown_types": true,
"forbidden_void_type": true,
"forbidden_identifier": true,
"try_without_catch": false,
"unused_variables": false,

78
ci/abaplint.json Normal file
View File

@ -0,0 +1,78 @@
{
"global": {
"files": "./ci/*.abap",
"skipGeneratedGatewayClasses": true,
"skipGeneratedPersistentClasses": true,
"skipGeneratedFunctionGroups": true
},
"dependencies": [
{
"url": "https://github.com/abaplint/deps",
"folder": "/deps",
"files": "/src/**/*.*"
}
],
"syntax": {
"version": "v702",
"errorNamespace": "^(Z|Y|LT?CL_|TY_|LIF_)",
"globalConstants": [
"icon_led_red",
"icon_led_yellow",
"icon_led_green",
"icon_led_inactive",
"icon_message_information",
"icon_system_help",
"icon_stack",
"icon_abap",
"icon_display_text",
"icon_set_state",
"icon_workflow_fork",
"icon_okay",
"icon_folder",
"abap_func_exporting",
"abap_func_tables",
"cssf_formtype_text",
"seoc_category_exception",
"seoc_category_webdynpro_class",
"seoc_exposure_private",
"seoc_exposure_protected",
"seoc_exposure_public",
"seoc_exposure_public",
"seoc_version_active",
"seoc_version_inactive",
"seok_access_free",
"seok_access_modify",
"seok_pgmid_r3tr",
"seop_ext_class_locals_def",
"seop_ext_class_locals_imp",
"seop_ext_class_macros",
"seop_ext_class_testclasses",
"sews_c_vif_version",
"skwfc_obtype_folder",
"skwfc_obtype_loio",
"so2_controller",
"ststc_c_type_dialog",
"ststc_c_type_object",
"ststc_c_type_parameters",
"ststc_c_type_report",
"swbm_c_op_delete_no_dialog",
"swbm_c_type_ddic_db_tabxinx",
"swbm_c_type_wdy_application",
"swbm_version_active",
"swbm_version_inactive",
"wbmr_c_skwf_folder_class",
"wdyn_limu_component_controller",
"wdyn_limu_component_definition",
"wdyn_limu_component_view"
],
"globalMacros": []
},
"rules": {
"unknown_types": true,
"allowed_object_naming": true,
"check_syntax": true,
"implement_methods": true,
"superclass_final": true,
"parser_error": true
}
}

View File

@ -3,6 +3,7 @@
"scripts": {
"test": "npm run eslint && npm run abaplint",
"merge": "abapmerge -f src/zabapgit.prog.abap -c zabapgit_full > zabapgit.abap",
"merge.ci": "cp zabapgit.abap ci/zabapgit_full.prog.abap && cd ci && abaplint && cd ..",
"abaplint": "abaplint",
"eslint": "eslint src"
},
@ -11,8 +12,8 @@
"url": "git+https://github.com/larshp/abapGit.git"
},
"devDependencies": {
"@abaplint/cli": "^2.30.0",
"abapmerge": "^0.13.1",
"eslint": "^6.8.0"
"@abaplint/cli": "^2.33.0",
"abapmerge": "^0.14.0",
"eslint": "^7.1.0"
}
}