From f46e1e1c5977c3f62d0b919e6c7ec01631af7c8f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Christian=20G=C3=BCnter?= Date: Fri, 17 Aug 2018 13:34:09 +0200 Subject: [PATCH] Fix close hotkey overview popup #1833 (#1835) * Fix close hotkey overview popup * Add text how to close hotskeys overview --- src/ui/zcl_abapgit_gui_chunk_lib.clas.abap | 10 ++++++---- src/zabapgit_js_common.w3mi.data.js | 6 ++++++ 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/src/ui/zcl_abapgit_gui_chunk_lib.clas.abap b/src/ui/zcl_abapgit_gui_chunk_lib.clas.abap index ef966dc6d..547bd9417 100644 --- a/src/ui/zcl_abapgit_gui_chunk_lib.clas.abap +++ b/src/ui/zcl_abapgit_gui_chunk_lib.clas.abap @@ -18,8 +18,8 @@ CLASS zcl_abapgit_gui_chunk_lib DEFINITION PUBLIC FINAL CREATE PUBLIC. RAISING zcx_abapgit_exception. CLASS-METHODS render_item_state - IMPORTING iv_lstate TYPE char1 - iv_rstate TYPE char1 + IMPORTING iv_lstate TYPE char1 + iv_rstate TYPE char1 RETURNING VALUE(rv_html) TYPE string. CLASS-METHODS render_branch_span @@ -49,7 +49,7 @@ ENDCLASS. -CLASS ZCL_ABAPGIT_GUI_CHUNK_LIB IMPLEMENTATION. +CLASS zcl_abapgit_gui_chunk_lib IMPLEMENTATION. METHOD render_branch_span. @@ -125,10 +125,12 @@ CLASS ZCL_ABAPGIT_GUI_CHUNK_LIB IMPLEMENTATION. && zcl_abapgit_html=>a( iv_txt = '❌' iv_typ = zif_abapgit_definitions=>c_action_type-onclick - iv_act = 'displayNews()' + iv_act = 'closeHotkeyOverview()' iv_class = 'close-btn' ) && '' ). + ro_html->add( |
Close window with ? or upper right corner X
| ). + " Generate hotkeys ro_html->add( |
| ). diff --git a/src/zabapgit_js_common.w3mi.data.js b/src/zabapgit_js_common.w3mi.data.js index 2deab858b..01c9fd0c7 100644 --- a/src/zabapgit_js_common.w3mi.data.js +++ b/src/zabapgit_js_common.w3mi.data.js @@ -555,6 +555,12 @@ function displayNews() { div.style.display = (div.style.display) ? '' : 'none'; } +// Hotkey Overview +function closeHotkeyOverview() { + var div = document.getElementById("hotkeys"); + div.style.display = (div.style.display) ? '' : 'none'; +} + function KeyNavigation() { }