start refactoring to use XML interfaces (#3796)

* start refactoring to use XML interfaces

#3531

* TABL + TRAN + UDMO + UENO

start using the interfaces for xml instead of class references
This commit is contained in:
Lars Hvam 2020-08-26 06:50:47 +02:00 committed by GitHub
parent 978389a070
commit f582225bf8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 77 additions and 67 deletions

View File

@ -33,7 +33,7 @@ CLASS zcl_abapgit_object_tabl DEFINITION PUBLIC INHERITING FROM zcl_abapgit_obje
"! Serialize IDoc Segment type/definition if exits "! Serialize IDoc Segment type/definition if exits
"! @parameter io_xml | XML writer "! @parameter io_xml | XML writer
"! @raising zcx_abapgit_exception | Exceptions "! @raising zcx_abapgit_exception | Exceptions
METHODS serialize_idoc_segment IMPORTING io_xml TYPE REF TO zcl_abapgit_xml_output METHODS serialize_idoc_segment IMPORTING io_xml TYPE REF TO zif_abapgit_xml_output
RAISING zcx_abapgit_exception. RAISING zcx_abapgit_exception.
"! Deserialize IDoc Segment type/definition if exits "! Deserialize IDoc Segment type/definition if exits
@ -41,7 +41,7 @@ CLASS zcl_abapgit_object_tabl DEFINITION PUBLIC INHERITING FROM zcl_abapgit_obje
"! @parameter iv_package | Target package "! @parameter iv_package | Target package
"! @parameter rv_deserialized | It's a segment and was desserialized "! @parameter rv_deserialized | It's a segment and was desserialized
"! @raising zcx_abapgit_exception | Exceptions "! @raising zcx_abapgit_exception | Exceptions
METHODS deserialize_idoc_segment IMPORTING io_xml TYPE REF TO zcl_abapgit_xml_input METHODS deserialize_idoc_segment IMPORTING io_xml TYPE REF TO zif_abapgit_xml_input
iv_package TYPE devclass iv_package TYPE devclass
RETURNING VALUE(rv_deserialized) TYPE abap_bool RETURNING VALUE(rv_deserialized) TYPE abap_bool
RAISING zcx_abapgit_exception. RAISING zcx_abapgit_exception.
@ -87,10 +87,10 @@ CLASS zcl_abapgit_object_tabl DEFINITION PUBLIC INHERITING FROM zcl_abapgit_obje
METHODS: METHODS:
serialize_texts serialize_texts
IMPORTING io_xml TYPE REF TO zcl_abapgit_xml_output IMPORTING io_xml TYPE REF TO zif_abapgit_xml_output
RAISING zcx_abapgit_exception, RAISING zcx_abapgit_exception,
deserialize_texts deserialize_texts
IMPORTING io_xml TYPE REF TO zcl_abapgit_xml_input IMPORTING io_xml TYPE REF TO zif_abapgit_xml_input
is_dd02v TYPE dd02v is_dd02v TYPE dd02v
RAISING zcx_abapgit_exception. RAISING zcx_abapgit_exception.

View File

@ -79,12 +79,12 @@ CLASS zcl_abapgit_object_tran DEFINITION
!cg_value TYPE any . !cg_value TYPE any .
METHODS serialize_texts METHODS serialize_texts
IMPORTING IMPORTING
!io_xml TYPE REF TO zcl_abapgit_xml_output !io_xml TYPE REF TO zif_abapgit_xml_output
RAISING RAISING
zcx_abapgit_exception . zcx_abapgit_exception .
METHODS deserialize_texts METHODS deserialize_texts
IMPORTING IMPORTING
!io_xml TYPE REF TO zcl_abapgit_xml_input !io_xml TYPE REF TO zif_abapgit_xml_input
RAISING RAISING
zcx_abapgit_exception . zcx_abapgit_exception .
METHODS deserialize_oo_transaction METHODS deserialize_oo_transaction
@ -109,7 +109,7 @@ ENDCLASS.
CLASS zcl_abapgit_object_tran IMPLEMENTATION. CLASS ZCL_ABAPGIT_OBJECT_TRAN IMPLEMENTATION.
METHOD add_data. METHOD add_data.

View File

@ -44,32 +44,32 @@ CLASS zcl_abapgit_object_udmo DEFINITION
METHODS update_tree . METHODS update_tree .
METHODS serialize_short_texts METHODS serialize_short_texts
IMPORTING IMPORTING
!io_xml TYPE REF TO zcl_abapgit_xml_output !io_xml TYPE REF TO zif_abapgit_xml_output
RAISING RAISING
zcx_abapgit_exception . zcx_abapgit_exception .
METHODS deserialize_short_texts METHODS deserialize_short_texts
IMPORTING IMPORTING
!io_xml TYPE REF TO zcl_abapgit_xml_input !io_xml TYPE REF TO zif_abapgit_xml_input
RAISING RAISING
zcx_abapgit_exception . zcx_abapgit_exception .
METHODS serialize_long_texts METHODS serialize_long_texts
IMPORTING IMPORTING
!io_xml TYPE REF TO zcl_abapgit_xml_output !io_xml TYPE REF TO zif_abapgit_xml_output
RAISING RAISING
zcx_abapgit_exception . zcx_abapgit_exception .
METHODS deserialize_long_texts METHODS deserialize_long_texts
IMPORTING IMPORTING
!io_xml TYPE REF TO zcl_abapgit_xml_input !io_xml TYPE REF TO zif_abapgit_xml_input
RAISING RAISING
zcx_abapgit_exception . zcx_abapgit_exception .
METHODS serialize_entities METHODS serialize_entities
IMPORTING IMPORTING
!io_xml TYPE REF TO zcl_abapgit_xml_output !io_xml TYPE REF TO zif_abapgit_xml_output
RAISING RAISING
zcx_abapgit_exception . zcx_abapgit_exception .
METHODS deserialize_entities METHODS deserialize_entities
IMPORTING IMPORTING
!io_xml TYPE REF TO zcl_abapgit_xml_input !io_xml TYPE REF TO zif_abapgit_xml_input
RAISING RAISING
zcx_abapgit_exception . zcx_abapgit_exception .
METHODS access_modify METHODS access_modify
@ -84,12 +84,12 @@ CLASS zcl_abapgit_object_udmo DEFINITION
zcx_abapgit_exception . zcx_abapgit_exception .
METHODS deserialize_model METHODS deserialize_model
IMPORTING IMPORTING
!io_xml TYPE REF TO zcl_abapgit_xml_input !io_xml TYPE REF TO zif_abapgit_xml_input
RAISING RAISING
zcx_abapgit_exception . zcx_abapgit_exception .
METHODS serialize_model METHODS serialize_model
IMPORTING IMPORTING
!io_xml TYPE REF TO zcl_abapgit_xml_output !io_xml TYPE REF TO zif_abapgit_xml_output
RAISING RAISING
zcx_abapgit_exception . zcx_abapgit_exception .
ENDCLASS. ENDCLASS.

View File

@ -54,19 +54,19 @@ CLASS zcl_abapgit_object_ueno DEFINITION
METHODS deserialize_docu_uen METHODS deserialize_docu_uen
IMPORTING IMPORTING
io_xml TYPE REF TO zcl_abapgit_xml_input io_xml TYPE REF TO zif_abapgit_xml_input
RAISING RAISING
zcx_abapgit_exception. zcx_abapgit_exception.
METHODS deserialize_docu_url METHODS deserialize_docu_url
IMPORTING IMPORTING
io_xml TYPE REF TO zcl_abapgit_xml_input io_xml TYPE REF TO zif_abapgit_xml_input
RAISING RAISING
zcx_abapgit_exception. zcx_abapgit_exception.
METHODS deserialize_docu_usp METHODS deserialize_docu_usp
IMPORTING IMPORTING
io_xml TYPE REF TO zcl_abapgit_xml_input io_xml TYPE REF TO zif_abapgit_xml_input
RAISING RAISING
zcx_abapgit_exception. zcx_abapgit_exception.
@ -74,13 +74,13 @@ CLASS zcl_abapgit_object_ueno DEFINITION
METHODS serialize_docu_uen METHODS serialize_docu_uen
IMPORTING IMPORTING
io_xml TYPE REF TO zcl_abapgit_xml_output io_xml TYPE REF TO zif_abapgit_xml_output
RAISING RAISING
zcx_abapgit_exception. zcx_abapgit_exception.
METHODS serialize_docu_url METHODS serialize_docu_url
IMPORTING IMPORTING
io_xml TYPE REF TO zcl_abapgit_xml_output io_xml TYPE REF TO zif_abapgit_xml_output
RAISING RAISING
zcx_abapgit_exception. zcx_abapgit_exception.
@ -90,7 +90,7 @@ CLASS zcl_abapgit_object_ueno DEFINITION
METHODS serialize_docu_usp METHODS serialize_docu_usp
IMPORTING IMPORTING
io_xml TYPE REF TO zcl_abapgit_xml_output io_xml TYPE REF TO zif_abapgit_xml_output
RAISING RAISING
zcx_abapgit_exception. zcx_abapgit_exception.
@ -105,7 +105,8 @@ ENDCLASS.
CLASS zcl_abapgit_object_ueno IMPLEMENTATION. CLASS ZCL_ABAPGIT_OBJECT_UENO IMPLEMENTATION.
METHOD build_text_name. METHOD build_text_name.
@ -135,6 +136,7 @@ CLASS zcl_abapgit_object_ueno IMPLEMENTATION.
ENDMETHOD. ENDMETHOD.
METHOD delete_docu_uen. METHOD delete_docu_uen.
DATA lt_dm02l TYPE STANDARD TABLE OF dm02l WITH DEFAULT KEY. DATA lt_dm02l TYPE STANDARD TABLE OF dm02l WITH DEFAULT KEY.
@ -181,6 +183,7 @@ CLASS zcl_abapgit_object_ueno IMPLEMENTATION.
ENDMETHOD. ENDMETHOD.
METHOD delete_docu_url. METHOD delete_docu_url.
DATA lt_dm42s TYPE STANDARD TABLE OF dm42s WITH DEFAULT KEY. DATA lt_dm42s TYPE STANDARD TABLE OF dm42s WITH DEFAULT KEY.
@ -231,6 +234,7 @@ CLASS zcl_abapgit_object_ueno IMPLEMENTATION.
ENDMETHOD. ENDMETHOD.
METHOD delete_docu_usp. METHOD delete_docu_usp.
DATA lt_dm45l TYPE STANDARD TABLE OF dm45l WITH DEFAULT KEY. DATA lt_dm45l TYPE STANDARD TABLE OF dm45l WITH DEFAULT KEY.
@ -259,43 +263,6 @@ CLASS zcl_abapgit_object_ueno IMPLEMENTATION.
ENDMETHOD. ENDMETHOD.
METHOD deserialize_docu_xxxx.
DATA ls_docu LIKE LINE OF it_docu.
DATA lv_objname TYPE lxeobjname.
DATA lv_change_flag TYPE char1.
DATA lv_error_status TYPE lxestatprc.
LOOP AT it_docu INTO ls_docu.
ls_docu-header-tdfuser = sy-uname.
ls_docu-header-tdfdate = sy-datum.
ls_docu-header-tdftime = sy-uzeit.
ls_docu-header-tdluser = sy-uname.
ls_docu-header-tdldate = sy-datum.
ls_docu-header-tdltime = sy-uzeit.
lv_objname = ls_docu-header-tdname.
CALL FUNCTION 'LXE_OBJ_DOKU_PUT_XSTRING'
EXPORTING
slang = me->mv_language
tlang = ls_docu-language
objtype = ls_docu-header-tdid
objname = lv_objname
header = ls_docu-header
content = ls_docu-content
IMPORTING
change_flag = lv_change_flag
pstatus = lv_error_status.
ENDLOOP.
ENDMETHOD.
METHOD deserialize_docu_uen. METHOD deserialize_docu_uen.
DATA lt_docu TYPE ty_docu_lines. DATA lt_docu TYPE ty_docu_lines.
@ -342,6 +309,7 @@ CLASS zcl_abapgit_object_ueno IMPLEMENTATION.
ENDMETHOD. ENDMETHOD.
METHOD deserialize_docu_usp. METHOD deserialize_docu_usp.
DATA lt_docu TYPE ty_docu_lines. DATA lt_docu TYPE ty_docu_lines.
@ -353,6 +321,44 @@ CLASS zcl_abapgit_object_ueno IMPLEMENTATION.
ENDMETHOD. ENDMETHOD.
METHOD deserialize_docu_xxxx.
DATA ls_docu LIKE LINE OF it_docu.
DATA lv_objname TYPE lxeobjname.
DATA lv_change_flag TYPE char1.
DATA lv_error_status TYPE lxestatprc.
LOOP AT it_docu INTO ls_docu.
ls_docu-header-tdfuser = sy-uname.
ls_docu-header-tdfdate = sy-datum.
ls_docu-header-tdftime = sy-uzeit.
ls_docu-header-tdluser = sy-uname.
ls_docu-header-tdldate = sy-datum.
ls_docu-header-tdltime = sy-uzeit.
lv_objname = ls_docu-header-tdname.
CALL FUNCTION 'LXE_OBJ_DOKU_PUT_XSTRING'
EXPORTING
slang = me->mv_language
tlang = ls_docu-language
objtype = ls_docu-header-tdid
objname = lv_objname
header = ls_docu-header
content = ls_docu-content
IMPORTING
change_flag = lv_change_flag
pstatus = lv_error_status.
ENDLOOP.
ENDMETHOD.
METHOD is_name_permitted. METHOD is_name_permitted.
" It is unlikely that a serialized entity will have a name that is not permitted. However " It is unlikely that a serialized entity will have a name that is not permitted. However
@ -372,6 +378,7 @@ CLASS zcl_abapgit_object_ueno IMPLEMENTATION.
ENDMETHOD. ENDMETHOD.
METHOD serialize_docu_uen. METHOD serialize_docu_uen.
DATA lt_docu TYPE ty_docu_lines. DATA lt_docu TYPE ty_docu_lines.
@ -393,6 +400,7 @@ CLASS zcl_abapgit_object_ueno IMPLEMENTATION.
ig_data = lt_docu ). ig_data = lt_docu ).
ENDMETHOD. ENDMETHOD.
METHOD serialize_docu_url. METHOD serialize_docu_url.
@ -413,6 +421,7 @@ CLASS zcl_abapgit_object_ueno IMPLEMENTATION.
ENDMETHOD. ENDMETHOD.
METHOD serialize_docu_usp. METHOD serialize_docu_usp.
DATA lt_docu TYPE ty_docu_lines. DATA lt_docu TYPE ty_docu_lines.
@ -425,6 +434,7 @@ CLASS zcl_abapgit_object_ueno IMPLEMENTATION.
ENDMETHOD. ENDMETHOD.
METHOD serialize_docu_xxxx. METHOD serialize_docu_xxxx.
DATA ls_docu TYPE ty_docu. DATA ls_docu TYPE ty_docu.
@ -477,6 +487,7 @@ CLASS zcl_abapgit_object_ueno IMPLEMENTATION.
ENDMETHOD. ENDMETHOD.
METHOD zif_abapgit_object~changed_by. METHOD zif_abapgit_object~changed_by.
SELECT SINGLE lstuser INTO rv_user SELECT SINGLE lstuser INTO rv_user
@ -638,5 +649,4 @@ CLASS zcl_abapgit_object_ueno IMPLEMENTATION.
serialize_docu_usp( io_xml ). serialize_docu_usp( io_xml ).
ENDMETHOD. ENDMETHOD.
ENDCLASS. ENDCLASS.

View File

@ -15,7 +15,7 @@ CLASS zcl_abapgit_objects_generic DEFINITION
METHODS deserialize METHODS deserialize
IMPORTING IMPORTING
!iv_package TYPE devclass !iv_package TYPE devclass
!io_xml TYPE REF TO zcl_abapgit_xml_input !io_xml TYPE REF TO zif_abapgit_xml_input
RAISING RAISING
zcx_abapgit_exception . zcx_abapgit_exception .
METHODS exists METHODS exists
@ -25,7 +25,7 @@ CLASS zcl_abapgit_objects_generic DEFINITION
zcx_abapgit_exception . zcx_abapgit_exception .
METHODS serialize METHODS serialize
IMPORTING IMPORTING
!io_xml TYPE REF TO zcl_abapgit_xml_output !io_xml TYPE REF TO zif_abapgit_xml_output
RAISING RAISING
zcx_abapgit_exception . zcx_abapgit_exception .
PROTECTED SECTION. PROTECTED SECTION.
@ -54,7 +54,7 @@ CLASS zcl_abapgit_objects_generic DEFINITION
zcx_abapgit_exception . zcx_abapgit_exception .
METHODS deserialize_data METHODS deserialize_data
IMPORTING IMPORTING
!io_xml TYPE REF TO zcl_abapgit_xml_input !io_xml TYPE REF TO zif_abapgit_xml_input
RAISING RAISING
zcx_abapgit_exception . zcx_abapgit_exception .
METHODS distribute_name_to_components METHODS distribute_name_to_components
@ -85,7 +85,7 @@ CLASS zcl_abapgit_objects_generic DEFINITION
zcx_abapgit_exception . zcx_abapgit_exception .
METHODS serialize_data METHODS serialize_data
IMPORTING IMPORTING
!io_xml TYPE REF TO zcl_abapgit_xml_output !io_xml TYPE REF TO zif_abapgit_xml_output
RAISING RAISING
zcx_abapgit_exception . zcx_abapgit_exception .
METHODS split_value_to_keys METHODS split_value_to_keys
@ -97,7 +97,7 @@ CLASS zcl_abapgit_objects_generic DEFINITION
!cv_non_value_pos TYPE numc3 . !cv_non_value_pos TYPE numc3 .
METHODS validate METHODS validate
IMPORTING IMPORTING
!io_xml TYPE REF TO zcl_abapgit_xml_input !io_xml TYPE REF TO zif_abapgit_xml_input
RAISING RAISING
zcx_abapgit_exception . zcx_abapgit_exception .
PRIVATE SECTION. PRIVATE SECTION.

View File

@ -15,7 +15,7 @@ CLASS zcl_abapgit_sotr_handler DEFINITION
!iv_pgmid TYPE pgmid !iv_pgmid TYPE pgmid
!iv_object TYPE trobjtype !iv_object TYPE trobjtype
!iv_obj_name TYPE csequence !iv_obj_name TYPE csequence
!io_xml TYPE REF TO zcl_abapgit_xml_output OPTIONAL !io_xml TYPE REF TO zif_abapgit_xml_output OPTIONAL
EXPORTING EXPORTING
!et_sotr TYPE zif_abapgit_definitions=>ty_sotr_tt !et_sotr TYPE zif_abapgit_definitions=>ty_sotr_tt
!et_sotr_use TYPE zif_abapgit_definitions=>ty_sotr_use_tt !et_sotr_use TYPE zif_abapgit_definitions=>ty_sotr_use_tt
@ -24,7 +24,7 @@ CLASS zcl_abapgit_sotr_handler DEFINITION
CLASS-METHODS create_sotr CLASS-METHODS create_sotr
IMPORTING IMPORTING
!iv_package TYPE devclass !iv_package TYPE devclass
!io_xml TYPE REF TO zcl_abapgit_xml_input !io_xml TYPE REF TO zif_abapgit_xml_input
RAISING RAISING
zcx_abapgit_exception . zcx_abapgit_exception .
PROTECTED SECTION. PROTECTED SECTION.