UI: Adjustments to Command Palette (#4080)

- Add prefix for utilities and help commands
- Remove leading spaces

Co-authored-by: Lars Hvam <larshp@hotmail.com>
This commit is contained in:
Marc Bernard 2020-10-28 01:46:53 -04:00 committed by GitHub
parent d14393dac5
commit f699812b02
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 13 additions and 2 deletions

View File

@ -2022,7 +2022,12 @@ function enumerateToolbarActions() {
if (item.nodeName !== "LI") continue; // unexpected node if (item.nodeName !== "LI") continue; // unexpected node
if (item.children.length >=2 && item.children[1].nodeName === "UL") { if (item.children.length >=2 && item.children[1].nodeName === "UL") {
// submenu detected // submenu detected
processUL(item.children[1], item.children[0].innerText); var menutext = item.children[0].innerText;
// special treatment for menus without text
if (!menutext) {
menutext = item.children[0].getAttribute("title");
}
processUL(item.children[1], menutext);
} else if (item.firstElementChild && item.firstElementChild.nodeName === "A") { } else if (item.firstElementChild && item.firstElementChild.nodeName === "A") {
var anchor = item.firstElementChild; var anchor = item.firstElementChild;
if (anchor.href && anchor.href !== "#") items.push([anchor, prefix]); if (anchor.href && anchor.href !== "#") items.push([anchor, prefix]);
@ -2042,7 +2047,7 @@ function enumerateToolbarActions() {
var prefix = item[1]; var prefix = item[1];
return { return {
action: anchor.href.replace("sapevent:", ""), action: anchor.href.replace("sapevent:", ""),
title: (prefix ? prefix + ": " : "") + anchor.innerText title: (prefix ? prefix + ": " : "") + anchor.innerText.trim()
}; };
}); });

View File

@ -53,9 +53,11 @@ CLASS zcl_abapgit_gui_page_main IMPLEMENTATION.
iv_act = zif_abapgit_definitions=>c_action-go_settings iv_act = zif_abapgit_definitions=>c_action-go_settings
)->add( )->add(
iv_txt = zcl_abapgit_gui_buttons=>advanced( ) iv_txt = zcl_abapgit_gui_buttons=>advanced( )
iv_title = 'Utilities'
io_sub = zcl_abapgit_gui_chunk_lib=>advanced_submenu( ) io_sub = zcl_abapgit_gui_chunk_lib=>advanced_submenu( )
)->add( )->add(
iv_txt = zcl_abapgit_gui_buttons=>help( ) iv_txt = zcl_abapgit_gui_buttons=>help( )
iv_title = 'Help'
io_sub = zcl_abapgit_gui_chunk_lib=>help_submenu( ) ). io_sub = zcl_abapgit_gui_chunk_lib=>help_submenu( ) ).
ENDMETHOD. ENDMETHOD.

View File

@ -430,9 +430,11 @@ CLASS zcl_abapgit_gui_page_repo_view IMPLEMENTATION.
iv_act = zif_abapgit_definitions=>c_action-go_settings iv_act = zif_abapgit_definitions=>c_action-go_settings
)->add( )->add(
iv_txt = zcl_abapgit_gui_buttons=>advanced( ) iv_txt = zcl_abapgit_gui_buttons=>advanced( )
iv_title = 'Utilities'
io_sub = zcl_abapgit_gui_chunk_lib=>advanced_submenu( ) io_sub = zcl_abapgit_gui_chunk_lib=>advanced_submenu( )
)->add( )->add(
iv_txt = zcl_abapgit_gui_buttons=>help( ) iv_txt = zcl_abapgit_gui_buttons=>help( )
iv_title = 'Help'
io_sub = zcl_abapgit_gui_chunk_lib=>help_submenu( ) ). io_sub = zcl_abapgit_gui_chunk_lib=>help_submenu( ) ).
ENDMETHOD. ENDMETHOD.

View File

@ -46,9 +46,11 @@ CLASS ZCL_ABAPGIT_GUI_PAGE_TUTORIAL IMPLEMENTATION.
iv_act = zif_abapgit_definitions=>c_action-go_settings iv_act = zif_abapgit_definitions=>c_action-go_settings
)->add( )->add(
iv_txt = zcl_abapgit_gui_buttons=>advanced( ) iv_txt = zcl_abapgit_gui_buttons=>advanced( )
iv_title = 'Utilities'
io_sub = zcl_abapgit_gui_chunk_lib=>advanced_submenu( ) io_sub = zcl_abapgit_gui_chunk_lib=>advanced_submenu( )
)->add( )->add(
iv_txt = zcl_abapgit_gui_buttons=>help( ) iv_txt = zcl_abapgit_gui_buttons=>help( )
iv_title = 'Help'
io_sub = zcl_abapgit_gui_chunk_lib=>help_submenu( ) ). io_sub = zcl_abapgit_gui_chunk_lib=>help_submenu( ) ).
ENDMETHOD. ENDMETHOD.