SAP/abapGit
1
0
Fork 0
mirror of https://github.com/abapGit/abapGit.git synced 2025-05-01 12:20:51 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

ZCL_ABAPGIT_UTILS refactor unit test (#4451)

Browse Source 
one method per test case, this makes it possible to see which unit test fails, if something fails

just numbered methods, because I'm lazy

closes #4441
This commit is contained in:
Lars Hvam 2021-01-26 06:20:50 +01:00 committed by GitHub
parent c89cff6b89
commit faa441ced0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 26 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
src/utils/zcl_abapgit_utils.clas.testclasses.abap
View File

@ -4,74 +4,96 @@ CLASS ltcl_utils_test DEFINITION FINAL
RISK LEVEL HARMLESS. RISK LEVEL HARMLESS.
PRIVATE SECTION. PRIVATE SECTION.
METHODS extract_author_data FOR TESTING. METHODS extract_author_data1 FOR TESTING RAISING cx_static_check.
METHODS extract_author_data2 FOR TESTING RAISING cx_static_check.
METHODS extract_author_data3 FOR TESTING RAISING cx_static_check.
METHODS extract_author_data4 FOR TESTING RAISING cx_static_check.
METHODS extract_author_data5 FOR TESTING RAISING cx_static_check.
METHODS extract_author_data6 FOR TESTING RAISING cx_static_check.
METHODS extract_author_data7 FOR TESTING RAISING cx_static_check.
METHODS extract_author_data8 FOR TESTING RAISING cx_static_check.
METHODS extract_author_data9 FOR TESTING RAISING cx_static_check.
ENDCLASS. ENDCLASS.
CLASS ltcl_utils_test IMPLEMENTATION. CLASS ltcl_utils_test IMPLEMENTATION.
METHOD extract_author_data. METHOD extract_author_data1.
TRY. TRY.
zcl_abapgit_utils=>extract_author_data( 'Volker Jägle äÖüß <github@beimir.net> 1573216988 +0000' ). zcl_abapgit_utils=>extract_author_data( 'Volker Jägle äÖüß <github@beimir.net> 1573216988 +0000' ).
CATCH zcx_abapgit_exception. CATCH zcx_abapgit_exception.
cl_abap_unit_assert=>fail( |Language-related special characters in author name are allowed.| ). cl_abap_unit_assert=>fail( |Language-related special characters in author name are allowed.| ).
ENDTRY. ENDTRY.
ENDMETHOD.
METHOD extract_author_data2.
TRY. TRY.
zcl_abapgit_utils=>extract_author_data( zcl_abapgit_utils=>extract_author_data(
'pull[bot&%#$] <39814207+pull[bot]@users.noreply.github.com> 1573216988 +0000' ). 'pull[bot&%#$] <39814207+pull[bot]@users.noreply.github.com> 1573216988 +0000' ).
CATCH zcx_abapgit_exception. CATCH zcx_abapgit_exception.
cl_abap_unit_assert=>fail( |Special characters in author name are allowed.| ). cl_abap_unit_assert=>fail( |Special characters in author name are allowed.| ).
ENDTRY. ENDTRY.
ENDMETHOD.
METHOD extract_author_data3.
TRY. TRY.
zcl_abapgit_utils=>extract_author_data( zcl_abapgit_utils=>extract_author_data(
'pull[bot] <39814207+pull[bot]@users.noreply.github.com> 1573216988 +00001' ). 'pull[bot] <39814207+pull[bot]@users.noreply.github.com> 1573216988 +00001' ).
cl_abap_unit_assert=>fail( |+00001 shouldn't be valid cause it's too long.| ). cl_abap_unit_assert=>fail( |+00001 shouldn't be valid cause it's too long.| ).
CATCH zcx_abapgit_exception. CATCH zcx_abapgit_exception.
ENDTRY. ENDTRY.
ENDMETHOD.
METHOD extract_author_data4.
TRY. TRY.
zcl_abapgit_utils=>extract_author_data( zcl_abapgit_utils=>extract_author_data(
'pull[bot] <39814207+pull[bot]@users.noreply.github.com> 15732169881 +0000' ). 'pull[bot] <39814207+pull[bot]@users.noreply.github.com> 15732169881 +0000' ).
cl_abap_unit_assert=>fail( |Value shouldn't be valid cause time is invalid.| ). cl_abap_unit_assert=>fail( |Value shouldn't be valid cause time is invalid.| ).
CATCH zcx_abapgit_exception. CATCH zcx_abapgit_exception.
ENDTRY. ENDTRY.
ENDMETHOD.
METHOD extract_author_data5.
TRY. TRY.
zcl_abapgit_utils=>extract_author_data( zcl_abapgit_utils=>extract_author_data(
'<39814207+pull[bot]@users.noreply.github.com> 1573216988 +0000' ). '<39814207+pull[bot]@users.noreply.github.com> 1573216988 +0000' ).
cl_abap_unit_assert=>fail( |Value shouldn't be valid cause no author name was supplied.| ). cl_abap_unit_assert=>fail( |Value shouldn't be valid cause no author name was supplied.| ).
CATCH zcx_abapgit_exception. CATCH zcx_abapgit_exception.
ENDTRY. ENDTRY.
ENDMETHOD.
METHOD extract_author_data6.
TRY. TRY.
zcl_abapgit_utils=>extract_author_data( 'pull[bot] 1573216988 +0000' ). zcl_abapgit_utils=>extract_author_data( 'pull[bot] 1573216988 +0000' ).
cl_abap_unit_assert=>fail( |Value shouldn't be valid cause no email was supplied.| ). cl_abap_unit_assert=>fail( |Value shouldn't be valid cause no email was supplied.| ).
CATCH zcx_abapgit_exception. CATCH zcx_abapgit_exception.
ENDTRY. ENDTRY.
ENDMETHOD.
METHOD extract_author_data7.
TRY. TRY.
zcl_abapgit_utils=>extract_author_data( 'pull[bot] <39814207+pull[bot]@users.noreply.github.com> +0000' ). zcl_abapgit_utils=>extract_author_data( 'pull[bot] <39814207+pull[bot]@users.noreply.github.com> +0000' ).
cl_abap_unit_assert=>fail( |Value shouldn't be valid cause no time was supplied.| ). cl_abap_unit_assert=>fail( |Value shouldn't be valid cause no time was supplied.| ).
CATCH zcx_abapgit_exception. CATCH zcx_abapgit_exception.
ENDTRY. ENDTRY.
ENDMETHOD.
METHOD extract_author_data8.
TRY. TRY.
zcl_abapgit_utils=>extract_author_data( zcl_abapgit_utils=>extract_author_data(
'pull[bot] <39814207+pull[bot]@users.noreply.github.com> 1573216988' ). 'pull[bot] <39814207+pull[bot]@users.noreply.github.com> 1573216988' ).
cl_abap_unit_assert=>fail( |Value shouldn't be valid cause +0000 wasn't supplied.| ). cl_abap_unit_assert=>fail( |Value shouldn't be valid cause +0000 wasn't supplied.| ).
CATCH zcx_abapgit_exception. CATCH zcx_abapgit_exception.
ENDTRY. ENDTRY.
ENDMETHOD.
METHOD extract_author_data9.
TRY. TRY.
zcl_abapgit_utils=>extract_author_data( zcl_abapgit_utils=>extract_author_data(
'<pull[bot]()> <39814207+pull[bot]@users.noreply.github.com> 1573216988 +0000' ). '<pull[bot]()> <39814207+pull[bot]@users.noreply.github.com> 1573216988 +0000' ).
CATCH zcx_abapgit_exception. CATCH zcx_abapgit_exception.
cl_abap_unit_assert=>fail( |Value should be valid though brackets are in author name.| ). cl_abap_unit_assert=>fail( |Value should be valid though brackets are in author name.| ).
ENDTRY. ENDTRY.
ENDMETHOD. ENDMETHOD.
ENDCLASS. ENDCLASS.