SAP/abapGit
1
0
Fork 0
mirror of https://github.com/abapGit/abapGit.git synced 2025-04-30 11:46:38 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

no need to pass is_checks by value

Browse Source 
plus some methods reordered
This commit is contained in:
larshp 2018-07-26 14:37:07 +00:00 committed by Lars Hvam
parent 95a8a42c25
commit faf2f93197
1 changed files with 53 additions and 53 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

106
src/zcl_abapgit_repo.clas.abap
View File

@ -63,7 +63,7 @@ CLASS zcl_abapgit_repo DEFINITION
zcx_abapgit_exception . zcx_abapgit_exception .
METHODS deserialize METHODS deserialize
IMPORTING IMPORTING
VALUE(is_checks) TYPE zif_abapgit_definitions=>ty_deserialize_checks is_checks TYPE zif_abapgit_definitions=>ty_deserialize_checks
RAISING RAISING
zcx_abapgit_exception . zcx_abapgit_exception .
METHODS refresh METHODS refresh
@ -141,33 +141,7 @@ ENDCLASS.
CLASS zcl_abapgit_repo IMPLEMENTATION. CLASS ZCL_ABAPGIT_REPO IMPLEMENTATION.
METHOD run_code_inspector.
DATA: li_code_inspector TYPE REF TO zif_abapgit_code_inspector,
lv_check_variant TYPE string.
lv_check_variant = get_local_settings( )-code_inspector_check_variant.
IF lv_check_variant IS INITIAL.
zcx_abapgit_exception=>raise( |No check variant maintained in repo settings.| ).
ENDIF.
li_code_inspector = zcl_abapgit_factory=>get_code_inspector(
iv_package = get_package( )
iv_check_variant_name = |{ lv_check_variant }| ).
rt_list = li_code_inspector->run( ).
DELETE rt_list WHERE kind = 'N'.
READ TABLE rt_list TRANSPORTING NO FIELDS
WITH KEY kind = 'E'.
mv_code_inspector_successful = boolc( sy-subrc <> 0 ).
ENDMETHOD.
METHOD constructor. METHOD constructor.
@ -191,6 +165,16 @@ CLASS zcl_abapgit_repo IMPLEMENTATION.
ENDMETHOD. "delete ENDMETHOD. "delete
METHOD delete_checks.
DATA: li_package TYPE REF TO zif_abapgit_sap_package.
li_package = zcl_abapgit_factory=>get_sap_package( get_package( ) ).
rs_checks-transport-required = li_package->are_changes_recorded_in_tr_req( ).
ENDMETHOD.
METHOD deserialize. METHOD deserialize.
DATA: lt_updated_files TYPE zif_abapgit_definitions=>ty_file_signatures_tt, DATA: lt_updated_files TYPE zif_abapgit_definitions=>ty_file_signatures_tt,
@ -249,16 +233,6 @@ CLASS zcl_abapgit_repo IMPLEMENTATION.
ENDMETHOD. ENDMETHOD.
METHOD delete_checks.
DATA: li_package TYPE REF TO zif_abapgit_sap_package.
li_package = zcl_abapgit_factory=>get_sap_package( get_package( ) ).
rs_checks-transport-required = li_package->are_changes_recorded_in_tr_req( ).
ENDMETHOD.
METHOD find_remote_dot_abapgit. METHOD find_remote_dot_abapgit.
FIELD-SYMBOLS: <ls_remote> LIKE LINE OF mt_remote. FIELD-SYMBOLS: <ls_remote> LIKE LINE OF mt_remote.
@ -489,6 +463,33 @@ CLASS zcl_abapgit_repo IMPLEMENTATION.
ENDMETHOD. "refresh ENDMETHOD. "refresh
METHOD run_code_inspector.
DATA: li_code_inspector TYPE REF TO zif_abapgit_code_inspector,
lv_check_variant TYPE string.
lv_check_variant = get_local_settings( )-code_inspector_check_variant.
IF lv_check_variant IS INITIAL.
zcx_abapgit_exception=>raise( |No check variant maintained in repo settings.| ).
ENDIF.
li_code_inspector = zcl_abapgit_factory=>get_code_inspector(
iv_package = get_package( )
iv_check_variant_name = |{ lv_check_variant }| ).
rt_list = li_code_inspector->run( ).
DELETE rt_list WHERE kind = 'N'.
READ TABLE rt_list TRANSPORTING NO FIELDS
WITH KEY kind = 'E'.
mv_code_inspector_successful = boolc( sy-subrc <> 0 ).
ENDMETHOD.
METHOD set. METHOD set.
* TODO: refactor * TODO: refactor
@ -588,6 +589,20 @@ CLASS zcl_abapgit_repo IMPLEMENTATION.
ENDMETHOD. ENDMETHOD.
METHOD update_last_deserialize.
DATA: lv_deserialized_at TYPE zif_abapgit_persistence=>ty_repo-deserialized_at,
lv_deserialized_by TYPE zif_abapgit_persistence=>ty_repo-deserialized_by.
GET TIME STAMP FIELD lv_deserialized_at.
lv_deserialized_by = sy-uname.
set( iv_deserialized_at = lv_deserialized_at
iv_deserialized_by = lv_deserialized_by ).
ENDMETHOD.
METHOD update_local_checksums. METHOD update_local_checksums.
" ASSUMTION: SHA1 in param is actual and correct. " ASSUMTION: SHA1 in param is actual and correct.
@ -665,19 +680,4 @@ CLASS zcl_abapgit_repo IMPLEMENTATION.
set( it_checksums = lt_checksums ). set( it_checksums = lt_checksums ).
ENDMETHOD. " update_local_checksums ENDMETHOD. " update_local_checksums
METHOD update_last_deserialize.
DATA: lv_deserialized_at TYPE zif_abapgit_persistence=>ty_repo-deserialized_at,
lv_deserialized_by TYPE zif_abapgit_persistence=>ty_repo-deserialized_by.
GET TIME STAMP FIELD lv_deserialized_at.
lv_deserialized_by = sy-uname.
set( iv_deserialized_at = lv_deserialized_at
iv_deserialized_by = lv_deserialized_by ).
ENDMETHOD.
ENDCLASS. ENDCLASS.