SAP/abapGit
1
0
Fork 0
mirror of https://github.com/abapGit/abapGit.git synced 2025-04-30 11:46:38 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

tp: use the correct transport type in the tr popup

Browse Source 
We are developing in an infinity system which is somehow cloned into a
new releases system. When we need to backport a bug fixes we do
cherry-pick the commits and pull them the release system. However, in
those systems we need to use the task type Repair.

Hence, we need to overwrite the default value of the parameter
wi_task_type of the function TRINT_ORDER_CHOICE which is 'S'
(Development/Correction) with the value 'R'.

I use the function TRINT_GET_REQUEST_TYPE and for the sake of simplicity
I assume that it is enough to know the transport type of the repository
package - in other words, it is no necessary to check every deserialized
object.

Related to #1446
This commit is contained in:
Jakub Filak 2018-06-11 10:57:45 +00:00
parent 56c58b7a29
commit fb6efabfb9
4 changed files with 15 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/ui/zcl_abapgit_popups.clas.abap
View File

@ -139,6 +139,8 @@ CLASS zcl_abapgit_popups DEFINITION
RAISING RAISING
zcx_abapgit_exception . zcx_abapgit_exception .
CLASS-METHODS popup_transport_request CLASS-METHODS popup_transport_request
IMPORTING
!is_transport_type TYPE zif_abapgit_definitions=>ty_transport_type
RETURNING RETURNING
VALUE(rv_transport) TYPE trkorr VALUE(rv_transport) TYPE trkorr
RAISING RAISING
@ -1015,6 +1017,9 @@ CLASS ZCL_ABAPGIT_POPUPS IMPLEMENTATION.
lt_e071k TYPE STANDARD TABLE OF e071k. lt_e071k TYPE STANDARD TABLE OF e071k.
CALL FUNCTION 'TRINT_ORDER_CHOICE' CALL FUNCTION 'TRINT_ORDER_CHOICE'
EXPORTING
wi_order_type = is_transport_type-request
wi_task_type = is_transport_type-task
IMPORTING IMPORTING
we_order = rv_transport we_order = rv_transport
TABLES TABLES

3
src/ui/zcl_abapgit_services_repo.clas.abap
View File

@ -121,7 +121,8 @@ CLASS ZCL_ABAPGIT_SERVICES_REPO IMPLEMENTATION.
ENDIF. ENDIF.
IF ls_checks-transport-required = abap_true. IF ls_checks-transport-required = abap_true.
ls_checks-transport-transport = zcl_abapgit_popups=>popup_transport_request( ). ls_checks-transport-transport = zcl_abapgit_popups=>popup_transport_request(
is_transport_type = ls_checks-transport-type ).
ENDIF. ENDIF.
CATCH zcx_abapgit_cancel. CATCH zcx_abapgit_cancel.

10
src/zcl_abapgit_objects.clas.abap
View File

@ -520,7 +520,8 @@ CLASS ZCL_ABAPGIT_OBJECTS IMPLEMENTATION.
METHOD deserialize_checks. METHOD deserialize_checks.
DATA: lt_results TYPE zif_abapgit_definitions=>ty_results_tt. DATA: lt_results TYPE zif_abapgit_definitions=>ty_results_tt,
li_package TYPE REF TO zif_abapgit_sap_package.
lt_results = files_to_deserialize( io_repo ). lt_results = files_to_deserialize( io_repo ).
@ -532,8 +533,11 @@ CLASS ZCL_ABAPGIT_OBJECTS IMPLEMENTATION.
it_results = lt_results ). it_results = lt_results ).
IF lines( lt_results ) > 0. IF lines( lt_results ) > 0.
rs_checks-transport-required = zcl_abapgit_sap_package=>get( io_repo->get_package( ) li_package = zcl_abapgit_sap_package=>get( io_repo->get_package( ) ).
)->are_changes_recorded_in_tr_req( ). rs_checks-transport-required = li_package->are_changes_recorded_in_tr_req( ).
IF NOT rs_checks-transport-required IS INITIAL.
rs_checks-transport-type = li_package->get_transport_type( ).
ENDIF.
ENDIF. ENDIF.
ENDMETHOD. ENDMETHOD.

1
src/zif_abapgit_definitions.intf.abap
View File

@ -119,6 +119,7 @@ INTERFACE zif_abapgit_definitions PUBLIC.
TYPES: BEGIN OF ty_transport, TYPES: BEGIN OF ty_transport,
required TYPE abap_bool, required TYPE abap_bool,
transport TYPE trkorr, transport TYPE trkorr,
type TYPE ty_transport_type,
END OF ty_transport. END OF ty_transport.