diff --git a/abaplint.json b/abaplint.json
index 94599f05b..42308c067 100644
--- a/abaplint.json
+++ b/abaplint.json
@@ -14,7 +14,9 @@
"enabled": true,
"exclude": [],
"define": false,
- "endselect": true
+ "endselect": true,
+ "execSQL": true,
+ "kernelCall": true
},
"breakpoint": {
"enabled": true,
@@ -55,6 +57,20 @@
"enabled": true,
"exclude": []
},
+ "double_space": {
+ "enabled": true,
+ "exclude": []
+ },
+ "empty_line_in_statement": {
+ "enabled": true,
+ "exclude": [],
+ "allowChained": true
+ },
+ "empty_loop": {
+ "enabled": true,
+ "exclude": [],
+ "length": 120
+ },
"empty_statement": {
"enabled": true,
"exclude": []
@@ -80,6 +96,10 @@
"enabled": true,
"exclude": []
},
+ "if_in_if": {
+ "enabled": true,
+ "exclude": []
+ },
"indentation": {
"enabled": true,
"exclude": [],
@@ -128,7 +148,7 @@
"enabled": true,
"exclude": []
},
- "message": {
+ "message_exists": {
"enabled": false,
"exclude": []
},
@@ -162,10 +182,6 @@
"exclude": [],
"depth": 5
},
- "no_exec_sql": {
- "enabled": true,
- "exclude": []
- },
"no_public_attributes": {
"enabled": true,
"exclude": []
@@ -203,11 +219,22 @@
"enabled": true,
"exclude": []
},
+ "remove_descriptions": {
+ "enabled": true,
+ "exclude": [],
+ "ignoreExceptions": true
+ },
"sequential_blank": {
"enabled": true,
"exclude": [],
"lines": 4
},
+ "short_case": {
+ "enabled": true,
+ "exclude": [],
+ "length": 1,
+ "allow": ["iv_action", "sy"]
+ },
"space_before_colon": {
"enabled": true,
"exclude": []
@@ -220,6 +247,10 @@
"enabled": false,
"exclude": []
},
+ "tabl_enhancement_category": {
+ "enabled": true,
+ "exclude": []
+ },
"when_others_last": {
"enabled": true,
"exclude": []
diff --git a/src/git/zcl_abapgit_git_tag.clas.abap b/src/git/zcl_abapgit_git_tag.clas.abap
index b0ed70b37..4b598248b 100644
--- a/src/git/zcl_abapgit_git_tag.clas.abap
+++ b/src/git/zcl_abapgit_git_tag.clas.abap
@@ -4,19 +4,18 @@ CLASS zcl_abapgit_git_tag DEFINITION
PUBLIC SECTION.
- CLASS-METHODS:
- add_tag_prefix
- IMPORTING
- iv_text TYPE csequence
- RETURNING
- VALUE(rv_text) TYPE string,
-
- remove_tag_prefix
- IMPORTING
- iv_text TYPE string
- RETURNING
- VALUE(rv_text) TYPE string.
-
+ CLASS-METHODS add_tag_prefix
+ IMPORTING
+ !iv_text TYPE csequence
+ RETURNING
+ VALUE(rv_text) TYPE string .
+ CLASS-METHODS remove_tag_prefix
+ IMPORTING
+ !iv_text TYPE string
+ RETURNING
+ VALUE(rv_text) TYPE string .
+ PROTECTED SECTION.
+ PRIVATE SECTION.
ENDCLASS.
diff --git a/src/git/zcl_abapgit_git_tag.clas.xml b/src/git/zcl_abapgit_git_tag.clas.xml
index ed281a521..8f4405e63 100644
--- a/src/git/zcl_abapgit_git_tag.clas.xml
+++ b/src/git/zcl_abapgit_git_tag.clas.xml
@@ -12,20 +12,6 @@
X
X
-
-
- ZCL_ABAPGIT_GIT_TAG
- ADD_TAG_PREFIX
- E
- ADD_TAG_PREFIX
-
-
- ZCL_ABAPGIT_GIT_TAG
- REMOVE_TAG_PREFIX
- E
- REMOVE_TAG_PREFIX
-
-
diff --git a/src/objects/zcl_abapgit_object_udmo.clas.abap b/src/objects/zcl_abapgit_object_udmo.clas.abap
index ab5c2737a..ff7d3d693 100644
--- a/src/objects/zcl_abapgit_object_udmo.clas.abap
+++ b/src/objects/zcl_abapgit_object_udmo.clas.abap
@@ -19,14 +19,15 @@ CLASS zcl_abapgit_object_udmo DEFINITION
PRIVATE SECTION.
TYPES:
- " You are reminded that the text serialisation / de-serialisation methods depend upon a common type.
- " To make the dependency explicit, there is one common definition.
+ " You are reminded that the text serialisation / de-serialisation methods depend upon a common type.
+ " To make the dependency explicit, there is one common definition.
BEGIN OF ty_udmo_text_type.
TYPES sprache TYPE dm40t-sprache.
TYPES dmoid TYPE dm40t-dmoid.
TYPES langbez TYPE dm40t-langbez.
TYPES as4local TYPE dm40t-as4local.
TYPES END OF ty_udmo_text_type .
+
DATA mv_data_model TYPE uddmodl .
DATA mv_text_object TYPE doku_obj .
DATA mv_lxe_text_name TYPE lxeobjname .
diff --git a/src/objects/zcl_abapgit_object_udmo.clas.xml b/src/objects/zcl_abapgit_object_udmo.clas.xml
index d8671ed7b..e0a742f95 100644
--- a/src/objects/zcl_abapgit_object_udmo.clas.xml
+++ b/src/objects/zcl_abapgit_object_udmo.clas.xml
@@ -12,68 +12,6 @@
X
X
-
-
- ZCL_ABAPGIT_OBJECT_UDMO
- ACCESS_FREE
- E
- RS Access Permission - Free
-
-
- ZCL_ABAPGIT_OBJECT_UDMO
- ACCESS_MODIFY
- E
- RS Access Permission - Modify
-
-
- ZCL_ABAPGIT_OBJECT_UDMO
- CONSTRUCTOR
- E
- Constructor
-
-
- ZCL_ABAPGIT_OBJECT_UDMO
- C_ACTIVE_STATE
- E
- Activation State
-
-
- ZCL_ABAPGIT_OBJECT_UDMO
- C_CORRECTION_OBJECT_TYPE
- E
- Object directory Type
-
-
- ZCL_ABAPGIT_OBJECT_UDMO
- C_LXE_TEXT_TYPE
- E
- Translation Object
-
-
- ZCL_ABAPGIT_OBJECT_UDMO
- C_TRANSPORT_OBJECT_CLASS
- E
- Object directory Class
-
-
- ZCL_ABAPGIT_OBJECT_UDMO
- IS_NAME_PERMITTED
- E
- Does the model comply with naming conventions?
-
-
- ZCL_ABAPGIT_OBJECT_UDMO
- MS_OBJECT_TYPE
- E
- Lock object structure for ABAP/4 Dictionary objects
-
-
- ZCL_ABAPGIT_OBJECT_UDMO
- UPDATE_TREE
- E
- Update the development workbench tree
-
-
diff --git a/src/objects/zcl_abapgit_object_vcls.clas.abap b/src/objects/zcl_abapgit_object_vcls.clas.abap
index 76a847a5d..d50132fbe 100644
--- a/src/objects/zcl_abapgit_object_vcls.clas.abap
+++ b/src/objects/zcl_abapgit_object_vcls.clas.abap
@@ -182,16 +182,16 @@ CLASS ZCL_ABAPGIT_OBJECT_VCLS IMPLEMENTATION.
lv_argument TYPE seqg3-garg,
lv_argument_langu TYPE seqg3-garg.
- lv_argument = me->ms_item-obj_name.
- lv_argument_langu = |@{ me->ms_item-obj_name }|.
+ lv_argument = me->ms_item-obj_name.
+ lv_argument_langu = |@{ me->ms_item-obj_name }|.
"Check all relevant maintein tabeles for view clusters
- IF check_lock( iv_tabname = 'VCLDIR' iv_argument = lv_argument ) = abap_true
- OR check_lock( iv_tabname = 'VCLDIRT' iv_argument = lv_argument_langu ) = abap_true
- OR check_lock( iv_tabname = 'VCLSTRUC' iv_argument = lv_argument ) = abap_true
- OR check_lock( iv_tabname = 'VCLSTRUCT' iv_argument = lv_argument_langu ) = abap_true
- OR check_lock( iv_tabname = 'VCLSTRUC' iv_argument = lv_argument ) = abap_true
- OR check_lock( iv_tabname = 'VCLMF' iv_argument = lv_argument ) = abap_true.
+ IF check_lock( iv_tabname = 'VCLDIR' iv_argument = lv_argument ) = abap_true
+ OR check_lock( iv_tabname = 'VCLDIRT' iv_argument = lv_argument_langu ) = abap_true
+ OR check_lock( iv_tabname = 'VCLSTRUC' iv_argument = lv_argument ) = abap_true
+ OR check_lock( iv_tabname = 'VCLSTRUCT' iv_argument = lv_argument_langu ) = abap_true
+ OR check_lock( iv_tabname = 'VCLSTRUC' iv_argument = lv_argument ) = abap_true
+ OR check_lock( iv_tabname = 'VCLMF' iv_argument = lv_argument ) = abap_true.
rv_is_locked = abap_true.
ENDIF.
diff --git a/src/objects/zcl_abapgit_object_vcls.clas.xml b/src/objects/zcl_abapgit_object_vcls.clas.xml
index bba6cd2e2..7dc7faba7 100644
--- a/src/objects/zcl_abapgit_object_vcls.clas.xml
+++ b/src/objects/zcl_abapgit_object_vcls.clas.xml
@@ -12,14 +12,6 @@
X
X
-
-
- ZCL_ABAPGIT_OBJECT_VCLS
- CHECK_LOCK
- E
- check if lock entry exits
-
-
diff --git a/src/objects/zcl_abapgit_object_webi.clas.abap b/src/objects/zcl_abapgit_object_webi.clas.abap
index bb00fdc00..1f9b7b839 100644
--- a/src/objects/zcl_abapgit_object_webi.clas.abap
+++ b/src/objects/zcl_abapgit_object_webi.clas.abap
@@ -193,7 +193,7 @@ CLASS ZCL_ABAPGIT_OBJECT_WEBI IMPLEMENTATION.
RETURN.
ENDIF.
- IF mi_vi->has_soap_extension_virtinfc( sews_c_vif_version-inactive ) = abap_true.
+ IF mi_vi->has_soap_extension_virtinfc( sews_c_vif_version-inactive ) = abap_true.
li_soap = mi_vi->get_soap_extension_virtinfc( sews_c_vif_version-inactive ).
ELSE.
li_soap = mi_vi->create_soap_extension_virtinfc( ls_soap-soap_appl_uri ).
diff --git a/src/persist/zcl_abapgit_persist_factory.clas.abap b/src/persist/zcl_abapgit_persist_factory.clas.abap
index 1b6bc0451..e1dd6de98 100644
--- a/src/persist/zcl_abapgit_persist_factory.clas.abap
+++ b/src/persist/zcl_abapgit_persist_factory.clas.abap
@@ -1,7 +1,6 @@
CLASS zcl_abapgit_persist_factory DEFINITION
PUBLIC
CREATE PRIVATE
-
GLOBAL FRIENDS zcl_abapgit_persist_injector .
PUBLIC SECTION.
diff --git a/src/persist/zcl_abapgit_persist_settings.clas.abap b/src/persist/zcl_abapgit_persist_settings.clas.abap
index d522d103c..6139099f9 100644
--- a/src/persist/zcl_abapgit_persist_settings.clas.abap
+++ b/src/persist/zcl_abapgit_persist_settings.clas.abap
@@ -15,6 +15,7 @@ CLASS zcl_abapgit_persist_settings DEFINITION
CLASS-METHODS get_instance
RETURNING
VALUE(ro_settings) TYPE REF TO zcl_abapgit_persist_settings .
+ PROTECTED SECTION.
PRIVATE SECTION.
DATA mo_settings TYPE REF TO zcl_abapgit_settings .
@@ -23,7 +24,7 @@ ENDCLASS.
-CLASS zcl_abapgit_persist_settings IMPLEMENTATION.
+CLASS ZCL_ABAPGIT_PERSIST_SETTINGS IMPLEMENTATION.
METHOD get_instance.
diff --git a/src/persist/zcl_abapgit_persist_settings.clas.xml b/src/persist/zcl_abapgit_persist_settings.clas.xml
index 42f7fbf57..a6c3097fb 100644
--- a/src/persist/zcl_abapgit_persist_settings.clas.xml
+++ b/src/persist/zcl_abapgit_persist_settings.clas.xml
@@ -13,14 +13,6 @@
X
X
-
-
- ZCL_ABAPGIT_PERSIST_SETTINGS
- GO_PERSIST
- E
- Settings
-
-
diff --git a/src/persist/zcl_abapgit_persistence_db.clas.abap b/src/persist/zcl_abapgit_persistence_db.clas.abap
index d404a2cba..8bf9fc023 100644
--- a/src/persist/zcl_abapgit_persistence_db.clas.abap
+++ b/src/persist/zcl_abapgit_persistence_db.clas.abap
@@ -65,13 +65,15 @@ CLASS zcl_abapgit_persistence_db DEFINITION
!iv_data TYPE zif_abapgit_persistence=>ty_content-data_str
RAISING
zcx_abapgit_exception .
+ PROTECTED SECTION.
PRIVATE SECTION.
CLASS-DATA go_db TYPE REF TO zcl_abapgit_persistence_db .
- DATA: mv_update_function TYPE funcname.
-
- METHODS get_update_function RETURNING VALUE(rv_funcname) TYPE funcname.
+ DATA mv_update_function TYPE funcname .
+ METHODS get_update_function
+ RETURNING
+ VALUE(rv_funcname) TYPE funcname .
METHODS validate_and_unprettify_xml
IMPORTING
!iv_xml TYPE string
diff --git a/src/persist/zcl_abapgit_persistence_db.clas.xml b/src/persist/zcl_abapgit_persistence_db.clas.xml
index 5ceda6e73..f34dd42b4 100644
--- a/src/persist/zcl_abapgit_persistence_db.clas.xml
+++ b/src/persist/zcl_abapgit_persistence_db.clas.xml
@@ -12,14 +12,6 @@
X
X
-
-
- ZCL_ABAPGIT_PERSISTENCE_DB
- GO_DB
- E
- Database persistence
-
-
diff --git a/src/persist/zcl_abapgit_persistence_repo.clas.abap b/src/persist/zcl_abapgit_persistence_repo.clas.abap
index 63d052ff6..18a64b041 100644
--- a/src/persist/zcl_abapgit_persistence_repo.clas.abap
+++ b/src/persist/zcl_abapgit_persistence_repo.clas.abap
@@ -1,7 +1,6 @@
CLASS zcl_abapgit_persistence_repo DEFINITION
PUBLIC
CREATE PROTECTED
-
GLOBAL FRIENDS zcl_abapgit_persist_factory .
PUBLIC SECTION.
diff --git a/src/ui/zcl_abapgit_gui_page_merge.clas.abap b/src/ui/zcl_abapgit_gui_page_merge.clas.abap
index b31034bcf..69761f9c3 100644
--- a/src/ui/zcl_abapgit_gui_page_merge.clas.abap
+++ b/src/ui/zcl_abapgit_gui_page_merge.clas.abap
@@ -16,7 +16,7 @@ CLASS zcl_abapgit_gui_page_merge DEFINITION
zcx_abapgit_exception .
METHODS zif_abapgit_gui_page~on_event
- REDEFINITION.
+ REDEFINITION.
PROTECTED SECTION.
METHODS render_content REDEFINITION.
diff --git a/src/ui/zcl_abapgit_gui_page_merge.clas.xml b/src/ui/zcl_abapgit_gui_page_merge.clas.xml
index afeffb18d..af27d011b 100644
--- a/src/ui/zcl_abapgit_gui_page_merge.clas.xml
+++ b/src/ui/zcl_abapgit_gui_page_merge.clas.xml
@@ -12,14 +12,6 @@
X
X
-
-
- ZCL_ABAPGIT_GUI_PAGE_MERGE
- MO_MERGE
- E
- Merge logic
-
-
diff --git a/src/ui/zcl_abapgit_gui_page_merge_res.clas.abap b/src/ui/zcl_abapgit_gui_page_merge_res.clas.abap
index aeb12aff2..57b082751 100644
--- a/src/ui/zcl_abapgit_gui_page_merge_res.clas.abap
+++ b/src/ui/zcl_abapgit_gui_page_merge_res.clas.abap
@@ -16,7 +16,7 @@ CLASS zcl_abapgit_gui_page_merge_res DEFINITION
zcx_abapgit_exception.
METHODS zif_abapgit_gui_page~on_event
- REDEFINITION .
+ REDEFINITION .
PROTECTED SECTION.
METHODS render_content REDEFINITION.
diff --git a/src/ui/zcl_abapgit_gui_page_merge_res.clas.xml b/src/ui/zcl_abapgit_gui_page_merge_res.clas.xml
index e06a84fa6..494f94d71 100644
--- a/src/ui/zcl_abapgit_gui_page_merge_res.clas.xml
+++ b/src/ui/zcl_abapgit_gui_page_merge_res.clas.xml
@@ -12,32 +12,6 @@
X
X
-
-
- ZCL_ABAPGIT_GUI_PAGE_MERGE_RES
- MO_MERGE
- E
- Merge logic
-
-
- ZCL_ABAPGIT_GUI_PAGE_MERGE_RES
- MO_MERGE_PAGE
- E
- GUI - Merging page
-
-
- ZCL_ABAPGIT_GUI_PAGE_MERGE_RES
- MO_REPO
- E
- Online Repository
-
-
- ZCL_ABAPGIT_GUI_PAGE_MERGE_RES
- MV_CURRENT_CONFLICT_INDEX
- E
- Row Index of Internal Tables
-
-
diff --git a/src/ui/zcl_abapgit_popups.clas.abap b/src/ui/zcl_abapgit_popups.clas.abap
index f186f89d0..9b1c14325 100644
--- a/src/ui/zcl_abapgit_popups.clas.abap
+++ b/src/ui/zcl_abapgit_popups.clas.abap
@@ -305,8 +305,8 @@ CLASS ZCL_ABAPGIT_POPUPS IMPLEMENTATION.
METHOD validate_folder_logic.
- IF iv_folder_logic <> zif_abapgit_dot_abapgit=>c_folder_logic-prefix
- AND iv_folder_logic <> zif_abapgit_dot_abapgit=>c_folder_logic-full.
+ IF iv_folder_logic <> zif_abapgit_dot_abapgit=>c_folder_logic-prefix
+ AND iv_folder_logic <> zif_abapgit_dot_abapgit=>c_folder_logic-full.
zcx_abapgit_exception=>raise( |Invalid folder logic { iv_folder_logic }. |
&& |Choose either { zif_abapgit_dot_abapgit=>c_folder_logic-prefix } |
diff --git a/src/utils/zcl_abapgit_convert.clas.abap b/src/utils/zcl_abapgit_convert.clas.abap
index bb797355b..83790b725 100644
--- a/src/utils/zcl_abapgit_convert.clas.abap
+++ b/src/utils/zcl_abapgit_convert.clas.abap
@@ -70,18 +70,14 @@ CLASS ZCL_ABAPGIT_CONVERT IMPLEMENTATION.
DO lv_len TIMES.
IF sy-index = 1.
-
"Intialize
- CASE lv_bitbyte+lv_offset(1).
- WHEN '1'.
- rv_int = 1.
- ENDCASE.
-
+ IF lv_bitbyte+lv_offset(1) = '1'.
+ rv_int = 1.
+ ENDIF.
ELSE.
- CASE lv_bitbyte+lv_offset(1).
- WHEN '1'.
- rv_int = rv_int + ( 2 ** ( sy-index - 1 ) ).
- ENDCASE.
+ IF lv_bitbyte+lv_offset(1) = '1'.
+ rv_int = rv_int + ( 2 ** ( sy-index - 1 ) ).
+ ENDIF.
ENDIF.
lv_offset = lv_offset - 1. "Move Cursor
diff --git a/src/utils/zcl_abapgit_login_manager.clas.abap b/src/utils/zcl_abapgit_login_manager.clas.abap
index 9999b60df..94ecf0806 100644
--- a/src/utils/zcl_abapgit_login_manager.clas.abap
+++ b/src/utils/zcl_abapgit_login_manager.clas.abap
@@ -29,6 +29,7 @@ CLASS zcl_abapgit_login_manager DEFINITION
VALUE(rv_auth) TYPE string
RAISING
zcx_abapgit_exception .
+ PROTECTED SECTION.
PRIVATE SECTION.
TYPES:
@@ -38,16 +39,14 @@ CLASS zcl_abapgit_login_manager DEFINITION
END OF ty_auth .
CLASS-DATA:
- gt_auth TYPE TABLE OF ty_auth WITH DEFAULT KEY.
-
- CLASS-METHODS:
- append
- IMPORTING
- !iv_uri TYPE string
- !iv_auth TYPE string
- RAISING
- zcx_abapgit_exception.
+ gt_auth TYPE TABLE OF ty_auth WITH DEFAULT KEY .
+ CLASS-METHODS append
+ IMPORTING
+ !iv_uri TYPE string
+ !iv_auth TYPE string
+ RAISING
+ zcx_abapgit_exception .
ENDCLASS.
diff --git a/src/utils/zcl_abapgit_login_manager.clas.xml b/src/utils/zcl_abapgit_login_manager.clas.xml
index 6709e3bee..1cdb8b29f 100644
--- a/src/utils/zcl_abapgit_login_manager.clas.xml
+++ b/src/utils/zcl_abapgit_login_manager.clas.xml
@@ -13,14 +13,6 @@
X
X
-
-
- ZCL_ABAPGIT_LOGIN_MANAGER
- TY_AUTH
- E
- TY_AUTH
-
-
diff --git a/src/utils/zcl_abapgit_progress.clas.xml b/src/utils/zcl_abapgit_progress.clas.xml
index 1500bd252..f12b69743 100644
--- a/src/utils/zcl_abapgit_progress.clas.xml
+++ b/src/utils/zcl_abapgit_progress.clas.xml
@@ -12,20 +12,6 @@
X
X
-
-
- ZCL_ABAPGIT_PROGRESS
- MV_CV_DATUM_NEXT
- E
- Date or Earliest, Next Progress Display
-
-
- ZCL_ABAPGIT_PROGRESS
- MV_CV_TIME_NEXT
- E
- Time of Earliest, Next Progress Display
-
-
diff --git a/src/utils/zcl_abapgit_requirement_helper.clas.abap b/src/utils/zcl_abapgit_requirement_helper.clas.abap
index 3585ca690..97d3d53e0 100644
--- a/src/utils/zcl_abapgit_requirement_helper.clas.abap
+++ b/src/utils/zcl_abapgit_requirement_helper.clas.abap
@@ -146,7 +146,7 @@ CLASS ZCL_ABAPGIT_REQUIREMENT_HELPER IMPLEMENTATION.
TYPES: BEGIN OF lty_color_line,
color TYPE lvc_t_scol.
- INCLUDE TYPE ty_requirement_status.
+ INCLUDE TYPE ty_requirement_status.
TYPES: END OF lty_color_line,
lty_color_tab TYPE STANDARD TABLE OF lty_color_line WITH DEFAULT KEY.
diff --git a/src/utils/zcl_abapgit_requirement_helper.clas.xml b/src/utils/zcl_abapgit_requirement_helper.clas.xml
index 9a839cc79..6a436621a 100644
--- a/src/utils/zcl_abapgit_requirement_helper.clas.xml
+++ b/src/utils/zcl_abapgit_requirement_helper.clas.xml
@@ -12,20 +12,6 @@
X
X
-
-
- ZCL_ABAPGIT_REQUIREMENT_HELPER
- TY_REQUIREMENT_STATUS
- E
- TY_REQUIREMENT_STATUS
-
-
- ZCL_ABAPGIT_REQUIREMENT_HELPER
- TY_REQUIREMENT_STATUS_TT
- E
- TY_REQUIREMENT_STATUS_TT
-
-
diff --git a/src/zcl_abapgit_merge.clas.xml b/src/zcl_abapgit_merge.clas.xml
index fe5824f9e..256619319 100644
--- a/src/zcl_abapgit_merge.clas.xml
+++ b/src/zcl_abapgit_merge.clas.xml
@@ -12,20 +12,6 @@
X
X
-
-
- ZCL_ABAPGIT_MERGE
- CONSTRUCTOR
- E
- CONSTRUCTOR
-
-
- ZCL_ABAPGIT_MERGE
- MO_REPO
- E
- Online Repository
-
-
diff --git a/src/zcl_abapgit_tadir.clas.abap b/src/zcl_abapgit_tadir.clas.abap
index d58ee6e04..129df0e6e 100644
--- a/src/zcl_abapgit_tadir.clas.abap
+++ b/src/zcl_abapgit_tadir.clas.abap
@@ -134,19 +134,18 @@ CLASS ZCL_ABAPGIT_TADIR IMPLEMENTATION.
-path = lv_path.
- CASE -object.
- WHEN 'SICF'.
+ IF -object = 'SICF'.
* replace the internal GUID with a hash of the path
- TRY.
- CALL METHOD ('ZCL_ABAPGIT_OBJECT_SICF')=>read_sicf_url
- EXPORTING
- iv_obj_name = -obj_name
- RECEIVING
- rv_hash = -obj_name+15.
- CATCH cx_sy_dyn_call_illegal_method ##NO_HANDLER.
+ TRY.
+ CALL METHOD ('ZCL_ABAPGIT_OBJECT_SICF')=>read_sicf_url
+ EXPORTING
+ iv_obj_name = -obj_name
+ RECEIVING
+ rv_hash = -obj_name+15.
+ CATCH cx_sy_dyn_call_illegal_method ##NO_HANDLER.
* SICF might not be supported in some systems, assume this code is not called
- ENDTRY.
- ENDCASE.
+ ENDTRY.
+ ENDIF.
ENDLOOP.
ENDMETHOD.
diff --git a/src/zif_abapgit_definitions.intf.abap b/src/zif_abapgit_definitions.intf.abap
index 7ad600e1a..eee735d50 100644
--- a/src/zif_abapgit_definitions.intf.abap
+++ b/src/zif_abapgit_definitions.intf.abap
@@ -24,7 +24,7 @@ INTERFACE zif_abapgit_definitions
ty_file_signature WITH UNIQUE KEY path filename .
TYPES:
BEGIN OF ty_file.
- INCLUDE TYPE ty_file_signature.
+ INCLUDE TYPE ty_file_signature.
TYPES: data TYPE xstring,
END OF ty_file .
TYPES:
@@ -99,7 +99,7 @@ INTERFACE zif_abapgit_definitions
ty_yes_no TYPE c LENGTH 1 .
TYPES:
BEGIN OF ty_overwrite.
- INCLUDE TYPE ty_item.
+ INCLUDE TYPE ty_item.
TYPES: decision TYPE ty_yes_no,
END OF ty_overwrite .
TYPES:
@@ -202,7 +202,7 @@ INTERFACE zif_abapgit_definitions
ty_seocompotx_tt TYPE STANDARD TABLE OF seocompotx WITH DEFAULT KEY .
TYPES:
BEGIN OF ty_tpool.
- INCLUDE TYPE textpool.
+ INCLUDE TYPE textpool.
TYPES: split TYPE c LENGTH 8.
TYPES: END OF ty_tpool .
TYPES:
@@ -430,16 +430,13 @@ INTERFACE zif_abapgit_definitions
repo_syntax_check TYPE string VALUE 'repo_syntax_check',
repo_code_inspector TYPE string VALUE 'repo_code_inspector',
repo_open_in_master_lang TYPE string VALUE 'repo_open_in_master_lang',
-
abapgit_home TYPE string VALUE 'abapgit_home',
abapgit_install TYPE string VALUE 'abapgit_install',
-
zip_import TYPE string VALUE 'zip_import',
zip_export TYPE string VALUE 'zip_export',
zip_package TYPE string VALUE 'zip_package',
zip_transport TYPE string VALUE 'zip_transport',
zip_object TYPE string VALUE 'zip_object',
-
git_pull TYPE string VALUE 'git_pull',
git_reset TYPE string VALUE 'git_reset',
git_branch_create TYPE string VALUE 'git_branch_create',
@@ -449,11 +446,9 @@ INTERFACE zif_abapgit_definitions
git_tag_delete TYPE string VALUE 'git_tag_delete',
git_tag_switch TYPE string VALUE 'git_tag_switch',
git_commit TYPE string VALUE 'git_commit',
-
db_display TYPE string VALUE 'db_display',
db_edit TYPE string VALUE 'db_edit',
bg_update TYPE string VALUE 'bg_update',
-
go_main TYPE string VALUE 'go_main',
go_explore TYPE string VALUE 'go_explore',
go_repo_overview TYPE string VALUE 'go_repo_overview',
@@ -470,11 +465,9 @@ INTERFACE zif_abapgit_definitions
go_settings TYPE string VALUE 'go_settings',
go_tutorial TYPE string VALUE 'go_tutorial',
go_patch TYPE string VALUE 'go_patch',
-
jump TYPE string VALUE 'jump',
jump_pkg TYPE string VALUE 'jump_pkg',
jump_transport TYPE string VALUE 'jump_transport',
-
url TYPE string VALUE 'url',
END OF c_action .
CONSTANTS c_tag_prefix TYPE string VALUE 'refs/tags/' ##NO_TEXT.
diff --git a/src/zif_abapgit_definitions.intf.xml b/src/zif_abapgit_definitions.intf.xml
index 5ded1ec6f..b92e48fdc 100644
--- a/src/zif_abapgit_definitions.intf.xml
+++ b/src/zif_abapgit_definitions.intf.xml
@@ -11,212 +11,6 @@
1
X
-
-
- ZIF_ABAPGIT_DEFINITIONS
- TT_REPO_FILES
- E
- TT_REPO_FILES
-
-
- ZIF_ABAPGIT_DEFINITIONS
- TY_BITBYTE
- E
- TY_BITBYTE
-
-
- ZIF_ABAPGIT_DEFINITIONS
- TY_CHMOD
- E
- TY_CHMOD
-
-
- ZIF_ABAPGIT_DEFINITIONS
- TY_COMMENT
- E
- TY_COMMENT
-
-
- ZIF_ABAPGIT_DEFINITIONS
- TY_FILE
- E
- TY_FILE
-
-
- ZIF_ABAPGIT_DEFINITIONS
- TY_FILES_ITEM_TT
- E
- TY_FILES_ITEM_TT
-
-
- ZIF_ABAPGIT_DEFINITIONS
- TY_FILES_TT
- E
- TY_FILES_TT
-
-
- ZIF_ABAPGIT_DEFINITIONS
- TY_FILE_ITEM
- E
- TY_FILE_ITEM
-
-
- ZIF_ABAPGIT_DEFINITIONS
- TY_FILE_SIGNATURE
- E
- TY_FILE_SIGNATURE
-
-
- ZIF_ABAPGIT_DEFINITIONS
- TY_FILE_SIGNATURES_TS
- E
- TY_FILE_SIGNATURES_TS
-
-
- ZIF_ABAPGIT_DEFINITIONS
- TY_FILE_SIGNATURES_TT
- E
- TY_FILE_SIGNATURES_TT
-
-
- ZIF_ABAPGIT_DEFINITIONS
- TY_GIT_USER
- E
- TY_GIT_USER
-
-
- ZIF_ABAPGIT_DEFINITIONS
- TY_ITEM
- E
- TY_ITEM
-
-
- ZIF_ABAPGIT_DEFINITIONS
- TY_ITEMS_TS
- E
- TY_ITEMS_TS
-
-
- ZIF_ABAPGIT_DEFINITIONS
- TY_ITEMS_TT
- E
- TY_ITEMS_TT
-
-
- ZIF_ABAPGIT_DEFINITIONS
- TY_METADATA
- E
- TY_METADATA
-
-
- ZIF_ABAPGIT_DEFINITIONS
- TY_OBJECT
- E
- TY_OBJECT
-
-
- ZIF_ABAPGIT_DEFINITIONS
- TY_OBJECTS_TT
- E
- TY_OBJECTS_TT
-
-
- ZIF_ABAPGIT_DEFINITIONS
- TY_REPO_FILE
- E
- TY_REPO_FILE
-
-
- ZIF_ABAPGIT_DEFINITIONS
- TY_RESULT
- E
- TY_RESULT
-
-
- ZIF_ABAPGIT_DEFINITIONS
- TY_RESULTS_TT
- E
- TY_RESULTS_TT
-
-
- ZIF_ABAPGIT_DEFINITIONS
- TY_SEOCOMPOTX_TT
- E
- TY_SEOCOMPOTX_TT
-
-
- ZIF_ABAPGIT_DEFINITIONS
- TY_SHA1
- E
- TY_SHA1
-
-
- ZIF_ABAPGIT_DEFINITIONS
- TY_SOTR
- E
- TY_SOTR
-
-
- ZIF_ABAPGIT_DEFINITIONS
- TY_SOTR_TT
- E
- TY_SOTR_TT
-
-
- ZIF_ABAPGIT_DEFINITIONS
- TY_STAGE_FILES
- E
- TY_STAGE_FILES
-
-
- ZIF_ABAPGIT_DEFINITIONS
- TY_STRING_TT
- E
- TY_STRING_TT
-
-
- ZIF_ABAPGIT_DEFINITIONS
- TY_SVAL_TT
- E
- TY_SVAL_TT
-
-
- ZIF_ABAPGIT_DEFINITIONS
- TY_TADIR
- E
- TY_TADIR
-
-
- ZIF_ABAPGIT_DEFINITIONS
- TY_TADIR_TT
- E
- TY_TADIR_TT
-
-
- ZIF_ABAPGIT_DEFINITIONS
- TY_TPOOL
- E
- TY_TPOOL
-
-
- ZIF_ABAPGIT_DEFINITIONS
- TY_TPOOL_TT
- E
- TY_TPOOL_TT
-
-
- ZIF_ABAPGIT_DEFINITIONS
- TY_TRANSPORT_TO_BRANCH
- E
- TY_TRANSPORT_TO_BRANCH
-
-
- ZIF_ABAPGIT_DEFINITIONS
- TY_TYPE
- E
- TY_TYPE
-
-