From ffb832a4ff968049ab225688cf74841102b6c149 Mon Sep 17 00:00:00 2001 From: hf-kklein Date: Thu, 22 Aug 2019 07:29:40 +0200 Subject: [PATCH] fix URL formatting, add note on **api**.github.com certificates (#2886) * fix URL formatting, add note on private repos & certificates * fix TLS / TSL typo * clarify when api.github.com certificates are needed according to https://github.com/larshp/abapGit/pull/2886#discussion_r316257182 --- docs/guide-ssl-setup.md | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/docs/guide-ssl-setup.md b/docs/guide-ssl-setup.md index 1eb09db1a..c45860ff1 100644 --- a/docs/guide-ssl-setup.md +++ b/docs/guide-ssl-setup.md @@ -36,15 +36,18 @@ order: 10 Report [ZABAPGIT_TEST_SSL](./other-test-ssl.html) can be used to verify that the connection works. -Also see blogs -* http://scn.sap.com/people/jens.gleichmann/blog/2008/10/31/calling-webservices-from-abap-via-httpsssl-with-pfx-certificates -* http://scn.sap.com/people/thomas.jung/blog/2004/11/17/bsp-a-developers-journal-part-xiv--consuming-webservices-with-abap +Also see the following blog posts on SCN: +* [Calling WebServices from ABAP via HTTPS/SSL with pfx certificates](http://scn.sap.com/people/jens.gleichmann/blog/2008/10/31/calling-webservices-from-abap-via-httpsssl-with-pfx-certificates) +* [BSP a Developer’s Journal Part XIV – Consuming WebServices with ABAP](http://scn.sap.com/people/thomas.jung/blog/2004/11/17/bsp-a-developers-journal-part-xiv--consuming-webservices-with-abap) The certificate list should end up looking something like this: ![](img/strust.png) +### Note on actions that require authentication +To perform operations that require authentication, like e.g. cloning a private or pushing to any GitHub repository, you need to install not only the certificates for github.com but also for [https://**api**.github.com](https://api.github.com). Repeat the download and STRUST import steps as described in the sections above accordingly. (See also [Issue#1491](https://github.com/larshp/abapGit/issues/1491)) + ### Note about GitHub -On [Feburary 22nd](https://githubengineering.com/crypto-removal-notice/), GitHub deprectated weak TSL connections. +On [2018-02-22](https://githubengineering.com/crypto-removal-notice/), GitHub deprectated weak TLS connections. See [SAP note 510007](https://launchpad.support.sap.com/#/notes/510007), section 7, for information on how to configure SSL.