Commit Graph

117 Commits

Author SHA1 Message Date
Lars Hvam
015800b45b
Less DDIC references (#3905)
* remove uses of CHAR30

* Update abaplint.json

* add basic unit test for ZCL_ABAPGIT_MESSAGE_HELPER

* replace uses of char50

* fix name

* Update abaplint.json

* use sy-uname instead of uname

in ZCL_ABAPGIT_USER_MASTER_RECORD
2020-09-21 07:39:22 +02:00
Alexander Tsybulsky
9574dca828
html event abstraction, phase 2 (action utils usage unification) (#3902)
* action utils improvements

* page unifications

* linter
2020-09-19 11:02:01 +02:00
Marc Bernard
475f67d1d8
Remove trailing spaces in HTML output (#3893)
* Remove trailing spaces from html

* Return string size
2020-09-17 17:07:46 +02:00
Lars Hvam
1668a95b53
remove NO_HANDLER pseudo comments when handlers exist (#3846)
* remove NO_HANDLER pseudo comments when handlers exist

* Update zcl_abapgit_url.clas.testclasses.abap
2020-09-06 09:07:23 +02:00
Lars Hvam
9c41a2b7d8
remove text pragmas and pseudo comments (#3827)
* remove text pragmas and pseudo comments

* fix whitespace

* fix carriage return

* test

* test

* Update zcl_abapgit_repo.clas.abap
2020-09-03 09:13:47 +02:00
Marc Bernard
e70875879b
Restart abapGit in case of self-update (#3804)
* Restart abapGit in case of self-update

Closes #3358

* Fix abapgit url detection

Old logic incorrectly matched for example https://github.com/abapGit-tests/CHAR

* Github only

* Separate method

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-03 09:07:57 +02:00
Lars Hvam
a16f6f3d17
Cleanup, remove unused TYPEs (#3824) 2020-09-01 16:29:53 +02:00
Alexander Tsybulsky
a4e6c87985
Switching to PRs (#3695)
* string map: public entries (read only)

* port http agent

* draft wip

* drafting

* fix SSL

* port ajson

* integrate ajson and http_agent

* agent global headers

* github enumerator

* update ajson

* draft wip

* enumerator factory

* http_agent via factory

* proxy

* repo->switch_origin draft

* refactor enum factory

* Revert "refactor enum factory"

This reverts commit bcfef40b38991adfe5f73677919db6bd0c652f7c.

* page wiring draft

* scripts draft

* "let it work!"

* repo setings page draft

* linter

* linter

* linter

* linter

* linter

* better settings page

* finetune page

* cleanups

* change hotkey

* fix ajson_error

* Update src/zcl_abapgit_repo_online.clas.abap

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* abaplint nesting 6

* remove description

* back to good old popups

* linter

* move commands to branches dropdown

* auth helpers

* move json to separate package

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-27 07:47:27 +02:00
Lars Hvam
978389a070
conversion, add singletons (#3792)
add singletons for string conversions in ZCL_ABAPGIT_CONVERT, in order to try improving performance

closes #3612
2020-08-25 07:36:57 +02:00
Lars Hvam
a3faae9831
SICF serialization performance (#3762)
* SICF serialization performance

closes #3751

* bugfix
2020-08-19 06:46:32 +02:00
Alexander Tsybulsky
c6b4cb1a70
String map improvements (#3696)
* string map freeze and UT

* linter

* linter

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-01 14:52:59 +02:00
Michael Käsemann
72ccc986c7
Faulty handling of post data (#3624)
* Fixed faulty translation of post data to parsable string

- Added method TRANSLATE_POSTDATA to ZCL_ABAPGIT_UTILS as a centralized place to translate post data to a string
- Replaced all post data string concatenations with the translation helper method to correctly parse spaces that fall to the end of a table line (this should solve #3073 as well as any other random crash caused by accidental misalignment of the post data)

* Backport ABAP statement to 7.02

* Code cleanup for linter checks

* Code cleanup for linter checks

* Fixed a possible error in parsing

If it_postdata contains an empty last line, the staging fails, because the string may contain a lot of soaces at the end of the previous to last line.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-16 15:51:36 +02:00
Shai
15f55276e1
Fix issue 3597 (#2 try) (#3601)
* Fix issue 3597 (#2 try)

When abapGit is being executed on SAP GUI for HTML, all the links don't work (don't do anything because SAPEVENT isn't being passed back to the application server).

* Fix build errors of previous commit

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-11 08:28:41 +02:00
Alexander Tsybulsky
f5dfd328f5
Dialogs: add online repo HTML form (#3533)
* first draft

* progress ...

* html->create()

* more progress

* and more

* getting closer

* wiring

* refactor popup_search_help

* refactor create_package to services

* fix services->new_online after rebase

* linter fixes

* more linter fixes

* straing map util

* error handling

* submits for side actions (ugly ... but ...)

* cleanups

* linter fixes

* refactor form values logic

* linter fix

* review fixes

* remove unused var after rebase

* review fixes, better side action layout

* linter fix

* minor css tweaks
2020-07-01 08:16:52 +02:00
Marc Bernard
01dce88475
Interface and implementing class in same package (#3528)
* Interface and implementing class in same package

* Interface and implementing class in same package

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-06-21 10:23:43 +02:00
Jaime Rodriguez Capote
a0087d3490
Changelog news (#3479)
* APACK definition

* Rework News

Use APACK version for news and remove restriction for repository to set available for all with APACK

* Remove APACK for abapGit

* TODO mark for version constant use

* Move is_abapgit_repo to zcl_abapgit_url

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-06-19 08:47:21 +02:00
Marc Bernard
38099501b8
Improved validation of URLs (#3486)
* Limit URLs to http and https

* Validate URLs

* Raise error only for validation (not for get_name)

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-06-14 20:14:39 +02:00
Lars Hvam
9720b4cd6d
replace ddic MANDT with SY-MANDT (#3492) 2020-06-13 09:29:42 +02:00
Lars Hvam
9af61c99c6
fully type sydatum and syuzeit (#3457) 2020-06-07 09:01:08 +02:00
Lars Hvam
d36b43defe
line break parameters (#3444)
* line break parameters

* Update zcl_abapgit_gui_page_repo_sett.clas.abap

* Update zcl_abapgit_gui_page_repo_sett.clas.abap

* fix
2020-06-04 15:10:35 +02:00
mariusraht2
c2fc8f00fe
Issue 3294: ZCL_ABAPGIT_TIME: Unit Test fails on AS ABAP 752, SP04 (#3295)
* Create pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Update zcl_abapgit_git_transport.clas.abap

* Update pull.yml

* Update pull.yml

* Updated testclass for util_time

* abaplint, get_utc

* Delete pull.yml

* Made time tests method more simple

Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-04-15 14:15:03 +02:00
Jaime Rodriguez Capote
fce71de4d1
Use constants for Y/N/P (#3291)
* Use constants

* Pretty Printer
2020-04-05 10:55:24 +02:00
Jaime Rodriguez Capote
27ac61e95d
Apack dependencies (#3285)
* Support APACK dependencies

Check installed apack package dependencies for current repository
Display a popup with dependencies

* abaplint checks

* abaplint checks

* abaplint checks

* Popup only when dependency not met

* abaplint checks

* abaplint checks

* Optimization

* abaplint checks

* abaplint checks

* Fix typo "dependeNcies"

* Remove address from dependency check

* Dependencies popup title

* Dependencies popup enhanced

* EXCEPTION column replacing MET
* Enable Git URL hiperlink

* APACK doc - Version dependency support

* Dependencies version check support

* abaplint checks

* abaplint checks

* Version utils

* fix syntax warning

* move set_dot_apack to protected

Co-authored-by: larshp <larshp@hotmail.com>
2020-04-05 08:57:59 +02:00
Christian Günter
1e4560b32a
Patch: new refresh functions (#3271)
* Patch: Refresh object first working version

* Patch: add refresh local and refresh repo + refact

* add missing stuff

* fix lint

* refactoring and cleanup

* add missing stuff

* refactor

* refactor

* refactor

* add title for menu bar

* Save and restore scroll position

* refactoring and cleanup

* refactor

* cleanup

* cleanup

* cleanup

* remove new hotkey

* disable object refresh for non-object files

* remove restore scrollposition

* cleanup

* refactor

* cleanup

* save scroll position

* Fix: refresh of deleted objects

* Fix dump: refresh new objects

* add hotkey support for refresh all local objects

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-03-26 12:30:22 +01:00
Jaime Rodriguez Capote
543114963f
abapOpenCheck - Naming Conventions revision #3239 (#3240)
* abapOpenChecks config file

* Ignore SCI config folder

* checks revision

* Revert "checks revision"

This reverts commit 56a12289df.

* Renaming non-constants

Pending:

* Remove SCI configuration

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-03-09 17:34:26 +01:00
Christian Günter
109c8c3be4
Patch: Remember patched lines when cancel Commit (#3212)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-02-19 13:55:19 +01:00
Christian Günter
5067e403b7
Patch: add beacon at beginning of objects (#3210)
* Patch: add beacon at beginning of objects

* extract constant + fix unit test
2020-02-19 12:48:26 +01:00
Mauricio Lauffer
a9a505faf4
Prefer RETURNING to EXPORTING (#3204)
* refactor: Prefer RETURNING to EXPORTING

* refactor: Prefer RETURNING to EXPORTING
2020-02-11 10:20:45 +01:00
Lars Hvam
eb7e819b25 refactoring, delete unused variables and methods (#3203)
* zlib

* xml

* processor

* shi5

* remove unused filter parameter

* pinf cleanup

* ssfo delete empty method

* highlighter

* gui page res, remove unused

* remove unused in diff class

* adt link

* gui, remove 2 unused parameters

* branch overview
2020-02-09 09:38:17 +01:00
Jens Schwarz
9285dd29b3
Fix for issue #1044 (#3167)
* Fix for issue #1044

* Change of local variable names

* fix of bad indentation

* Update src/objects/zcl_abapgit_objects_files.clas.abap

Co-Authored-By: Lars Hvam <larshp@hotmail.com>

* Update zcl_abapgit_objects_files.clas.abap

* Also always add BOM in abapgit.xml file

* Update zcl_abapgit_dot_abapgit.clas.abap

* Update zcl_abapgit_objects_files.clas.abap

* Update zcl_abapgit_convert.clas.abap

* Update zcl_abapgit_convert.clas.abap

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-02-01 07:43:08 +01:00
g-back
985d569f30
DIFF: Remove macros (#3188)
* remove macros

* change 740 syntax, move method call outside loop

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-02-01 07:38:05 +01:00
Lars Hvam
3e0b0505b1
remove commented code (#3166)
* update abaplint.json

* remove commented code

* remove 2 unused variables
2020-01-24 14:31:04 +01:00
Christian Guenter
bae1e21c5b Refactoring: Delete unused variables 2020-01-13 18:41:52 +01:00
Lars Hvam
b42f3bc485
Refactoring (#3134)
* fully type constants

* moving to single line

* move to single line

* enable keep_single_parameter_on_one_line
2019-12-28 12:11:32 +01:00
Frederik Hudák
c846801d19 Add adt link to objects on diff page (#3095)
* Add adt link to object name on diff page

* Fix abaplint, improve error handling

* abaplint

* Remove superflous method
2019-12-05 08:59:15 +01:00
mariusraht2
02204d07b4 Improved time conversion (#3096)
* Create pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Update zcl_abapgit_git_transport.clas.abap

* Update pull.yml

* Delete pull.yml

* Improved time conversion

Preparation for #3040

> rename time%3D>get to time%3D>get_unix
> added time conversion from unix to real (get_real)
> added unit tests for time conversion

* abapLint

* Raise cx_static_check and removed exc handling
2019-12-02 09:28:41 +01:00
mariusraht2
064e006c88 Issue 3042: Error author regex (#3070)
* Create pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Update zcl_abapgit_git_transport.clas.abap

* Update pull.yml

* Delete pull.yml

* Tags: Error author regex

> Regex couldn't match with string "pull[bot] <39814207+pull[bot]@users.noreply.github.com> 1573216988 +0000" because "[]" weren't allowed

* abapLint

* Added unit test for author_regex

#3042

* Any character in author name and Unit Tests

#3042
#3069

* Unit Tests and utils method for author regex

#3042
#3069

> Unit Tests for author_regex (zif_abapgit_definitions)
> New utils method for regex check as utils method in zcl_abapgit_utils
> Regex for author expects now at least one character for the author name ('^(.+)'...)
> Use zif_abapgit_definitions%3D>ty_commit_tt  instead of local type of the same type in class zcl_abapgit_branch_overview

* Changed utils method/tests and moved unit tests

#3042 - Error author regex
#3069 - Add unit tests

> Renamed is_author to extract_author_data and moved related source code from branch_overview to utils class
> Changed related unit tests to handle exception or not
> Moved unit tests to local class of zcl_abapgit_utils

* abapLint

* abapLint

* abapLint

* abapLint

* exclude 7bit test for testclass
2019-11-21 06:40:25 +01:00
mariusraht2
89dfeb69f8 Issue 3060: Check repo URLs before creating a new online repo (#3063)
* Create pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Update zcl_abapgit_git_transport.clas.abap

* Update pull.yml

* Delete pull.yml

* Check repo URLs before creating a new online repo

Fixes #3060

* Check repo URLs before creating a new online repo

Use method zcl_abapgit_url%3D>name and replace the assert with an exception
2019-11-17 10:31:27 +01:00
Alexander Tsybulsky
f0bb81f04a #3022 patch commit state 2019-11-03 07:57:28 +01:00
Italo N
f4c8d13a2c Bug - PROG name contain '%3D' (#2980)
Issue #2923
2019-10-27 11:19:32 +01:00
Fabian Lupa
d72028a1e8 Progress indicator minimum percentage (#2855)
Fixes #2762
2019-08-07 21:25:57 -07:00
Christian Günter
99a6716f32 Log viewer: Add more exception information + actions (#2832) 2019-08-03 04:29:32 -07:00
Lars Hvam
d42bb98662
fixes #2808 (#2818)
fixes #2808
2019-07-31 00:41:01 -07:00
Lars Hvam
f6e8332754
Cleanup (#2753)
* refactor IF

* fix some indentation

* indentation fixes

* indentation fixes

* indentation

* indentation
2019-06-25 03:02:51 -07:00
Martin Fuchs
4aab0166ac Pass log to deserialization API and show log (#2729)
* Pass log interface for de-serialization

Interface ZIF_ABAPGIT_LOG is now passed for deseriaization API.
This includes:
- Log messages for FUGR: Imported function modules and includes
- Improved error messages for TABL compare
- Log objects w/o changes
- Log is shown in the UI if available ("Log" entry appears if a log exists, no persistence!)
This PR enhances #2534 and #2694

Another important change: In case an object fails (or a single function module in a group fails), the import continues with the next object!

* small pretty printer changes

small pretty printer changes

* fix abaplint issues

reduce line sizes and ensure 7.02 compatibility

* show errors and warnings from pull

Errors and warnings after a pull are now part of the "message list" above the object list in the main screen and will be shown immediately. The new"Log" button shows errors, warnings and success messages on demand.
The log title is now part of the ZIF_ABAPGIT_LOG interface.

* fix abaplint issue

fix abaplint issue
2019-06-21 23:05:10 -07:00
Fabian Lupa
3f01361d13 Check other dev clients in user master record (#2710)
* Fallback check other clients in user master record

* Replace SELECT...ENDSELECT with SELECT SINGLE
2019-06-11 08:57:28 -07:00
Martin Fuchs
42a3e7dfbb
fix_log_get_status (#2715)
Fix error in status calculation for ZCL_ABAPGIT_LOG for whole log and message table.
This PR belongs to #2694.
2019-05-29 09:10:06 +02:00
Martin Fuchs
2e781b316a ZIF_ABAPGIT_LOG: extend and move UI methods to new class (#2694)
* log: move show functions to new class

Enhance ZIF_ABAPGIT_LOG
- add IS_ITEM structure (object) to message adding functions
- add method "add_exception"
- add method "add_info"
- relocate methods "show", "to_html" and "write" to new class ZCL_ABAPGIT_LOG_VIEWER
Introduction of new log viewer class ZCL_ABAPGIT_LOG_VIEWER
Replacement of relocated methods where used
-> This is the next step providing a log for serialzation/de-serialization (see #2534)

* fix abaplint issues

fix abaplint issues

* fix abaplint issues (2)

fix abaplint issues
2019-05-26 03:16:03 -07:00
Alexander Tsybulsky
2fdff035be unify convert utils, part1 2019-04-24 07:59:06 -07:00
Lars Hvam
7bbaf069e2
File format update collection (#2605)
* File format update - changed object handler

I removed the following fields:

CLAS
VSEOCLASS-VERSION

INTF
VSEOINTERF-VERSION

PROG
PROGDIR-STATE

DCLS
AS4LOCAL
ABAP_LANGUAGE_VERSION (if exists)

DDLS
ABAP_LANGUAGE_VERSION (if exists)

DDLX
VERSION
RESPONSIBLE
MASTER_SYSTEM

MSAG
DOKIL-DOKSTATE

ENQU
DD25V-AS4LOCAL
DD25V-AS4VERS

* fix syntax error

* also clear PROG VARCL

* update XML files
2019-03-31 01:17:46 -07:00