Commit Graph

26 Commits

Author SHA1 Message Date
Lars Hvam
eb7e819b25 refactoring, delete unused variables and methods (#3203)
* zlib

* xml

* processor

* shi5

* remove unused filter parameter

* pinf cleanup

* ssfo delete empty method

* highlighter

* gui page res, remove unused

* remove unused in diff class

* adt link

* gui, remove 2 unused parameters

* branch overview
2020-02-09 09:38:17 +01:00
Lars Hvam
847a8d9444
branch_overview: refactor DEFINE to private method (#3168) 2020-01-25 09:38:13 +01:00
mariusraht2
064e006c88 Issue 3042: Error author regex (#3070)
* Create pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Update zcl_abapgit_git_transport.clas.abap

* Update pull.yml

* Delete pull.yml

* Tags: Error author regex

> Regex couldn't match with string "pull[bot] <39814207+pull[bot]@users.noreply.github.com> 1573216988 +0000" because "[]" weren't allowed

* abapLint

* Added unit test for author_regex

#3042

* Any character in author name and Unit Tests

#3042
#3069

* Unit Tests and utils method for author regex

#3042
#3069

> Unit Tests for author_regex (zif_abapgit_definitions)
> New utils method for regex check as utils method in zcl_abapgit_utils
> Regex for author expects now at least one character for the author name ('^(.+)'...)
> Use zif_abapgit_definitions%3D>ty_commit_tt  instead of local type of the same type in class zcl_abapgit_branch_overview

* Changed utils method/tests and moved unit tests

#3042 - Error author regex
#3069 - Add unit tests

> Renamed is_author to extract_author_data and moved related source code from branch_overview to utils class
> Changed related unit tests to handle exception or not
> Moved unit tests to local class of zcl_abapgit_utils

* abapLint

* abapLint

* abapLint

* abapLint

* exclude 7bit test for testclass
2019-11-21 06:40:25 +01:00
Sdfraga
de8618af32 Fixing Page Branch Overview Hierarchy (#2594)
* Divide determine_branch for simplicity

* Separate Branches and Commits

* Sort branches by Commit Time

* Fixing abaplint errors
2019-03-28 23:10:23 -07:00
larshp
9b9417b094 remove empty lines in statements #2474 2019-03-03 02:43:03 -08:00
Christian Guenter
8cc6567d40 rename zcl_abapgit_tag to zcl_abapgit_git_tag 2019-02-26 21:29:41 -08:00
Lars Hvam
9d4436822e
Cleanup (#2408)
* delete method CHECK_PROG_CHANGED_SINCE

not in use anymore

* delete method ADD_XML_FROM_PLUGIN

looks like it is not used anywhere, also not in plugins

* naming conventions
2019-02-17 01:28:58 -08:00
Lars Hvam
e8b6b0020d
Add interface for ZCL_ABAPGIT_PROGRESS #2303 (#2316)
* interface for progress class

* adjust branch overview

* adjust git pack

* adjust diff page

* adjust objects class

* adjust activation class

* adjust repo online class

* adjust serialize class

few methods moved

* adjust tadir class
2019-01-23 06:28:54 +01:00
Lars Hvam
3f494f091f
Use built-in types (#2306)
* remove uses of DTEL BOOLEAN

* remove uses of DTEL BOOLE_D

* remove uses of DTEL FLAG

* remove uses of DTEL SAP_BOOL

* remove uses of DTEL XFELD

* Update zcl_abapgit_popups.clas.abap
2019-01-20 07:59:24 +01:00
Christian Günter
d6c063090d Branch overview: show commit details when hover #1821 (#2190)
* Branch overview: show commit details when hover

* update external libraries to gitgraph 1.14.0

* refactor function names

* refactor js + add comments
2018-12-09 07:51:21 +01:00
Sdfraga
af2ac36253 Removed Branch Overview Singleton - issue#2047 (#2048)
* Removed Branch Overview Singleton - issue#2047

* Implement Multiton for Branch Overview

* Removing zabapgit_test_ssl

* Fixes #2047

ZCL_ABAPGIT_FACTORY%3D>GET_BRANCH_OVERVIEW now updates BRANCH_OBERVIEW state if the instance it's already created

* Remove Singleton Logic for Branch Overview

* Remove Setup method
2018-11-15 10:47:29 +01:00
larshp
9270a58b62 cleanup unreference variables 2018-11-09 11:55:47 +01:00
Lars Hvam
06616580eb
Naming conventions (#2059)
* fix naming conventions

* naming conventions
2018-11-07 12:50:20 +01:00
larshp
788a7fedb9 naming conventions #2053 2018-11-07 09:00:12 +01:00
Domi Bigl
529bfc478e add handling of deleted branches in branchoverview (#1928)
* add handling of deleted branches in branchoverview

also display deleted branches in branch overview but w/o a branch name

* PP #1823
2018-09-21 09:12:38 +02:00
Christian Guenter
69c6854e8e Fix ifinite loop in ZCL_ABAPGIT_BRANCH_OVERVIEW 2018-09-10 18:38:57 +02:00
Domi Bigl
9b2e68d06f fix RETURNING with EXPORT/CHANGING <740 SP2 2018-09-10 16:10:20 +02:00
Domi Bigl
93c518a142 Branch OV - Sort by parents instead of time + PP #577 (#1890)
* Branch OV - Sort by parents instead of time #577

* Branch OV - Sort by parents PP #577
2018-09-08 08:30:42 +02:00
Johannes Konings
d25bfaf725 fix some naming conventions
https://github.com/larshp/abapGit/issues/1132
2018-08-17 09:24:22 +02:00
larshp
004db9ebc0 fix syntax warnings 2018-08-07 07:30:57 +02:00
Johannes Konings
09791d0685 Unit test ZCL_ABAPGIT_BRANCH_OVERVIEW for author regex (#1767)
* changed assert to exception

* unit test for author regex added

* Umlauts removed
2018-08-06 12:54:43 +02:00
Lars Hvam
95a8a42c25
Parse commit message in branch overview, fix for PGP signature #1387 (#1698)
* pretty print, trigger reordering of methods

* skip PGP signature

* change PARSE_COMMITS to static

change PARSE_COMMITS to static and add unit tests class

* add simple unit test and fix CI findings
2018-07-27 13:16:34 +02:00
Johannes Konings
cdf2f5f448 ABAP Unit for ZCL_ABAPGIT_BRANCH_OVERVIEW #1647 (#1654)
branch overview:
* preparation ABAP Unit
* change to key

#1647
2018-07-20 09:29:41 +02:00
Christian Guenter
6afa45c5ed fix checkout annotated tags 2018-06-07 21:05:11 +02:00
Christian Guenter
2c80628de3 implement annotated tags 2018-05-26 22:16:43 +02:00
Lars Hvam
68d0571516
More classes to global (#1209)
* lcl_background to global

* lcl_branch_overview to global

* lcl_services_git to global

* lcl_services_repo and lcl_services_db to global

* lcl_services_abapgit to global

* lcl_gui_chunk_lib to global

* lcl_gui_view_tutorial to global

* lif_auth to global

* lcl_auth and lcl_gui_view_repo to global

* lcl_view_repo

* lcl_gui_page_syntax to global

* 2 pages to global

* refactor router, less dynamic references

* background pages to global

* branch overview to global

* settings page to global

* repo settings page to global

* explore page to global

* diff page to global

* debug info to global

* main page to global

* refactor router, no dynamic references

* db pages to global

* router to global

* gui to global

* clean up includes

* move type definnition to interface

to avoid syntax error after abapmerge

* move types to interface

* move types to interface

* rename tyep

* move type

* move types

* move type
2018-02-17 12:40:54 +01:00