Commit Graph

104 Commits

Author SHA1 Message Date
Marc Bernard
7ce457dc8d
Fix user settings containing invalid repo key (#3569)
* Update zcl_abapgit_persistence_user.clas.abap

* Fix dump when last repo is invalid

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-01 15:24:33 +02:00
Lars Hvam
d36b43defe
line break parameters (#3444)
* line break parameters

* Update zcl_abapgit_gui_page_repo_sett.clas.abap

* Update zcl_abapgit_gui_page_repo_sett.clas.abap

* fix
2020-06-04 15:10:35 +02:00
Lars Hvam
ea03cc5e4a
Fewer DDIC type references (#3434)
* Fewer DDIC type references

* Update abaplint.json
2020-05-29 06:30:24 +02:00
Lars Hvam
5a21bbba7d
remove self interface references (#3412) 2020-05-24 15:28:25 +02:00
Jaime Rodriguez Capote
543114963f
abapOpenCheck - Naming Conventions revision #3239 (#3240)
* abapOpenChecks config file

* Ignore SCI config folder

* checks revision

* Revert "checks revision"

This reverts commit 56a12289df.

* Renaming non-constants

Pending:

* Remove SCI configuration

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-03-09 17:34:26 +01:00
Lars Hvam
e201bf566f
remove class prefixes if its current class (#3137)
* remove class prefixes if its current class

* Update abaplint.json
2020-01-06 13:20:19 +01:00
Lars Hvam
714fe7202d
whitespace fixes (#2964)
* whitespace fixes

* fix sql compare operators
2019-10-11 02:50:16 -07:00
Alexander Tsybulsky
f2f82278e7 Serialize master lang only + settings UI improvements (#2954)
* repo settings ui improvements

* serialize_master_lang_only UI

* downport

* connect settings and serialization (MSAG)

* dtel doma tran prog fugr

* linter fixes
2019-10-07 23:03:57 -07:00
Christian Günter
3905c67edd Order by on repo page (#2933)
* Order by on repo page

* move render_cols_pec to zcl_abapgit_gui_chunk_lib

* cleanup

* cleanup

* first new working version

* fix lint

* add OrderByHelper

* add new feature clear

* rename ICON to CLEAR

* cleanup

* refactor actions

* fix typo in method name

* remove duplication

* rename render_col_spec to render_order_by_table_he

* refactor type

* fix eslint warning

* isoltate repo_tab CSS

* fix non-code and metadata files at the top

* refactor

* cleanup

* new features "diffs first" + remove clear

* refactor

* take directories into account

* cleanup
2019-10-05 22:54:04 -07:00
ThomasPloski
a5ebe60642 Refactoring of ZCL_ABAPGIT_ENVIRONMENT (#2826)
* Refactoring of ZCL_ABAPGIT_ENVIRONMENT #2810

* fixes saplint issues

* fixes saplint isues

* fixes saplint issues

* fixes issue based on review

* align zcl_abapgit_objects.clas.abap to master

* add the test class again
2019-08-01 02:49:59 -07:00
Lars Hvam
9fade89856
change constructors to public (#2677)
* enable abaplint constructor check

* change constructor to public

* change constructor to public

* change constructors to public
2019-05-16 23:20:10 -07:00
Srinivasu Reddy
d1c5e332d4 Added client check to add the ability to run abapGit in production/QA environments (#2668)
* Added client check 

Check if repository objects are modifiable in client. If not make write_protected setting active for all repos and make this setting disabled in repo setting page.

* fix abaplint errors

fix for abaplint errors

* code changes as suggested in review

1) Remove zcl_abapgit_client_check class
2) Add is_repo_object_changes_allowed method to zcl_abapgit_environment class

* Delete zcl_abapgit_client_check class

Delete zcl_abapgit_client_check class
2019-05-15 11:32:56 -07:00
Lars Hvam
7bbaf069e2
File format update collection (#2605)
* File format update - changed object handler

I removed the following fields:

CLAS
VSEOCLASS-VERSION

INTF
VSEOINTERF-VERSION

PROG
PROGDIR-STATE

DCLS
AS4LOCAL
ABAP_LANGUAGE_VERSION (if exists)

DDLS
ABAP_LANGUAGE_VERSION (if exists)

DDLX
VERSION
RESPONSIBLE
MASTER_SYSTEM

MSAG
DOKIL-DOKSTATE

ENQU
DD25V-AS4LOCAL
DD25V-AS4VERS

* fix syntax error

* also clear PROG VARCL

* update XML files
2019-03-31 01:17:46 -07:00
Lars Hvam
f9318305e9
Minor fixes (#2532)
* minor fixes regarding unused variables

* minor code inspector fixes
2019-03-15 05:54:39 -07:00
Lars Hvam
fc167ff3cd
update abaplint config to latest (#2480)
* update abaplint config to latest

* remove some descriptions

* remove more descriptions

* fixes

* fixes
2019-03-04 07:12:42 -08:00
Christian Guenter
f73e18d587 Online repo "display name" to overrule default name 2019-02-25 07:20:01 -08:00
Lars Hvam
cb4479b95b
Cleanup (#2361)
* pretty print

* move identical code outside IF

* remove space before .

* remove unreferenced variables

* remove unreferenced variables

* remove unreferenced variables

* fix pseudo comment

* remove unreferenced field symbols
2019-02-04 23:08:29 -08:00
Lars Hvam
3f494f091f
Use built-in types (#2306)
* remove uses of DTEL BOOLEAN

* remove uses of DTEL BOOLE_D

* remove uses of DTEL FLAG

* remove uses of DTEL SAP_BOOL

* remove uses of DTEL XFELD

* Update zcl_abapgit_popups.clas.abap
2019-01-20 07:59:24 +01:00
Eduardo Ferrari Copat
d47027ad6c Remove redundant class and interface metadata (#2195)
* Remove CLSFINAL from VSEOCLASS serialization

* Remove EXPOSURE from VSEOCLASS serialization

* Remove clsabstrct from VSEOCLASS serialization

* Remove EXPOSURE from VSEOINTERF serialization

* Revert "Remove EXPOSURE from VSEOINTERF serialization"

This reverts commit 4036b7d015.
2018-12-12 14:31:42 +01:00
sbcgua
e809df8384 repo->set refactoring, disconnect repo from persistence (#2164)
* 1st attempt (events)

* temp stash

* split persistence and repo, beta

* fix

* fix2

* fix3

* linter fixes

* review fixes
2018-12-02 09:10:55 +01:00
larshp
aae099b93d naming conventions 2018-11-11 17:45:12 +01:00
larshp
788a7fedb9 naming conventions #2053 2018-11-07 09:00:12 +01:00
Frederik Hudák
1bb195b344 Removed the rest of endmethod/endclass comments 2018-10-18 07:27:27 +02:00
Lars Hvam
fa39fcd43f
Code inspector fixes (#1997)
* pretty print

* definitions to top of routine

* space before .

* omit parameter names where possible

* double space after if

* remove pseudo comments where possible
2018-10-12 07:56:27 +02:00
Marcello Urbani
40fd90b14d Release locks/abapGit on pure BASIS system Issue #1826 (#1850)
* abapGit on pure BASIS system #1826

* fixed spacing

* Added fallback to old FM

* fixed spacing
2018-08-21 10:36:26 +02:00
Johannes Konings
d25bfaf725 fix some naming conventions
https://github.com/larshp/abapGit/issues/1132
2018-08-17 09:24:22 +02:00
larshp
6044d3e7b2 move PERSIST_USER behind interface
move PERSIST_USER behind interface

will be moved to instantiate via factory in follow up PR
2018-08-13 18:34:28 +02:00
larshp
273947240c interface and factory for persist_repo 2018-08-10 07:02:30 +02:00
Christian Günter
ff4d126856 Vimium like link hint navigation #1706 (#1729)
* Vimium like link hint navigation

After this commit is applied, the link hint navigation can be used.
The feature can be activated and configured in the user settings.
Role model is the link hint navigation in the Google Chrome plugin
Vimium.

* refactoring: introduce KeyNavigation prototype

* refactoring: introduce LinkHints prototype
2018-08-04 07:36:28 +02:00
Frederik Hudák
34a65ba8e4 Removed unnecessary default comments from testclasses 2018-08-03 13:32:57 +02:00
larshp
58fa197ed5 Move settings type to background interface 2018-07-29 14:01:45 +02:00
Lars Hvam
43da0f819c
Background mode refactoring (#1707)
* move background logic to new package

* background refactored

* background, gui page refactored

* find implementations

and fix code inspector findings

* pretty print interface
2018-07-29 10:08:42 +02:00
Christian Guenter
335759f741 Store user and time for last deserialize
With this commit after every deserialize operation the user, date and time
are stored in repo xml. The information is shown in repo overview.
2018-07-25 06:50:18 +02:00
Christian Günter
7ac8dc15b6 Remove local SHA1 from online repository #1485, #1509 (#1666)
* Remove local SHA1 from online repository

In this commit we remove the local SHA1 and all its references from
ZCL_ABAPGIT_REPO_ONLINE. SHA1 is also removed from repo persistency.
SHA1 insn't needed anymore. All where-used places were either migrated to
remote_SHA1 or removed.

* reintroduce logic after push
2018-07-22 10:11:09 +02:00
Christian Guenter
1c59b131b7 add created_by and created_at to repo xml 2018-07-01 15:53:56 +00:00
christianguenter2
ea798193d0 Block commit/push if code inspection has errors
- new local setting to set check variant
- new local setting to block pull if code inspector check fails
- check is executed before staging
- new page to display code inspector results
2018-06-28 13:21:29 +02:00
Christian Guenter
e167464f1d add commit to toggle_favorites 2018-06-19 11:24:00 +00:00
ThomasPloski
3587ff8d39
Delivery class of database table zabapgit changed
Delivery class L offers a table design w/o client field information
2018-05-30 08:11:33 +02:00
larshp
4f48a54681 error parsing xml, #1344 2018-05-07 12:31:13 +02:00
Christian Guenter
e1551c3941 move type defintiion to zif_abapgit_definitions 2018-05-05 12:35:04 +00:00
Christian G#nter
3bacb05837 Fix no global settings to migrate 2018-05-04 10:05:42 +02:00
Christian Günter
6bbbf65c47 User specific abapGit settings 2018-04-23 21:28:09 +02:00
Lars Hvam
7a9bec815a
Seperate UI and logic (#1286)
* no activation popup in background

* purge: seperate ui and logic

* order by primary key
2018-03-30 12:28:00 +02:00
Lars Hvam
936e500f0e
cleanup persistency package (#1270)
* ZCL_ABAPGIT_PERSIST_MIGRATE cleanup old migration

* delete ZCL_ABAPGIT_SERVICES_DB

by refactoring use to GUI pages

* pretty settings in db overview page
2018-03-26 13:54:05 +02:00
Lars Hvam
f17985b27e
Add option for "Only local objects", issue 1260 (#1268)
* refactor write protect and ignore subpackages

to local settings structure, this makes it a lot easier to exetend, plus adds structure

* delete method GET_MASTER_LANGUAGE

* add local settings to repo settings page

* add setting for only local objects #1260
2018-03-26 12:23:01 +02:00
Oliver Rogers
41aabcf50b Add new setting for Automatic Background with user
Add new setting for Automatic background push with user details from SU01 to distinguish from existing logic.
2018-02-21 22:18:52 +00:00
Lars Hvam
59c1f277ab
more renaming #1132 (#1212)
* more renaming #1132

* fix indentation
2018-02-18 10:04:26 +01:00
Lars Hvam
803148fa0f
fix some naming conventions #1132 (#1211) 2018-02-17 13:55:12 +01:00
Lars Hvam
85d364d460
move some unit tests to global classes (#1210) 2018-02-17 12:53:06 +01:00
Lars Hvam
68d0571516
More classes to global (#1209)
* lcl_background to global

* lcl_branch_overview to global

* lcl_services_git to global

* lcl_services_repo and lcl_services_db to global

* lcl_services_abapgit to global

* lcl_gui_chunk_lib to global

* lcl_gui_view_tutorial to global

* lif_auth to global

* lcl_auth and lcl_gui_view_repo to global

* lcl_view_repo

* lcl_gui_page_syntax to global

* 2 pages to global

* refactor router, less dynamic references

* background pages to global

* branch overview to global

* settings page to global

* repo settings page to global

* explore page to global

* diff page to global

* debug info to global

* main page to global

* refactor router, no dynamic references

* db pages to global

* router to global

* gui to global

* clean up includes

* move type definnition to interface

to avoid syntax error after abapmerge

* move types to interface

* move types to interface

* rename tyep

* move type

* move types

* move type
2018-02-17 12:40:54 +01:00
larshp
ad20031902 trying to fix build, #1134 2018-01-13 11:18:28 +00:00
Lars Hvam
97b5a3d143
code inspector fixes (#1131)
* code inspector fixes

* more
2018-01-13 10:49:47 +01:00
Lars Hvam
436a03936a
Persistence to global (#1130)
* refactor persistence get_instance

* more persistence to global

* more

* more

* fix indentation
2018-01-13 09:56:50 +01:00
larshp
996bed2603 lcl_persistence_db to global 2018-01-12 12:14:50 +00:00