Commit Graph

2 Commits

Author SHA1 Message Date
Martin Fuchs
1d58d5a0ed Allow access to private repos when using ADT (#2635)
* Allow access to private repos when using ADT

In case of using a private repository in ADT (aka ABAP in Eclipse), username and password are passed to the backend system. The ADT backend coding currently handles this via class ZCL_ABAPGIT_DEFAULT_AUTH_INFO. To avoid sending a password dialog in the backend system, class CL_ABAPGIT_PASSWORD_DIALOG needs to be adjusted to take over user/pw from ZCL_ABAPGIT_DEFAULT_AUTH_INFO in a generic way. I know this is not nice and it would be better to have ZCL_ABAPGIT_DEFAULT_AUTH_INFO in ZABAPGIT. Even the best solution would be to re-use ZCL_ABAPGIT_LOGIN_MANAGER instead, but I would recommend to refactor this in a new pull request later on...

* Add comment

Add comment for temporary solution and link to PR#2635
2019-04-19 00:20:54 -07:00
larshp
1d591b545e lcl_password_dialog to global 2018-02-11 12:07:16 +00:00