Commit Graph

387 Commits

Author SHA1 Message Date
Frederik Hudák
0a67f95c11
Replace assert in gui_page_stage with check (#3392)
* Update zcl_abapgit_gui_page_stage.clas.abap

* Change to exception

* add reference to issue as comment in code

* Update zcl_abapgit_gui_page_stage.clas.abap

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-23 11:42:41 +02:00
Marc Bernard
6d2deece76
Add missing TH closing tag (#3393) 2020-05-23 06:32:34 +02:00
Maxim Engel
f20e13d3ab
Fix for missing-field-popup (#3391)
Fix for missing-field-popup during cloning online repos, due to missing description.

Closes #3390
2020-05-22 17:43:23 +02:00
Frederik Hudák
5d34284805
Highlight hovered line (#3347)
* Highlight hovered line

* Better hover color

* Remove hover border in diffs

* Change bacgkround color

* Fix unrelated syntax errors in css
2020-05-22 10:10:41 +02:00
Marc Bernard
aa204c1e8f
Map blank "last changed by" to "unknown" (#3387)
* Map blank "last changed by" to "unknown" 

Fix blank entry in filter dropdown

* Whitespace
2020-05-22 10:02:33 +02:00
larshp
2d168e170b move stage structures to interface #3377 2020-05-21 07:25:54 +02:00
Frederik Hudák
2886c00592 Fix syntax error in gui_router
Somehow lost this change from #3378. The class no longer exists.
2020-05-21 06:58:26 +02:00
Frederik Hudák
be260435f5
Move explore link (#3378)
* Move explore link

* Update zcl_abapgit_services_abapgit.clas.abap

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-20 19:47:42 +02:00
Frederik Hudák
3335317278
Remove page playground (#3375)
* Remove page playground

* Remove constant
2020-05-20 18:28:03 +02:00
Alexander Tsybulsky
8eae18c0f5
Gui refactoring part 4 (#3362)
* refactoring and remove get_events from gui_page

* cleanups

* more cleanups

* register_deferred_script

* refactor page_stage

* refactor page_diff

* refactor page_commit

* refactor page_debuginfo

* linter fixes

* refactor page_tag

* refactor rage_repo_over

* refactor page_patch

* make gui_page->scripts private
2020-05-20 17:50:00 +02:00
Marc Bernard
aa71ed52ae
Set filter for file open and save dialogs / Add new setting for default commit comment (#3371)
* Set filter for file open and save dialogs

Set the file filter dropdown and default to *.ZIP in file open and save dialogs

* Add new setting for default commit comment

New abapGit setting to define a default for the comment used for commits. Object and/or filename can added to the comment automatically, which works similar to GitHub if a single file is changed. If multiple objects are changed, then object/file count is included in the default for the comment.

* Update CLAS ZCL_ABAPGIT_GUI_PAGE_COMMIT

* Fix text for $object

Fixed case when one object with multiple files was changed

* Pretty print

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-20 12:37:58 +02:00
Marc Bernard
840d818b2d
Minor improvement for debug info (#3372)
- Full SAP GUI patch
- APACK version
2020-05-19 17:46:07 +02:00
Frederik Hudák
202e2d0239
Unify different wordings of 'Diff' (#3367)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-19 07:30:51 +02:00
Alexander Tsybulsky
310d8673dd
Gui refactoring, chapter 3 (#3355)
* zcl_abapgit_html_parts primitive

* integrate parts in GUI

* bughunting and renames

* scripts collection, move hotkeys js to parts

* linter fixes

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-13 12:58:43 +02:00
Marc Bernard
40a1ef3a13
Allow setting of display name for offline repos (#3359)
Minor improvement to enable "Display Name" setting for offline projects which is shown in favorites for example
2020-05-13 12:42:23 +02:00
Alexander Tsybulsky
c056076170
Gui refactoring 2 (#3338)
* hotkeys refactoring: draft logic

- new interfaces
- gui services binding
- move render to zcl_hotkeys
- move global hotkeys to hotkeys class
- remove unnecessary stuff from gui_page

* implement zif_abapgit_gui_hotkeys in rel.pages

* settings page draft

* remove zif_abapgit_gui_page_hotkey

* linter fixes

* finalize rendering logic

* finalize settings

* linter fix

* sorting tweak

* fix abapgit_full work

Co-authored-by: Christian Günter <christianguenter@googlemail.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>
2020-05-08 10:26:54 +02:00
mariusraht2
b91043a270
Refactor Popup (#3310)
* Create pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Update zcl_abapgit_git_transport.clas.abap

* Update pull.yml

* Update pull.yml

* Delete pull.yml

* Refactored popup logic

Related to #3040

Refactoring of popup logic/calling to be able to reuse it as commit list.

* Removed reset flag

Removed reset flag cause it doesn't belong to this PR (will be readded later)

Co-authored-by: pull[bot] <39814207+pull[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-04 08:36:24 +02:00
Christian Günter
48454c5922
fix page diff dump: use repo instead of repo_online (#3304)
* fix page diff dump: use repo instead of repo_onlin

* make repo online an attribute
2020-04-14 18:57:21 +02:00
Christian Günter
c9241e7cff
Fix zcl_abapgit_gui_component definition (#3299)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-04-09 09:39:35 +02:00
Christian Günter
decc2d4863
Page Patch: fix unit test (#3293) 2020-04-08 15:58:22 +02:00
Alexander Tsybulsky
0eb22a0c87
Gui refactor, part 1 (#3289)
* gui component and event registering

* remove iv_prev_page from event_handler if

* constructors raising zcx_abapgit_exception

* get_gui_services - UT friendly

* linter fixes

* more linter fixes

* zif_gui_services stub all methods

* linter fix

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-04-07 10:30:43 +02:00
Jaime Rodriguez Capote
fce71de4d1
Use constants for Y/N/P (#3291)
* Use constants

* Pretty Printer
2020-04-05 10:55:24 +02:00
Jaime Rodriguez Capote
27ac61e95d
Apack dependencies (#3285)
* Support APACK dependencies

Check installed apack package dependencies for current repository
Display a popup with dependencies

* abaplint checks

* abaplint checks

* abaplint checks

* Popup only when dependency not met

* abaplint checks

* abaplint checks

* Optimization

* abaplint checks

* abaplint checks

* Fix typo "dependeNcies"

* Remove address from dependency check

* Dependencies popup title

* Dependencies popup enhanced

* EXCEPTION column replacing MET
* Enable Git URL hiperlink

* APACK doc - Version dependency support

* Dependencies version check support

* abaplint checks

* abaplint checks

* Version utils

* fix syntax warning

* move set_dot_apack to protected

Co-authored-by: larshp <larshp@hotmail.com>
2020-04-05 08:57:59 +02:00
Christian Günter
803ca23176
Refactor page diff: Introduce subclass for patch (#3283)
* Introduce zcl_abapgit_gui_page_patch as subclass of zcl_abapgit_gui_page_diff

introduce pop-method on GUI stack

fix linter + raising exception when gui stack emp

introduce zcl_abapgit_gui_page_patch

more

add

fix linter

remove go back to patch after commit

fix linter

remove bookmark for stage page

remove pop

src/ui/core/zcl_abapgit_gui.clas.abap

 src/zcl_abapgit_repo_online.clas.abap

* refactor: move more logic to  render_line_split_ro

* refactor move logic to render_diff_head_after_stat

* add logic to render_table_head_non_unified

* extract render_table_head_unified

* extract of is_patch_possible calculation

* fix linter

* move hotkey to patch

* refactor and rename to get_normalized_fname_with_p

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-03-31 17:14:13 +02:00
Christian Günter
1e4560b32a
Patch: new refresh functions (#3271)
* Patch: Refresh object first working version

* Patch: add refresh local and refresh repo + refact

* add missing stuff

* fix lint

* refactoring and cleanup

* add missing stuff

* refactor

* refactor

* refactor

* add title for menu bar

* Save and restore scroll position

* refactoring and cleanup

* refactor

* cleanup

* cleanup

* cleanup

* remove new hotkey

* disable object refresh for non-object files

* remove restore scrollposition

* cleanup

* refactor

* cleanup

* save scroll position

* Fix: refresh of deleted objects

* Fix dump: refresh new objects

* add hotkey support for refresh all local objects

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-03-26 12:30:22 +01:00
Frederik Hudák
63640bb3fc
Minor ux improvements (#3253)
* Resize stage list to full width

* Move patch button to the top menu

* Center stage list, increase line width in repo, stage

* Repo page - Increase line height for path column

* Stage list to full size

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-03-21 09:56:53 +01:00
Eduardo Ferrari Copat
e74d40516c
Diff - Add option to collapse files (#3248)
* Update zcl_abapgit_gui_page_diff.clas.abap

* Update zcl_abapgit_gui_page_diff.clas.abap

* Update zabapgit_css_common.w3mi.data.css

* Update zabapgit_css_common.w3mi.data.css

* test

* Update zabapgit_css_theme_default.w3mi.data.css

* Add collapse to css

* Add user select

* onDiffCollapse

* show source

* src

* Tries text

* hide/show

* uses nodisplay instead of hidden

* good hide

* ===

* Add button

* lint

* lint

* set function as global

* lint

* Exclude gui page diff

* remove extra space

* chevron

* pointer

* class

* Icons

* lint

* lint

* hide

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-03-12 17:09:00 +01:00
g-back
79a1a667c6
Switch branch protected (#3250)
* add write-protect check for switch branch

* disable link for disabled toolbar functions

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-03-11 12:54:24 +01:00
larshp
e638e6065a ZCL_ABAPGIT_GUI_PAGE_DIFF propagate exception 2020-03-10 08:17:12 +01:00
Jaime Rodriguez Capote
543114963f
abapOpenCheck - Naming Conventions revision #3239 (#3240)
* abapOpenChecks config file

* Ignore SCI config folder

* checks revision

* Revert "checks revision"

This reverts commit 56a12289df.

* Renaming non-constants

Pending:

* Remove SCI configuration

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-03-09 17:34:26 +01:00
larshp
8fcf072917 remove call to super->constructor
there is no super class
2020-03-09 17:19:34 +01:00
larshp
b4b3414009 non existing package: fix dump #3224 2020-03-03 10:10:35 +01:00
Daniel Wegner
eb10fae8ef
Proxy bypass (#3221)
* add proxy bypass option in settings

* add proxy bypass popup and persist settings

* add proxy bypass to proxy config class

* Fix Proxy Bypass Button HTML

* Fix indentation

* Implement Method popup_proxy_bypass

* Fix behaviour in case of empty range tab

* Fix behaviour in case of empty range tab 2
2020-03-02 15:30:23 +01:00
Christian Günter
cec926e954
Diff: Only add beacon at beginning while patching (#3218) 2020-02-20 16:43:02 +01:00
Christian Günter
a8d474fab4
Patch: add path to jump target (#3216)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-02-20 09:39:56 +01:00
Christian Günter
1668e670cf
Fix patch: multiple files with same name (#3213)
- unify id generation
- generate unique filenames

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-02-19 14:24:04 +01:00
Christian Günter
109c8c3be4
Patch: Remember patched lines when cancel Commit (#3212)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-02-19 13:55:19 +01:00
Christian Günter
5067e403b7
Patch: add beacon at beginning of objects (#3210)
* Patch: add beacon at beginning of objects

* extract constant + fix unit test
2020-02-19 12:48:26 +01:00
Mauricio Lauffer
a9a505faf4
Prefer RETURNING to EXPORTING (#3204)
* refactor: Prefer RETURNING to EXPORTING

* refactor: Prefer RETURNING to EXPORTING
2020-02-11 10:20:45 +01:00
Lars Hvam
eb7e819b25 refactoring, delete unused variables and methods (#3203)
* zlib

* xml

* processor

* shi5

* remove unused filter parameter

* pinf cleanup

* ssfo delete empty method

* highlighter

* gui page res, remove unused

* remove unused in diff class

* adt link

* gui, remove 2 unused parameters

* branch overview
2020-02-09 09:38:17 +01:00
Jaime Rodriguez Capote
701f83ec2d
Travis-CI Error (#3201)
./src/ui/zcl_abapgit_gui_page_merge.clas.abap[187, 18] - Keep single parameter on one line (keep_single_parameter_on_one_line)

https://travis-ci.org/jrodriguez-rc/abapGit/builds/647280505?utm_medium=notification%26utm_source=github_status
2020-02-07 12:34:59 +01:00
Alexander Tsybulsky
0dba9e5af3
remove DEFINE from zcl_abapgit_gui_view_repo (#3186)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-01-30 08:10:53 +01:00
Alexander Tsybulsky
0c3cdf639e
remove DEFINED from zcl_abapgit_gui_page_repo_over (#3185)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-01-30 08:03:19 +01:00
Alexander Tsybulsky
dc96e3b3ef
remove DEFINE from zcl_abapgit_ui_factory (#3184)
* remove DEFINE from zcl_abapgit_ui_factory

* linter fixes

* better approach

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-01-30 07:57:53 +01:00
larshp
d8047ccad6 use built-in type 2020-01-25 17:47:33 +01:00
Lars Hvam
9872f28d1d
GUI_PAGE_MERGE: refactor DEFINE (#3173)
* GUI_PAGE_MERGE: refactor DEFINE

* fix
2020-01-25 09:48:26 +01:00
Lars Hvam
3e0b0505b1
remove commented code (#3166)
* update abaplint.json

* remove commented code

* remove 2 unused variables
2020-01-24 14:31:04 +01:00
Fabian Lupa
c4f4c713b6 Handle spaces in stage filter (#3153)
* Handle spaces in stage filter

#3073

* Fix JS lint issue

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-01-14 17:01:56 +01:00
Christian Guenter
bae1e21c5b Refactoring: Delete unused variables 2020-01-13 18:41:52 +01:00
Lars Hvam
75812fb17b
less prefixes (#3144) 2020-01-11 09:24:36 +01:00