Commit Graph

36 Commits

Author SHA1 Message Date
Marc Bernard
0ab3ee0a06
Remove aliases from object classes (#5588) 2022-06-04 10:33:42 +02:00
Marc Bernard
375092c370
DEVC: Clean-up OTR entries (#5507)
Uninstalling objects like `ENHC` just removes their references to OTR entries (`sotr_use/u` tables). Therefore, when the package is uninstalled, the remaining OTR entries will be completely removed.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-01 12:18:08 +02:00
Marc Bernard
e6378ac17f
DEVC: Fix DYNPRO_SEND_IN_BACKGROUND (#5461)
When deserializing SAP packages that do not exist in background, AG will dump with `DYNPRO_SEND_IN_BACKGROUND`. This is caused by a popup asking for the transport.

Fixed by passing the transport to the save method.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-04-08 11:33:18 +02:00
Marc Bernard
00e1505613
DEVC: Raise error for main/structure packages (#5444)
* DEVC: Raise error for main/structure packages

Main or structure package and cannot be used in local packages (`$...`). 

abapGit will now raise an error, if one tries to pull main or structure packages into a local package.

* Split into two messages

* Locally

* Local

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-04-06 09:17:09 +02:00
Marc Bernard
3fa3323b2e
Refactor: Jump to Object Logic (#5158)
* Refactor: Jump to Object Logic

Continue #5114

- Removes jump_adt and jump_se11 from zcl_abapgit_objects_super
- Remove almost all object-specific jump handlers (zif_abapgit_object~jump) since they are covered by GUI Jumper now

* Remove ZCL_ABAPGIT_OBJECT_SICF

* Remove obsolete RS_TOOL_ACCESS

* FUGR

* IATU

* PDXX

* SRVD

* XINX

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Christian Günter <christianguenter@googlemail.com>
2021-11-29 15:52:13 -05:00
Lars Hvam
4301d3e8c8
no chained assignment (#5140)
* no chained assignment

* bugfix
2021-11-19 16:19:27 +01:00
Marc Bernard
5f4eb56071
DEVC: Application component for local packages (#4790)
For local packages, the application component is now stored in AG persistence. This will avoid the diff, if transportable packages are pulled into local packages.

Closes #1880
2021-05-28 05:45:17 +02:00
Marc Bernard
da43c34fc4
DEVC: Unlock in case of errors (#4561)
* DEVC: Unlock in case of errors

If a package object cannot be deleted or deserialized properly, it remains locked.

The change unlocks the object in these cases.

* Update set_lock

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-02-28 17:16:33 +01:00
Marc Bernard
db61b57b80
DEVC: Avoid syntax check warning (#4559)
* DEVC: Avoid syntax check warning 

Add pragma

* Lint

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-02-24 05:53:34 +01:00
Marc Bernard
dd813ed807
DEVC: Fix check if package is empty (#4466)
* DEVC: Fix check if package is empty

SOTR object is linked to SAP package and removed together with the package on uninstall. Therefore, it should not be taken into account when checking if a package is empty.

* Update comment

Co-authored-by: Lars Hvam <larshp@hotmail.com>

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-02-02 21:01:48 +01:00
Marc Bernard
8ff0445673
DEVC: Avoid dump when creating new package (#4419)
Usually, in abapGit packages are created by the folder logic already. But it dumps with "`li_package` is not assigned," if deserialize is used in other ways.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-01-18 09:19:31 +01:00
Sercan K.D
55ee890080
Fix missing i_suppress_dialog parameter syntax error in 731 system (#4328)
* Fix missing i_suppress_dialog parameter syntax error in 731 system

* replace cx_root with cx_sy_dyn_call_param_not_found

* revert back to cx_root because checks have failed

"Statement does not exist in ABAPv702(or a parser error)"

* Revert "revert back to cx_root because checks have failed"

This reverts commit 73b9b2aa6f.

* replace cx_root with cx_sy_dyn_call_param_not_found, sorry i didn't see that extra quote character, should be fine now.

* fix whitespace

Co-authored-by: larshp <larshp@hotmail.com>
2020-12-15 08:00:29 +01:00
Marc Bernard
3d26041779
DEVC: Remove obsolete TADIR entries during uninstall (#4150)
* DEVC: Remove obsolete TADIR entries 

In case a package is local (ie no transports), abapGit will now check if objects still exist in the package. In case an object does not exist anymore, the corresponding TADIR entry will be removed. This allows empty local packages to be uninstalled automatically.

* Lint

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-12 08:55:18 +01:00
Marc Bernard
bdc44f7476
Remove self-references (#4115)
* Remove self-references

Remove unnecessary self-references (me->)

https://github.com/SAP/styleguides/blob/master/clean-abap/CleanABAP.md#omit-the-self-reference-me-when-calling-an-instance-method

* 702: Fix syntax error

No chaining with EXPORTING & CHANGING

* remove addiontal me, update abaplint config

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-02 09:25:27 +01:00
Frederik Hudák
d04b1b057c
DEVC - Clear obsolete fields (#4054)
* DEVC - Clear obsolete fields

* Remove on deserialize side
2020-10-22 19:04:41 +02:00
Lars Hvam
d36b43defe
line break parameters (#3444)
* line break parameters

* Update zcl_abapgit_gui_page_repo_sett.clas.abap

* Update zcl_abapgit_gui_page_repo_sett.clas.abap

* fix
2020-06-04 15:10:35 +02:00
Lars Hvam
3e0b0505b1
remove commented code (#3166)
* update abaplint.json

* remove commented code

* remove 2 unused variables
2020-01-24 14:31:04 +01:00
Lars Hvam
714fe7202d
whitespace fixes (#2964)
* whitespace fixes

* fix sql compare operators
2019-10-11 02:50:16 -07:00
Martin Fuchs
9f2db446b1 simplified GET_DESERIALIZE_STEPS
Since all object handler contains exactly the same CASE statement for STEP definition, I would recommend that each object handler simply returns the STEP he belongs to.
This fix should "simply" issue #2499.
2019-05-05 00:57:52 -07:00
GoWa
21527528c6 call redefined method of IF 2019-03-12 21:49:15 -07:00
larshp
25f6284493 implement GET_DESERIALIZE_STEPS
this is a quick fix, field LATE_DESER will be removed in future
2019-03-12 07:37:56 -07:00
Lars Hvam
3213d0c2dd
Deserialization performance, refactor COMPARE_TO_REMOTE_VERSION (#2438)
* core part refactored #2436

* indentation

* fix implementations

* delete ZCL_ABAPGIT_COMPARISON_NULL

* pretty print

* Update serializers.md

* downport
2019-02-20 22:20:24 -08:00
Lars Hvam
25d4c9ea07
Remove HAS_CHANGED_SINCE #1021 (#2401)
* core part removed

* remove method implementations
2019-02-15 06:51:57 -08:00
Lars Hvam
610c48d51f
Remove commented code (#2285)
* delete commented code

* delete commented code

* commented code
2019-01-13 10:28:18 +01:00
Domi Bigl
b7e5a56080 DEVC: get package from devclass or object name 2018-11-10 08:22:39 +01:00
Domi Bigl
cf05295170 mark inactive objects in repo list #1943 (#2017)
* mark inactive objects in repo list

Inactive object are marked in the repo list
The sort order for changed files is not changed
unchanged inactive files come right after the changed files

* move acitve check to object interface

* add is_active for objects up to F

* add is_active for objects up to P

* add is_active for objects up to T

* add is_active for objects up to X

all core object implement (except SSFO) the standard active check via FM RS_INACTIVE_OBJECTS_WARNING now

* add is_active to plugins bridge - always active

* finish object interface implementation + objects

* add is_active for offline with object interface

* rename returning to RV_

* use returning for serialize

* cleanup, PP, UT
2018-10-31 15:54:57 +01:00
Christian Guenter
840fe06262 downport 702 2018-08-06 19:59:49 +02:00
Lars Hvam
4fa485bf96
Remove superfluous spaces (#1712)
* remove spaces

* remove spaces

* remove spaces

* remove double space
2018-07-29 10:08:54 +02:00
Christian Guenter
ad5ae2a185 delete empty packages 2018-07-05 23:19:32 +02:00
christianguenter2
6521d09470 Block pull if any of deserialized object is locked 2018-06-18 14:18:58 +02:00
Christian Guenter
0792fd8b64 downport DEVC 2018-05-08 08:29:36 +00:00
larshp
98c86a2447 minor changes
remove unused variables and method
2018-03-22 14:09:19 +01:00
Lars Hvam
7b002c66da
transport layer invalid #1020 (#1248) 2018-03-17 08:19:41 +01:00
Fabian Lupa
889106b68b Improve error messages (#1213)
* Add T100 support to ZCX_ABAPGIT_EXCEPTION

* Use T100 error messages in DEVC

* Replace zcx_abapgit_exception->text with get_text

* Use SE24 generated constructor in T100 exception
2018-03-10 13:27:09 +01:00
Lars Hvam
803148fa0f
fix some naming conventions #1132 (#1211) 2018-02-17 13:55:12 +01:00
Lars Hvam
f14ac831ba
Objects to global (#1187)
* add global classes for objects

* fix metadata

* comment old code

fix serializer class
move missing interfaces

* keep objects and bridge as local

* fix syntax errors

and remove SICF -> tadir dependency, instead tadir -> SICF

* remove dependency TABL -> lcl_popups

* fix indentation

* remove old includes

* fix parser errors

* fix deserializing
2018-02-11 09:16:16 +01:00