Commit Graph

118 Commits

Author SHA1 Message Date
Francisco Milán
105a202f8c
Fix typos within the code base (#6858) 2024-03-16 10:24:16 +01:00
Christian Günter
8881860e2f
Create package popup: Fix prefill package name (#6752)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2024-01-16 06:48:38 +01:00
Christian Günter
fbd9e70fa5
Add unit tests for ZCL_ABAPGIT_GUI_PAGE_SETT_REMO->VALIDATE_FORM (#6712)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2023-12-20 14:50:06 -05:00
Lars Hvam
9419a10e87
put zcl_abapgit_default_transport behind interface (#6673) 2023-11-30 07:48:55 +01:00
Lars Hvam
e9d8c1d985
packages: remove scompkdtln from public scope (#6656) 2023-11-24 07:02:53 +01:00
Lars Hvam
b3af744289
popups cleanup (#6629) 2023-11-07 16:30:13 -05:00
Lars Hvam
22f76e264d
refactor popup_to_select_transports (#6624) 2023-11-06 11:33:14 -05:00
Christian Günter
7bdd8f9f4c
Extract calls to FM FUNCTION_EXISTS (#6588) 2023-10-27 13:16:53 +02:00
Marc Bernard
2645e2208b
Fine-tune popups to confirm uninstall (#6504)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2023-09-21 17:32:22 +02:00
Lars Hvam
7011e87d8c
move more git definitions (#6369) 2023-07-27 06:09:37 +02:00
Lars Hvam
1d8af69ae3
move more git definitions (#6365) 2023-07-23 15:33:52 +02:00
Lars Hvam
8d839aee23
cleanup, delete unused popup choose_pr_popup() (#6349)
Co-authored-by: Christian Günter <christianguenter@googlemail.com>
2023-07-17 10:13:32 +02:00
Marc Bernard
cf528c5413
TABU: Several enhancements (#6191) 2023-04-06 10:13:27 +02:00
Marc Bernard
c43b8ccda4
Improve visualization of tags (#6098) 2023-02-27 08:45:35 +01:00
Alexander Tsybulsky
c0a5fadfee
Refactor popup_to_select_from_list (#6089)
Co-authored-by: Christian Günter <christianguenter@googlemail.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2023-02-26 13:02:31 +01:00
Lars Hvam
9ffec8c306
Refactor: SELECT e07t to CTS INTF (#6082) 2023-02-24 15:22:38 +01:00
Marc Bernard
db7e5ac19f
Prevent dump if too many requests are selected (#6064) 2023-02-10 18:51:06 +01:00
Lars Hvam
a7c20da7a2
move ALV type defintion to intf popups (#6034)
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2023-02-03 16:37:47 +01:00
Lars Hvam
773f2f7749
refactor, extract git definitions to git (#6029)
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
2023-02-03 11:46:00 +01:00
Lars Hvam
7382459a23
rename and move time class (#6024) 2023-02-02 09:28:13 +01:00
Marc Bernard
0f87b87003
Enhancement for Object Selector (#6009)
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2023-01-31 11:50:44 +01:00
Christian Günter
2b5211a778
Local settings: add F4 value help for check varint (#5910) 2022-12-02 11:15:30 -05:00
Christian Günter
c40406930a
add label F4 value help (#5891)
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-11-30 12:29:40 -05:00
Marc Bernard
e1f78f733b
Remove unused branch popup (#5742)
`branch_popup_callback` and `POPUP_GET_VALUES_USER_BUTTONS` are not used anymore and leftovers from previous refactoring.
2022-09-07 09:47:44 -04:00
Christian Günter
2d178b650a
Improve folder logic popup (#5662) 2022-06-27 13:20:35 +02:00
Marc Bernard
ddd7e47425
Refactor: Commit list popup (#5569)
* Refactor: Commit list popup

- Move popup for selecting a commit to `zcl_abapgit_popup`
- Allow to skip sorting of commits in `zcl_abapgit_git_commit` which often led to "too many commits" error (on GitHub you get the 300 most recent commits)

Popup will be used in `zcl_abapgit_gui_page_sett_remo` and `zcl_abapgit_gui_page_tags` (separate PR)

* Fix test classes

* Replace popup in remote settings

* Remove type

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-05-24 16:43:46 +02:00
Marc Bernard
6d2510c84e
Fix tag popup message (#5567)
Tag popup is used for delete and switch therefore the message must be moved to the switch method.
2022-05-18 17:54:15 +02:00
Marc Bernard
0fea49b74c
Remove "Tag Overview" popup (#5463)
* Remove "Tag Overview" popup

- The "Tag > Overview" feature has been removed (because of bad performance and low value)
- The tag select popup has been refactored. The code has been moved to `zcl/if_abapgit_popups`. Only change is that the popup is now centered like the others.
- Therefore, class `zcl_abapgit_tag_popups` has been removed

* Update injectors

* Remove interface

* Secondary key
2022-04-25 07:28:07 +02:00
Marc Bernard
3742f2b0d6
UI: Transport popup (#5453) 2022-04-22 07:37:15 +02:00
Marc Bernard
ef502d8275
UI: Transport popup (#5452)
Add parameter for new logic
2022-04-06 15:55:48 +02:00
Marc Bernard
daa35ab666
UI: Transport popup (#5438)
If default transport is set and its type matches to what is required, then use it as default for the transport popup.

This will make it easier for example if a pull or uninstall failed and needs to be repeated since you want to continue using the same transport.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-04-05 16:15:08 +02:00
Marc Bernard
254e6d51e3
UI: Center Popups - Part 2 (#5290)
* UI: Center Popups - Part 2

Adjusting more popups #5275

* Refactor for method length

* Lint indent
2022-01-25 18:40:20 +01:00
Frank Müller
c932426b44
Pre Filter Backend and GUI Logic (#5227)
* Initial

* Adjustments

* Router

* Abaplint

* abaplint

* diff between eclipse and vscode

* Multiple Adjustments

* Split Backend And GUI Logic

* Multiple Adjustments

* No Unit Tests

* abaplint

* Rename ZCL_ABAPGIT_REPO_PRE_FILTER to ...TR

* Multiple Adjustments

* Refactor the OVP action links into a toolbar

* abaplint

* Replace BAPI_MSG by STRING

* Rename Pre Filter to Object Filter

* Rename Pre Filter also in abap_transpile.json

* restore from main

* Check if <ls_item>-li_class is filled in Toolbar

* Adj. toolbars and move TR Req to zif_abapgit_popup

* abaplint

* Move  ty_trrngtrkor_tt to zif_abapgit_definitions

* abaplint

* Move and rename filter menu entries

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: IBM <mbox-060-sap-extern-tbom@daimler.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-01-25 10:00:09 +01:00
Marc Bernard
cf9ede7d7c
UI: Center Popups (#5274)
* UI: Center Popups

GUI popups were showing up all over the screen. On bigger screens, they often display outside the abapGit HTML frame.

With this change, most popups will show nicely centered or close to it (some fine tuning might still be required).

Notes: 
- Some popups like the one prompting for a transport request do not allow to influence the screen position. 
- Follow-up: Consolidate "Tag Popups" from `ZCL_ABAPGIT_TAG_POPUPS` to `ZCL_ABAPGIT_POPUPS` and adjust accordingly.

* Lint

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-01-23 08:50:11 +01:00
Lars Hvam
e45bdfc4e4
unit testing updates (#5080)
* wip, unit testing

* refactor popup

* update abaplint

* transpile additional classes

* all data classes

* all git

* update

* fix

* change type

* all gui

* all http

* ZCL_ABAPGIT_USER_RECORD

* all zlib

* all exceptions

* all xml

* all html

* all html zif

* all gui zif

* all xml zif

* all repo zif

* more generic

* star

* zif_abapgit_longtexts

* sort

* zcl_abapgit_news

* zcl_abapgit_adt_link

* ZCL_ABAPGIT_DIFF

* more

* add zcl_abapgit_services_git
2021-11-02 16:50:30 +01:00
Marc Bernard
c2e9e58319
Enhance "Force Pull" to become "Selective Pull" (#4733)
* Enhance "Force Pull" to become "Selective Pull"

With this PR you can now peform a selective pull. Yay!

- Changes "Force Pull" to show *all* changed objects in the usual "Overwrite Popup". This allows you to select individual objects to be pulled no matter if they were changed locally or remotely.
- Does *not* change the regular "Pull" logic

Closes #413, #4282

* Combine delete and overwrite popups

* Add icons to abaplint.json

* Change if to case

* Add icons to abaplint.json

* Enhance UTs

* show_icon

* Show icon

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-05-20 06:19:00 +02:00
Marc Bernard
d47c72f429
Remote Settings: Toolbar icon & clean-up (#4724)
* Remote Settings: Clean-up

Continue #4718

- Branch > Switch to PR: removed
- Advanced > Checkout commit: removed
- Advanced > Make Offline / Online: removed menu items and popups
- Advanced > Change Remote: removed menu item and page

* Remove ty_popups

* Remove checkout_commit

* Remove repo_view switch_to_pr

* Remove get_switched

* Add "Edit" icon also for offline

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-04-27 19:03:06 +02:00
Mike Pokraka
69ac4fd768
Change some masters to main %26 remove unused parameter (#4710)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-04-19 17:15:47 +02:00
g-back
1cbda2f2ae
Refactor "Export Package to ZIP" to HTML Form (#4652)
* refactor export package to zip to HTML form

* change literal to constant

* downport statement

* remove popup package_export

* reorder methods, unify whitespace

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-03-22 13:17:54 +01:00
Lars Hvam
11fd111572
move perf test option to new repo (#4645)
* move perf test option to new repo

Moving the performance test option to separate repository,
https://github.com/abapGit/performance-test

I guess this feature is not used very often, it will reduce the overall code size, and instead of refactoring these popups to HTML they can stay ALVs in the new repo

* fixes
2021-03-17 07:12:59 +01:00
g-back
72f34f5bdf
Refactor "Object to Files" to html form (#4623)
* start conversion from popup to html form

* replace magic with constants

* revert label

* restructure to gui component


modify export object logic

* adjust whitespace

* remove test_changed_by functionality

* remove popup_object

Co-authored-by: Goran Back <g.back@geringhoff.de>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-03-12 12:31:17 +01:00
g-back
71c4849ae5
Minor Fixes (#4627)
* remove exception from signature, remove comment

* change search help, try fieldname first

* enable lang switch when multiple tcodes are assgnd
2021-03-11 14:51:48 +01:00
Lars Hvam
d7f74bd49c
zif_abapgit_poups cleanup (#4608)
* zif_abapgit_poups cleanup

delete method POPUP_TO_INFORM

* delete method POPUP_PROXY_BYPASS
2021-03-07 12:15:26 +01:00
Marc Bernard
73576ee60e
Improve error messages (#4472)
* Improve error messages

Pass T100 messages to UI/log

* T100 errors

* APACK

* OO

* DEVC

* DRUL

* DTDC

* SRVB

* OBJS

* Program

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-02-03 16:31:55 +01:00
Marc Bernard
978b7a4a57
Terminology: Inclusive Language - Part 4 (#4432)
* Terminology: Inclusive Language - Part 4

Continue change of terminology (#4043)

* Service

* Language

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-01-21 17:18:03 +01:00
Lars Hvam
725d92f98e
bugfix, PR popup sorting (#4206) 2020-11-20 08:51:01 +01:00
Marc Bernard
b25a67acea
Terminology: Inclusive Language - Part 2 (#4159)
* Terminology: Inclusive Language - Part 2

Change "Master Language" to "Main Language" in UI and comments (documentation and variables next)

* Docs

* Docs

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-11 10:36:38 +01:00
Lars Hvam
e35df57646
Change TY_SVAL_TT location (#4155) 2020-11-10 14:21:42 +01:00
Marc Bernard
6779e90448
UI: Sort "Switch origin" by PR number (#4127)
- Sort descending by PR number
- Rename menu items

Closes https://github.com/abapGit/abapGit/issues/4031

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-03 08:41:06 +01:00
mariusraht2
9ac7630711
ZABAPGIT_FORMS: Remove obsolete form package_popup and related callback handler (#4029)
* ZABAPGIT_FORMS: Remove obsolete methods

- Remove branch_popup
- Remove package_popup

* Readd branch_popup

* Readd branch_popup

* Remove related callback handler

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-16 09:11:18 +02:00