Commit Graph

4616 Commits

Author SHA1 Message Date
Lars Hvam
4b2309f952
zif_abapgit_html, remove uses of char1 (#4351) 2020-12-24 08:36:58 +01:00
Marc Bernard
a3ce719b0c
Remove unnecessary constructors (#4341)
* Remove unnecessary constructors

A constructor that redefines the super constructor but only calls the super constructor with the same parameters is unnecessary and can be removed

https://github.com/abaplint/abaplint/issues/1417

* Lint

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-12-22 07:05:13 +01:00
Marc Bernard
c74ca9eb4c
TABL: No structure comparison for global temp tables (#4347)
Closes #4081

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-12-22 06:52:58 +01:00
Marc Bernard
73cba7ff1b
Fix sorting of objects in repo view (#4346)
Regression of #4087. Closes #4339

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-12-22 06:47:45 +01:00
Jānis B
6e4982f417
fix creation of TR entries for uninstalled PROGs (#4343)
* fix creation of TR entries for uninstalled PROGs

Fixes creation of CTS Transport Request entries for PROG Objects uninstalled from transportable package.

* Abaplint Fixes

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-12-22 06:44:46 +01:00
Marc Bernard
d289439411
Update docs about parallel processing (#4348)
- No parallel processing in standalone version
- Requires logon group config for developer version
2020-12-22 06:41:50 +01:00
dependabot-preview[bot]
47d8d93b3a
Update eslint requirement from ^7.15.0 to ^7.16.0 (#4344)
Updates the requirements on [eslint](https://github.com/eslint/eslint) to permit the latest version.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md)
- [Commits](https://github.com/eslint/eslint/compare/v7.15.0...v7.16.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-12-21 09:22:10 +01:00
Lars Hvam
e6ef63a489
unit testing test (#4326)
* unit testing test

* update deps

* update deps

* update deps

* update deps

* update deps

* update deps

* upd

* remove empty keyword

* update deps

* update deps

* whitespace

* update deps
2020-12-20 10:42:28 +01:00
jan-jezek
158d1e27b7
Serialise only main language for ENHS and ENHO objects (#4337)
* Add language parameter to sotr

* Added language parameter to accomodate change

* Abaplint fixes

* Abaplint

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Abaplint

* abaplint bot

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* abaplint bot

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Removed iv_language from object

* Method call without parameter name

Co-authored-by: Jan Jezek <jan.jezek@sap.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-12-18 11:11:24 +01:00
Lars Hvam
0003d8b85e
update ajson with writer (#4255)
* update ajson with writer

* update to latest

* fix exceptions

* convert exception
2020-12-18 09:55:57 +01:00
Marc Bernard
4402ed8cab
Add refresh after failed uninstall (#4334)
* Add refresh after failed uninstall

If uninstall does not complete successfully, the old state of the repo will be shown. This will refresh the state and properly show which objects were deleted and which still remain.

* Update src/zcl_abapgit_repo_srv.clas.abap

Co-authored-by: Lars Hvam <larshp@hotmail.com>

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-12-16 15:09:29 +01:00
Marc Bernard
a0736db371
Add description of creating test repo (#4335)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-12-16 08:27:10 +01:00
Marc Bernard
f1bf013adf
Refactor: GUI router state transfer (#4336)
Moving page-dependent state changes to separate methods for clarity
2020-12-16 08:23:00 +01:00
Lars Hvam
643db383b0
syntax: move unit tests (#4333)
syntax highligting, move unit tests for abap to abap class, xml to xml class

this avoids having cyclic references, previously HIGHLIGTER called FACTORY which instantiated ABAP which inherited from HIGHLIGTER
2020-12-15 16:31:20 +01:00
Marc Bernard
01a2363c72
ENHO: Implement missing deserialize for WDYC (#4332)
* ENHO: Implement missing deserialize for WDYC

Related to #3586

* Downport

* Update src/objects/enh/zcl_abapgit_object_enho_wdyc.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-12-15 10:23:02 +01:00
Marc Bernard
8e6fe2c785
Fix: Several repos for same URL (#4330)
Regression from #4313:
Fix "Malformed URL" error if at least one offline repo exists

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-12-15 08:09:35 +01:00
Marc Bernard
744ce9efce
Align naming of object super classes (#4327)
* Align naming of object super classes

- SAXX_SUPER for SAMC %26 SAPC
- W3XX_SUPER for W3HT %26 W3MI

* Delete old classes

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-12-15 08:05:11 +01:00
Sercan K.D
55ee890080
Fix missing i_suppress_dialog parameter syntax error in 731 system (#4328)
* Fix missing i_suppress_dialog parameter syntax error in 731 system

* replace cx_root with cx_sy_dyn_call_param_not_found

* revert back to cx_root because checks have failed

"Statement does not exist in ABAPv702(or a parser error)"

* Revert "revert back to cx_root because checks have failed"

This reverts commit 73b9b2aa6f.

* replace cx_root with cx_sy_dyn_call_param_not_found, sorry i didn't see that extra quote character, should be fine now.

* fix whitespace

Co-authored-by: larshp <larshp@hotmail.com>
2020-12-15 08:00:29 +01:00
Christian Günter
0e4f29efa1
New Repo: Check package existence before showing popup (#4323)
* New Repo: Check package existence before showing p

* fix lint errors

* fix linter

* add more unit tests

* refactor unit tests

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-12-14 14:54:28 +01:00
Marc Bernard
c6f6ddb17e
VIEW: Fix deserialize of maintenance views (#4317)
Maintenance views can have dependencies on tables with foreign keys. Such cases can lead to errors during deserialize since the foreign key relationships between tables are processed only in the "late" step.

This fix moves the processing of maintenance views (viewclass = c) to the "late" step.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-12-14 14:52:50 +01:00
Marc Bernard
cfb813f3cd
Update "Adding Icons" documentation (#4314)
Update after https://github.com/abapGit/icon-font/pull/12

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-12-14 14:43:44 +01:00
Lars Hvam
1643bdabe5
unit testing test (#4298)
* update deps

* update deps

* update deps

* update deps

* update deps

* update deps

* update deps

* update deps

* update deps

* update deps
2020-12-14 09:27:42 +01:00
Marc Bernard
ac1c3baa0d
Fix typo "odd" > "of" (#4316) 2020-12-13 08:29:28 +01:00
Lars Hvam
260af61407
ecatt exceptions, test (#4312) 2020-12-12 08:51:49 +01:00
Jaime Rodriguez Capote
6c87fa3f05
Several repos for same URL (#4313)
* Check URL repo before add

* Unit tests

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-12-12 08:49:38 +01:00
Marc Bernard
d0983cf386
Dialogs: HTML form enhancements (#4264)
* Dialogs: HTML form tweaks

- Minor increase of contrast for background, input- and readonly fields
- Add read-only option for columns of table control

* Add is_empty

* Add init and hidden

* Render

* Remove init

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-12-12 08:45:47 +01:00
Marc Bernard
869c0bccb5
WDYN: Improve error messages (#4310)
Pass exception text to UI/log

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-12-11 07:54:19 +01:00
Marc Bernard
46e2dd827b
Package Structure - Part 4 (#4305)
* Package Structure - Part 4

$ABAPGIT_OBJECTS_CORE:

ZCL_ABAPGIT_DEPENDENCIES
ZCL_ABAPGIT_FILE_STATUS
ZCL_ABAPGIT_FOLDER_LOGIC
ZCL_ABAPGIT_OBJECTS
ZCL_ABAPGIT_OBJECTS_ACTIVATION
ZCL_ABAPGIT_OBJECTS_FILES
ZCL_ABAPGIT_SERIALIZE
ZCL_ABAPGIT_TADIR
ZIF_ABAPGIT_COMPARATOR
ZIF_ABAPGIT_OBJECT
ZIF_ABAPGIT_OBJECTS
ZIF_ABAPGIT_TADIR
ZCL_ABAPGIT_SKIP_OBJECTS

$ABAPGIT_OBJECTS_TEXTS:

ZIF_ABAPGIT_LANG_DEFINITIONS

#4253

* ZIF_ABAPGIT_LANG_DEFINITIONS

* Sync

* Sync

* Sync

* Sync

* Move objects

* Sync

* always upload build artifact

* Move type to interface

* Types

* Add package

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-12-11 07:50:10 +01:00
Lars Hvam
efaa0e65c0
more generic exception catching (#4307) 2020-12-11 07:46:07 +01:00
jan-jezek
c6a54b9912
Fix master language only, duplicate entries for shi3 objects (#4308)
* Fix master language only for shi3 objects

* Fix abaplint

* Fix duplicates in shi3

* Abaplint

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
2020-12-11 07:43:52 +01:00
Marc Bernard
8fcc5c2f95
DSYS: Get changed by (#4303)
Get "changed by" user

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-12-09 09:27:11 +01:00
Marc Bernard
8118ab836d
SMIM: Improve error messages (#4304)
Pass T100 messages to UI/log

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-12-09 08:02:55 +01:00
Marc Bernard
eb1a6fab90
SOTS: Get changed by (#4302)
Get "changed by" user
2020-12-09 05:27:13 +01:00
Marc Bernard
b31885796d
Fix pull errors related to files deleted remotely (#4281)
In case files are deleted remotely, the files are now ignored during a pull. In other words, "pull" will not touch objects that exist only locally and not remotely.

To delete such objects locally, use "reset local (forced pull)" which will show a popup for these objects and let you delete them.

Closes #4277

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-12-08 17:16:04 +01:00
Marc Bernard
3c598bbf60
Improve "Cannot find .abapgit.xml" situation (#4240)
* Improve ""Cannot find .abapgit.xml" situation

Skip check during creating of repo and increase file count.

Closes #4174

* New online

* Add UT

* Move check to content list

* Update zcl_abapgit_repo_srv.clas.abap

* Lint

* Rename to check_repo_size

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-12-08 15:35:31 +01:00
Fabian Lupa
97671a8889
Adjust image URLs in readme (#4301)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-12-08 15:26:10 +01:00
Marc Bernard
74cedd459c
Fix unit test for user records (#4300)
* Fix unit test for user records

Perform unit test only if a user with an email address exists

Closes #4247

* Remove test

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-12-08 15:09:49 +01:00
Marc Bernard
ed2898240e
Update README.md (#4299)
- Added abapGit logo
- Updated sloc count
- Updated remarks about installation issues
2020-12-08 05:06:38 +01:00
dependabot-preview[bot]
83d83d16e5
Update @abaplint/cli requirement from ^2.61.10 to ^2.62.0 (#4296)
Updates the requirements on [@abaplint/cli](https://github.com/abaplint/abaplint) to permit the latest version.
- [Release notes](https://github.com/abaplint/abaplint/releases)
- [Commits](https://github.com/abaplint/abaplint/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-12-07 10:39:24 +01:00
Marc Bernard
0fc7b43a35
PROG: Fix transport and work area (#4242)
* PROG: Remove objects from work area 

Fixes issue with incomplete deletion of inactive objects

Closes #4151

* Lint

* Add correction

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-12-07 09:38:56 +01:00
Lars Hvam
297a579757
github actions: save build artifact (#4295)
* save build artifact

* upd
2020-12-07 09:28:35 +01:00
Marc Bernard
07cdc0e0e8
Resolve circular reference in /syntax/ (#4292)
Closes #4258

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-12-07 09:13:58 +01:00
dependabot-preview[bot]
88372f0430
Update @abaplint/runtime requirement from ^0.8.19 to ^0.8.21 (#4294)
Updates the requirements on [@abaplint/runtime](https://github.com/abaplint/transpiler) to permit the latest version.
- [Release notes](https://github.com/abaplint/transpiler/releases)
- [Commits](https://github.com/abaplint/transpiler/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-12-07 09:09:37 +01:00
dependabot-preview[bot]
d5f2fcfbd7
Update @abaplint/transpiler-cli requirement from ^0.8.19 to ^0.8.21 (#4293)
Updates the requirements on [@abaplint/transpiler-cli](https://github.com/abaplint/transpiler) to permit the latest version.
- [Release notes](https://github.com/abaplint/transpiler/releases)
- [Commits](https://github.com/abaplint/transpiler/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
2020-12-07 09:06:57 +01:00
Lars Hvam
fa97ded1dc
unit testing test (#4256)
* update deps

* add some interfaces

* update deps

* update deps

* add zif_abapgit_auth

* add zif_abapgit_environment

* update deps

* add interfaces

* update deps

* update deps

* update deps

* update deps
2020-12-06 15:26:06 +01:00
Fabian Lupa
ca51d8b0c7
Ensure open in main language opens same abapGit version (#4291)
Fixes #4276

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-12-06 06:36:45 +01:00
Fabian Lupa
2788e5f0f3
Fix adjust_display_commit_url markdown table (#4290)
* Fix adjust_display_commit_url markdown table

Fixes #4289

* Fix table spacing
2020-12-05 17:21:26 +01:00
Marc Bernard
21432e8538
Fix dump when using abapGit for more than 50 navigation steps (#4288)
Reverting back to a proper exit of screens using `LEAVE TO SCREEN` and avoid increasing the size of the callstack. 

Closes #4279 

PS: The crash mentioned in #4027 was prevented by removing the commit hash from the check screen. It works also with `LEAVE TO SCREEN`.
2020-12-05 09:48:21 +01:00
Marc Bernard
5ed2f5bb22
DOMA: Fix serialize for missing translations (#4283)
Closes #4278

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-12-04 09:01:24 +01:00
Marc Bernard
1c8f8038c5
Package Structure - Part 3 (#4286)
$ABAPGIT_OBJECTS_OO:

ZCL_ABAPGIT_OO_BASE
ZCL_ABAPGIT_OO_CLASS
ZCL_ABAPGIT_OO_FACTORY
ZCL_ABAPGIT_OO_INTERFACE
ZCL_ABAPGIT_OO_SERIALIZER
ZIF_ABAPGIT_OO_OBJECT_FNC

#4253

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-12-04 08:51:43 +01:00