Commit Graph

813 Commits

Author SHA1 Message Date
yellappam
1246e2718f
Sort includes (#5352)
In some systems, function modules RS_GET_ALL_INCLUDES returns an include *T00. Where *T00 include is not returned, abapGit adds to the internal table. This results in different sorting order in different systems. Sort to keep the same order.
2022-02-15 06:37:58 +01:00
Marc Bernard
92b583bb18
Improve progress bar and log for pull (#5311)
- Eliminate flashing of progress bar during deserialize
- Updated description for deserialize steps
- Add steps to log (see below)

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-02-14 08:25:27 +01:00
Shyam Balachandran
371b1d4137
Fix for Service Binding issue #5212 (#5344)
Fix for SRVB (Service Binding) is lost in version 1.113.0 #5212

Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-02-11 16:58:28 +01:00
Lars Hvam
09936744e9
SICF, clear ICFALIASNO (#5338) 2022-02-10 11:58:12 +01:00
Albert Mink
9ddad8b559
CHKO et al.: Raise if deleting TADIR fails (#5337)
This behavior will be defined centrally in #5263. But for now, just raise if something with the TADIR fails.
2022-02-08 09:34:11 +01:00
Albert Mink
8c2840e517
fix type for the dynamic calls (#5333)
fixes #5332
2022-02-07 12:05:56 -05:00
Albert Mink
d79a38eec2
Enable AFF to delete TADIR entries (#5326)
* Enable AFF to delete TADIR entries

* AbapLint policy I

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* AbapLine policy II

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* AbapLint policy III

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* AbapLint policy IV

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* AbapLint policy V

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* AbapLint XY

* don't call AFF for trivial tasks

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
2022-02-07 10:12:44 +01:00
Marc Bernard
b5b252744d
Detect JSON files during pull (#5313) 2022-02-02 14:24:38 -05:00
Albert Mink
a18d7542e7
CHKO et al.: Do write TADIR entry (#5320) 2022-02-02 14:12:16 -05:00
Albert Mink
fee5c18761
Deserialize active when calling ABAP file formats (#5319) 2022-02-02 14:08:54 -05:00
Marc Bernard
631132736d
UI: Center Popups - Part (#5315)
Adjusting more popups #5275
2022-02-02 07:35:02 +01:00
Marc Bernard
ec9ff1a29f
TABL: Properly show inactive objects (#5303)
* TABL: Properly show inactive objects

Current `is_active` check is insufficient for DDIC objects and can't detect "new" or "partically active" objects.

Introduces a new `is_active_ddic` method in `zcl_abapgit_objects_super` which should be used by all DDIC types (follow-up). 

Ref #5294

* Update zcl_abapgit_objects.clas.abap

* Update
2022-02-01 16:11:18 +01:00
Marc Bernard
ce31e33688
Refactor: Activation log (#5302)
* Refactor: Activation log

- Merges the activation log into the regular pull log
- Removes duplicate messages

* Update

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-02-01 15:24:35 +01:00
Marc Bernard
a828d80044
DOMA: Fix serialize of translations (#5304)
Closes #5296

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-02-01 14:36:31 +01:00
DerGuteWolf
6da51326b1
WAPA: Fix repeated pull of BSP page (Fiori) (#5310)
* Fix for #5179 Do not mess with mo_files during deserialize

* style fix
2022-02-01 13:38:44 +01:00
Marc Bernard
6efaa0e0b4
Refactor: Remove ddic flag (#5295)
Closes #5264

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-01-30 16:37:56 +01:00
Marc Bernard
927587880f
Remove UI dependency from test (#5298) 2022-01-30 16:34:20 +01:00
Marc Bernard
fd167aa13b
Avoid double deserialize of text symbols (#5273)
* Avoid double deserialize of text symbols

Text symbols are already deserialized in `ZCL_ABAPGIT_OBJECTS_PROGRAM->DESERIALIZE_TEXTPOOL`.

* remove method

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-01-24 14:16:50 +01:00
Marc Bernard
5e3e5b60e4
Fix status for new sub-packages (#5278) 2022-01-22 08:57:08 +01:00
NicoleG
b7b867c3ac
AIFC additional interface validation checks (#5267) 2022-01-18 10:38:08 +01:00
Albert Mink
c83060f366
CHKO object calling AFF Framework (#5163) 2022-01-18 10:23:10 +01:00
Marc Bernard
1a31eb3f2f
Correct task name parallel processing (#5269)
When serializing objects in parallel threads, it can happen that there are not sufficient system resources available (free dialog processes). In this case, abapGit can run into error "RFC task <task name> already open". This is caused by reusing the same task name in subsequent tries to serialize an object.

The correction appends a sequential number to the previous task name so each try will result in a unique task name.

Closes #5224.

PS: This does not fix any resource issues but should prevent the error. It will lead to wait situations and longer processing, however.
2022-01-14 11:47:47 +01:00
Lars Hvam
d7db1e3079
add unit test xslt_before_prog (#5268)
ref #5262
2022-01-13 09:32:39 +01:00
Marc Bernard
53bd8c3fe5
Don't include XML when serializing AFF (#5254)
* Don't include XML when serializing AFF

Avoids output of metadata XML when serialized object contains JSON (ABAP file format).

Preparation for #5126

PS: Contains new and updated unit tests

* Rename is_json_metadata

* CP

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-01-12 16:54:33 +01:00
Fabian Lupa
be8a0062f8
Use transport parameter in ENHO+SFPF (#5258)
* objects: use provided Transport in deserialization of ENHO+SFPF

I have been working on RFC enabled functions modules for executing
abapGit operations and I found out that transported objects of type ENHO
and SFPF cannot be pulled over my RFC methods because the specified
transport was not used.

This commit simply takes over the approach from other objects where
we already read the transport number.

For SFPF, I had to add "darkmode" which was missing and which is
necessary to avoid any dialogues.

I am not sure if there are other objects with the same problem, so
I might be posting similar patches in future.

* Downport #5199

* Fix indentation

* Always pass transport in SFPF

Co-authored-by: Jakub Filak <jakub.filak@sap.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2022-01-10 10:21:34 +01:00
Marc Bernard
074ae5a69b
Refactor: Calling batch input (#5252)
* Refactor: Calling batch input

Standardizes calling batch input API and handling errors.

* Fix indent

* Add new window

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-01-10 09:27:17 +01:00
Lars Hvam
c3b9980486
replace XUBNAME with SYUNAME (#5248) 2022-01-06 08:18:45 +01:00
Frederik Hudák
faab3bb0b0
TOBJ - fix xslt serialization dump (#5247) 2022-01-04 17:06:54 +01:00
Frank Müller
b67c06dc2d
Pre Filter Backend Logic (#5226)
* Repo, Repo Online, File Status

* Stage Logic

* Adjustments

* abaplint

* abaplint

* abaplint

* diff between eclipse and vscode

* Centralisation and reuse

* Filter at Get Remote Files instead of Set

* Split Backend And GUI Logic

* abaplint

* abaplint

* Filter Unit Tests

* Missing ,

* remove own type for trobj_name

* Multiple Adjustments

* Rename ZCL_ABAPGIT_REPO_PRE_FILTER to ..._TR

* abaplint

* Replace BAPI_MSG by STRING

* Rename Pre Filter to Object Filter

* Rename Pre Filter also in abap_transpile.json

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-01-04 07:35:57 +01:00
Lars Hvam
fd401956b8
Refactoring: Prioritization/sequence of deserialization (#5198) 2022-01-03 10:55:06 +01:00
Marc Bernard
2eaaff7ad9
Adjust usage of transport in object classes (#5218)
After #5216

Replaces `zcl_abapgit_default_transport=>get_instance( )->get( )` logic with `iv_transport` for the following object types:
`AMSD, BDEF, DRUL, DTDC, FDT0, FUGR, INTF, PROG, SQSC, SRVB, SRVD, WDCA`

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2022-01-03 10:50:53 +01:00
Marc Bernard
35f18c57d9
Pass transport to object classes (#5216)
Adds transport number for `zif_abapgit_object~deserialize` and `zif_abapgit_object~delete` to pass the transport number to the object classes.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-12-20 18:47:10 +01:00
Marc Bernard
089e04d7e4
W3xx: Avoid diffs of parameters (#5231)
It's possible that systems return parameters unsorted causing diffs. Sorting the parameters will avoid this.
2021-12-19 14:43:23 -05:00
NicoleG
c23357f22f
AIFC - Enablement of AIFC development object for AIF content in abapgit (#5197) 2021-12-18 14:51:21 +01:00
Lars Hvam
7d5d1cabca
file status, bugfix (#5220)
closes #5219
2021-12-14 11:56:26 -05:00
Fabian Lupa
dc51247e9b
Always use active version for DOCU CL (#5201)
* Always use active version for DOCU CL

* CLAS/INTF delete documentation on pull

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-12-14 06:36:00 +01:00
Marc Bernard
5bcdbce3b8
DDLX/SMTG: Raise exception (#5217)
Change to `raise_with_text`
2021-12-14 03:54:13 +01:00
Marc Bernard
c7e4af3be2
Add user exit for serialize postprocessing (#5194)
There are scenarios where you want to serialize objects differently than abapGit. This exit is called at the end of the serialize process and gives an opportunity to change the content of the serialzed files.

One such scenario would be to automatically pretty-print code. This can be achieved by looping over all `.abap` files and processing them accordingly in this exit.

Closes #5050

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-12-11 07:30:50 +01:00
Lars Hvam
97d8723b6f
prioritize_deser, add unit tests (#5193)
* prioritize_deser, add unit tests

* more tests

* change to string

* update to latest npm packages, and more unit test
2021-12-10 13:46:32 -05:00
manhofmann
a637caf864
performance optimization parallel mode (#5187)
* performance optimization parallel mode

in parallel mode a new session is created for each object to be serialized. method IS_TYPE_SUPPORTED is called in each new session with only one object type. however all objects are loaded via method SUPPORTED_LIST. this change implements a specific cache for method IS_TYPE_SUPPORTED.

* Update src/objects/zcl_abapgit_objects.clas.abap

Co-authored-by: Christian Günter <christianguenter@googlemail.com>

* moved type defintion to PRIVATE SECTION

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Christian Günter <christianguenter@googlemail.com>
2021-12-09 06:58:58 +01:00
Marc Bernard
b46c8b4599
Refactor: Consolidate front-end classes (#5172)
* Refactor: Consolidate front-end classes

There's no need for two "front-end classes". Moves all of ZCL_ABAPGIT_GUI_FUNCTIONS to ZCL_ABAPGIT_FRONTEND_SERVICES. Now all front-end calls are nicely together.

No functional change, some method reordering. 

Ref #2510, #5145

* Add missing interface

Co-authored-by: Christian Günter <christianguenter@googlemail.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-12-09 06:49:43 +01:00
Marc Bernard
9e629475dc
Fix dump ASSERTION_FAILED (#5190)
"Exists check" might be called for objects without `TADIR` entry (like `NSPC`). 

Regression of #4952 which removed the "if"

a72d3314cb (diff-4a3135e0f538157951fefdea06986dc644f6005a2af7f6917ff7f7f2f771f622L299)
2021-12-08 20:50:37 -05:00
Christian Günter
451ab7cadf
WebGUI: Disable jump (#5184)
Co-authored-by: Christian Günter <christian.guenter@emineo.ch>
2021-12-06 16:13:24 -05:00
Marc Bernard
3fa3323b2e
Refactor: Jump to Object Logic (#5158)
* Refactor: Jump to Object Logic

Continue #5114

- Removes jump_adt and jump_se11 from zcl_abapgit_objects_super
- Remove almost all object-specific jump handlers (zif_abapgit_object~jump) since they are covered by GUI Jumper now

* Remove ZCL_ABAPGIT_OBJECT_SICF

* Remove obsolete RS_TOOL_ACCESS

* FUGR

* IATU

* PDXX

* SRVD

* XINX

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Christian Günter <christianguenter@googlemail.com>
2021-11-29 15:52:13 -05:00
Shyam Balachandran
9aa0dd154e
SRVB: Service Binding object changes (#4976)
* Fix issue 3443

Service Binding(SRVB) object changes

* Correcting abap lint findings

* Correcting abaplint findings 2

* Update zcl_abapgit_object_srvb.clas.abap

Changes to serialize and exists methods

* Update zcl_abapgit_object_srvb.clas.abap

Correct serialize and exists method

* Update zcl_abapgit_object_srvb.clas.abap

abapgit lint fixes

* Update zcl_abapgit_object_srvb.clas.abap

- Correcting exists method based on feedback
- Removing incorrect DDIC options for SRVB

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2021-11-26 08:06:50 +01:00
Marc Bernard
4ecbc30a2e
Add DRUL and DTDC to mass activation (#5156)
* Add DRUL and DTDC to mass activation

DDIC mass activation supports Dependency Rules (DRUL) and Dynamic Cache (DTDC) object

* Len

* Update abap_transpile.json
2021-11-22 13:30:19 -05:00
Alexander Tsybulsky
a671bb8dc3
Expand TABL includes before PUT (#5153) 2021-11-22 12:57:38 -05:00
Lars Hvam
4301d3e8c8
no chained assignment (#5140)
* no chained assignment

* bugfix
2021-11-19 16:19:27 +01:00
Frank Müller
6d02555f96
Check that include belongs to the same fugr (#5134)
* Check that include belongs to the same fugr

* abaplint

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-11-15 16:50:44 +01:00
Marc Bernard
53951dc2ad
Remove more unused variables (#5112)
* Remove more unused variables

* rm

* rm

* rm

* rm

* needed for refactor later

* rm

* Needed for callback

* rm

* rm

* Pragma

* rm enho

* rm

* rm

* Setting unused_variables

* Revert unused_variables setting

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-11-09 16:22:29 +01:00