Commit Graph

32 Commits

Author SHA1 Message Date
Christian Günter
13c4d57dd3
Patch: enable new view options similar to Diff (#5162)
* enable new view options on patch page

* add unit test

* new constant for unchanged lines
2021-11-26 07:41:57 +01:00
Marc Bernard
53951dc2ad
Remove more unused variables (#5112)
* Remove more unused variables

* rm

* rm

* rm

* rm

* needed for refactor later

* rm

* Needed for callback

* rm

* rm

* Pragma

* rm enho

* rm

* rm

* Setting unused_variables

* Revert unused_variables setting

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-11-09 16:22:29 +01:00
Marc Bernard
9f689e4e4f
Title case for hotkey descriptions (#5113)
Closes #5089
2021-11-05 17:22:37 +01:00
Christian Günter
64b7de74ee
Page patch: fix for binary files involved (#5067) 2021-10-28 09:04:19 +02:00
Marc Bernard
679f2050b0
Diff and Patch Pages Update (#5056)
* Diff and Patch Pages Update

- Fix refresh of a single file on diff page (it was displaying all diffs afterwards)
- Add some hotkey assignments
- Replace "Refresh" after filename with icon

normal:

hover:

* Local refresh on patch page

* Update zcl_abapgit_gui_page_patch.clas.abap

* Patch page: Add js for refresh all hotkey

Co-authored-by: Christian Günter <christianguenter@googlemail.com>
2021-10-27 07:28:17 +02:00
Marc Bernard
aa60faa299
Commit Page Update (#5048)
* Commit Page Update

Here's the redesigned commit page moving to the HTML forms you know form other dialogs (goes together with #5047 for best look).

New features:
- check of mandatory entries
- validation of email address format
- link to docs (t.b..d.)
- summary of changes on top, list of changed filed on bottom
- placeholder for body

Closes #5029

* rm > remove

* Create guide-stage-commit.md

* Add files via upload

* Update guide-stage-commit.md

* Delete commit_done.png

* Add files via upload

* Update guide-moving-package.md

* Add files via upload

* Add files via upload

* Update zcl_abapgit_gui_page_patch.clas.xml

* Update zcl_abapgit_gui_page_stage.clas.xml

* Update zcl_abapgit_gui_page_merge.clas.xml

* Update zcl_abapgit_gui_page_commit.clas.xml

* Update zcl_abapgit_gui_page_code_insp.clas.xml

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-25 16:12:06 +02:00
Christian Günter
4ce32ba7a6
Diff-page: enable refresh functions (#4992)
* Diff-page: Enable refresh functions

* cleanup

* Diff: add refresh local hotkey

* Rename 'Refresh' to 'Refresh All'

Co-authored-by: Alexander Tsybulsky <sbcgua@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>
2021-10-09 07:06:55 +02:00
Marc Bernard
ef8f830734
Refactor hotkey controller (#4990)
- Removed "class analysis logic" from hotkey collection
- Hotkeys are now registered directly in the hotkey controller (similar to asset manager)
- `zif_abapgit_hotkeys->get_hotkey_actions` was changed to instance method and can therefore be redefined in subclasses
- Renamed the controller class to match the interface name

Co-authored-by: Christian Günter <christianguenter@googlemail.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2021-10-01 08:43:25 +02:00
Frederik Hudák
60a82331b5
Add more keyboard shortcuts for main page (#4846)
* Add more shortcuts for main page

* Update zabapgit_css_common.w3mi.data.css

* Update zcl_abapgit_gui_router.clas.abap

* Change keyboard shortcuts

* fix js

* fix js

* deindent

* indentation

* one more

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
2021-07-06 11:32:27 +02:00
Frederik Hudák
50bd3941e0
Change default width of abapgit (#4751)
* Change default width of abapgit

* Center settings forms
2021-05-12 18:10:33 +02:00
Lars Hvam
c2492dd47e
delete unused methods (#4125)
* ZCL_ABAPGIT_REPO_FILTER

delete ZCL_ABAPGIT_REPO_FILTER->GET_PACKAGE
ZCL_ABAPGIT_REPO_FILTER delete MV_PACKAGE

* testclass, delete method given_fstate

* delete ZCL_ABAPGIT_GUI_PAGE_PATCH->IS_EVERY_CHANGE

delete method delete ZCL_ABAPGIT_GUI_PAGE_PATCH->IS_EVERY_CHANGED_LINE_PATCHED

* delete ZCL_ABAPGIT_OBJECTS_SUPER->CHECK_TIMESTAMP
2020-11-03 08:45:21 +01:00
Marc Bernard
9672f5b030
Adjust name prefix for types (#3991)
* Part 1

* Part 2

* Part 3

* Lint

* Part 5

* Part 6

* Part 7

* Part 8

* Part 9

* Enforce type naming prefix

All types need to start with TY_...

* Fix local types
2020-10-07 08:54:15 +02:00
Alexander Tsybulsky
6941d9824a
html event abstraction, phase 4 - form_data (#3975)
* event->post_data logic

* part of pages, commit test

this is also long text
to test

* string_map: port strict() feature

* pages refactoring part 2

* linter

* docs

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-05 09:33:01 +02:00
Alexander Tsybulsky
9574dca828
html event abstraction, phase 2 (action utils usage unification) (#3902)
* action utils improvements

* page unifications

* linter
2020-09-19 11:02:01 +02:00
Alexander Tsybulsky
555f2f3d0b
html event abstraction, phase 1 (#3900)
* event class, interface and gui

* router adaptation

* rest of the pages

* linter fixes

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-19 07:57:39 +02:00
Lars Hvam
f0208ae883
html, use interfaces (#3871)
* html, use interfaces

#3460

* fix syntax, remove alias

* last one 🎉
2020-09-12 05:16:21 +02:00
Lars Hvam
6739b768e9
html refactoring (#3843)
* html refactoring

change A() to instance method
remove ADD_CHECKBOX alias

* removes ICON alias

* more
2020-09-06 09:45:51 +02:00
Lars Hvam
9c41a2b7d8
remove text pragmas and pseudo comments (#3827)
* remove text pragmas and pseudo comments

* fix whitespace

* fix carriage return

* test

* test

* Update zcl_abapgit_repo.clas.abap
2020-09-03 09:13:47 +02:00
Lars Hvam
86657cc691
HTML refactoring (#3813)
* HTML refactoring

* removes the ADD_ICON alias

#3460

* remove IS_EMPTY alias

* more

* refactoring
2020-08-31 09:37:36 +02:00
Lars Hvam
84c80a761c
refactoring, use interface for html (#3793)
* refactoring, use interface for html

replace uses of zcl_abapgit_html with zif_abapgit_html

#3460

* replace additional uses of the A alias

* This removes the A alias from the HTML class

This removes the following alias,
"a FOR zif_abapgit_html~a ."

* fix syntax error
2020-08-27 07:51:51 +02:00
Frederik Hudák
f5052cf0b6
Use title case in page titles, menus, forms (#3765)
* Use title case for page titles

Other minor changes:

- patch page is no longer called diff
- "code inspector" in main page action menu renamed to "check"

* Two more

* Update zcl_abapgit_gui_page_db_dis.clas.abap

* Update zcl_abapgit_gui_page_repo_sett.clas.abap

* Repo advanced menu

* Commit form labels

* Repo setting lables

* Settings, repo

* Final ones?

* Database util

* Column name in stage page

* abaplint

* Update zcl_abapgit_gui_page_stage.clas.abap

* Hover texts for stage column, commit settings

* lint
2020-08-22 09:50:10 +02:00
Christian Günter
dfc19fe718
Patch for staged files only (#3730)
* Allow Hotkeys on helper object

* Patch for staged files only

* cleanup

* fix linter

* Fix: refresh on page patch keeps sel. files

* Fix: Diff and Patch shd appear when only rem. Chg.

* fix linter

* clarify stage helper object in JS
2020-08-13 08:48:27 +02:00
Lars Hvam
17b6411cdb
remove unused variables (#3721)
* remove unused

* remove fstate

* remove

* false

* AVAS, delete method insert_links

* fstate

* sotr

* WAPA

* ssfo

* ddls mock
2020-08-11 18:11:39 +02:00
Michael Käsemann
72ccc986c7
Faulty handling of post data (#3624)
* Fixed faulty translation of post data to parsable string

- Added method TRANSLATE_POSTDATA to ZCL_ABAPGIT_UTILS as a centralized place to translate post data to a string
- Replaced all post data string concatenations with the translation helper method to correctly parse spaces that fall to the end of a table line (this should solve #3073 as well as any other random crash caused by accidental misalignment of the post data)

* Backport ABAP statement to 7.02

* Code cleanup for linter checks

* Code cleanup for linter checks

* Fixed a possible error in parsing

If it_postdata contains an empty last line, the staging fails, because the string may contain a lot of soaces at the end of the previous to last line.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-16 15:51:36 +02:00
Lars Hvam
420e6f5964
replace HTML with interface (#3490)
* replace HTML with interface

part of #3460

* pretty print
2020-06-13 09:39:46 +02:00
Alexander Tsybulsky
5c4c0b882e
Gui refactoring - part 5 (#3403)
* refactor mi_gui_services to getter

* zif_html->set_title (for debug of postponed parts)

* add set_title to all postponed parts

* gui optional rollback on error

* forgotten gui_services call

* docs

* remove gui_page redirect #3404

* forgotten html~set_title in hotkey class

also renamed render_js_part into render_scripts for unification and reuse register_deferred_script - this is why I lost it int the first place

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-05-24 10:42:06 +02:00
Alexander Tsybulsky
8eae18c0f5
Gui refactoring part 4 (#3362)
* refactoring and remove get_events from gui_page

* cleanups

* more cleanups

* register_deferred_script

* refactor page_stage

* refactor page_diff

* refactor page_commit

* refactor page_debuginfo

* linter fixes

* refactor page_tag

* refactor rage_repo_over

* refactor page_patch

* make gui_page->scripts private
2020-05-20 17:50:00 +02:00
Alexander Tsybulsky
c056076170
Gui refactoring 2 (#3338)
* hotkeys refactoring: draft logic

- new interfaces
- gui services binding
- move render to zcl_hotkeys
- move global hotkeys to hotkeys class
- remove unnecessary stuff from gui_page

* implement zif_abapgit_gui_hotkeys in rel.pages

* settings page draft

* remove zif_abapgit_gui_page_hotkey

* linter fixes

* finalize rendering logic

* finalize settings

* linter fix

* sorting tweak

* fix abapgit_full work

Co-authored-by: Christian Günter <christianguenter@googlemail.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>
2020-05-08 10:26:54 +02:00
Christian Günter
48454c5922
fix page diff dump: use repo instead of repo_online (#3304)
* fix page diff dump: use repo instead of repo_onlin

* make repo online an attribute
2020-04-14 18:57:21 +02:00
Christian Günter
decc2d4863
Page Patch: fix unit test (#3293) 2020-04-08 15:58:22 +02:00
Alexander Tsybulsky
0eb22a0c87
Gui refactor, part 1 (#3289)
* gui component and event registering

* remove iv_prev_page from event_handler if

* constructors raising zcx_abapgit_exception

* get_gui_services - UT friendly

* linter fixes

* more linter fixes

* zif_gui_services stub all methods

* linter fix

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-04-07 10:30:43 +02:00
Christian Günter
803ca23176
Refactor page diff: Introduce subclass for patch (#3283)
* Introduce zcl_abapgit_gui_page_patch as subclass of zcl_abapgit_gui_page_diff

introduce pop-method on GUI stack

fix linter + raising exception when gui stack emp

introduce zcl_abapgit_gui_page_patch

more

add

fix linter

remove go back to patch after commit

fix linter

remove bookmark for stage page

remove pop

src/ui/core/zcl_abapgit_gui.clas.abap

 src/zcl_abapgit_repo_online.clas.abap

* refactor: move more logic to  render_line_split_ro

* refactor move logic to render_diff_head_after_stat

* add logic to render_table_head_non_unified

* extract render_table_head_unified

* extract of is_patch_possible calculation

* fix linter

* move hotkey to patch

* refactor and rename to get_normalized_fname_with_p

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-03-31 17:14:13 +02:00