Commit Graph

652 Commits

Author SHA1 Message Date
Marc Bernard
5c1298697d
Trigger main command when pressing enter in form (#4102)
* Triggers main command when pressing enter in form

Adds hidden button that triggers main command when pressing the enter key

* Lint

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-05 09:46:21 +01:00
Marc Bernard
b408cad115
Backup and restore for abapGit persistency (#4137)
* Backup and restore for abapGit persistency

Backup complete content of abapGit persistency to a ZIP file and restore when necessary.

* Messages

* 702

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-05 09:28:48 +01:00
Marc Bernard
87a3806ce1
UI: Unify rendering of transport, user names - part 2 (#4133)
- Added icon for user
- Changed icon for transport to truck
- Adapted "staging" page 
- Renamed CSS-classes because of conflict with classes used on staging page

Screenshots #4097
Closes #4098

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-04 14:51:34 +01:00
Frederik Hudák
990441dbe0
Retrieve transport and changed by for deletions (#4056)
* Retrieve transport and changed by for deletions

* Refactor

* Remove breakpoint

* Update src/ui/zcl_abapgit_gui_page_stage.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Update src/ui/zcl_abapgit_gui_page_stage.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Update src/ui/zcl_abapgit_gui_page_stage.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Abaplint

* ABAPLINT

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-03 08:52:49 +01:00
Lars Hvam
c2492dd47e
delete unused methods (#4125)
* ZCL_ABAPGIT_REPO_FILTER

delete ZCL_ABAPGIT_REPO_FILTER->GET_PACKAGE
ZCL_ABAPGIT_REPO_FILTER delete MV_PACKAGE

* testclass, delete method given_fstate

* delete ZCL_ABAPGIT_GUI_PAGE_PATCH->IS_EVERY_CHANGE

delete method delete ZCL_ABAPGIT_GUI_PAGE_PATCH->IS_EVERY_CHANGED_LINE_PATCHED

* delete ZCL_ABAPGIT_OBJECTS_SUPER->CHECK_TIMESTAMP
2020-11-03 08:45:21 +01:00
Lars Hvam
df652f0436
delete various unused local variables (#4126) 2020-11-03 08:43:04 +01:00
Marc Bernard
6779e90448
UI: Sort "Switch origin" by PR number (#4127)
- Sort descending by PR number
- Rename menu items

Closes https://github.com/abapGit/abapGit/issues/4031

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-03 08:41:06 +01:00
Marc Bernard
e6acd28bda
Fix invalid HTML (#4128)
* Fix invalid HTML

- Fix HTML in case changelog contains `<, >, &` characters

* Invalid unquoted attribute value

* No tags after </body>
2020-11-03 08:38:02 +01:00
Marc Bernard
29aea372a5
UI: Adjustments to Repo Palette (#4079)
* UI: Adjustments to Repo Palette

- Sort alphabetically
- Pad offline icon (using CSS)

* CSS

* CSS

* Remove css changes

Css is fixed in #4112

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Alexander Tsybulsky <sbcgua@users.noreply.github.com>
2020-11-02 09:38:33 +01:00
Marc Bernard
dd37881589
702: Fix syntax error and missing check variant (#4117)
* 702: Downport 

No chaining with CHANGING

* 702: Downport

* Syntax check variant

* Too many fields warning

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-02 09:29:09 +01:00
Marc Bernard
bdc44f7476
Remove self-references (#4115)
* Remove self-references

Remove unnecessary self-references (me->)

https://github.com/SAP/styleguides/blob/master/clean-abap/CleanABAP.md#omit-the-self-reference-me-when-calling-an-instance-method

* 702: Fix syntax error

No chaining with EXPORTING & CHANGING

* remove addiontal me, update abaplint config

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-02 09:25:27 +01:00
Alexander Tsybulsky
614a8d60a3
new icons and css adjustments (#4112)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-11-02 09:16:59 +01:00
mariusraht2
ec99d16ec0
Checkout commit: Add menu entry and finish implementation (#4101)
* Implementation

* Add menu entry for checkout commit

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-30 10:24:27 +01:00
Marc Bernard
666dfbda66
UI: Unify rendering of branch, package, transport, user names (#4097)
* UI: Unify rendering of branch, package, user names

Branch name was already rendered "boxed with a leading icon". The same is now done for package and user names.

See `zcl_abapgit_gui_chunk_lib->render_branch_name, render_package_name, render_user_name`.

Closes #4059

* Lint %26 transport

* Unknown user

* Transport css

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-30 10:13:09 +01:00
Marc Bernard
5d480d8e8d
Fix jump links on diff page (#4096)
Some files that existed locally didn't have a link. After #4084, the state can be evaluated properly to determine if local object exists.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-30 10:01:42 +01:00
Frederik Hudák
888bbcb27e
Disable sorting for action column (#4087)
* Disable sorting for action column

* abaplint

* Revert renamed methods
2020-10-28 12:23:00 +01:00
mariusraht2
6b336c58f0
ZCL_ABAPGIT_REPO_ONLINE: Change methods fetch_remote and push to be able to retrieve and push objects also by commit hash (#4077)
* Implementation

* Add changes to push method

* Reset commit hash if branch is being switched

* abapLint: Remove whitespace

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
2020-10-28 11:56:56 +01:00
mariusraht2
a4172c6acc
ZCL_ABAPGIT_SERVICES_GIT: Add new method checkout_commit to let the user check out commits (#4076)
* Implementation

* abapLint: Omit exporting

* Omit obsolete variables

* Add caller for checkout_commit

* Extend hash column for 1 character

* Add reset_remote to set_sha1

* Merge branch 'master' into add_checkout_commit

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-28 11:08:39 +01:00
mariusraht2
69b6c3c38a
Implementation (#4086) 2020-10-28 10:41:22 +01:00
Marc Bernard
f699812b02
UI: Adjustments to Command Palette (#4080)
- Add prefix for utilities and help commands
- Remove leading spaces

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-28 06:46:53 +01:00
Marc Bernard
46f504a0e8
UI: Adjustments to Hotkeys (#4083)
- Add hotkey "f" for "new offline"
- Add hotkey "c" for "syntax check"
- Fix #3927
2020-10-28 06:42:40 +01:00
mariusraht2
3ec07c6493
ZCL_ABAPGIT_SERVICES_GIT: Change signature of method checkout_commit_build_popup (#4072)
* Implementation

* Remove unrelated pretty printer changes

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-27 16:14:16 +01:00
mariusraht2
5aebc0c88e
ZCL_ABAPGIT_SERVICES_GIT: Add method checkout_commit_build_list to build the popup selection table for commits (#4070)
* Implementation

* abapLint: Omit exporting and avoid void types

* Clear all exporting parameters first

* Remove unrelated pretty printer changes
2020-10-27 16:05:04 +01:00
Jaime Rodriguez Capote
d6fbcc1fb6
Fix repo view class name importing ZIP (#4065) 2020-10-26 10:39:16 +01:00
Fabian Lupa
ceeb95eec1
Fix arrow direction for sort order (#4062) 2020-10-26 08:06:28 +01:00
mariusraht2
54ce6771bd
Issue #4027: Resolve possible crash of AG and add option to be able to suppress showing commit hash on Code Inspector result page (#4028)
* Replace LEAVE with CALL SCREEN

* Add new option iv_show_commit

Add new option iv_show_commit to GUI_CHUNK_LIB to be able to suppress showing commit hash on GUI_PAGE_CODE_INSP page

* abapLint: Replace 'EQ' by '='

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Hide commit hash on other pages too

Hide commit hash on ZCL_ABAPGIT_GUI_PAGE_REPO_SETT and ZCL_ABAPGIT_GUI_PAGE_SYNTAX pages

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-19 11:19:02 +02:00
mariusraht2
9ac7630711
ZABAPGIT_FORMS: Remove obsolete form package_popup and related callback handler (#4029)
* ZABAPGIT_FORMS: Remove obsolete methods

- Remove branch_popup
- Remove package_popup

* Readd branch_popup

* Readd branch_popup

* Remove related callback handler

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-16 09:11:18 +02:00
Alexander Tsybulsky
19c49fd960
Bugfixes in html_form and Finetune add pages to new event (#4011)
* refactor validation in html_form + UT

* minor UT tweak

* subtle form bugfix (boolc return space string)

* cleanup add forms

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-12 16:40:24 +02:00
Alexander Tsybulsky
4b6c424465
html event abstraction, phase 5 - case insensitive query and form_data (#4007)
* case-insensitive string map

* refactor gui_event and its UTs

* remove query uppercased in pages

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-11 10:47:37 +02:00
Marc Bernard
0adb9dec58
Add Offline: Uppercase package name (#4002) 2020-10-09 12:30:07 +02:00
Lars Hvam
f9d064829a
remove more ALIASes (#3986)
most of these are not in use, but was also public
2020-10-07 09:05:28 +02:00
Lars Hvam
4e96acd4be
use HEAD symref as default branch (#3983)
* use HEAD symref as default branch

closes #3974

* autodetect
2020-10-07 08:59:30 +02:00
Marc Bernard
9672f5b030
Adjust name prefix for types (#3991)
* Part 1

* Part 2

* Part 3

* Lint

* Part 5

* Part 6

* Part 7

* Part 8

* Part 9

* Enforce type naming prefix

All types need to start with TY_...

* Fix local types
2020-10-07 08:54:15 +02:00
Alexander Tsybulsky
7c0ec067a1
rename repo related pages (#3982) 2020-10-06 08:22:22 +02:00
Marc Bernard
42c909e688
Refactor: Remove dynamic instantiation of ZCL_ABAPGIT_MESSAGE_HELPER (#3966)
* Refactor: Remove dynamic instantiation of ZCL_ABAPGIT_MESSAGE_HELPER

Consolidate `ZCL_ABAPGIT_MESSAGE_HELPER` features into `ZCX_ABAPGIT_EXCEPTION` and removes helper.

* Remove helper

* Pretty

* Update chunk_lib

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-05 16:50:36 +02:00
Alexander Tsybulsky
6941d9824a
html event abstraction, phase 4 - form_data (#3975)
* event->post_data logic

* part of pages, commit test

this is also long text
to test

* string_map: port strict() feature

* pages refactoring part 2

* linter

* docs

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-05 09:33:01 +02:00
Marc Bernard
25774396e6
Dialogs: add offline repo HTML form (#3960)
* Dialogs: add offline repo HTML form

* Dialogs: add offline repo HTML form

* Dialogs: add offline repo HTML form

* Lint

* Lint

* Chaining

* Set required attribute

* Check for empty display name

* Change validation

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-10-03 10:18:45 +02:00
Marc Bernard
c9da76b3ee
Fix error from CL_PACKAGE_FACTORY=>LOAD_PACKAGE (#3958)
* Fix error from CL_PACKAGE_FACTORY=>LOAD_PACKAGE

* Variable

* Change to T100 messages

* super->constructor( )

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-29 17:29:02 +02:00
Marc Bernard
5bde9bd549
Fix syntax errors in 702 (#3955)
* Fix syntax errors in 702

* Fix syntax errors in 702
2020-09-28 19:58:31 +02:00
Alexander Tsybulsky
e95b6f7806
html event abstraction, phase 3 - query (#3903)
* event->query

* page db refactoring

* linter fix

* linter fix

* address repo via key= param

* linter

* mv_getdata WIP

* mv_getdata - finish

* cleanup action utils

* linter fix

* another linter fix

* docs for event->query
2020-09-28 16:41:59 +02:00
Marc Bernard
dc9773bee9
Fix handling of T100 exceptions (#3943)
* Fix errors raised during deletion

* Fix error handler

* Harmonize top and bottom message banners

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-27 10:56:08 +02:00
Lars Hvam
1c1b04fbe9
update lint config, minor refactors (#3948) 2020-09-27 09:24:31 +02:00
Lars Hvam
fff8f1b237
new URL, updates (#3936)
* Update build.yml

* docs, update urls

* code, update links
2020-09-24 09:42:52 +02:00
Fabian Lupa
f2defab59e
Add option to synchronize theme with frontend (#3929)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-23 12:34:15 +02:00
Fabian Lupa
b7d318d2e9
Add button to launch IEChooser.exe on Windows (#3922)
* Add button to launch IEChooser.exe on Windows

* Fix CASE statement

* Determine iechooser.exe path using system directory

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-23 12:31:01 +02:00
Lars Hvam
03724484f1
use boolc (#3920) 2020-09-23 12:28:13 +02:00
Fabian Lupa
8ad4d130d4
Fix sort by created at in repo overview (#3919)
Fixes #3918

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-22 08:56:58 +02:00
Fabian Lupa
a2f57aeb9a
Split up global settings button and utility menu (#3913)
* Split settings and dev utils menu

* Fix missing settings hotkey on repo view

* Revert "Fix missing settings hotkey on repo view"

This reverts commit 1444744a5f.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-22 08:54:40 +02:00
Lars Hvam
015800b45b
Less DDIC references (#3905)
* remove uses of CHAR30

* Update abaplint.json

* add basic unit test for ZCL_ABAPGIT_MESSAGE_HELPER

* replace uses of char50

* fix name

* Update abaplint.json

* use sy-uname instead of uname

in ZCL_ABAPGIT_USER_MASTER_RECORD
2020-09-21 07:39:22 +02:00
Fabian Lupa
a16a903f57
Show repo list button in tutorial (#3910)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-20 09:43:54 +02:00
Fabian Lupa
bab9b7ba22
Show tutorial if there are no repos (#3907)
Fixes #3553

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-20 09:40:57 +02:00
Alexander Tsybulsky
aae82485e0
html_form chaining (#3908) 2020-09-20 09:29:12 +02:00
Alexander Tsybulsky
6e515e1063
Unified validate and normalize form params in html_form class (#3904)
* html_from - validate and normalize form params

* docs
2020-09-20 07:41:46 +02:00
Alexander Tsybulsky
9574dca828
html event abstraction, phase 2 (action utils usage unification) (#3902)
* action utils improvements

* page unifications

* linter
2020-09-19 11:02:01 +02:00
Alexander Tsybulsky
555f2f3d0b
html event abstraction, phase 1 (#3900)
* event class, interface and gui

* router adaptation

* rest of the pages

* linter fixes

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-19 07:57:39 +02:00
Fabian Lupa
143a7ccc1c
Downport, fixes #3897 (#3899) 2020-09-19 07:54:36 +02:00
Alexander Tsybulsky
d20cdd07c2
syst_title is missing in 731 (#3896)
* syst_title is mising in 731

* adjust type

* Update abaplint.json

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-17 17:40:38 +02:00
Marc Bernard
475f67d1d8
Remove trailing spaces in HTML output (#3893)
* Remove trailing spaces from html

* Return string size
2020-09-17 17:07:46 +02:00
Lars Hvam
9f396366cd
gui refactoring, for web edition (#3890)
* put cl_gui_html_viewer behind an interface

* cleanup

* injectable html viewer

* method_parameter_names, exclude zif_abapgit_html_viewer

* fix whitespace

* public get_asset_manager

* Update abaplint.json

* add prefixes
2020-09-16 12:39:23 +02:00
Lars Hvam
5b93872199
reduce existing string templates (#3886) 2020-09-15 08:14:42 +02:00
Lars Hvam
2ff25e27dd
pretty print ZCL_ABAPGIT_HTML_FORM and static (#3880)
pretty print class ZCL_ABAPGIT_HTML_FORM, and change two static methods to instance, this will make future possible changes to the class easier to see in the history
2020-09-12 06:50:31 +02:00
Lars Hvam
f0208ae883
html, use interfaces (#3871)
* html, use interfaces

#3460

* fix syntax, remove alias

* last one 🎉
2020-09-12 05:16:21 +02:00
Marc Bernard
7e4ae44fea
Enhance result view of Code Inspector/Syntax Check (#3861)
Follow-up to #3717: 
- Proper display of public, protected, and private sections
- Add CLAS prefix to be inline with other object types

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-11 11:23:33 +02:00
mariusraht2
4dce10e83c
popup_to_select_from_list can handle element-based tables (#3858)
* popup_to_select_from_list can handle element tabs

popup_to_select_from_list can now handle element-based non-structured tables like a table of url strings

Therefore related to #3639

* Update zcl_abapgit_popups.clas.abap

* Fixed wrong value assigning and added assert
2020-09-11 09:25:21 +02:00
Lars Hvam
42a532b9eb
reduce usage of ddic types (#3859)
* add SAP_BOOL as forbidden void type

* reduce

* Update abaplint.json

* sychar10

* sylangu

* Update abaplint.json
2020-09-10 15:30:25 +02:00
Fabian Lupa
dc5725b49c
Add performance test (#3847)
* Add performance test

* Fix some linter errors

* Refactor free selections to reduce method length

* Performance test add title to result ALV

* Attempt downport

* Downport

* Pretty Printer VS abaplint

* Undo more changes done by pretty printer

* Adjust performance popup title and ALV layout

* Move free sel dialog to global for abapmerge

* Move some type definitions for abapmerge

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-08 10:39:20 +02:00
g-back
3e4ce7bf73
Offline Repos: add ZIP Import/Export to actions (#3823)
* navigate to repo after ZIP import

* add zip import/export action for offline repos

* rename action labels

* change new state to be dependent on current page


change replacing -> new page if action called from repo list
rerender if in repo view

* add some TODOs, see PR discussion

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-08 10:32:17 +02:00
Lars Hvam
6739b768e9
html refactoring (#3843)
* html refactoring

change A() to instance method
remove ADD_CHECKBOX alias

* removes ICON alias

* more
2020-09-06 09:45:51 +02:00
Marc Bernard
c09cc67c83
Fix startup of repo view (#3831)
* Update error msg

* Fix login popup errors and cancelation

* Remove validate/reset methods

* Lint

* Rename iv_repo_online to io_repo_online

* Change to error in status bar

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-09-04 09:32:38 +02:00
Lars Hvam
9c41a2b7d8
remove text pragmas and pseudo comments (#3827)
* remove text pragmas and pseudo comments

* fix whitespace

* fix carriage return

* test

* test

* Update zcl_abapgit_repo.clas.abap
2020-09-03 09:13:47 +02:00
Lars Hvam
98a261df1b
remove some unused variables (#3825) 2020-09-01 16:32:44 +02:00
Lars Hvam
86657cc691
HTML refactoring (#3813)
* HTML refactoring

* removes the ADD_ICON alias

#3460

* remove IS_EMPTY alias

* more

* refactoring
2020-08-31 09:37:36 +02:00
Lars Hvam
271e365f06
html, use interfaces (#3811)
* html, use interfaces

* more

* more

* more

* this removes the ADD_A alias
2020-08-29 08:00:56 +02:00
Lars Hvam
84c80a761c
refactoring, use interface for html (#3793)
* refactoring, use interface for html

replace uses of zcl_abapgit_html with zif_abapgit_html

#3460

* replace additional uses of the A alias

* This removes the A alias from the HTML class

This removes the following alias,
"a FOR zif_abapgit_html~a ."

* fix syntax error
2020-08-27 07:51:51 +02:00
Alexander Tsybulsky
a4e6c87985
Switching to PRs (#3695)
* string map: public entries (read only)

* port http agent

* draft wip

* drafting

* fix SSL

* port ajson

* integrate ajson and http_agent

* agent global headers

* github enumerator

* update ajson

* draft wip

* enumerator factory

* http_agent via factory

* proxy

* repo->switch_origin draft

* refactor enum factory

* Revert "refactor enum factory"

This reverts commit bcfef40b38991adfe5f73677919db6bd0c652f7c.

* page wiring draft

* scripts draft

* "let it work!"

* repo setings page draft

* linter

* linter

* linter

* linter

* linter

* better settings page

* finetune page

* cleanups

* change hotkey

* fix ajson_error

* Update src/zcl_abapgit_repo_online.clas.abap

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* abaplint nesting 6

* remove description

* back to good old popups

* linter

* move commands to branches dropdown

* auth helpers

* move json to separate package

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-27 07:47:27 +02:00
Lars Hvam
681f60a265
background pull: always overwrite all objects (#3802)
* background pull: always overwrite all objects

always choose to overwrite all objects when using the pull in background feature. If the decision is not set the job will fail with a "undecided" error

#3800

* fix page title typo
2020-08-27 07:38:18 +02:00
g-back
8fc08b9c22
Add success messages for repo removal/uninstall (#3797)
* add success messages for repo removal/uninstall

* remove single quotes, add packg name to remove msg

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-27 07:33:55 +02:00
Lars Hvam
bb6785812e
styling, fix background color on background settin (#3801) 2020-08-27 07:30:41 +02:00
Marc Bernard
f1f3673b09
Improve display when there are no changes in repo view (#3803)
* Improve display when there are no changes in repo view

* Update view and remove empty_package method

* Empty package msg

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-27 07:27:24 +02:00
Lars Hvam
a9d22356a1
test (#3791) 2020-08-25 07:29:12 +02:00
Frederik Hudák
380857a896
Reposition repo filters (#3779)
* Reposition repo filters

* Remove show order by logic

* Fix diffs first being backwards

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-25 07:14:50 +02:00
Lars Hvam
dcc655eccf
syntax check page, show variant used (#3790)
* syntax check page, show variant used

closes #3660

* unify variant rendering
2020-08-25 07:05:32 +02:00
Marc Bernard
af5b898a37
Refactor branch constants (#3784)
* Branch constants

* Refactor branch constants

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-24 11:25:46 +02:00
Marc Bernard
e4bafbe715
Validate if branch exists when displaying repo (#3749)
* Validate if branch exists when displaying repo

* Validate if branch exists when displaying repo

* Lint

* Lint and 702

* Lint

* Rename validate_branch to validate

* Fix msg and branch display name

* Move msg to UI layer

* Lint

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>
2020-08-24 11:15:46 +02:00
Frederik Hudák
5c826e5993
Navigate to repo after new online (#3780)
* Navigate to repo after new online

* Update zcl_abapgit_gui_page_addonline.clas.abap
2020-08-22 14:39:39 +02:00
Marc Bernard
fe95dc7e5f
abapGit Emergency Mode (#3756)
* abapGit Emergency Mode

On rare occasions, it is necessary to edit the abapGit settings to overcome an issue (example: https://github.com/larshp/abapGit/issues/3701). 

This enhancement allows you to start abapGit in "emergency mode", which directly shows the "Database Utility" for you to view or edit any setting. 

How to start abapGit in "Emergency Mode":

1. Go to transaction SU3 to maintain your user profile
2. Maintain parameter DBT with value "ZABAPGIT" (all-caps).
3. Start abapGit
4. After exiting abapGit, go back to SU3 and remove parameter DBT

* Update ref-database-util.md

* Add files via upload

* Update ref-database-util.md

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-22 09:55:33 +02:00
Frederik Hudák
a824368a4e
Add top repo menu to more pages (#3764)
* Add top repo menu to more pages

- diff, patch
- syntax check, code inspector
- repo settings

* Add to syntax check page, add margin

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-22 09:53:35 +02:00
Frederik Hudák
f5052cf0b6
Use title case in page titles, menus, forms (#3765)
* Use title case for page titles

Other minor changes:

- patch page is no longer called diff
- "code inspector" in main page action menu renamed to "check"

* Two more

* Update zcl_abapgit_gui_page_db_dis.clas.abap

* Update zcl_abapgit_gui_page_repo_sett.clas.abap

* Repo advanced menu

* Commit form labels

* Repo setting lables

* Settings, repo

* Final ones?

* Database util

* Column name in stage page

* abaplint

* Update zcl_abapgit_gui_page_stage.clas.abap

* Hover texts for stage column, commit settings

* lint
2020-08-22 09:50:10 +02:00
Frederik Hudák
a176682f44
Hide stage and patch action links for offline repo (#3767)
Stage dumps and patch shows an error that this is not possible.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-19 07:06:27 +02:00
Marc Bernard
3846dd96a4
Hide "Action" column when toggling "Details" (#3747)
Turning on "Details" in Repo Overview will now hide the "Action" column to improve display on smaller screens.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-19 07:02:01 +02:00
Marc Bernard
77a002f584
Fix error when using "Advanced > Force Stage" (#3759)
* Fix error when using "Advanced > Force Stage"

Closes https://github.com/larshp/abapGit/issues/3650

* Lint

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-19 06:49:58 +02:00
Marc Bernard
37b938575e
Fix syntax errors in 702 (#3750)
* Fix syntax errors in 702

* Fix syntax errors in 702

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-18 07:05:52 +02:00
Lars Hvam
d5e5baa7d8
delete method ZCL_ABAPGIT_HTML=>CREATE (#3736) 2020-08-18 06:54:20 +02:00
Marc Bernard
5c53211219
Fix dump in Repo Overview for offline repos (#3746) 2020-08-17 17:22:04 +02:00
Lars Hvam
f878f3b4c3
remove some double spaces (#3740) 2020-08-16 08:24:12 +02:00
Lars Hvam
d1f277365b
create_sotr, remove unused parameters (#3739)
* minor changes

* create_sotr, remove unused parameters
2020-08-16 08:21:49 +02:00
Frederik Hudák
2a0a97bcd7
Add settings action link to main page, style for branch column (#3737)
* Add settings action link to main page

* Add branch styling to main page

* fix width

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-15 09:35:31 +02:00
Domi Bigl
20f93ff514
show last commit hash with link if possible (#3731)
* show last commit hash w/ link if possible

link to commit is supported for github.com and bitbucket.org

* remove inline data declaration

* add gitlab link support with UT

* add commit icon for non supported provider

* remove inline declaration

* remove new for CRETE OBJECT

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-13 15:41:45 +02:00
Marc Bernard
5a56166d6d
Activate objects without popup (#3725)
* Activate objects without popup

* Activate objects without popup

* Lint

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-13 08:55:10 +02:00
Christian Günter
dfc19fe718
Patch for staged files only (#3730)
* Allow Hotkeys on helper object

* Patch for staged files only

* cleanup

* fix linter

* Fix: refresh on page patch keeps sel. files

* Fix: Diff and Patch shd appear when only rem. Chg.

* fix linter

* clarify stage helper object in JS
2020-08-13 08:48:27 +02:00
Lars Hvam
17b6411cdb
remove unused variables (#3721)
* remove unused

* remove fstate

* remove

* false

* AVAS, delete method insert_links

* fstate

* sotr

* WAPA

* ssfo

* ddls mock
2020-08-11 18:11:39 +02:00
Christian Günter
e3c1623275
Fix dump in Code Insp. Display for exception class (#3724) 2020-08-10 17:14:09 +02:00
Lars Hvam
867c74701f
remove some unused variables (#3719)
* remove some unused variables

* more unused
2020-08-09 08:44:54 +02:00
Lars Hvam
0052664c7c
optimize TADIR select (#3718) 2020-08-08 10:30:01 +02:00
Marc Bernard
324db52335
Enhance result view of Code Inspector/Syntax Check (#3717)
* Enhance result view of Code Inspector/Syntax Check

* Enhance result view of Code Inspector/Syntax Check

* Enhance result view of Code Inspector/Syntax Check

* Lint

* Move sort
2020-08-07 07:17:42 +02:00
Marc Bernard
c026ee89b0
Downport: Fix syntax errors in 702 (#3674)
* Downport: Fix syntax error in 702

Method "ASSERT_TRUE" does not exist in 702

* Downport: Fix syntax error in 702

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-06 13:50:53 +02:00
Christian Günter
4af7026e15
Fix: Open repo in master lang. opens repo (#3710)
After this fix is applied the menu "advanced > open in master language" opens the repo directly and doesn't open the repo list.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-06 13:37:48 +02:00
antonioyanez
a98ba1dfe1
fix bug of ignore subpackages flag (#3715)
Closes #3712
2020-08-06 11:53:58 +02:00
Alexander Tsybulsky
8bc12fef01
tutorial to component (#3704) 2020-08-05 07:47:10 +02:00
Frederik Hudák
b34f5c36b5
Remember repo list filter (#3671)
* Remember repo list filter

resolves #3552 

Changes:
- store filter in local storage instead of session storage, so it is remembered on abapgit restart
- filter is saved whenever it is changed instead of page unload
- removed debug output, it doesn't need to clutter the main page

* Don't resave on page load

* Add semicolons

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-08-01 12:42:20 +02:00
Lars Hvam
837d45bc83
fix whitespace (#3690) 2020-07-31 06:22:01 +02:00
Frederik Hudák
a1ecc65ecc
Improved branching messages (#3685)
* Improvements to branch messages

* Names without refs/heads
2020-07-31 06:15:56 +02:00
Alexander Tsybulsky
525634e42b
page hoc concept (#3626)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-23 15:10:40 +02:00
Michael Käsemann
04e71feabe
Improved staging robustness (#3625)
* Improved staging robustness

- Skipped any objects in the changelist that are not marked for staging prior to processing them , to avoid that they keep other objects without errors from being staged if the user wants to stage parts of the changes

* Reduced line length

* Removed missed whitespace

* Update abaplint.json

* Update abaplint.json

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-23 14:59:22 +02:00
Frederik Hudák
144e53608d
Add action column to repo overview (#3645)
* Add stage, patch buttons to repo overview

* Fix abaplint

* Add syntax check, code inspector

* Add pull

* constant naming

* Last changes

* lint

* lint

* Update abaplint.json

* Update abaplint.json

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-21 07:24:38 +02:00
Michael Käsemann
72ccc986c7
Faulty handling of post data (#3624)
* Fixed faulty translation of post data to parsable string

- Added method TRANSLATE_POSTDATA to ZCL_ABAPGIT_UTILS as a centralized place to translate post data to a string
- Replaced all post data string concatenations with the translation helper method to correctly parse spaces that fall to the end of a table line (this should solve #3073 as well as any other random crash caused by accidental misalignment of the post data)

* Backport ABAP statement to 7.02

* Code cleanup for linter checks

* Code cleanup for linter checks

* Fixed a possible error in parsing

If it_postdata contains an empty last line, the staging fails, because the string may contain a lot of soaces at the end of the previous to last line.

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-16 15:51:36 +02:00
Alexander Tsybulsky
07e1f787c6
gui_page cleanups (#3615)
* move test_changed_by from gui_page to services

* kind of linter fix

* move more action to router

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-13 17:42:40 +02:00
Alexander Tsybulsky
144cb8822c
improve missing branch styling (#3619)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-13 11:34:39 +02:00
Lars Hvam
0feae7c1b2
ZCL_ABAPGIT_FRONTEND_SERVICES private (#3617)
private instantiation
2020-07-13 11:17:21 +02:00
Alexander Tsybulsky
d18d4c798e
Fix #3609 (clone uppercase pkg name) (#3613) 2020-07-12 08:56:44 +02:00
Lars Hvam
cd9ea97a63
HTML: move add_icon to interface (#3608)
* HTML: move add_icon to interface

* ZCL_ABAPGIT_HTML_TOOLBAR use interface

* ZCL_ABAPGIT_GUI_REPO_OVER use interface

* ZCL_ABAPGIT_GUI_PAGE_VIEW_REPO  use intf
2020-07-12 08:37:15 +02:00
ed-holland
df48acc015
Clearer error message for no branch (#3605)
* CI Update

* Raise exception when no .abapgit.xml is found (#3512)

Update

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Updated documentation for repo settings & icons (#3499)

* Completed to-dos

- Updated abapgit.xml example
- Completed missing docu for local settings

* screenshots

* screenshots

* Delete repo_settings_local.png

* screenshots

* Delete repo_settings_local.png

* screenshots

* screenshots

* Combine write-protect setting

* Merged to repo settings

* screenshots

* screenshots

* merged to repo settings

* merged to repo settings

* Adding details

* Added links

* links

* icons

* icons

* icons

* icons

* icons

* icons

* icons

* Update ref-icons.md

* icons

* icons

* Update docs/ref-dot-abapgit.md

Co-authored-by: Lars Hvam <larshp@hotmail.com>

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Fix icon display in docs (#3517)

Icons showed on github.com but not on docs.abapgit.org

* +On/offline: If package already in other repo, nav to repo (#3525)

* New method to get repo from package

If package already exists in a repo and it returns the repo and reason why the package can't be used in a new repo

* UI: If package exists in repo, nav to repo

+Online, +Offline - if repo is already versioned, navigate to repo and show message why package could not be used in new repo

Closes https://github.com/larshp/abapGit/issues/3452

Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>

* Update eslint requirement from ^7.2.0 to ^7.3.0 (#3534)

* Update @abaplint/cli requirement from ^2.36.6 to ^2.36.9 (#3535)

* Fix syntax errors in 702 (#3548)

Caused by https://github.com/larshp/abapGit/pull/3525

* SCP1 Import Order (#3543)

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Update .gitlab-ci.yml

* Update eslint requirement from ^7.3.0 to ^7.3.1 (#3556)

* Update @abaplint/cli requirement from ^2.36.9 to ^2.37.2 (#3557)

* Repo overview as main page (#3498)

* Add main menu, toggle favorites

* Make abapgit logo go to overview

* Remove favorite repo links

* Fix remember filter

* Separator between filters

* Remove unused code

* Repo overview to main page

* Fix errors

* Fix naming

* Downport js

* Add separator

* remove unrelated changes

* Fix spacing

* Add package link

* Fix orderby dumping

* Only show tutorial with no favorites

Still have to do something about empty table

* Move abapgit installation info to debug info

* Improve tutorial, resolves #3497

* Add branch switch link

* Reduce line length

* Revert temporary hack

* Working version of removing logo

* No longer show tutorial in repositories

* Code cleanup

* More cleanup, rename tutorial to page

* Fix

* Force order by favorite

* Add checkmark icons

* View repo to page, rework menu

* Fix build

* Return logo

* Fix hotkeys on repo page, rename to page

* Fix show last repo, cleanup

* Abaplint

* Rollback js reformat

* Fix tutorial title, hotkeys

* Try resolve strange situation with PR

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Remove unused method (#3554)

* Remove unused method

* whitespace

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* 1.97.0 (#3561)

* 1.97.0

whitespace

* 1.97.0

* v1.97.0

* fix for apply_order_by (#3566)

* Update zcl_abapgit_repo.clas.abap (#3570)

* Dialogs: add online repo HTML form (#3533)

* first draft

* progress ...

* html->create()

* more progress

* and more

* getting closer

* wiring

* refactor popup_search_help

* refactor create_package to services

* fix services->new_online after rebase

* linter fixes

* more linter fixes

* straing map util

* error handling

* submits for side actions (ugly ... but ...)

* cleanups

* linter fixes

* refactor form values logic

* linter fix

* review fixes

* remove unused var after rebase

* review fixes, better side action layout

* linter fix

* minor css tweaks

* Fix user settings containing invalid repo key (#3569)

* Update zcl_abapgit_persistence_user.clas.abap

* Fix dump when last repo is invalid

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* UI: Fixes for dark theme (#3540)

* Add logo for dark theme

* Dark theme fixes

* Dark theme fixes

* Solve conflict

* Remove logo changes

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>

* Missing objects in overwrite confirmation popup (#3558)

* Missing objects in overwrite confirmation popup

Closes https://github.com/larshp/abapGit/issues/3550

* Unit tests

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Fix open url in repo view (#3581)

* Fix open url in repo view

* Move call_browser to gui_router

* CSS and logo fixes (#3578)

* css cleanups

* orange logo

* Revert "orange logo"

This reverts commit b9aa45bbd0.

* update font

* css improvements

* remove logo png

* re-layout page title and footer

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Html form improvements and docs (#3582)

* auto id

* fix html validation (form in ul)

* form groups

* move colors to theme

* docs for html form component

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Generate news instance (#3585)

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Update @abaplint/cli requirement from ^2.37.2 to ^2.37.5 (#3588)

* Update eslint requirement from ^7.3.1 to ^7.4.0 (#3589)

* Update .gitlab-ci.yml

* fix repo palette (#3580)

* fix repo palette

* fix page_view_repo after rebase

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Adjust new logo color for dark theme (#3592)

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Add deleted objects to overwrite confirm popup (#3591)

* Add deleted objects to overwrite confirm popup

Closes https://github.com/larshp/abapGit/issues/2845

* Pretty print

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Top menu improvements (#3590)

* Use icons, add back menu to repo show page

* Event handling

* Abaplint

* Add menu to tutorial page

* Lint

* More icons

* Update tutorial, reorganize button code

* Move icon css

* Fix error

* Fix menu

* Update .gitlab-ci.yml

* Fix rebase issue

* Fix rebase mess up

* Raise exception when no .abapgit.xml is found (#3512)

Update

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Updated documentation for repo settings & icons (#3499)

* Completed to-dos

- Updated abapgit.xml example
- Completed missing docu for local settings

* screenshots

* screenshots

* Delete repo_settings_local.png

* screenshots

* Delete repo_settings_local.png

* screenshots

* screenshots

* Combine write-protect setting

* Merged to repo settings

* screenshots

* screenshots

* merged to repo settings

* merged to repo settings

* Adding details

* Added links

* links

* icons

* icons

* icons

* icons

* icons

* icons

* icons

* Update ref-icons.md

* icons

* icons

* Update docs/ref-dot-abapgit.md

Co-authored-by: Lars Hvam <larshp@hotmail.com>

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Fix icon display in docs (#3517)

Icons showed on github.com but not on docs.abapgit.org

* +On/offline: If package already in other repo, nav to repo (#3525)

* New method to get repo from package

If package already exists in a repo and it returns the repo and reason why the package can't be used in a new repo

* UI: If package exists in repo, nav to repo

+Online, +Offline - if repo is already versioned, navigate to repo and show message why package could not be used in new repo

Closes https://github.com/larshp/abapGit/issues/3452

Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>

* Update eslint requirement from ^7.2.0 to ^7.3.0 (#3534)

* Update @abaplint/cli requirement from ^2.36.6 to ^2.36.9 (#3535)

* Fix syntax errors in 702 (#3548)

Caused by https://github.com/larshp/abapGit/pull/3525

* SCP1 Import Order (#3543)

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Update .gitlab-ci.yml

* Update eslint requirement from ^7.3.0 to ^7.3.1 (#3556)

* Update @abaplint/cli requirement from ^2.36.9 to ^2.37.2 (#3557)

* Repo overview as main page (#3498)

* Add main menu, toggle favorites

* Make abapgit logo go to overview

* Remove favorite repo links

* Fix remember filter

* Separator between filters

* Remove unused code

* Repo overview to main page

* Fix errors

* Fix naming

* Downport js

* Add separator

* remove unrelated changes

* Fix spacing

* Add package link

* Fix orderby dumping

* Only show tutorial with no favorites

Still have to do something about empty table

* Move abapgit installation info to debug info

* Improve tutorial, resolves #3497

* Add branch switch link

* Reduce line length

* Revert temporary hack

* Working version of removing logo

* No longer show tutorial in repositories

* Code cleanup

* More cleanup, rename tutorial to page

* Fix

* Force order by favorite

* Add checkmark icons

* View repo to page, rework menu

* Fix build

* Return logo

* Fix hotkeys on repo page, rename to page

* Fix show last repo, cleanup

* Abaplint

* Rollback js reformat

* Fix tutorial title, hotkeys

* Try resolve strange situation with PR

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Remove unused method (#3554)

* Remove unused method

* whitespace

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* 1.97.0 (#3561)

* 1.97.0

whitespace

* 1.97.0

* v1.97.0

* fix for apply_order_by (#3566)

* Update zcl_abapgit_repo.clas.abap (#3570)

* Dialogs: add online repo HTML form (#3533)

* first draft

* progress ...

* html->create()

* more progress

* and more

* getting closer

* wiring

* refactor popup_search_help

* refactor create_package to services

* fix services->new_online after rebase

* linter fixes

* more linter fixes

* straing map util

* error handling

* submits for side actions (ugly ... but ...)

* cleanups

* linter fixes

* refactor form values logic

* linter fix

* review fixes

* remove unused var after rebase

* review fixes, better side action layout

* linter fix

* minor css tweaks

* Fix user settings containing invalid repo key (#3569)

* Update zcl_abapgit_persistence_user.clas.abap

* Fix dump when last repo is invalid

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* UI: Fixes for dark theme (#3540)

* Add logo for dark theme

* Dark theme fixes

* Dark theme fixes

* Solve conflict

* Remove logo changes

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>

* Missing objects in overwrite confirmation popup (#3558)

* Missing objects in overwrite confirmation popup

Closes https://github.com/larshp/abapGit/issues/3550

* Unit tests

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Fix open url in repo view (#3581)

* Fix open url in repo view

* Move call_browser to gui_router

* CSS and logo fixes (#3578)

* css cleanups

* orange logo

* Revert "orange logo"

This reverts commit b9aa45bbd0.

* update font

* css improvements

* remove logo png

* re-layout page title and footer

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Html form improvements and docs (#3582)

* auto id

* fix html validation (form in ul)

* form groups

* move colors to theme

* docs for html form component

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Generate news instance (#3585)

Co-authored-by: Lars Hvam <larshp@hotmail.com>

* Update @abaplint/cli requirement from ^2.37.2 to ^2.37.5 (#3588)

* Update eslint requirement from ^7.3.1 to ^7.4.0 (#3589)

* Improve message when no branches selectable

* Update .gitlab-ci.yml

* Fix linter issues

* Fix rebase mess up

* Enhanced Error message

* Delete .gitlab-ci.yml

Co-authored-by: Ed Wenmakers <ed.wenmakers@redwood.com>
Co-authored-by: Christian Günter <christianguenter@googlemail.com>
Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Marc Bernard <59966492+mbtools@users.noreply.github.com>
Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Rakshith Gore <58498218+goreraks@users.noreply.github.com>
Co-authored-by: Lukáš Novák <lthenovi@gmail.com>
Co-authored-by: Alexander Tsybulsky <sbcgua@users.noreply.github.com>
Co-authored-by: Jaime Rodriguez Capote <jrodriguez@resultoconsultoria.com>
2020-07-11 12:38:55 +02:00
Shai
15f55276e1
Fix issue 3597 (#2 try) (#3601)
* Fix issue 3597 (#2 try)

When abapGit is being executed on SAP GUI for HTML, all the links don't work (don't do anything because SAPEVENT isn't being passed back to the application server).

* Fix build errors of previous commit

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-11 08:28:41 +02:00
Frederik Hudák
d49d0656b0
Top menu improvements (#3590)
* Use icons, add back menu to repo show page

* Event handling

* Abaplint

* Add menu to tutorial page

* Lint

* More icons

* Update tutorial, reorganize button code

* Move icon css

* Fix error

* Fix menu
2020-07-09 09:12:58 +02:00
Marc Bernard
e0c93b0d7c
Add deleted objects to overwrite confirm popup (#3591)
* Add deleted objects to overwrite confirm popup

Closes https://github.com/larshp/abapGit/issues/2845

* Pretty print

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-07 15:31:21 +02:00
Marc Bernard
a980d9812d
Adjust new logo color for dark theme (#3592)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-07 15:21:34 +02:00
Alexander Tsybulsky
2699e2d513
fix repo palette (#3580)
* fix repo palette

* fix page_view_repo after rebase

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-07 14:59:31 +02:00
Alexander Tsybulsky
f80b537c7c
defaul theme fix (grey headings) (#3587)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-06 08:12:47 +02:00
Jaime Rodriguez Capote
fd32cbd951
Generate news instance (#3585)
Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-05 18:08:51 +02:00
Alexander Tsybulsky
6fe168640c
Html form improvements and docs (#3582)
* auto id

* fix html validation (form in ul)

* form groups

* move colors to theme

* docs for html form component

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-05 17:57:45 +02:00
Alexander Tsybulsky
cae3aae5e2
CSS and logo fixes (#3578)
* css cleanups

* orange logo

* Revert "orange logo"

This reverts commit b9aa45bbd0.

* update font

* css improvements

* remove logo png

* re-layout page title and footer

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-04 12:47:14 +02:00
Jaime Rodriguez Capote
f8d74cc928
Fix open url in repo view (#3581)
* Fix open url in repo view

* Move call_browser to gui_router
2020-07-04 12:35:38 +02:00
Marc Bernard
493bb969b2
UI: Fixes for dark theme (#3540)
* Add logo for dark theme

* Dark theme fixes

* Dark theme fixes

* Solve conflict

* Remove logo changes

Co-authored-by: Lars Hvam <larshp@hotmail.com>
Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>
2020-07-02 09:15:31 +02:00
Marc Bernard
7ce457dc8d
Fix user settings containing invalid repo key (#3569)
* Update zcl_abapgit_persistence_user.clas.abap

* Fix dump when last repo is invalid

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-07-01 15:24:33 +02:00
Frederik Hudák
961afa37f8
Fix error after removing/uninstalling repo (#3572)
Main and repo are no longer one page, so the `re_render` action does not make sense anymore. `new_page_replacing` is used instead of `new_page` so you cannot navigate back to the removed repo.
2020-07-01 15:10:39 +02:00
Alexander Tsybulsky
f5dfd328f5
Dialogs: add online repo HTML form (#3533)
* first draft

* progress ...

* html->create()

* more progress

* and more

* getting closer

* wiring

* refactor popup_search_help

* refactor create_package to services

* fix services->new_online after rebase

* linter fixes

* more linter fixes

* straing map util

* error handling

* submits for side actions (ugly ... but ...)

* cleanups

* linter fixes

* refactor form values logic

* linter fix

* review fixes

* remove unused var after rebase

* review fixes, better side action layout

* linter fix

* minor css tweaks
2020-07-01 08:16:52 +02:00
Lukáš Novák
d621551146
fix for apply_order_by (#3566) 2020-06-30 10:11:27 +02:00
Lars Hvam
051c9c6569
1.97.0 (#3561)
* 1.97.0

whitespace

* 1.97.0

* v1.97.0
2020-06-29 16:52:15 +02:00
Frederik Hudák
e4fd14ee73
Remove unused method (#3554)
* Remove unused method

* whitespace

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-06-29 16:40:01 +02:00
Frederik Hudák
32cf59ca1e
Repo overview as main page (#3498)
* Add main menu, toggle favorites

* Make abapgit logo go to overview

* Remove favorite repo links

* Fix remember filter

* Separator between filters

* Remove unused code

* Repo overview to main page

* Fix errors

* Fix naming

* Downport js

* Add separator

* remove unrelated changes

* Fix spacing

* Add package link

* Fix orderby dumping

* Only show tutorial with no favorites

Still have to do something about empty table

* Move abapgit installation info to debug info

* Improve tutorial, resolves #3497

* Add branch switch link

* Reduce line length

* Revert temporary hack

* Working version of removing logo

* No longer show tutorial in repositories

* Code cleanup

* More cleanup, rename tutorial to page

* Fix

* Force order by favorite

* Add checkmark icons

* View repo to page, rework menu

* Fix build

* Return logo

* Fix hotkeys on repo page, rename to page

* Fix show last repo, cleanup

* Abaplint

* Rollback js reformat

* Fix tutorial title, hotkeys

* Try resolve strange situation with PR

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-06-29 16:34:59 +02:00
Marc Bernard
dc95fb3efd
Fix syntax errors in 702 (#3548)
Caused by https://github.com/larshp/abapGit/pull/3525
2020-06-27 16:25:23 +02:00
Marc Bernard
01dce88475
Interface and implementing class in same package (#3528)
* Interface and implementing class in same package

* Interface and implementing class in same package

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-06-21 10:23:43 +02:00
Marc Bernard
09120cb80d
+On/offline: If package already in other repo, nav to repo (#3525)
* New method to get repo from package

If package already exists in a repo and it returns the repo and reason why the package can't be used in a new repo

* UI: If package exists in repo, nav to repo

+Online, +Offline - if repo is already versioned, navigate to repo and show message why package could not be used in new repo

Closes https://github.com/larshp/abapGit/issues/3452

Co-authored-by: Frederik Hudák <frederik.hudak@sap.com>
2020-06-20 14:32:00 +02:00
Marc Bernard
d74284bd8b
Minor improvements of icons in repo view (#3493)
* Minor improvement for icons in repo view

* Add Icon Legend in "Debug Info"

A place to see available icons (will copy it to documentation).

* Pretty print

* Reverse icons in debug info

Icons are now in docs. No need for this here

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-06-16 16:54:01 +02:00
Marc Bernard
ed09b51855
Fix incorrect status of ignored files in repo view (#3506)
* Fix incorrect status of ignored filed in repo view

After update of repo settings, some ignored files showed as "-/A". 
https://github.com/larshp/abapGit/pull/3415

* Whitespace

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-06-16 16:00:30 +02:00
Marc Bernard
d006cd0658
Removed default for commit comment (#3513)
* Removed default for commit comment

Closes https://github.com/larshp/abapGit/issues/3511

* Removed default for commit comment

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-06-16 15:57:04 +02:00
Lars Hvam
024167ce97
replace SYREPID (#3501)
* Update abaplint.json

* replace SYREPID
2020-06-16 07:34:12 +02:00
Christian Günter
58fb961a19
Fix: remove URL validation for offline repos (#3508) 2020-06-15 12:53:40 +02:00
Marc Bernard
38099501b8
Improved validation of URLs (#3486)
* Limit URLs to http and https

* Validate URLs

* Raise error only for validation (not for get_name)

Co-authored-by: Lars Hvam <larshp@hotmail.com>
2020-06-14 20:14:39 +02:00
Lars Hvam
420e6f5964
replace HTML with interface (#3490)
* replace HTML with interface

part of #3460

* pretty print
2020-06-13 09:39:46 +02:00