Commit Graph

2467 Commits

Author SHA1 Message Date
Alexander Tsybulsky
39ee3c961f fix #3048, remote only stage js error (#3086) 2019-11-27 06:19:01 +01:00
Italo N
0f379b950a DOMA: consider clearing VALPOS (#3083) 2019-11-26 07:39:25 +01:00
g-back
965082510b Exchange sy-langu usage with mv_language for consistency (#3082) 2019-11-26 07:29:59 +01:00
Lars Hvam
29cb891d23
remove obsolete NO_HANDLER pragmas (#3085)
* remove obsolete NO_HANDLER pragmas

* update lint to latest
2019-11-25 07:35:41 +01:00
mariusraht2
064e006c88 Issue 3042: Error author regex (#3070)
* Create pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Update zcl_abapgit_git_transport.clas.abap

* Update pull.yml

* Delete pull.yml

* Tags: Error author regex

> Regex couldn't match with string "pull[bot] <39814207+pull[bot]@users.noreply.github.com> 1573216988 +0000" because "[]" weren't allowed

* abapLint

* Added unit test for author_regex

#3042

* Any character in author name and Unit Tests

#3042
#3069

* Unit Tests and utils method for author regex

#3042
#3069

> Unit Tests for author_regex (zif_abapgit_definitions)
> New utils method for regex check as utils method in zcl_abapgit_utils
> Regex for author expects now at least one character for the author name ('^(.+)'...)
> Use zif_abapgit_definitions%3D>ty_commit_tt  instead of local type of the same type in class zcl_abapgit_branch_overview

* Changed utils method/tests and moved unit tests

#3042 - Error author regex
#3069 - Add unit tests

> Renamed is_author to extract_author_data and moved related source code from branch_overview to utils class
> Changed related unit tests to handle exception or not
> Moved unit tests to local class of zcl_abapgit_utils

* abapLint

* abapLint

* abapLint

* abapLint

* exclude 7bit test for testclass
2019-11-21 06:40:25 +01:00
mariusraht2
6491967d76 Issue 3029: TABL: SAPGUI data preview doesn't work when opened (#3059)
* Create pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Update zcl_abapgit_git_transport.clas.abap

* Update pull.yml

* TABL: SAPGUI data preview doesn't work when opened

Fixes #3029

> Call RS_TOOL_ACCESS instead of ABAP4_CALL_TRANSACTION

* Delete pull.yml
2019-11-17 10:42:21 +01:00
mariusraht2
5fa3057c48 Issue 3042: Error author regex on Tag switch (#3067)
* Create pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Update zcl_abapgit_git_transport.clas.abap

* Update pull.yml

* Delete pull.yml

* Tags: Error author regex

> Regex couldn't match with string "pull[bot] <39814207+pull[bot]@users.noreply.github.com> 1573216988 +0000" because "[]" weren't allowed

* abapLint
2019-11-17 10:38:09 +01:00
mariusraht2
89dfeb69f8 Issue 3060: Check repo URLs before creating a new online repo (#3063)
* Create pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Update zcl_abapgit_git_transport.clas.abap

* Update pull.yml

* Delete pull.yml

* Check repo URLs before creating a new online repo

Fixes #3060

* Check repo URLs before creating a new online repo

Use method zcl_abapgit_url%3D>name and replace the assert with an exception
2019-11-17 10:31:27 +01:00
mariusraht2
8df12d34e0 Issue 3061: Change default value for creation of playground page (#3062)
* Create pull.yml

* Update zcl_abapgit_git_transport.clas.abap

* Update zcl_abapgit_git_transport.clas.abap

* Update pull.yml

* Delete pull.yml

* Change def. value for creation of playground page

Closes #3061

* Update zcl_abapgit_popups.clas.abap
2019-11-17 10:18:40 +01:00
Christian Günter
83a781e1d7 IWVB: SAP Gateway Business Suite Enablement -Vocab (#3049) 2019-11-12 11:03:04 +01:00
Alexander Tsybulsky
5edea3acda quick fix unicode char in js (ctrl+enter) #3035 (#3052) 2019-11-11 09:21:22 +01:00
Christian Günter
93f5186b1d Object serializer descriptions (#3050) 2019-11-11 09:15:03 +01:00
Christian Günter
061245a33b IAXU: downport no static call of CL_W3_API_XML3 (#3047)
* IAXU: downport no static call of CL_W3_API_XML3

* downport check_duplicates
2019-11-08 13:02:12 +01:00
Lars Hvam
3776ac353a
Get all branches, including pull request refs (#3031)
* update example for listing branches

* do not ignore any branches

* add new get_all method

* Update zcl_abapgit_git_branch_list.clas.testclasses.abap
2019-11-06 09:51:34 +01:00
mariusraht2
4f1ed3b8b6 Exception Handling: IATU refactored (#3043)
* Create pull.yml

* Refactored IATU

* Delete pull.yml

* abapLint
2019-11-06 09:46:35 +01:00
mariusraht2
fb527126ef Fix applied (#3037) 2019-11-06 09:42:47 +01:00
Lars Hvam
04a6d7e484
Update abaplint.json to latest (#3045)
* Update abaplint.json

* chain mainly declarations
2019-11-06 09:35:18 +01:00
mariusraht2
e014efd3f4 log viewer: refactor types (#3041) 2019-11-06 09:30:21 +01:00
Lars Hvam
678b3bebd5
pretty print class (#3032) 2019-11-06 08:53:28 +01:00
g-back
7c05815437 Small refactorings (#3033)
* remove unusued variables

* surround "recover_version" calls with try-catch
2019-11-05 08:09:47 +01:00
Italo N
be9b57a0f2 Commit form should not be cleared on error (#3015)
* Commit form should not be cleared on error

* move the type definition to ZIF_ABAPGIT_DEFINITION

* Move type definition to new interface
2019-11-04 11:48:53 +01:00
Alexander Tsybulsky
f0bb81f04a #3022 patch commit state 2019-11-03 07:57:28 +01:00
Alexander Tsybulsky
d501afdf83 downport (#3026) 2019-11-01 17:25:44 +01:00
Frederik Hudák
509a69e480 'Duplicates' error: show duplicate object names (#3024)
* 'Duplicates' error: show duplicate object names

* Update zcl_abapgit_objects.clas.abap

* Update zcl_abapgit_objects.clas.abap
2019-11-01 17:22:04 +01:00
Lars Hvam
dca54d2590
refactoring public attributes (#3023)
* testclass for testing and remove public attr

* refactor public vars in local class

* rename
2019-11-01 17:07:17 +01:00
Lars Hvam
9c6bba620c
1.91.0 (#3019)
* 1.91.0

* Update changelog.txt
2019-10-31 15:16:45 +01:00
Italo N
7d587e1a1a Issue #2957 (#2975)
But It's generate a lot of DIFF, when XML remote has the INDEX filled.
2019-10-31 15:07:59 +01:00
Frederik Hudák
04e196b816 Improve branching messages (#3018)
Mention name of branch which was just deleted/switched to.
2019-10-31 14:35:29 +01:00
Alexander Tsybulsky
4f3bd19a8b stage UX improvements: ctrl-enter, autoadd deleted, remote state bugfix (#3007)
* stage: ctrl-enter, autoadd deleted

* linter fix

* eslint fix

* review fixes
2019-10-31 14:29:23 +01:00
Christian Guenter
99761e37c9 Links: add tooltip with hotkey 2019-10-31 08:42:37 +01:00
Johan Wigert
df303d2cc6 Object should be removed, but has NO deletion flag in transport (#3009)
* Update zcl_abapgit_transport_objects.clas.abap

* Update zcl_abapgit_transport_objects.clas.testclasses.abap
2019-10-30 06:50:16 +01:00
Alexander Tsybulsky
1af5648e5f Diff state at stage and commit pages (#3003)
* state at stage and commit pages

* review fix
2019-10-27 11:26:59 +01:00
Italo N
f4c8d13a2c Bug - PROG name contain '%3D' (#2980)
Issue #2923
2019-10-27 11:19:32 +01:00
Christian Günter
c99ff03253 FTGL: feature toggle (#3004)
* FTGL: feature toggle

* update ref-supported

* Update ref-supported.md
2019-10-27 08:46:57 +01:00
Alexander Tsybulsky
af97a51fa5 commit selected button (#2993) 2019-10-25 06:46:01 +02:00
mariusraht2
3900842392 Add object type IAXU (#2978)
* Possible Solution #1

* Update zcl_abapgit_objects_super.clas.xml

* abapLint

* Removed german language flag

* Fixes

* Removed flag for german language

* Removed test code

* abapLint

* Implemented suggestions from PR

> mo_xml_api is just local now
> li_service removed
> implemented exception handling for calls of xml api methods set_changeable, delete and save
> integrated sy-subrc into all exception calls
> wrote update routine if IAXU object already exists (object will be deleted first and after that local method save is called)

* abapLint

* abapLint

* String template, restructured api methods

* Remove descriptions

* abapLint

* Fixed issues after restructuring api methods calls

* Alternative error handling for existence check

* Use api existence check instead of load

* Fixed some bugs
2019-10-24 05:53:12 +02:00
Alexander Tsybulsky
fc2c803be5 me filter 2019-10-22 15:27:28 +02:00
larshp
523ab5c862 refactor CONSTANT definition 2019-10-20 14:51:34 +02:00
David Scheiklies
f4e33039d6 Add commit success message (#2979)
* New version of #2973

* Update zcl_abapgit_gui_page_commit.clas.abap
2019-10-16 21:40:17 -07:00
Christian Günter
b7d0f2115e SMTG: OM: Email Template implementation (#2976) 2019-10-15 22:32:03 -07:00
g-back
033b32de7d Repository-Validation: More specific Error Message (#2965)
* add additional read to better specifiy error msg

issue #2914

* add line break in error message
2019-10-15 22:23:23 -07:00
Alexander Tsybulsky
5c10415b28 possibility to export pkg with master lang only (#2966) 2019-10-13 23:02:42 -07:00
Christian Günter
bc082b15b0 Link Hints: fix start value calculation (#2970)
* Link Hints: fix start value calculation

* fix comment
2019-10-13 22:39:56 -07:00
Marcello Urbani
b8cc55ec3f Fixes #2904 dump importing zip (#2963)
* Fixes #2904 dump importing zip

* Fix linting issues
2019-10-12 04:00:10 -07:00
Alex
17a67933e3 Fix for issue #2922 (#2960)
* added a picture for pull from zip

it can then be used in guide-import-zip.md

* Fix for Issue 2922

https://github.com/larshp/abapGit/issues/2922

Added a new test method find_head_closing_tag.
Implemented fix in method zcl_abapgit_gui_html_processor->find_head_offset.

* Removed dont needed Pull_from_zip.png 

Removed dont needed Pull_from_zip.png

* Restored NewLines handling in patch_html

Restored NewLines handling in patch_html

* Fixed some abapLint Warnings

Fixed some abapLint Warnings

* Fixed some abapLint messages

Fixed some abapLint messages
2019-10-12 03:56:28 -07:00
ThomasPloski
dcb4d94275 Support of Baseinfo String for DDLS Object Handler (#2967)
* support of baseinfo string in ddls

* fixes abaplint findings

* fixes abaplint issues
2019-10-11 05:41:01 -07:00
Lars Hvam
714fe7202d
whitespace fixes (#2964)
* whitespace fixes

* fix sql compare operators
2019-10-11 02:50:16 -07:00
Christian Guenter
8bf4b5df4c Page overview: fix order by column mismatch 2019-10-09 21:14:12 -07:00
Lars Hvam
ef0d149fa3
SCP1, sets of sets (#2945)
* SCP1, first few bits

* try this

* fix transport
2019-10-09 01:59:48 -07:00
Alexander Tsybulsky
f2f82278e7 Serialize master lang only + settings UI improvements (#2954)
* repo settings ui improvements

* serialize_master_lang_only UI

* downport

* connect settings and serialization (MSAG)

* dtel doma tran prog fugr

* linter fixes
2019-10-07 23:03:57 -07:00
Lars Hvam
28e052dbce
serialization, FORM fixes (#2950)
* FORM, tdlines duplicated, closes #2949

* FORM, set TDVERSION to constant, closes #2935
2019-10-07 22:44:50 -07:00
larshp
90e012a1ae for low number of obj run single thread 2019-10-07 22:41:36 -07:00
Lars Hvam
2b9f7d30c7
1.90.0 (#2946)
* 1.90.0

* v1.90.0
2019-10-06 23:43:48 -07:00
Jakub Filak
4c3c4e8ea8 objects: work around the protected redefinition shortdump (#2891)
The methods CL_OO_CLASS_SECTION_SOURCE=>SCAN_SECTION_SOURCE calls the
function SCAN_ABAP_OBJECTS_SECTION without the parameter superclsname
which causes that variable scan_result (vse_tabs) holds a broken table of
redefinitions for protected methods which leads into a short dump during
CL_OO_CLASS_SECTION_SOURCE=>REVERT_SCAN_RESULTS.

The problem does not occur for public section because the public section
contains "CLASS ... INHERITING FROM ...", so superclsname gets
populated. It's obvious that the class definition statement is not
present in the protected section.

The crash is reported as DBSQL_DUPLICATE_KEY_ERROR in the program
SAPLSEOR at INSERT_REDEFINITIONS.

The code is the following:

    * first refresh db table
        perform delete_redefinitions
          using inhkey.
        delete adjacent duplicates from redefinitions.
    * insert again
        insert seoredef from table redefinitions.

One might think that the delete statement form clears the table seoredef
but the problem is that the variable inhkey contains the super class
name so no redefinitions are actually removed and the insert statement
attempts to insert the redefinitions without parent class again.

The proper solution is to enhance CL_OO_CLASS_SECTION_SOURCE=>SCAN_SECTION_SOURCE
to pass the super class name to SCAN_ABAP_OBJECTS_SECTION - at least for
the protected section.

However, I am not patient and I am not going to wait for the proper fix
(which the maintainers may refuse).
2019-10-06 23:18:44 -07:00
Christian Guenter
d7e2833483 Warning at stage when not logged on in master lang 2019-10-06 01:12:33 -07:00
Christian Günter
a40e7f1bbc new function 'add all objects to transport request' (#2942)
* new function 'add all objects to transport req'

* enable cancel
2019-10-06 00:21:51 -07:00
Christian Günter
6decda9c07 Refactor zcl_abapgit_gui_view_repo (#2939)
* refactor build branch/tag dropdown

* refactor build advanced dropdown

* refactor build main toolbar

* cleanup

* cleanup

* post merge conflict fixes
2019-10-05 23:17:27 -07:00
BlackmanCC
b49eaab687 fix errorhandling bug #2940 (#2941) 2019-10-05 22:58:52 -07:00
Christian Günter
3905c67edd Order by on repo page (#2933)
* Order by on repo page

* move render_cols_pec to zcl_abapgit_gui_chunk_lib

* cleanup

* cleanup

* first new working version

* fix lint

* add OrderByHelper

* add new feature clear

* rename ICON to CLEAR

* cleanup

* refactor actions

* fix typo in method name

* remove duplication

* rename render_col_spec to render_order_by_table_he

* refactor type

* fix eslint warning

* isoltate repo_tab CSS

* fix non-code and metadata files at the top

* refactor

* cleanup

* new features "diffs first" + remove clear

* refactor

* take directories into account

* cleanup
2019-10-05 22:54:04 -07:00
Martin Fuchs
67ebff3b7c No log messages for local objects after pull (#2932)
* No log messages for local objects after pull

In case a package contains objects that are are not part of the remote repository, the pull log contains messages like "Object (type ) only exists local; no import required". It is not necessary that messages for local object appears in the log. For pull requests, messages for the affected objects (objects to be imported) are sufficient.
This change ir related to issue #2931.

* rename (z)if_abapgit_definitions

rename (z)if_abapgit_definitions
2019-10-05 22:41:02 -07:00
Christian Günter
22d19023e4 NROB: write transport request entry (#2926)
* NROB-serialization: write transport request entry

* switch to corr_insert

* cleanup
2019-09-28 23:41:43 -07:00
Christian Günter
680dbd6b74 DDLS-Serialization: Write transport request entry (#2927) 2019-09-26 01:41:38 -07:00
Christian Guenter
d086bc1623 PERS: downport 2019-09-26 01:32:55 -07:00
Andrew Barnard
98ca315dac UENO: Entity Type Implementation (#1906) (#2911)
* UENO: Entity Type Implementation (#1906)

* Resolve ABAPlint issues

Resolve ABAPlint issues

* UENO - Use zcl_abapgit_objects_generic

Removal of many unnecessary methods due to use of zcl_abapgit_objects_generic
2019-09-18 22:02:35 -07:00
Christian Günter
ee6d488a07 Branch Overview: fix support for branches with # (#2920) 2019-09-16 04:36:47 -07:00
CASAG-MariusRaht
9ad8973ab6 #2725 (#2907)
* #2725

> Bottom logo is now clickable and links to the repository page on GitHub
> New menu item 'Changelog' under 'Help' which links to the changelog.txt

Special Notes: 
> Link to documentation was already implemented
> Link for menu item 'Tutorials' isn't linked to anything. But that seems to be right, because there isn't a tutorial site separated from the documentation website

* abaplint: Normalization

* Update zcl_abapgit_services_abapgit.clas.abap

* Update zcl_abapgit_services_abapgit.clas.abap

* abaplint: fix max line length error

* abaplint

* Removed "|{}|"
2019-09-15 01:09:27 -07:00
CASAG-MariusRaht
0fd851c8d2 #2723 (#2909)
#2723
> Implemented re-run button for syntax check
2019-09-12 07:33:24 -07:00
Christian Günter
b6f82aa8cf Command palette: Jump to files on Diff/Stage page (#2913)
* Patch/Diff: Command palette for file jump

* change hotkey to F2

* cleanup

* Improve JS func call
2019-09-12 05:29:52 -07:00
CASAG-MariusRaht
0e27d90212 Fix for #2896 (#2906)
> Error message for missing development object
> Reopen "Object to File"-PopUp when object was not found
> Spelling correction for error message
2019-09-09 22:02:12 -07:00
Alexander Tsybulsky
739b14ab6a Command palette: Git actions (#2908)
* enumerateToolbarActions

* command prefix

* docs
2019-09-09 21:34:30 -07:00
Christian Günter
780856c212 PERS: Personalization object implementation (#2905)
* PERS: Personalization object implementation

* Update ref-supported.md
2019-09-08 00:25:05 -07:00
Alexander Tsybulsky
587f792026 Command palette (Ctrl+P): Go to repo ... (#2897)
* command palette

* support for Ctrl; case insensitive search

* some wip

* refactor KeyNavigation

* eslint

* commandPalette key navigation improved

* last backspace hides the palette

* minor cleanups and ids
2019-09-07 23:12:49 -07:00
Christian Günter
cb00442062 Diff/Patch: Add Jump to file (#2895)
* Diff/Patch: Add Jump to file

* Patch/Diff: Add bottom margin for scrolling

* Remove filtered files from jump list
2019-08-30 04:17:17 -07:00
Sebastian Wolf
e5e63e089b APACK: Introduce versioned dependencies (#2894)
* APACK: Introduce versioned dependencies

* APACK: Make docs more precise wrt support
2019-08-29 00:53:09 -07:00
Alexander Tsybulsky
883c39bd25 column sorting in repo overview (#2887)
* column sorting draft

* linter fix

* remove old code

* fix toggleDetails - remember state

* eslint fix

* remove unused JS functions

* add column header for macro call
2019-08-26 22:06:27 -07:00
Christian Günter
2d143b081a fix CI result CSS (#2884) 2019-08-21 22:25:09 -07:00
Christian Günter
13c227359a Fix code inspector page navigation (#2883) 2019-08-21 22:22:11 -07:00
Jakub Filak
9a6e6e8b24 ui: add a workaround for JavaGUI dyn form bug (#2873)
JavaGUI does not pass values of options from forms generated via
JavaScript.

This commit adds enhances the base page class to render stub forms
(empty form elements), so the page's JavaScript does not need to create
the form element on its own.

It is an optional behavior and can be enabled by redefining the method
get_events which should return table of required events and the base
page object will add the empty form elements for them. Every table line
will be converted to a form with id = "form_" + the event's name.

On the action submit SAP event in the common JavaScript, the method
checks if there is the stub form and if so, the method uses it instead
of creating the dynamic one. Otherwise, it follows the old approach that
creates the form at run-time.

--- v2

Use 'null' instead of 'undefined' to check the form was not found in
the JavaScript code.

---

Issues: #1866, #2769
2019-08-21 22:18:45 -07:00
Lars Hvam
cb341e778f
increase serialization parallel timeout #2874 (#2876) 2019-08-19 21:33:57 -07:00
Alexander Tsybulsky
7133ae4b29 UT fix #2863 (#2871) 2019-08-15 22:23:56 -07:00
Lars Hvam
817aa7e718
optimize skip logic #2864 (#2868) 2019-08-13 22:39:41 -07:00
larshp
cf5630cbce ecatt, show error instead of dumping #2862 2019-08-13 22:34:43 -07:00
Lars Hvam
27f712a47b
linting (#2861)
* rewrite

* Update abaplint.json

* Update abaplint.json

* move to include where its used

* Update .gitignore

* Update abaplint.json

* Update package.json

* Update package.json
2019-08-11 23:16:10 -07:00
Lars Hvam
c173458e39
avoid use of STATICS #2828 (#2858)
* enable check for STATICS

* refactor to CLASS-DATA

* rename
2019-08-08 01:30:13 -07:00
Fabian Lupa
d72028a1e8 Progress indicator minimum percentage (#2855)
Fixes #2762
2019-08-07 21:25:57 -07:00
Fabian Lupa
cb80f78a6e Cancel branch creation if branch already exists (#2854) 2019-08-07 21:22:11 -07:00
Fabian Lupa
f5f9f6dc6a AUTH jump check FM existence
#1167
2019-08-07 19:20:39 -07:00
Lars Hvam
9de609ef2a
refactor seox (#2850) 2019-08-06 23:24:48 -07:00
Christian Günter
e9c4a5e63a FUGR: Fix transport request recording (#2848)
* FUGR: Fix transport request recording

* Move corrnum retrieval to methods

* cleanup
2019-08-06 01:06:31 -07:00
Lars Hvam
c3229f65d4
v1.89.0 (#2846)
* 1.89.0

* v1.89.0
2019-08-05 03:00:38 -07:00
Christian Günter
cacf02d285 warning when SAPGUI for Java is used (#2841) 2019-08-05 02:02:42 -07:00
Christian Günter
c008788b9b Improve error information - follow up Part 3 (#2837)
*  Improve tooltip of "Goto source" link

* add another test
2019-08-05 01:57:30 -07:00
Christian Günter
77d3ff885f Fix hint position for checkboxes (#2834) 2019-08-04 09:47:58 -07:00
Christian Günter
4c4fae820f Patch: Disable unified view (#2836) 2019-08-03 04:34:49 -07:00
Christian Günter
99a6716f32 Log viewer: Add more exception information + actions (#2832) 2019-08-03 04:29:32 -07:00
Christian Günter
b994382f78 Improve error information - follow up Part 2 (#2814)
- Cleanup JS
- Delete superflous functions and methods
2019-08-03 04:24:03 -07:00
Christian Günter
5cd2044745 Serialzie: Improve exception handling (#2831) 2019-08-02 22:06:23 -07:00
Alexander Tsybulsky
e379dd3cfe Completely dynamic JS hints (#2825)
* draft rewrite hint to be dynamic

* linter fixes

* remove color setting

* remove backspace and esc handling

* close dropdowns

* return some comments in JS

* linter fixes

* Fix hint for dropdown first time + alw close drdwn
2019-08-02 07:45:27 -07:00
ThomasPloski
d623d20d03 Improve object handler for CDS metadata extension (DDLX) (#2816)
* fixes issue #2815

The existing object handler for CDS metadata extension (DDLX) has been reviewed by an expert.
Doing this, the following feedback has been provided:

enable existing logging capability
include environment specific logic (e.g. import of an inactive version)
improve exception handling so that the related object information can be displayed in log
assign package information to handle abap language version ina proper way
adapt lock object

* fixes saplint issues

* fixes saplint issues

* fixes saplint issues

* extract dependency injection for TADIR_INSERT

* fixes saplint issues

* zcl_abapgit_environment.clas.testclasses.abap set to master version

* changes related to code review

* redo changes

* redo changes

* back to master version
2019-08-02 07:26:55 -07:00
Lars Hvam
cd87c97be7
environment, add tests and fix dump (#2827) 2019-08-02 01:21:03 -07:00
Lars Hvam
8d87beea60
tutorial is just a view, no need to implement intf (#2823) 2019-08-01 03:17:59 -07:00
ThomasPloski
a5ebe60642 Refactoring of ZCL_ABAPGIT_ENVIRONMENT (#2826)
* Refactoring of ZCL_ABAPGIT_ENVIRONMENT #2810

* fixes saplint issues

* fixes saplint isues

* fixes saplint issues

* fixes issue based on review

* align zcl_abapgit_objects.clas.abap to master

* add the test class again
2019-08-01 02:49:59 -07:00
sandraros
3f05693262 UI Dark Theme #2610 (#2787)
* UI Dark Theme #2610

Proposal - Right now, only the first obvious screens were checked, and there are still a few issues with them.

* CSS cleanup of unused elements
2019-08-01 00:57:30 -07:00
Lars Hvam
6f37ba37dd
fixes #2822 (#2824) 2019-07-31 00:55:08 -07:00
Lars Hvam
48222ca050
indentation fixes (#2820)
* indentation fixes

* fixes
2019-07-31 00:49:10 -07:00
Alexander Tsybulsky
d8b3034a30 close button css fixes (#2819) 2019-07-31 00:44:59 -07:00
Lars Hvam
d42bb98662
fixes #2808 (#2818)
fixes #2808
2019-07-31 00:41:01 -07:00
Alexander Tsybulsky
29c45a7e7c more convenient html pp comment (#2817) 2019-07-31 00:36:51 -07:00
Christian Günter
50a6cf8ac9 Improve error information - follow up Part I (#2813)
* Improve error information - follow up Part I

- Bug: remove errorenous regex
- Add tooltip for message id and message class

* Replace text of message link
2019-07-30 05:04:00 -07:00
Christian Guenter
50cc8b810f Better error message 2019-07-30 03:05:39 -07:00
Christian Günter
5081ddf7d0 Improve error information - HTML error message (#2775)
* Improve error information

With this commit errors that are raised with zcx_abapgit_exception=>raise
and issued with message are enriched with two additional functions.

1) Go to source
Navigates to the source code position where zcx_abapgit_exception=>raise
is called

2) Callstack
Shows a popup with the full callstack and the possibility to navigate to
the source of each line with double click

This feature requires the full abapGit repository. Without nothing
changes.

* issue messages directly

* zcx_abapgit_exception: adapt callstack handling

- callstack as attribute
- export callstack to ABAP memory only when SAPGui is available

* rename memory id

* Add comment why we don't delete callstack from MEM

* cleanup

* first try html error display

* add some comments

* add longtext

* goto_source and callstack implemented

* part 2

* remove

* fix

* add close button

* fix long classname

* fix linter

* add jump to SE91

* fix lintmr

* fix and cleanup

* fix linter

* fix linter

* fix eslint

* fix linter

* remove message class

* remove superfluous constant

* add missing method implementation

* refactor

* add hotkey for message longtext toggling

* hotkey 2

* refactor + resize callstack popup

* Refactoring: simplify control flow

* fix goto callstack for merged abapGit

* refactor: simplify control flow

* Refactoring: introduce message helper

* fix linter

* remove TODO pragmas

* ren. render meth + move zcl_abapgit_gui_chunk_lib

* refactoring: simplify control flow

* simplify exception handling

* refactor

* refactor

* refactor

* remove duplication

* Rename method

* rename method

* remove superfluous constant

* call ZCL_ABAPGIT_MESSAGE_HELPER dynamically

* cleanup

* Improve UX

* fix linter

* remove hotkey
2019-07-28 03:46:53 -07:00
Johan Wigert
b068ddcaa3 Fix for issue #2772 (#2806)
* Update zcl_abapgit_transport_objects.clas.abap

* Update zcl_abapgit_transport_objects.clas.testclasses.abap

* Update zcl_abapgit_transport_objects.clas.testclasses.abap

* Update zcl_abapgit_transport_objects.clas.abap

* Update zcl_abapgit_transport_objects.clas.abap

* Update zcl_abapgit_transport_objects.clas.abap
2019-07-21 21:30:17 -07:00
Hector Martinez
6b5fbd52fd adds serialization of FUGR text pool translations (#2780) (#2790)
* fix for issue #2747

* fixes issue #2746

* adds serialization of function groups text pool translations

* whitespace fixes
2019-07-21 03:35:11 -07:00
Sdfraga
ddcc1ee3c6 Proxy port length (#2800)
* Ensure Proxy Port has 4 digit length

* Ensure Proxy Port has 4 digit length
2019-07-18 07:12:25 -07:00
Christian Guenter
24e319cc68 Downport 2019-07-18 07:07:20 -07:00
Łukasz Pęgiel
63c8e4808c add log for Offline install (#2798)
* add log for Offline install

* white space
2019-07-17 08:17:09 -07:00
Lars Hvam
998815f6fb
closes #2791 (#2792)
another quick fix for the staus codes, #2791
2019-07-17 01:06:12 -07:00
Christian Guenter
1a9d1b3d08 Patch: delete all lines removes the file 2019-07-17 00:58:31 -07:00
Lars Hvam
1dbd4d1912
Refactoring types (#2785)
* align use less different types

* refactor

* updates
2019-07-15 09:33:37 -07:00
larshp
2db46137fc #2783, update error description 2019-07-14 23:31:33 -07:00
Hector Martinez
699e4fd65c fixes issue #2746 (#2776)
* fix for issue #2747

* fixes issue #2746
2019-07-12 02:00:17 -07:00
Frederik Hudák
777445002a Revert behavior of second back button (#2779)
* Revert behavior of second back button

* Leave clearing of stack on go home
2019-07-10 21:28:20 -07:00
Frederik Hudák
0299fb61c7 Consistent sort ordering of files (#2778) 2019-07-10 00:37:09 -07:00
Lars Hvam
ce84d2455f
additional gateway support (#2771)
* additional gateway support

* Update ref-supported.md
2019-07-07 23:38:55 -07:00
Lars Hvam
f88237f411
remove double spaces (#2770)
* remove double spaces

* whitespace
2019-07-02 20:54:35 -07:00
Lars Hvam
c84b209944
Minor lint updates (#2766)
* remove some double space

* update abaplint to latest

* fixes
2019-07-01 22:08:54 -07:00
Alexander Tsybulsky
df0aca8272 Improve css preprocessing (#2765)
* improve assetman get_text_asset

* move css_processor to ui_core, reuse get_text_asse

* fix %26 refactor UTs

* zcl_abapgit_gui_html_processor

* if fix

* replace core logic

* comment finetuning

* linter fixes

* more linter fixes

* fix UTs, based on review
2019-07-01 20:53:43 -07:00
Christian Guenter
1f52d8b2c7 TR request jump: fallback to SAPGUI 2019-07-01 20:50:06 -07:00
Hector Martinez
3e53360722 fix for issue #2747 (#2760) 2019-06-28 23:06:07 -07:00
Frederik Hudák
f5d421e399 ADT jump for package link and transports (#2758)
* ADT jump for package links

* Also handle transport requests/tasks

* fix abaplint
2019-06-28 23:02:37 -07:00
Lars Hvam
f6e8332754
Cleanup (#2753)
* refactor IF

* fix some indentation

* indentation fixes

* indentation fixes

* indentation

* indentation
2019-06-25 03:02:51 -07:00
Fabian Lupa
7f04d59bf9 Belize theme (#2733)
* Add Belize theme

* Implement polyfill for CSS variables

* Fix CSS variables with spaces in values

* Always load default theme and add others on top

* Adjust theme CSS for use with variables

* Support variables referencing variables in CSS

* Adjust themes

* Add font size to theme

* Skip asset registration for unused themes

* Unify theme greyscale

* Refactor CSS preprocessor

* Refactor CSS preprocessor, add basic tests

* Fix linter issues

* Always load theme asset

Otherwise switching does not work
2019-06-25 03:02:40 -07:00
Lars Hvam
500f469835
1.88.0 (#2751)
* 1.88.0

* v1.88.0
2019-06-21 23:19:02 -07:00
Martin Fuchs
4aab0166ac Pass log to deserialization API and show log (#2729)
* Pass log interface for de-serialization

Interface ZIF_ABAPGIT_LOG is now passed for deseriaization API.
This includes:
- Log messages for FUGR: Imported function modules and includes
- Improved error messages for TABL compare
- Log objects w/o changes
- Log is shown in the UI if available ("Log" entry appears if a log exists, no persistence!)
This PR enhances #2534 and #2694

Another important change: In case an object fails (or a single function module in a group fails), the import continues with the next object!

* small pretty printer changes

small pretty printer changes

* fix abaplint issues

reduce line sizes and ensure 7.02 compatibility

* show errors and warnings from pull

Errors and warnings after a pull are now part of the "message list" above the object list in the main screen and will be shown immediately. The new"Log" button shows errors, warnings and success messages on demand.
The log title is now part of the ZIF_ABAPGIT_LOG interface.

* fix abaplint issue

fix abaplint issue
2019-06-21 23:05:10 -07:00
Hector Martinez
a69e313090 fix for issue #2745 (#2749)
* solves issue #2745

* format

* format, now with abaplint
2019-06-21 23:00:05 -07:00
Christian Günter
6b7e4d62dd Improve error handling for delete_tadir (#2741)
* Improve error handling for delete_tadir

* add TODO comment for delete tadir
2019-06-16 09:01:53 -07:00
Frederik Hudák
abc43d4e5a With 'show changes only' enabled, also filter changed files, not just objects (#2740)
* When 'show changes only' enabled, also filter changed files, not just objects

Fixes #2739

* fix whitespace

* Fix syntax error
2019-06-16 04:53:37 -07:00
Christian Guenter
0b78d4c1a8 Downport 2019-06-13 23:18:03 -07:00
Christian Günter
ffc411b8f1 use remote .abapgit if local repo is empty (#2736)
* use remote .abapgit if repo is empty

* use method find_remote_dot_abapgit

* cleanup

* cleanup /2
2019-06-13 23:01:22 -07:00
Frederik Hudák
c679d11d7b Change behavior of second back button to go home (#2679)
* Change behavior of second back button to go home

* Change logic as proposed

* Don't go to tutorial page on exit

* Final changes

* Fix abaplint
2019-06-13 22:59:18 -07:00
larshp
f8c017a8de replace conversion exit usage #2716 2019-06-11 10:46:15 -07:00
Lars Hvam
5fb5dc552f
workaround #2737
this should make it give a warning instead of a syntax error
2019-06-11 19:29:03 +02:00
Christian Guenter
1d1ab1db18 TOBJ: delete tadir 2019-06-11 08:58:09 -07:00
Christian Guenter
b5a1b343ca W3HT + W3MI: delete tadir 2019-06-11 08:57:51 -07:00
Fabian Lupa
3f01361d13 Check other dev clients in user master record (#2710)
* Fallback check other clients in user master record

* Replace SELECT...ENDSELECT with SELECT SINGLE
2019-06-11 08:57:28 -07:00
Thomas B
84042f1370 Enhance 'Transport to ZIP' to process multiple transport requests (#2683)
* New Program : Mass Transport to local zip file

Create new program ZMASSGIT in order to convert multiple tranport request to local zip files ( by giving output folder ).
Timestamped subfolder will be created in the input folder.

* Add files via upload

* Update zmassgit.prog.abap

* Add files via upload

* Add files via upload

* Delete zmassgit.prog.xml

* Delete zmassgit.prog.abap

* Add files via upload

* Add files via upload

* Add files via upload

* Add files via upload

* Delete zabapgit_masstransp2zip.fugr.lzabapgit_masstransp2zipf01.abap

* Delete zabapgit_masstransp2zip.fugr.lzabapgit_masstransp2zipf01.xml

* Delete zabapgit_masstransp2zip.fugr.lzabapgit_masstransp2zipplc.abap

* Delete zabapgit_masstransp2zip.fugr.lzabapgit_masstransp2zipplc.xml

* Delete zabapgit_masstransp2zip.fugr.lzabapgit_masstransp2zipscr.abap

* Rename zabapgit_masstransp2zip.fugr.lzabapgit_masstransp2zipscr.xml to src/zabapgit_masstransp2zip.fugr.lzabapgit_masstransp2zipscr.xml

* Rename zabapgit_masstransp2zip.fugr.lzabapgit_masstransp2ziptop.abap to src/zabapgit_masstransp2zip.fugr.lzabapgit_masstransp2ziptop.abap

* Rename zabapgit_masstransp2zip.fugr.lzabapgit_masstransp2ziptop.xml to src/zabapgit_masstransp2zip.fugr.lzabapgit_masstransp2ziptop.xml

* Rename zabapgit_masstransp2zip.fugr.saplzabapgit_masstransp2zip.abap to src/zabapgit_masstransp2zip.fugr.saplzabapgit_masstransp2zip.abap

* Rename zabapgit_masstransp2zip.fugr.saplzabapgit_masstransp2zip.xml to src/zabapgit_masstransp2zip.fugr.saplzabapgit_masstransp2zip.xml

* Rename zabapgit_masstransp2zip.fugr.xml to src/zabapgit_masstransp2zip.fugr.xml

* Rename zabapgit_masstransp2zip.fugr.z_abapgit_transports_2_zip.abap to src/zabapgit_masstransp2zip.fugr.z_abapgit_transports_2_zip.abap

* Rename zcl_abapgit_transport_mass.clas.abap to src/zcl_abapgit_transport_mass.clas.abap

* Rename zcl_abapgit_transport_mass.clas.xml to src/zcl_abapgit_transport_mass.clas.xml

* Delete zcl_abapgit_zip.clas.abap

* Delete zcl_abapgit_zip.clas.xml

* Add files via upload

* Add files via upload

* Add files via upload

* Add files via upload

* Add files via upload

* Add files via upload

* Update zcl_abapgit_zip.clas.abap

* Update zabapgit_masstransp2zip.fugr.lzabapgit_masstransp2zipf01.abap

* Update zabapgit_masstransp2zip.fugr.lzabapgit_masstransp2zipf01.abap

* Update zabapgit_masstransp2zip.fugr.lzabapgit_masstransp2zipf01.abap

* Update zcl_abapgit_transport_mass.clas.xml

* Update zcl_abapgit_transport_mass.clas.abap

* Update zabapgit_masstransp2zip.fugr.saplzabapgit_masstransp2zip.abap

* Update zabapgit_masstransp2zip.fugr.lzabapgit_masstransp2zipplc.abap

* Update zabapgit_masstransp2zip.fugr.saplzabapgit_masstransp2zip.xml

* Update zabapgit_masstransp2zip.fugr.lzabapgit_masstransp2zipplc.abap

* Update zabapgit_masstransp2zip.fugr.lzabapgit_masstransp2zipplc.abap

* Update zabapgit_masstransp2zip.fugr.saplzabapgit_masstransp2zip.abap

* New version without function group

* Cleanup

* Abaplint

* AbapLint Fixes

* Remove plugins objects from master

* Skip log flag in ZIP export

* Popup to ask the Export logic ( FULL / PREFIX ..)

* line length for abaplint

* Refactoring of code

Avoid redundancy of code and remove unused constant.

* Reduce line 50 length for abaplint ( < 120 )

* Change by the review of code

Refactoring of code

* AbapLint Fix
2019-06-11 08:57:08 -07:00
Alexander Tsybulsky
6845fe3ea4 Ui themes support (#2700)
* settings ui_theme

* theme css rendering

* theme split

* linetr fix
2019-06-07 03:36:44 -07:00
larshp
f9f8adcf9e remove use of CONVERSION_EXIT_RSDAT_INPUT 2019-06-03 22:24:55 -07:00
Lars Hvam
58235f1e6a
do not skip descriptions check for exception classes (#2714)
* do not skip descriptions check for exception classes

* remove description

* remove description

* remove description

* remove description

* remove description

* remove description

* remove description

* remove description
2019-05-29 23:54:06 -07:00
larshp
4169d1045a generic serializer: order by primary key #2682 2019-05-29 23:53:50 -07:00