Commit Graph

240 Commits

Author SHA1 Message Date
Fabian Lupa
1bef6949f2 Delete missing TVIMF entries on reset local (TOBJ)
Fixes #2267
2019-01-17 13:22:52 +01:00
larshp
3509df80ae add class descriptions 2019-01-14 20:06:33 +01:00
Lars Hvam
610c48d51f
Remove commented code (#2285)
* delete commented code

* delete commented code

* commented code
2019-01-13 10:28:18 +01:00
Andre Becker
da600fa2d3 Improve error handling of ttyp object handler (#2272)
* improve error handling of function modules

* fix abaplint errors

* refactor to hardcoded error strings

* refactor fm error handling to string templates

* removing msag class
2019-01-12 12:44:24 +01:00
Jan Pascal Tschudy
ef0f6e631a fix remove inline method call 2019-01-04 14:35:47 +01:00
larshp
9a935d2a14 TABL: use sy-subrc instead of syst_subrc 2019-01-04 14:19:33 +01:00
Christian Guenter
1de9456567 Fix TABL regression 2019-01-02 11:50:08 +01:00
Domi Bigl
311efc0d20 add IDoc Segment support as part of TABL (#2246)
* add IDoc Segement support as part of TABL

IDoc Segement type/definition is just customizing and has no own transport object but it generates a structure and is coupled to it

The segment type/definitions have their own XML at the TABL object

* fix abaplint errors

* move segment type/defintion to TABL xml
2019-01-02 06:05:49 +01:00
larshp
f1a0307fa9 VCLS clear CHANGEDATE #2227
VCLS clear CHANGEDATE #2227
2018-12-30 08:03:55 +01:00
larshp
c37ce5ff06 Cleanup classes package assignment #2217 2018-12-30 08:03:38 +01:00
larshp
e0841e3bec indentation and se80 reorderings
no logic changes
2018-12-26 06:35:55 +01:00
larshp
f9749776d8 fix naming 2018-12-25 09:10:15 +00:00
larshp
6385caade6 fix whitespace and other minor changes 2018-12-20 09:23:01 +01:00
Lars Hvam
5f9df74463
reduce method length, #2146 (#2212)
* TRAN: refactor method SPLIT_PARAMETERS

new method SHIFT_PARAM added

* settings page: refactoring

rename BUILD_SETTINGS to POST
split contents into smaller methods
2018-12-20 09:22:33 +01:00
Lars Hvam
35f1462d3a
updates to experimental DDIC activation logic (#2206)
* updates to experimental ddic activation logic

* deleted too much

* special handling for INDX

* fixored, this seems to work
2018-12-17 08:17:53 +01:00
Lars Hvam
c9252b1b2a
CLAS cleanup (#2204)
* cleanup old experimental CLAS

* Move ZCL_ABAPGIT_OO_CLASS_NEW to _CLASS
2018-12-17 08:17:07 +01:00
Eduardo Ferrari Copat
d47027ad6c Remove redundant class and interface metadata (#2195)
* Remove CLSFINAL from VSEOCLASS serialization

* Remove EXPOSURE from VSEOCLASS serialization

* Remove clsabstrct from VSEOCLASS serialization

* Remove EXPOSURE from VSEOINTERF serialization

* Revert "Remove EXPOSURE from VSEOINTERF serialization"

This reverts commit 4036b7d015.
2018-12-12 14:31:42 +01:00
CCapa
13f84140f4 Sapscript : sequence of Windows in tdlines files (#2191)
* Sapscript : sequence of Windows in tdlines files

Hello Lars,

You can find a code modification in the method _read_form of class zcl_abapgit_object_form related to the issue #2188
I have added a logic to sort by windows name the contains of the internal table ET_LINES . It allows to have always thre same sequence of  windows code in the file (xxxxxxxxxxgit.form.tdlines). Then file comparison will work with all export.

Regards
Christophe

* Sapscript : sequence of Windows in tdlines files

Hello Lars,

I have moved the code to a new private method _sort_tdlines_by_windows
But I don't add 'ASSERT sy-subrc = 0.'. 
The reason is that during my tests I found some windows in the form without elements inside (windows is not used anymore but it sill exists. The devlopper ddin't remove it). In this case the result of the ASSERT is a dump.
Using the loop from SY-TABIX there is no risk. If no entry exists in the internal table then the loop is not executed.

if needed I can add the following condition before doing the loop :
       IF line_exists( lt_lines[ tdformat = lv_elt_windows
                                tdline = ls_form_windows-tdwindow ] ).
Christophe

* Sapscript : sequence of Windows in tdlines files

I have done the adjustments for the CLEAR and to be  compatible with 702

Christophe

* Sapscript : sequence of Windows in tdlines files

Whitespace at end of line removed
2018-12-08 13:26:09 +01:00
larshp
79c799dffb SUCU support via generic serializer 2018-11-25 07:29:22 +01:00
larshp
158d54aceb pretty print: keywords upper case 2018-11-23 12:17:00 +01:00
larshp
6e9f6b8a45 TABL refactoring, CLEAR_DD03P_FIELDS added #2128 2018-11-23 05:58:04 +01:00
larshp
2fe5b30e4d TRAN refactoring, reduce method length #2128 2018-11-23 05:57:52 +01:00
Christian Guenter
b395132f3b SUSC: Delete tadir 2018-11-20 09:10:38 +01:00
Christian Guenter
8e8c478a7f SUSC: Fix code inspector errors 2018-11-17 10:27:40 +01:00
larshp
aac3c1b709 rename constants 2018-11-17 06:13:41 +01:00
Christian Guenter
e61108511d DDLX: Fix transport request recording + activation 2018-11-15 08:03:48 +01:00
Domi Bigl
ffac70b9c3 TRAN: ignore object not found while delete
If the transaction can't be found in FM RPY_TRANSACTION_DELETE, it's already deleted
2018-11-11 18:41:21 +01:00
Domi Bigl
297112614e SHI3: delete in more direct way - no confirm popup #2035 (#2094)
* SHI3: delete in more direct way - no confirm popup

SHI3 delete is done in a more direct way without confirmation popup

* naming conventions
2018-11-11 17:48:51 +01:00
larshp
aae099b93d naming conventions 2018-11-11 17:45:12 +01:00
Domi Bigl
95287136d6 SUSC: delete in more direct way - no confirm popup #2036 (#2079)
* SUSC: delete in more direct way - no confirm popup

delete needs to be done with a code copy of FM SUSR_DELETE_OBJECT_CLASS
I really hate this but there is no other way

* SUSC: delete in more direct way - no confirm popup

* test

* test

* naming conventions

* PP
2018-11-11 17:44:40 +01:00
Christian Günter
dc173ad906 DCLS: Fix activation error + TADIR handling + late deserialization #2051 (#2085)
* DCLS: Fix activation and move to late deser.

* DCLS: improve tadir handling + activation
2018-11-11 06:32:56 +01:00
Christian Guenter
2a08aca65a SFSW: synchronous deletion 2018-11-11 06:31:42 +01:00
Domi Bigl
b7e5a56080 DEVC: get package from devclass or object name 2018-11-10 08:22:39 +01:00
Christian Günter
36fccd3b52 Fix TADIR handling #2066 (#2078)
* AUTH + FORM: delete tadir

* SFBS + SFBF: delete tadir

* SFSW: synchronous deletion
2018-11-10 08:11:22 +01:00
Christian Günter
74bf1b7e66 SICF: Better errors + is_locked 2018-11-09 11:56:06 +01:00
larshp
9270a58b62 cleanup unreference variables 2018-11-09 11:55:47 +01:00
Christian Guenter
fec33acf5f DDLX: add tadir handling 2018-11-09 05:37:26 +01:00
larshp
7cdbbc92b6 remove some unreferenced variables 2018-11-08 16:35:08 +01:00
larshp
6415f9e249 update abaplint to latest 2018-11-08 06:26:32 +01:00
larshp
28ae85e270 naming conventions 2018-11-08 06:15:07 +01:00
Lars Hvam
06616580eb
Naming conventions (#2059)
* fix naming conventions

* naming conventions
2018-11-07 12:50:20 +01:00
Lars Hvam
89e5010fd0
Naming conventions fixes, #2053 (#2058)
* fix more naming conventions

* more naming conventions fixes
2018-11-07 12:05:27 +01:00
Christian Guenter
e17d3334ff PARA: implement is_locked 2018-11-05 12:47:44 +01:00
Domi Bigl
e326273f20 SCP1: delete in more direct way - no confirm popup
FM SCPR_PRSET_MN_DELETE has some confirmation popups so the delete is done in a more direct way without popups
2018-11-05 12:47:31 +01:00
Christian Guenter
8b1cbd4b89 PARA: better error information 2018-11-03 12:48:51 +01:00
Christian Guenter
45a2ba1cd1 add factory for GUI_IS_AVAILABLE
This commit adds an indirection for function module GUI_IS_AVAILABLE
via interface ZIF_ABAPGIT_GUI_FUNCTIONS and factory ZCL_ABAPGIT_UI_FACTORY.

For tests the implementation can be replaced with
ZCL_ABAPGIT_UI_INJECTOR=>SET_GUI_FUNCTIONS
2018-11-03 08:42:32 +01:00
Christian Günter
db6f21f78c ENHO: save dark 2018-11-03 08:41:25 +01:00
Christian Guenter
6c3538a13a PARA: fix error handling 2018-11-03 08:40:46 +01:00
Domi Bigl
95deb3ed57 Add checks for empty class includes CLAS 2018-11-03 08:40:19 +01:00
Domi Bigl
b8ed4589af SSFO: change workarea range_node_code type 2018-11-01 07:16:43 +01:00